[PATCH] drm/amd/display: Prevent potential buffer overflow in map_hw_resources

2024-02-20 Thread Srinivasan Shanmugam
Adds a check in the map_hw_resources function to prevent a potential buffer overflow. The function was accessing arrays using an index that could potentially be greater than the size of the arrays, leading to a buffer overflow. Adds a check to ensure that the index is within the bounds of the arra

[PATCH] drm/amdgpu/jpeg: add support for jpeg multi instance

2024-02-20 Thread Alex Deucher
From: Saleemkhan Jamadar Enable support for multi instance on JPEG 4.0.6. v2: squash in fixes (Alex) Signed-off-by: Saleemkhan Jamadar Reviewed-by: Veerabadhran Gopalakrishnan Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 177 --- 1 file chan

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-20 Thread Alex Deucher
On Tue, Feb 20, 2024 at 2:41 PM Romano wrote: > > If the increased low range is allowed via boot option, like in proposed > patch, user clearly made an intentional decision. Undefined, but won't > fry his hardware for sure. Undefined is also overclocking in that > matter. You can go out of range w

Re: [PATCH 1/2] drm/amdkfd: Document and define SVM event tracing macro

2024-02-20 Thread Philip Yang
On 2024-02-16 15:16, Felix Kuehling wrote: On 2024-02-15 10:18, Philip Yang wrote: Document how to use SMI system management interface to receive SVM events. Define SVM events message stri

[PATCH] drm/amd: Update atomfirmware.h for DCN401

2024-02-20 Thread Aurabindo Pillai
Add new firmware header definitions reqiured for DCN401 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/include/atomfirmware.h | 33 ++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/drm/amd/include/atomfirmwar

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-20 Thread Alex Deucher
On Tue, Feb 20, 2024 at 10:27 AM Hans de Goede wrote: > > Hi, > > On 2/20/24 16:15, Alex Deucher wrote: > > On Tue, Feb 20, 2024 at 10:03 AM Linux regression tracking (Thorsten > > Leemhuis) wrote: > >> > >> On 20.02.24 15:45, Alex Deucher wrote: > >>> On Mon, Feb 19, 2024 at 9:47 AM Linux regres

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-20 Thread Alex Deucher
On Tue, Feb 20, 2024 at 11:46 AM Romano wrote: > > For Windows, apps like MSI Afterburner is the one to try and what most > people go for. Using it in the past myself, I would be surprised if it > adhered to such a high min power cap. But even if it did, why would we > have to. > > Relying on vend

RE: [PATCH 4/4] drm/amdgpu: Do not program VM_L2_CNTL under SRIOV

2024-02-20 Thread Dhume, Samir
[AMD Official Use Only - General] Reviewed-by: Samir Dhume -Original Message- From: amd-gfx On Behalf Of Victor Lu Sent: Tuesday, January 2, 2024 12:30 PM To: amd-gfx@lists.freedesktop.org Cc: Chander, Vignesh ; Lu, Victor Cheng Chi (Victor) Subject: [PATCH 4/4] drm/amdgpu: Do not pro

RE: [PATCH 2/4] drm/amdgpu: Do not program SQ_TIMEOUT_CONFIG in SRIOV

2024-02-20 Thread Dhume, Samir
[AMD Official Use Only - General] Reviewed-by: Samir Dhume -Original Message- From: amd-gfx On Behalf Of Victor Lu Sent: Tuesday, January 2, 2024 12:30 PM To: amd-gfx@lists.freedesktop.org Cc: Chander, Vignesh ; Lu, Victor Cheng Chi (Victor) Subject: [PATCH 2/4] drm/amdgpu: Do not pro

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-20 Thread Alex Deucher
On Tue, Feb 20, 2024 at 10:42 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > > > On 20.02.24 16:27, Hans de Goede wrote: > > Hi, > > > > On 2/20/24 16:15, Alex Deucher wrote: > >> On Tue, Feb 20, 2024 at 10:03 AM Linux regression tracking (Thorsten > >> Leemhuis) wrote: > >>> > >>> O

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-20 Thread Christian König
Am 20.02.24 um 16:15 schrieb Alex Deucher: On Tue, Feb 20, 2024 at 10:03 AM Linux regression tracking (Thorsten Leemhuis) wrote: On 20.02.24 15:45, Alex Deucher wrote: On Mon, Feb 19, 2024 at 9:47 AM Linux regression tracking (Thorsten Leemhuis) wrote: On 17.02.24 14:30, Greg KH wrote: On S

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-20 Thread Alex Deucher
On Tue, Feb 20, 2024 at 10:03 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > On 20.02.24 15:45, Alex Deucher wrote: > > On Mon, Feb 19, 2024 at 9:47 AM Linux regression tracking (Thorsten > > Leemhuis) wrote: > >> > >> On 17.02.24 14:30, Greg KH wrote: > >>> On Sat, Feb 17, 2024 at 0

Re: Kernel 6.7+ broke under-powering of my RX 6700XT. (Archlinux, mesa/amdgpu)

2024-02-20 Thread Alex Deucher
On Mon, Feb 19, 2024 at 9:47 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > On 17.02.24 14:30, Greg KH wrote: > > On Sat, Feb 17, 2024 at 02:01:54PM +0100, Roman Benes wrote: > >> Minimum power limit on latest(6.7+) kernels is 190W for my GPU (RX 6700XT, > >> mesa, archlinux) and I ca

Re: [PATCH 2/2] drm/amdgpu: use new reset-affected accessors for userspace interfaces

2024-02-20 Thread Lazar, Lijo
On 2/20/2024 7:52 PM, Christian König wrote: > Am 20.02.24 um 07:32 schrieb Lazar, Lijo: >> On 2/16/2024 8:43 PM, Alex Deucher wrote: >>> Use the new reset critical section accessors for debugfs, sysfs, >>> and the INFO IOCTL to provide proper mutual exclusivity >>> to hardware with respect the

Re: [PATCH 2/2] drm/amdgpu: use new reset-affected accessors for userspace interfaces

2024-02-20 Thread Christian König
Am 20.02.24 um 07:32 schrieb Lazar, Lijo: On 2/16/2024 8:43 PM, Alex Deucher wrote: Use the new reset critical section accessors for debugfs, sysfs, and the INFO IOCTL to provide proper mutual exclusivity to hardware with respect the GPU resets. This looks more like a priority inversion. When

Re: [PATCH 5/5] drm/amdgpu: skip GFX FED error in page fault handling

2024-02-20 Thread Christian König
Am 19.02.24 um 09:15 schrieb Tao Zhou: Let kfd interrupt handler process it. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc

RE: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-20 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Christian König > Sent: Tuesday, February 20, 2024 9:10 AM > To: Alex Deucher > Cc: Limonciello, Mario ; Wentland, Harry > ; amd-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; Mahfooz, Hamza ; > Li, Sun peng (Le

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-20 Thread Christian König
Am 19.02.24 um 16:28 schrieb Alex Deucher: On Mon, Feb 19, 2024 at 10:19 AM Christian König wrote: Am 16.02.24 um 19:37 schrieb Alex Deucher: On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On

Re: [PATCH v2] drm/amd/display: Fix potential null pointer dereference in dc_dmub_srv

2024-02-20 Thread Chung, ChiaHsuan (Tom)
Reviewed-by: Tom Chung On 2/20/2024 5:06 PM, Srinivasan Shanmugam wrote: Fixes potential null pointer dereference warnings in the dc_dmub_srv_cmd_list_queue_execute() and dc_dmub_srv_is_hw_pwr_up() functions. In both functions, the 'dc_dmub_srv' variable was being dereferenced before it was ch

[PATCH v2] drm/amd/display: Fix potential null pointer dereference in dc_dmub_srv

2024-02-20 Thread Srinivasan Shanmugam
Fixes potential null pointer dereference warnings in the dc_dmub_srv_cmd_list_queue_execute() and dc_dmub_srv_is_hw_pwr_up() functions. In both functions, the 'dc_dmub_srv' variable was being dereferenced before it was checked for null. This could lead to a null pointer dereference if 'dc_dmub_srv

Re: [PATCH] drm/radeon: Call mmiowb() at the end of radeon_ring_commit()

2024-02-20 Thread Christian König
Am 20.02.24 um 08:49 schrieb Huacai Chen: Commit fb24ea52f78e0d595852e ("drivers: Remove explicit invocations of mmiowb()") remove all mmiowb() in drivers, but it says: "NOTE: mmiowb() has only ever guaranteed ordering in conjunction with spin_unlock(). However, pairing each mmiowb() removal in

[PATCH] drm/radeon: Call mmiowb() at the end of radeon_ring_commit()

2024-02-20 Thread Huacai Chen
Commit fb24ea52f78e0d595852e ("drivers: Remove explicit invocations of mmiowb()") remove all mmiowb() in drivers, but it says: "NOTE: mmiowb() has only ever guaranteed ordering in conjunction with spin_unlock(). However, pairing each mmiowb() removal in this patch with the corresponding call to sp