RE: [PATCH 3/5] drm/amdgpu: Add ras helper to query boot errors

2024-01-01 Thread Zhang, Hawking
[AMD Official Use Only - General] Good point, Le, will switch to the existing helper for the cross die access in v2. Regards, Hawking -Original Message- From: Ma, Le Sent: Tuesday, January 2, 2024 14:45 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, Stanley ; W

RE: [PATCH 3/5] drm/amdgpu: Add ras helper to query boot errors

2024-01-01 Thread Ma, Le
[AMD Official Use Only - General] > -Original Message- > From: Hawking Zhang > Sent: Tuesday, January 2, 2024 11:44 AM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Wang, Yang(Kevin) > ; Chai, Thomas ; Li, > Candice > Cc: Zhang, Hawking ; Deucher, Alexander > ; Laza

Re: [PATCH] drm/amd/pm: Add mem_busy_percent for GCv9.4.3 apu

2024-01-01 Thread Lazar, Lijo
On 12/22/2023 10:52 PM, Asad Kamal wrote: Expose sysfs entry mem_busy_percent for GC version 9.4.3 APU system Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar Thanks, Lijo --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driv

RE: [PATCH 3/5] drm/amdgpu: Add ras helper to query boot errors

2024-01-01 Thread Zhang, Hawking
[AMD Official Use Only - General] I was hoping the macro could be used for 64bit registers as well. i.e., the aca regs. Regards, Hawking -Original Message- From: Wang, Yang(Kevin) Sent: Tuesday, January 2, 2024 13:24 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yan

RE: [PATCH 2/3] drm/amdgpu: Query ras capablity from psp

2024-01-01 Thread Zhang, Hawking
[AMD Official Use Only - General] The ret gives us a chance to fallback to legacy query approach (from vbios). You might want to see patch #3 of the series for more details, go to the following lines in patch #3 + /* query ras capability from psp */ + if (amdgpu_psp_get_ras_capabil

RE: [PATCH 3/5] drm/amdgpu: Add ras helper to query boot errors

2024-01-01 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] -Original Message- From: Hawking Zhang Sent: Tuesday, January 2, 2024 11:44 AM To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, Stanley ; Wang, Yang(Kevin) ; Chai, Thomas ; Li, Candice Cc: Zhang, Hawking ; Deucher, Alexander ; Lazar, Lijo ; Ma, L

RE: [PATCH 2/3] drm/amdgpu: Query ras capablity from psp

2024-01-01 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] -Original Message- From: Hawking Zhang Sent: Tuesday, January 2, 2024 11:45 AM To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, Stanley ; Wang, Yang(Kevin) ; Chai, Thomas ; Li, Candice Cc: Zhang, Hawking ; Deucher, Alexander ; Lazar, Lijo ; Ma, L

[PATCH 3/3] drm/amdgpu: Replace DRM_* with dev_* in amdgpu_psp.c

2024-01-01 Thread Hawking Zhang
So kernel message has the device pcie bdf information, which helps issue debugging especially in multiple GPU system. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 144 1 file changed, 75 insertions(+), 69 deletions(-) diff --git a/drivers/g

[PATCH 2/3] Revert "drm/amdgpu: enable mca debug mode on APU by default"

2024-01-01 Thread Hawking Zhang
Not needed any more with firmware fixes Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 842405bb8995..d6e74b4dc6

[PATCH 1/3] drm/amdgpu: Packed socket_id to ras feature mask

2024-01-01 Thread Hawking Zhang
Initialize RAS feature mask bit[31:29] with socket_id. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 72b6e41329b0..842405bb

[PATCH 3/3] drm/amdgpu: Centralize ras cap query to amdgpu_ras_check_supported

2024-01-01 Thread Hawking Zhang
Move ras capablity check to amdgpu_ras_check_supported. Driver will query ras capablity through psp interace, or vbios interface, or specific ip callbacks. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 170 +--- 1 file changed, 93 insertions(+), 7

[PATCH 2/3] drm/amdgpu: Query ras capablity from psp

2024-01-01 Thread Hawking Zhang
Instead of traditional atomfirmware interfaces for RAS capability, host driver can query ras capability from psp starting from psp v13_0_6. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 13 + drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 2 ++ drivers/gpu/dr

[PATCH 1/3] drm/amdgpu: Align ras block enum with firmware

2024-01-01 Thread Hawking Zhang
Driver and firmware share the same ras block enum. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h index 5785b705c692..8b053602c5ca 10

[PATCH 0/3] Add ras cap query from psp

2024-01-01 Thread Hawking Zhang
Driver can query RAS capability through psp or bios. Hawking Zhang (3): drm/amdgpu: Align ras block enum with firmware drm/amdgpu: Query ras capablity from psp drm/amdgpu: Centralize ras cap query to amdgpu_ras_check_supported drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 13 ++ drivers/gpu/d

[PATCH 5/5] drm/amdgpu: Query boot status if boot failed

2024-01-01 Thread Hawking Zhang
Check and report firmware boot status if it doesn't reach steady status. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c b/drivers/gpu/drm/amd/amdgpu/ps

[PATCH 4/5] drm/amdgpu: Query boot status if discovery failed

2024-01-01 Thread Hawking Zhang
Check and report boot status if discovery failed. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c

[PATCH 3/5] drm/amdgpu: Add ras helper to query boot errors

2024-01-01 Thread Hawking Zhang
Add ras helper function to query boot time gpu errors. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 95 + drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 15 +++- 3 files changed, 112 insertions(+), 1

[PATCH 2/5] drm/amdgpu: Init pcie_index/data address as fallback

2024-01-01 Thread Hawking Zhang
To allow using this helper for indirect access when nbio funcs is not available. For instance, in ip discovery phase. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/

[PATCH 1/5] drm/amdgpu: drop psp v13 query_boot_status implementation

2024-01-01 Thread Hawking Zhang
Will replace it with new implementation to cover boot fails in ip discovery phase. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 - drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 15 - drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h| 4 -- drivers/gpu/drm/amd/am

[PATCH 0/5] Add boot time error reporting

2024-01-01 Thread Hawking Zhang
For ASICs that support boot time error reporting, poll all the boot time errors cached in registers and make it available in kernel log. Hawking Zhang (5): drm/amdgpu: drop psp v13 query_boot_status implementation drm/amdgpu: Init pcie_index/data address as fallback drm/amdgpu: Add ras helpe

Re: [PATCH] drm/amd/display: Fix sending VSC (+ colorimetry) packets for DP/eDP displays without PSR

2024-01-01 Thread Joshua Ashton
From the issue: ``` Thank you for for fixing this! I built a custom kernel with this patch on the fedora rawhide kernel (6.7.0-0.rc8.61.fc40.x86_64) and now the colors look correct. SDR content is now displayed as sRGB and HDR/WCG content can use the full capabilities of the display. I current

[PATCH] drm/amd/display: Fix sending VSC (+ colorimetry) packets for DP/eDP displays without PSR

2024-01-01 Thread Joshua Ashton
The check for sending the vsc infopacket to the display was gated behind PSR (Panel Self Refresh) being enabled. The vsc infopacket also contains the colorimetry (specifically the container color gamut) information for the stream on modern DP. PSR is typically only supported on mobile phone eDP d