RE: [PATCH v2] drm/amdgpu: Use the right method to get IP version

2023-12-06 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Thursday, December 7, 2023 12:23 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH v2] drm/amdgpu: Use the right method to g

[linux-next:master] BUILD REGRESSION 577a4ee0b96fb043c9cf4a533c550ff587e526cf

2023-12-06 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 577a4ee0b96fb043c9cf4a533c550ff587e526cf Add linux-next specific files for 20231206 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202312061337.wnvsk0al-...@intel.com https

[PATCH v2] drm/amdgpu: Use the right method to get IP version

2023-12-06 Thread Lijo Lazar
Replace direct usage of adev->ip_versions with amdgpu_ip_version. Signed-off-by: Lijo Lazar --- v2: Fix two more instances in amdgpu_dm.c drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ++- drivers/gpu/drm/amd/amdgpu/gmc_v

Re: [PATCH] drm/amd/pm: fix pp_*clk_od typo

2023-12-06 Thread Lazar, Lijo
On 12/7/2023 1:09 AM, Dmitrii Galantsev wrote: Fix pp_dpm_sclk_od and pp_dpm_mclk_od typos. Those were defined as pp_*clk_od but used as pp_dpm_*clk_od instead. This change removes the _dpm part. Signed-off-by: Dmitrii Galantsev Reviewed-by: Lijo Lazar Add below tag also before w

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-06 Thread Mario Limonciello
On 12/6/2023 20:07, Kai-Heng Feng wrote: On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello wrote: On 12/6/2023 19:23, Kai-Heng Feng wrote: On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello wrote: On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles on hardwar

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-06 Thread Mario Limonciello
On 12/6/2023 19:23, Kai-Heng Feng wrote: On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello wrote: On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles on hardware rotated modes. So, if a user is using hardware rotated modes with PSR-SU enabled, use PSR-SU FFU fo

[pull] amdgpu drm-fixes-6.7

2023-12-06 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.7. The following changes since commit 33924328498e903bea74727353e5012d29653aff: Merge tag 'drm-intel-fixes-2023-12-01-1' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2023-12-05 12:19:22 +1000) are available in the Git repository at: https://gi

[PATCH v2 1/2] drm/amdgpu: Auto-validate DMABuf imports in compute VMs

2023-12-06 Thread Felix Kuehling
DMABuf imports in compute VMs are not wrapped in a kgd_mem object on the process_info->kfd_bo_list. There is no explicit KFD API call to validate them or add eviction fences to them. This patch automatically validates and fences dymanic DMABuf imports when they are added to a compute VM. Revalidat

[PATCH v2 2/2] drm/amdkfd: Bump KFD ioctl version

2023-12-06 Thread Felix Kuehling
This is not strictly a change in the IOCTL API. This version bump is meant to indicate to user mode the presence of a number of changes and fixes that enable the management of VA mappings in compute VMs using the GEM_VA ioctl for DMABufs exported from KFD. Signed-off-by: Felix Kuehling --- inclu

Proposal to add CRIU support to DRM render nodes

2023-12-06 Thread Felix Kuehling
Executive Summary: We need to add CRIU support to DRM render nodes in order to maintain CRIU support for ROCm application once they start relying on render nodes for more GPU memory management. In this email I'm providing some background why we are doing this, and outlining some of the problems

Re: [PATCH] drm/amd/pm: fix pp_*clk_od typo

2023-12-06 Thread Deucher, Alexander
[AMD Official Use Only - General] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Dmitrii Galantsev Sent: Wednesday, December 6, 2023 2:39 PM To: amd-gfx@lists.freedesktop.org Cc: Galantsev, Dmitrii Subject: [PATCH] drm/amd/pm: fix pp_*clk_od typo Fix p

[PATCH 13/13] drm/amd/display: 3.2.264

2023-12-06 Thread Aurabindo Pillai
From: Aric Cyr Summary: Bug fixes for: * DCN35 power gating * P-state change, & prefetch logic * ABM * DP 2.1 Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 10/13] drm/amd/display: For prefetch mode > 0, extend prefetch if possible

2023-12-06 Thread Aurabindo Pillai
From: Alvin Lee [Description] For mode programming we want to extend the prefetch as much as possible (up to oto, or as long as we can for equ) if we're not already applying the 60us prefetch requirement. This is to avoid intermittent underflow issues during prefetch. The prefetch extension is a

[PATCH 08/13] drm/amd/display: Disable OPTC pg to match DC Hubp/dpp pg

2023-12-06 Thread Aurabindo Pillai
From: Allen [Why] To match the hardware sequence Reviewed-by: Charlene Liu Acked-by: Aurabindo Pillai Signed-off-by: Allen --- drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn3

[PATCH 04/13] drm/amd/display: Revert "Fix conversions between bytes and KB"

2023-12-06 Thread Aurabindo Pillai
From: Taimur Hassan [Why & How] HostVMMinPageSize is expected to be in KB according to spec, the checks later down the line reflect this as well. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Taimur Hassan --- .../drm/amd/display/dc/dml2/display_mode_core.c | 16

[PATCH 12/13] drm/amd/display: fix HW block PG sequence

2023-12-06 Thread Aurabindo Pillai
From: Charlene Liu [why] Power up and power down has reverted programming order. also make sure disable root clock last. Reviewed-by: Muhammad Ahmed Acked-by: Aurabindo Pillai Signed-off-by: Charlene Liu --- .../gpu/drm/amd/display/dc/dcn35/dcn35_init.c | 3 +- .../amd/display/dc/hwss/dcn3

[PATCH 07/13] drm/amd/display: Populate dtbclk from bounding box

2023-12-06 Thread Aurabindo Pillai
From: Fangzhi Zuo dtbclk is unavaliable from pmfw. Try to grab the value from bounding box Reviewed-by: Charlene Liu Acked-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 14 +- .../amd/display/dc/dml2/dml2_translation_help

[PATCH 11/13] drm/amd/display: Force p-state disallow if leaving no plane config

2023-12-06 Thread Aurabindo Pillai
From: Alvin Lee [Description] - When we're in a no plane config, DCN is always asserting P-State allow - This creates a scenario where the P-State blackout can start just as VUPDATE takes place and transitions the DCN config to a one where one or more HUBP's are active which can result in

[PATCH 06/13] drm/amd/display: Revert DP2 MST hub triple display fix

2023-12-06 Thread Aurabindo Pillai
From: Michael Strauss [WHY] Introduces regression with DP2 native displays [HOW] Revert commit 311ba210d Reviewed-by: Charlene Liu Acked-by: Aurabindo Pillai Signed-off-by: Michael Strauss --- drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 7 --- 1 file changed, 7 deletions(-) diff

[PATCH 09/13] drm/amd/display: Exit from idle state before accessing HW data

2023-12-06 Thread Aurabindo Pillai
From: Sung Joon Kim [why & how] User interface cannot guarantee system is in idle state, so need to ensure we exit idle state before accessing any HW data. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim --- drivers/gpu/drm/amd/display/dc/dce/dmub_abm

[PATCH 01/13] drm/amd/display: Remove minor revision 5 until proper parser is ready

2023-12-06 Thread Aurabindo Pillai
From: Joshua Aberback Reviewed-by: Dillon Varone Acked-by: Aurabindo Pillai Signed-off-by: Joshua Aberback --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/disp

[PATCH 05/13] drm/amd/display: trivial comment change

2023-12-06 Thread Aurabindo Pillai
FP guard is valid for all recent asics, not just RV, so fix the comment. Reviewed-by: Chaitanya Dhere Acked-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/

[PATCH 03/13] drm/amd/display: allow DP40 cables to do UHBR13.5

2023-12-06 Thread Aurabindo Pillai
From: Ran Shi why: With DP2.1a expansion we are allowing DP40 cables to do UHBR13.5 how: Assume UHBR10 means UHBR13.5 also for unknown cable type and passive cable type. Reviewed-by: George Shen Acked-by: Aurabindo Pillai Signed-off-by: Ran Shi --- .../display/dc/link/protocols/link_dp_capa

[PATCH 00/13] DC Patches for Dec 11, 2023

2023-12-06 Thread Aurabindo Pillai
This DC patchset brings improvements in multiple areas. In summary, we have: Bug fixes for: * DCN35 power gating * P-state change, & prefetch logic * ABM * DP 2.1 Cc: Daniel Wheeler === Allen (1): drm/amd/display: Disable OPTC pg to match DC Hubp/dpp pg Alvin Lee (2): drm/amd/dis

[PATCH 02/13] drm/amd/display: Use explicit size for types in DCCG's struct dp_dto_params

2023-12-06 Thread Aurabindo Pillai
Reviewed-by: Alvin Lee Acked-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h b/drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h

[PATCH] drm/amd/pm: fix pp_*clk_od typo

2023-12-06 Thread Dmitrii Galantsev
Fix pp_dpm_sclk_od and pp_dpm_mclk_od typos. Those were defined as pp_*clk_od but used as pp_dpm_*clk_od instead. This change removes the _dpm part. Signed-off-by: Dmitrii Galantsev --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH] drm/amd/display: Restore guard against default backlight value < 1 nit

2023-12-06 Thread Mario Limonciello
Mark reports that brightness is not restored after Xorg dpms screen blank. This behavior was introduced by commit d9e865826c20 ("drm/amd/display: Simplify brightness initialization") which dropped the cached backlight value in display code, but also removed code for when the default value read bac

Re: [PATCH] drm/amdgpu: Use the right method to get IP version

2023-12-06 Thread Lazar, Lijo
On 12/6/2023 7:40 PM, Alex Deucher wrote: On Wed, Dec 6, 2023 at 7:57 AM Lijo Lazar wrote: Replace direct usage of adev->ip_versions with amdgpu_ip_version. Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher I see two more instances of direct use. Will send a v2. Thanks, Lijo --

Re: [PATCH v2] drm/amdkfd: Use partial hmm page walk during buffer validation in SVM

2023-12-06 Thread Chen, Xiaogang
On 12/5/2023 12:48 PM, Philip Yang wrote: On 2023-12-04 15:23, Xiaogang.Chen wrote: From: Xiaogang Chen v2: -not need calculate vram page number for new registered svm range, only do it for split vram pages. SVM uses hmm page walk to valid buffer before map to gpu vm. After have partial mi

[PATCH v3] drm/amdkfd: Use partial hmm page walk during buffer validation in SVM

2023-12-06 Thread Xiaogang . Chen
From: Xiaogang Chen v2: -not need calculate vram page number for new registered svm range, only do it for split vram pages. v3: -use dma address to calculate vram page number of split svm range; use migrate_vma from hmm to calculate page number that migrate to vram. SVM uses hmm page walk to va

Re: [PATCH v3 3/9] drm/amd/display: read gamut remap matrix in fixed-point 31.32 format

2023-12-06 Thread Rodrigo Siqueira Jordao
On 11/28/23 10:52, Melissa Wen wrote: Instead of read gamut remap data from hw values, convert HW register values (S2D13) into a fixed-point 31.32 matrix for color state log. Change DCN10 log to print data in the format of the gamut remap matrix. Signed-off-by: Melissa Wen --- .../amd/disp

Re: [PATCH v3 1/9] drm/amd/display: decouple color state from hw state log

2023-12-06 Thread Rodrigo Siqueira Jordao
On 11/28/23 10:52, Melissa Wen wrote: Prepare to hook up color state log according to the DCN version. v3: - put functions in single line (Siqueira) Signed-off-by: Melissa Wen --- .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 26 +-- 1 file changed, 18 insertions(+), 8

Re: [REGRESSION] rx7600 stopped working after "1cfb4d612127 drm/amdgpu: put MQDs in VRAM"

2023-12-06 Thread Linux regression tracking #update (Thorsten Leemhuis)
[TLDR: This mail in primarily relevant for Linux kernel regression tracking. See link in footer if these mails annoy you.] On 26.10.23 19:33, Alexey Klimov wrote: > #regzbot introduced: 1cfb4d612127 > #regzbot title: rx7600 stopped working after "1cfb4d612127 drm/amdgpu: put > MQDs in VRAM" > >

Re: [PATCH] drm/amdgpu: Use the right method to get IP version

2023-12-06 Thread Alex Deucher
On Wed, Dec 6, 2023 at 7:57 AM Lijo Lazar wrote: > > Replace direct usage of adev->ip_versions with amdgpu_ip_version. > > Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

RE: [PATCH] drm/amdgpu: Use the right method to get IP version

2023-12-06 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, December 6, 2023 20:41 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH] drm/amdgpu: Use the right method to get

[PATCH] drm/amdgpu: Use the right method to get IP version

2023-12-06 Thread Lijo Lazar
Replace direct usage of adev->ip_versions with amdgpu_ip_version. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ++- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- drivers/gpu/drm/amd/displ