[PATCH 7/7] drm/amd/display: Promote DAL to 3.2.262

2023-11-21 Thread Tom Chung
From: Aric Cyr This version brings along following fixes: - Add DSC granular throughput adjustment - Allow DTBCLK disable for DCN35 - Update Fixed VS/PE Retimer Sequence - Block dcn315 dynamic crb allocation when unintended - Update dcn315 lpddr pstate latency Reviewed-by: Tom Chung Acked-by: T

[PATCH 6/7] drm/amd/display: Add DSC granular throughput adjustment

2023-11-21 Thread Tom Chung
From: Ilya Bakoulin [Why/How] Update DSC DPCD parsing to take granular throughput adjustment into consideration. Reviewed-by: Wenjing Liu Acked-by: Tom Chung Signed-off-by: Ilya Bakoulin --- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 10 -- 1 file changed, 8 insertions(+), 2 delet

[PATCH 4/7] drm/amd/display: [FW Promotion] Release 0.0.194.0

2023-11-21 Thread Tom Chung
From: Anthony Koo - Add a new dmub command in enum dmub_cmd_cab_type Reviewed-by: Tom Chung Acked-by: Tom Chung Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd

[PATCH 5/7] drm/amd/display: Allow DTBCLK disable for DCN35

2023-11-21 Thread Tom Chung
From: Nicholas Kazlauskas [Why] DTBCLK is enabled on idle and it will burn power. [How] There's a few issues here: - Always enabling DTBCLK on clock manager init - Setting refclk when DTBCLK is supposed to be disabled - Not applying the correct calculated version refclk, but instead the base v

[PATCH 3/7] drm/amd/display: Update Fixed VS/PE Retimer Sequence

2023-11-21 Thread Tom Chung
From: Michael Strauss [WHY/HOW] Add a new AUX sequence provided by vendor to improve interop with specific display configurations. Reviewed-by: Wenjing Liu Acked-by: Tom Chung Signed-off-by: Michael Strauss --- .../protocols/link_dp_training_fixed_vs_pe_retimer.c | 10 ++ 1 file ch

[PATCH 2/7] drm/amd/display: block dcn315 dynamic crb allocation when unintended

2023-11-21 Thread Tom Chung
From: Dmytro Laktyushkin [WHY/HOW] Limit the dynamic crb to dual stream configs that include eDP Reviewed-by: Charlene Liu Acked-by: Tom Chung Signed-off-by: Dmytro Laktyushkin --- .../drm/amd/display/dc/resource/dcn315/dcn315_resource.c| 6 -- 1 file changed, 4 insertions(+), 2 dele

[PATCH 1/7] drm/amd/display: update dcn315 lpddr pstate latency

2023-11-21 Thread Tom Chung
From: Dmytro Laktyushkin [WHY/HOW] Increase the pstate latency to improve ac/dc transition Reviewed-by: Charlene Liu Acked-by: Tom Chung Signed-off-by: Dmytro Laktyushkin --- .../drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 8 1 file changed, 4 insertions(+), 4 deletions(

[PATCH 0/7] DC Patches Nov 20 2023

2023-11-21 Thread Tom Chung
This DC patchset brings improvements in multiple areas. In summary, we have: - Add DSC granular throughput adjustment - Allow DTBCLK disable for DCN35 - Update Fixed VS/PE Retimer Sequence - Block dcn315 dynamic crb allocation when unintended - Update dcn315 lpddr pstate latency Cc: Daniel Wheele

[PATCH v2] drm/amdgpu: fix memory overflow in the IB test

2023-11-21 Thread Tim Huang
Fix a memory overflow issue in the gfx IB test for some ASICs. At least 20 bytes are needed for the IB test packet. v2: correct code indentation errors. (Christian) Signed-off-by: Tim Huang Reviewed-by: Yifan Zhang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +

RE: [PATCH] drm/amdgpu: add init_registers for nbio v7.11

2023-11-21 Thread Zhang, Yifan
[AMD Official Use Only - General] Reviewed-by: Yifan Zhang -Original Message- From: Ma, Li Sent: Tuesday, November 21, 2023 5:10 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Zhang, Yifan ; Yu, Lang ; Ma, Li Subject: [PATCH] drm/amdgpu: add init_r

[PATCH v2 4/4] drm/amdkfd: Import DMABufs for interop through DRM

2023-11-21 Thread Felix Kuehling
Use drm_gem_prime_fd_to_handle to import DMABufs for interop. This ensures that a GEM handle is created on import and that obj->dma_buf will be set and remain set as long as the object is imported into KFD. Signed-off-by: Felix Kuehling Reviewed-by: Ramesh Errabolu Reviewed-by: Xiaogang.Chen Ac

[PATCH v2 3/4] drm/amdkfd: Export DMABufs from KFD using GEM handles

2023-11-21 Thread Felix Kuehling
Create GEM handles for exporting DMABufs using GEM-Prime APIs. The GEM handles are created in a drm_client_dev context to avoid exposing them in user mode contexts through a DMABuf import. Signed-off-by: Felix Kuehling Reviewed-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c

[PATCH v2 2/4] drm/prime: Helper to export dmabuf without fd

2023-11-21 Thread Felix Kuehling
Change drm_gem_prime_handle_to_fd to drm_gem_prime_handle_to_dmabuf to export a dmabuf without creating an FD as a user mode handle. This is more useful for users in kernel mode. Suggested-by: Thomas Zimmermann Signed-off-by: Felix Kuehling --- drivers/gpu/drm/drm_prime.c | 63 +

[PATCH v2 1/4] Revert "drm/prime: Unexport helpers for fd/handle conversion"

2023-11-21 Thread Felix Kuehling
This reverts commit 71a7974ac7019afeec105a54447ae1dc7216cbb3. These helper functions are needed for KFD to export and import DMABufs the right way without duplicating the tracking of DMABufs associated with GEM objects while ensuring that move notifier callbacks are working as intended. CC: Chris

Re: ✓ Fi.CI.BAT: success for drm/i915: Fix UHBR data, link M/N/TU and PBN values (rev6)

2023-11-21 Thread Imre Deak
On Tue, Nov 21, 2023 at 02:37:33AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix UHBR data, link M/N/TU and PBN values (rev6) > URL : https://patchwork.freedesktop.org/series/126526/ > State : success Thanks for the reviews and acks, the patchset is pushed to drm-inte

Re: [RFC PATCH v2] drm/amdkfd: Run restore_workers on freezable WQs

2023-11-21 Thread Felix Kuehling
[+Gang] On 2023-11-10 07:07, Pan, Xinhui wrote: [AMD Official Use Only - General] Wait, I think we need a small fix below. --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -2036,6 +2036,7 @@ int kfd_resume_all_processes(void) int ret = 0

[PATCH] drm/radeon: Fix eDP for single-display iMac11,1

2023-11-21 Thread Alex Deucher
From: Gilles Risch The Apple iMac11,1 (late 2009) has an integrated ATI Mobility Radeon HD 4850. This machine suffers from a similar problem as the iMac10,1 (late 2009) and the iMac11,2 (mid 2010). This small patch fixes the issue on this machine. Fixes freedesktop issue 164 Link: https://gitlab

Re: [PATCH] drm/amdgpu: add init_registers for nbio v7.11

2023-11-21 Thread Alex Deucher
On Tue, Nov 21, 2023 at 4:27 AM Li Ma wrote: > > enable init_registers callback func for nbio v7.11. > > Signed-off-by: Li Ma Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 18 ++-- > .../asic_reg/nbio/nbio_7_11_0_offset.h| 2 ++ > .../asic_reg

Re: [PATCH] gpu: display: remove unnecessary braces to fix coding style

2023-11-21 Thread Alex Deucher
On Tue, Nov 21, 2023 at 4:27 AM Christian König wrote: > > Am 21.11.23 um 05:36 schrieb RutingZhang: > > checkpatch complains that: > > > > WARNING: braces {} are not necessary for single statement blocks > > +if (pool->base.irqs != NULL) { > > +dal_irq_serv

[PATCH] dma-buf: Correct the documentation of name and exp_name symbols

2023-11-21 Thread Ramesh Errabolu
Fix the documentation of struct dma_buf members name and exp_name as to how these members are to be used and accessed. Signed-off-by: Ramesh Errabolu --- include/linux/dma-buf.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/linux/dma-buf.h b/include/linu

Re: WARNING in allocate_mst_payload

2023-11-21 Thread Jeff Layton
The monitors are individually connected to the same card. The Dell 34" is connected via displayport, and the Sceptre monitor is connected via HDMI. Thanks, Jeff On Tue, 2023-11-21 at 14:13 +0100, Christian König wrote: > Hi Jeff, > > first of all adding Harry from our display team. > > From a

Re: [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

2023-11-21 Thread Felix Kuehling
There are two patches that didn't make it into Linux 6.6 that reduce the stack size in kfd_topology_add_device. Can you check if those fix the problem? commit aa5a9b2ccda2fa834fddb4bd30a2ab831598f551 Author: Alex Deucher Date: Tue Sep 26 12:00:23 2023 -0400 drm/amdkfd: drop struct kfd_c

Re: [PATCH] drm/amdgpu: Force order between a read and write to the same address

2023-11-21 Thread Felix Kuehling
On 2023-11-20 12:41, Alex Sierra wrote: Setting register to force ordering to prevent read/write or write/read hazards for un-cached modes. Signed-off-by: Alex Sierra Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 8 .../gpu/drm/amd

[PATCH 2/2] drm/amdgpu: fix AGP addressing when GART is not at 0

2023-11-21 Thread Alex Deucher
This worked by luck if the GART aperture ended up at 0. When we ended up moving GART on some chips, the GART aperture ended up offsetting the the AGP address since the resource->start is a GART offset, not an MC address. Fix this by moving the AGP address setup into amdgpu_bo_gpu_offset_no_check(

[PATCH 1/2] drm/amdgpu/gmc: check if AGP is disabled in amdgpu_gmc_agp_addr()

2023-11-21 Thread Alex Deucher
Return AMDGPU_BO_INVALID_OFFSET if the AGP aperture is disabled. There is no reason to check further if the aperture is disabled. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c

Re: [PATCH] drm/amdgpu: fix memory overflow in the IB test

2023-11-21 Thread Christian König
Am 21.11.23 um 07:25 schrieb Tim Huang: Fix a memory overflow issue in the gfx IB test for some ASICs. At least 20 bytes are needed for the IB test packet. Signed-off-by: Tim Huang Good catch. --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2

[PATCH] gpu: display: remove unnecessary braces to fix coding style

2023-11-21 Thread RutingZhang
checkpatch complains that: WARNING: braces {} are not necessary for single statement blocks +if (pool->base.irqs != NULL) { +dal_irq_service_destroy(&pool->base.irqs); +} Fixed it by removing unnecessary braces to fix the coding style issue.

Re: [Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-21 Thread Heiner Kallweit
On 21.11.2023 09:58, Jani Nikula wrote: > On Mon, 20 Nov 2023, Heiner Kallweit wrote: >> v4: >> - more ack and review tags > > Please do not send new versions just to record the acks and > reviews. They should be added while applying the patches. > Right, typically also patchwork interprets and

Re: Radeon regression in 6.6 kernel

2023-11-21 Thread Alex Deucher
On Mon, Nov 20, 2023 at 5:40 PM Phillip Susi wrote: > > Alex Deucher writes: > > > Yes. Those changes went into 6.7 though, not 6.6 AFAIK. Maybe I'm > > misunderstanding what the original report was actually testing. If it > > was 6.7, then try reverting: > > 56e449603f0ac580700621a356d35d5716

Re: [PATCH v2 01/11] drm/dp_mst: Store the MST PBN divider value in fixed point format

2023-11-21 Thread Imre Deak
On Thu, Nov 16, 2023 at 03:18:31PM +0200, Imre Deak wrote: [...] > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > index ed784cf27d396..63024393b516e 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_d

Re: WARNING in allocate_mst_payload

2023-11-21 Thread Christian König
Hi Jeff, first of all adding Harry from our display team. From a quick look the obvious missing information is how are your monitors wired up? Are those individually DP or HDMI connected to the PC or are they daisy chained through MST? If it's daisy chained please double check that you don't

WARNING in allocate_mst_payload

2023-11-21 Thread Jeff Layton
I have a recurring problem where my workstation tries to put the monitor to sleep, which triggers a warning down in the depths of the video card driver. When I return to the machine the monitor is black, but not in powersave mode and all of the windows on my desktop have been shuffled off to the se

Re: [PATCH] gpu: display: remove unnecessary braces to fix coding style

2023-11-21 Thread Christian König
Am 21.11.23 um 05:36 schrieb RutingZhang: checkpatch complains that: WARNING: braces {} are not necessary for single statement blocks +if (pool->base.irqs != NULL) { +dal_irq_service_destroy(&pool->base.irqs); +} Fixed it by removing unnec

[PATCH] drm/amdgpu: add init_registers for nbio v7.11

2023-11-21 Thread Li Ma
enable init_registers callback func for nbio v7.11. Signed-off-by: Li Ma --- drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 18 ++-- .../asic_reg/nbio/nbio_7_11_0_offset.h| 2 ++ .../asic_reg/nbio/nbio_7_11_0_sh_mask.h | 29 +++ 3 files changed, 40 inserti

Re: [Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-21 Thread Jani Nikula
On Mon, 20 Nov 2023, Heiner Kallweit wrote: > v4: > - more ack and review tags Please do not send new versions just to record the acks and reviews. They should be added while applying the patches. Thanks, Jani. -- Jani Nikula, Intel