RE: [PATCH] drm/amdgpu: needn't set aggregated doorbell for map queue

2023-11-13 Thread Liang, Prike
[Public] Please ignore this patch, double confirm from the stakeholder the MES map queue has possibility to change as an unmap queue after write the doorbell. Regards, --Prike > -Original Message- > From: Liang, Prike > Sent: Thursday, November 9, 2023 3:36 PM > To: amd-gfx@lists.freed

[PATCH] drm/amdgpu: correct the amdgpu runtime dereference usage count

2023-11-13 Thread Prike Liang
Fix the amdgpu runpm dereference usage count. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index 0cac

RE: [PATCH 1/2] drm/amdgpu: correct the amdgpu runtime dereference usage count

2023-11-13 Thread Liang, Prike
[Public] > -Original Message- > From: Deucher, Alexander > Sent: Friday, November 10, 2023 5:46 AM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH 1/2] drm/amdgpu: correct the amdgpu runtime > dereference usage count > > [Public] > > > -Original Message- >

[PATCH] drm/amdkfd: Fix sq_intr error typo

2023-11-13 Thread Yunxiang Li
Here the register field should be read from context_id1 rather than 0 as indicated by the macro name. Fixes: cc009e613de6 ("drm/amdkfd: Add KFD support for soc21 v3") Signed-off-by: Yunxiang Li --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> We're not in a hurry. It's just my experience with patch series' affecting > multiple subsystems that typically the decision was to apply the full > series via one tree. Also to avoid inquires from maintainers like: > Shall I take it or are you going to take it? > Of course there may be differen

[PATCH] drm/amd/display: fix a NULL pointer dereference in amdgpu_dm_i2c_xfer()

2023-11-13 Thread Mario Limonciello
When ddc_service_construct() is called, it explicitly checks both the link type and whether there is something on the link which will dictate whether the pin is marked as hw_supported. If the pin isn't set or the link is not set (such as from unloading/reloading amdgpu in an IGT test) then fail th

Re: [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support

2023-11-13 Thread Harry Wentland
Please just use "drm/amd/display:" as tag in the commit subject. With that fixed, this is Acked-by: Harry Wentland Harry On 2023-11-13 06:23, Heiner Kallweit wrote: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> Preferably this series should be applied via the i2c tree. Are we in a hurry here, i.e. does it block further development of the i801 smbus driver? My gut feeling says the patches should rather go via drm and fbdev trees, but I may be convinced otherwise. signature.asc Description: PGP signa

Re: [PATCH 19/24] drm/amdkfd: enable pc sampling stop

2023-11-13 Thread James Zhu
On 2023-11-13 12:04, Yat Sin, David wrote: [AMD Official Use Only - General] *From:* Zhu, James *Sent:* Monday, November 13, 2023 10:20 AM *To:* Yat Sin, David ; Zhu, James ; amd-gfx@lists.freedesktop.org *Cc:* Kuehling, Felix ; Greathouse, Joseph *Subject:* Re: [PATCH 19/24] drm/amdkfd:

RE: [PATCH 19/24] drm/amdkfd: enable pc sampling stop

2023-11-13 Thread Yat Sin, David
[AMD Official Use Only - General] From: Zhu, James Sent: Monday, November 13, 2023 10:20 AM To: Yat Sin, David ; Zhu, James ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Greathouse, Joseph Subject: Re: [PATCH 19/24] drm/amdkfd: enable pc sampling stop On 2023-11-10 14:07, Yat Sin,

Re: [Patch v3] drm/ttm: Schedule delayed_delete worker closer

2023-11-13 Thread Christian König
Am 11.11.23 um 14:08 schrieb Rajneesh Bhardwaj: Try to allocate system memory on the NUMA node the device is closest to and try to run delayed_delete workers on a CPU of this node as well. To optimize the memory clearing operation when a TTM BO gets freed by the delayed_delete worker, scheduling

Re: [PATCH v2] drm/amd/display: add a debugfs interface for the DMUB trace mask

2023-11-13 Thread Aurabindo Pillai
On 11/13/2023 9:56 AM, Hamza Mahfooz wrote: For features that are implemented primarily in DMUB (e.g. PSR), it is useful to be able to trace them at a DMUB level from the kernel, especially when debugging issues. So, introduce a debugfs interface that is able to read and set the DMUB trace mas

Re: [PATCH v2] drm/amd/display: add a debugfs interface for the DMUB trace mask

2023-11-13 Thread Christian König
Am 13.11.23 um 15:56 schrieb Hamza Mahfooz: For features that are implemented primarily in DMUB (e.g. PSR), it is useful to be able to trace them at a DMUB level from the kernel, especially when debugging issues. So, introduce a debugfs interface that is able to read and set the DMUB trace mask d

Re: [PATCH 22/24] drm/amdkfd: add pc sampling release when process release

2023-11-13 Thread James Zhu
On 2023-11-13 10:19, Yat Sin, David wrote: [AMD Official Use Only - General] *From:* Zhu, James *Sent:* Monday, November 13, 2023 10:13 AM *To:* Yat Sin, David ; Zhu, James ; amd-gfx@lists.freedesktop.org *Cc:* Kuehling, Felix ; Greathouse, Joseph *Subject:* Re: [PATCH 22/24] drm/amdkfd:

Re: [PATCH 19/24] drm/amdkfd: enable pc sampling stop

2023-11-13 Thread James Zhu
On 2023-11-10 14:07, Yat Sin, David wrote: [AMD Official Use Only - General] -Original Message- From: Zhu, James Sent: Friday, November 3, 2023 9:12 AM To:amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix; Greathouse, Joseph ; Yat Sin, David; Zhu, James Subject: [PATCH 19/24] drm/amdkf

RE: [PATCH 22/24] drm/amdkfd: add pc sampling release when process release

2023-11-13 Thread Yat Sin, David
[AMD Official Use Only - General] From: Zhu, James Sent: Monday, November 13, 2023 10:13 AM To: Yat Sin, David ; Zhu, James ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Greathouse, Joseph Subject: Re: [PATCH 22/24] drm/amdkfd: add pc sampling release when process release On 2023

Re: [PATCH 22/24] drm/amdkfd: add pc sampling release when process release

2023-11-13 Thread James Zhu
On 2023-11-10 14:08, Yat Sin, David wrote: [AMD Official Use Only - General] -Original Message- From: Zhu, James Sent: Friday, November 3, 2023 9:12 AM To:amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix; Greathouse, Joseph ; Yat Sin, David; Zhu, James Subject: [PATCH 22/24] drm/amdkf

RE: [PATCH v2] drm/amdgpu: Do not program VF copy regs in mmhub v1.8 under SRIOV (v2)

2023-11-13 Thread Dhume, Samir
[AMD Official Use Only - General] Reviewed-by: Samir Dhume -Original Message- From: Lu, Victor Cheng Chi (Victor) Sent: Friday, November 10, 2023 5:00 PM To: amd-gfx@lists.freedesktop.org Cc: Dhume, Samir ; Lu, Victor Cheng Chi (Victor) Subject: [PATCH v2] drm/amdgpu: Do not program V

[PATCH v2] drm/amd/display: add a debugfs interface for the DMUB trace mask

2023-11-13 Thread Hamza Mahfooz
For features that are implemented primarily in DMUB (e.g. PSR), it is useful to be able to trace them at a DMUB level from the kernel, especially when debugging issues. So, introduce a debugfs interface that is able to read and set the DMUB trace mask dynamically at runtime and document how to use

RE: [PATCH 00/20] DC Patches Nov 08, 2023

2023-11-13 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eD

Re: [PATCH 2/2] drm/virtio: Modify RESOURCE_GET_LAYOUT ioctl

2023-11-13 Thread Dmitry Osipenko
On 11/10/23 10:16, Julia Zhang wrote: > Modify RESOURCE_GET_LAYOUT ioctl to handle the use case that query > correct stride for guest linear resource before it is created. > > Signed-off-by: Julia Zhang > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 26 -- > drivers/gpu/drm/virtio/

RE: [PATCH 1/1] drm/amdgpu: finalizing mem_partitions at the end of GMC v9 sw_fini

2023-11-13 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Ma, Le Sent: Monday, November 13, 2023 18:36 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH 1/1] drm/amdgpu: finalizing mem_partitions at the end of GMC v9 sw_f

[PATCH 1/1] drm/amdgpu: finalizing mem_partitions at the end of GMC v9 sw_fini

2023-11-13 Thread Le Ma
The valid num_mem_partitions is required during ttm pool fini, thus move the cleanup at the end of the function. Signed-off-by: Le Ma --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/driver

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Simon Ser
On Monday, November 13th, 2023 at 11:15, Pekka Paalanen wrote: > > > On Mon, 13 Nov 2023 09:44:15 + > Simon Ser cont...@emersion.fr wrote: > > > On Monday, November 13th, 2023 at 10:38, Pekka Paalanen ppaala...@gmail.com > > wrote: > > > > > On Mon, 13 Nov 2023 09:18:39 + > >

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Pekka Paalanen
On Mon, 13 Nov 2023 09:44:15 + Simon Ser wrote: > On Monday, November 13th, 2023 at 10:38, Pekka Paalanen > wrote: > > > On Mon, 13 Nov 2023 09:18:39 + > > Simon Ser cont...@emersion.fr wrote: > > > > > On Monday, October 23rd, 2023 at 10:25, Simon Ser cont...@emersion.fr > > > wro

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Michel Dänzer
On 11/13/23 10:47, Simon Ser wrote: > On Monday, November 13th, 2023 at 10:41, Michel Dänzer > wrote: > >> On 11/13/23 10:18, Simon Ser wrote: >> >>> On Monday, October 23rd, 2023 at 10:25, Simon Ser cont...@emersion.fr wrote: >>> > +An atomic commit with the flag DRM_MODE_PAGE_FLIP_

Re: [PATCH v2] drm/amdgpu: Address member 'ring' not described in 'amdgpu_ vce, uvd_entity_init()'

2023-11-13 Thread Christian König
Am 13.11.23 um 06:31 schrieb Srinivasan Shanmugam: Fixes the following: drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:237: warning: Function parameter or member 'ring' not described in 'amdgpu_vce_entity_init' drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:405: warning: Function parameter or member 'ring'

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Simon Ser
On Monday, November 13th, 2023 at 10:41, Michel Dänzer wrote: > On 11/13/23 10:18, Simon Ser wrote: > > > On Monday, October 23rd, 2023 at 10:25, Simon Ser cont...@emersion.fr wrote: > > > > > > > > > > > > > > +An atomic commit with the flag > > > > > > > > > > > > DRM_MODE_PAGE_FLIP_ASYNC i

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Simon Ser
On Monday, November 13th, 2023 at 10:38, Pekka Paalanen wrote: > On Mon, 13 Nov 2023 09:18:39 + > Simon Ser cont...@emersion.fr wrote: > > > On Monday, October 23rd, 2023 at 10:25, Simon Ser cont...@emersion.fr wrote: > > > > > > > > > > > > > > +An atomic commit with the flag > > > > > >

Re: [PATCH] drm/amdgpu: Address member 'ring' not described in 'amdgpu_ vce, uvd_entity_init()'

2023-11-13 Thread Christian König
Am 12.11.23 um 05:25 schrieb Srinivasan Shanmugam: Fixes the following: drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:237: warning: Function parameter or member 'ring' not described in 'amdgpu_vce_entity_init' drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:405: warning: Function parameter or member 'ring'

Re: [PATCH] drm/ttm: set max_active to recommened default

2023-11-13 Thread Christian König
Am 11.11.23 um 14:11 schrieb Rajneesh Bhardwaj: To maximize per cpu execution context for the work items, use the recommended settings i.e. WQ_DFL_ACTIVE(256). There is no apparent reason to throttle to 16 while process tear down. Well big NAK to this. During process tear down it can be that hu

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Michel Dänzer
On 11/13/23 10:18, Simon Ser wrote: > On Monday, October 23rd, 2023 at 10:25, Simon Ser wrote: > >>> +An atomic commit with the flag DRM_MODE_PAGE_FLIP_ASYNC is allowed >>> to >>> +effectively change only the FB_ID property on any planes. >>> No-operation changes

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Pekka Paalanen
On Mon, 13 Nov 2023 09:18:39 + Simon Ser wrote: > On Monday, October 23rd, 2023 at 10:25, Simon Ser wrote: > > > > > > > > > > > > +An atomic commit with the flag DRM_MODE_PAGE_FLIP_ASYNC > > > > > > > > > > > is allowed to > > > > > > > > > > > +effectively change only the FB_ID property

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Simon Ser
On Monday, October 23rd, 2023 at 10:25, Simon Ser wrote: > > > > > > > > > > +An atomic commit with the flag DRM_MODE_PAGE_FLIP_ASYNC is > > > > > > > > > > allowed to > > > > > > > > > > +effectively change only the FB_ID property on any planes. > > > > > > > > > > No-operation changes > > > >

RE: [PATCH 2/2] drm/amdgpu: add amdgpu runpm usage trace for separate funcs

2023-11-13 Thread Liang, Prike
[Public] > -Original Message- > From: Deucher, Alexander > Sent: Friday, November 10, 2023 5:49 AM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH 2/2] drm/amdgpu: add amdgpu runpm usage trace for > separate funcs > > [Public] > > > -Original Message- > >

Re: Radeon regression in 6.6 kernel

2023-11-13 Thread Phillip Susi
Bagas Sanjaya writes: > Please show the full bisect log, and also tell why these commits are > skipped. Two of them would not compile and one would not boot. Here's the log. # bad: [4bbdb725a36b0d235f3b832bd0c1e885f0442d9f] Merge tag 'iommu-updates-v6.7' of git://git.kernel.org/pub/scm/linux/