Remove redundant functions members of pptable_funcs and change
the function type as static because they are not called by other
files.
Signed-off-by: Ma Jun
---
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 4 --
.../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 2 -
.../gpu/drm/amd/pm/swsmu/s
[AMD Official Use Only - General]
Series is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Shiwu Zhang
Sent: Tuesday, November 7, 2023 11:06
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH 2/2] drm/amdgpu: expose the connected port num info
On 11/7/2023 1:47 AM, Hunter Chasens wrote:
Resolves Sphinx unexpected indentation warning when compiling
documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
a literal block to keep vertical formatting of the
example power state list.
Signed-off-by: Hunter Chasens
---
By catting the xgmi_port_num sysfs node, it prints out the info in the
format of : -> :
for one xgmi link.
For example, in case of 4 sockets fully and evenly connected setup, it
would be like as below for the first node in the hive.
01:02 -> 02:03
01:03 -> 02:02
01:07 -> 03:04
01:04 -> 03:07
01:06
The port num info is firstly introduced with 20.00.01.13 xgmi ta and
make them as part of topology info.
Signed-off-by: Shiwu Zhang
Reviewed-by: Le Ma
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 1 +
2 files changed, 6 insertions(+)
diff --g
On 2023-11-06 2:14, Lawrence Yiu wrote:
After unbinding a GPU, KFD becomes locked and unusable, resulting in
applications not being able to use ROCm for compute anymore and rocminfo
outputting the following error message:
ROCk module is loaded
Unable to open /dev/kfd read-write: Invalid argument
On 11/6/2023 15:40, Alex Deucher wrote:
On Mon, Nov 6, 2023 at 3:07 PM Mario Limonciello
wrote:
DPM should be enabled on dGPUs that are used in eGPU enclosures
regardless of the host support.
Are you sure? Seems like this would be dependent on whether the eGPU
bridge supports dynamic switch
On Mon, Nov 6, 2023 at 3:07 PM Mario Limonciello
wrote:
>
> DPM should be enabled on dGPUs that are used in eGPU enclosures
> regardless of the host support.
Are you sure? Seems like this would be dependent on whether the eGPU
bridge supports dynamic switching or not.
Alex
>
> Signed-off-by: M
On 11/7/23 00:25, Alex Deucher wrote:
Applied. This matches what we already do in the other clear state headers.
Alex
On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh
wrote:
sparse static analysis tools generate a warning with this message
"Using plain integer as NULL pointer". In this case th
On Mon, Nov 6, 2023 at 4:20 PM Abhinav Singh
wrote:
>
> On 11/7/23 00:25, Alex Deucher wrote:
> > Applied. This matches what we already do in the other clear state headers.
> >
> > Alex
> >
> > On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh
> > wrote:
> >>
> >> sparse static analysis tools genera
On 11/6/23 12:17, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
>
> Signed-off-by: Hunter Chasens
On 11/6/23 11:06, Hunter Chasens wrote:
> First, apologies to Jani Nikula. I accedently top posted on the other thread.
> My email client is giving me a hard time. The following works and, if
> everyone agrees, I'll send out a v2.
>
> * E.g.::
> *
> * S: 19Mhz *
> * 0: 615Mhz
> * 1: 80
Resolves Sphinx unexpected indentation warning when compiling
documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
a literal block to keep vertical formatting of the
example power state list.
Signed-off-by: Hunter Chasens
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++---
On 10/06, Sebastian Wick wrote:
> On Thu, Oct 05, 2023 at 04:14:55PM -0100, Melissa Wen wrote:
> > Hello,
> >
> > Just another iteration for AMD driver-specific color properties.
> > Basically, addressing comments from the previous version.
> >
> > Recap: this series extends the current KMS color
DPM should be enabled on dGPUs that are used in eGPU enclosures
regardless of the host support.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
First, apologies to Jani Nikula. I accedently top posted on the other thread.
My email client is giving me a hard time. The following works and, if
everyone agrees, I'll send out a v2.
* E.g.::
*
* S: 19Mhz *
* 0: 615Mhz
* 1: 800Mhz
* 2: 888Mhz
* 3: 1000Mhz
Am 06.11.23 um 16:47 schrieb Tatsuyuki Ishi:
On Nov 6, 2023, at 22:44, Christian König
wrote:
Am 02.11.23 um 15:04 schrieb Tatsuyuki Ishi:
In Vulkan, it is the application's responsibility to perform adequate
synchronization before a sparse unmap, replace or BO destroy operation.
Until now, t
On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote:
> Tangentially related; the link speed is currently symmetric but there are
> two sysfs files. Mika left a comment in drivers/thunderbolt/switch.c it may
> be asymmetric in the future. So we may need to keep that in mind on any
> d
Applied. This matches what we already do in the other clear state headers.
Alex
On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh
wrote:
>
> sparse static analysis tools generate a warning with this message
> "Using plain integer as NULL pointer". In this case this warning is
> being shown because
On 11/02, Joshua Ashton wrote:
> Also, Melissa, you cannot do:
>
> if (!plane_state->color_mgmt_changed)
> return 0;
>
> in amdgpu_dm_plane_set_color_properties.
>
> The allocation for dc_plane_state could be new and zero'ed so it needs to be
> set every time. (Until AMDGPU h
On 11/02, Joshua Ashton wrote:
>
>
> On 10/5/23 18:15, Melissa Wen wrote:
> > Add 3D LUT property for plane color transformations using a 3D lookup
> > table. 3D LUT allows for highly accurate and complex color
> > transformations and is suitable to adjust the balance between color
> > channels.
Applied. Thanks!
Alex
On Sun, Nov 5, 2023 at 11:07 AM Sam James wrote:
>
> GCC 14 introduces a new -Walloc-size included in -Wextra which errors out
> on various files in drivers/gpu/drm/amd/amdgpu like:
> ```
> amdgpu_amdkfd_gfx_v8.c:241:15: error: allocation of insufficient size ‘4’ for
> ty
On 10/06, Sebastian Wick wrote:
> On Thu, Oct 05, 2023 at 04:15:04PM -0100, Melissa Wen wrote:
> > Add 3D LUT property for plane color transformations using a 3D lookup
> > table. 3D LUT allows for highly accurate and complex color
> > transformations and is suitable to adjust the balance between c
On 11/6/2023 12:10, Lukas Wunner wrote:
On Fri, Nov 03, 2023 at 02:07:57PM -0500, Mario Limonciello wrote:
The USB4 spec specifies that PCIe ports that are used for tunneling
PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and
behave as a PCIe Gen1 device. The actual perform
Applied. Thanks!
On Tue, Oct 24, 2023 at 2:11 PM Bragatheswaran Manickavel
wrote:
>
> The member variable enable_hpo_pg_support is already initialized
> and hence the reinitialization instruction can be removed. Issue
> identified using the doubleinit.cocci Coccinelle semantic patch script.
>
>
On 11/6/23 22:10, Jani Nikula wrote:
On Mon, 06 Nov 2023, Abhinav Singh wrote:
On 11/6/23 16:53, Jani Nikula wrote:
On Fri, 03 Nov 2023, Abhinav Singh wrote:
sparse static analysis tools generate a warning with this message
"Using plain integer as NULL pointer". In this case this warning is
On Mon, Nov 06, 2023 at 10:59:13AM -0600, Mario Limonciello wrote:
> On 11/5/2023 11:39, Lukas Wunner wrote:
> > On Fri, Nov 03, 2023 at 02:07:55PM -0500, Mario Limonciello wrote:
> > > The `is_thunderbolt` bit has been used to indicate that a PCIe device
> > > contained the Intel VSEC which is use
On Fri, Nov 03, 2023 at 02:07:57PM -0500, Mario Limonciello wrote:
> The USB4 spec specifies that PCIe ports that are used for tunneling
> PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and
> behave as a PCIe Gen1 device. The actual performance of these ports is
> controlled b
On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote:
> On Fri, 3 Nov 2023, Mario Limonciello wrote:
>
> > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to
> > using dev_is_removable() to be able to detect USB4 devices as well.
>
> Please extend this with more de
On 11/5/2023 11:39, Lukas Wunner wrote:
On Fri, Nov 03, 2023 at 02:07:55PM -0500, Mario Limonciello wrote:
The `is_thunderbolt` bit has been used to indicate that a PCIe device
contained the Intel VSEC which is used by various parts of the kernel
to change behavior. To later allow usage with USB
On 11/6/2023 06:52, Ilpo Järvinen wrote:
On Fri, 3 Nov 2023, Mario Limonciello wrote:
The USB4 spec specifies that PCIe ports that are used for tunneling
PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and
behave as a PCIe Gen1 device. The actual performance of these ports
On 11/6/2023 06:41, Ilpo Järvinen wrote:
On Fri, 3 Nov 2023, Mario Limonciello wrote:
commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ for Thunderbolt
ports") added a check into pciehp code to explicitly set NoCompl+
for all Intel Thunderbolt controllers, including those that don't
need it.
On 11/6/2023 10:47, Mika Westerberg wrote:
On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote:
On Fri, 3 Nov 2023, Mario Limonciello wrote:
pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to
using dev_is_removable() to be able to detect USB4 devices as well.
On 11/6/2023 06:33, Ilpo Järvinen wrote:
On Fri, 3 Nov 2023, Mario Limonciello wrote:
All callers have switched to dev_is_removable() for detecting
hotpluggable PCIe devices.
Signed-off-by: Mario Limonciello
---
include/linux/pci.h | 22 --
1 file changed, 22 deletions(
On Mon, 06 Nov 2023, Abhinav Singh wrote:
> On 11/6/23 16:53, Jani Nikula wrote:
>> On Fri, 03 Nov 2023, Abhinav Singh wrote:
>>> sparse static analysis tools generate a warning with this message
>>> "Using plain integer as NULL pointer". In this case this warning is
>>> being shown because we ar
[Public]
> Hi all,
>
> This week this patchset was tested on the following systems:
> * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U
> * MSI Gaming X Trio RX 6800
> * Gigabyte Gaming OC RX 7900 XTX
>
> These systems were tested on the following display/connection ty
On 2023-11-06 5:40, ZhenGuo Yin wrote:
[Why]
There will be a warning trace when cleaning up the gtt
drm_mm allocator during unloading driver since gang_ctx_bo
and wptr_bo do not get freed.
This isn't just a problem with module unloading, but a more general
memory leak. pqm_uninit runs not duri
> On Nov 6, 2023, at 22:44, Christian König wrote:
>
> Am 02.11.23 um 15:04 schrieb Tatsuyuki Ishi:
>> In Vulkan, it is the application's responsibility to perform adequate
>> synchronization before a sparse unmap, replace or BO destroy operation.
>> Until now, the kernel applied the same rule a
On 11/6/23 16:53, Jani Nikula wrote:
On Fri, 03 Nov 2023, Abhinav Singh wrote:
sparse static analysis tools generate a warning with this message
"Using plain integer as NULL pointer". In this case this warning is
being shown because we are trying to intialize a pointer to NULL using
integer val
On Mon, Nov 6, 2023 at 10:22 AM Mikhail Gavrilov
wrote:
>
> Hi,
> another release cycle, and another regression.
> After another kernel update in Fedora Rawhide GPU not
> entering in graphic mode on my laptop ASUS ROG Strix G15 Advantage
> Edition G513QY-HQ007.
> And in kernel log appears this bug
On Fri, 3 Nov 2023, Mario Limonciello wrote:
> The USB4 spec specifies that PCIe ports that are used for tunneling
> PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and
> behave as a PCIe Gen1 device. The actual performance of these ports is
> controlled by the fabric implemen
On Fri, 3 Nov 2023, Mario Limonciello wrote:
> All callers have switched to dev_is_removable() for detecting
> hotpluggable PCIe devices.
>
> Signed-off-by: Mario Limonciello
> ---
> include/linux/pci.h | 22 --
> 1 file changed, 22 deletions(-)
>
> diff --git a/include/lin
On Fri, 3 Nov 2023, Mario Limonciello wrote:
> pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to
> using dev_is_removable() to be able to detect USB4 devices as well.
Please extend this with more details. I had to lookup the TBT change to
be able to make any guess why you
On Fri, 3 Nov 2023, Mario Limonciello wrote:
> commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ for Thunderbolt
> ports") added a check into pciehp code to explicitly set NoCompl+
> for all Intel Thunderbolt controllers, including those that don't
> need it.
>
> This overloaded the purpose of t
On Fri, 3 Nov 2023, Mario Limonciello wrote:
> pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to
> using dev_is_removable() to be able to detect USB4 devices as well.
Same here as with 1/9.
--
i.
> Signed-off-by: Mario Limonciello
> ---
> drivers/gpu/drm/radeon/radeo
Am 02.11.23 um 15:04 schrieb Tatsuyuki Ishi:
In Vulkan, it is the application's responsibility to perform adequate
synchronization before a sparse unmap, replace or BO destroy operation.
Until now, the kernel applied the same rule as implicitly-synchronized
APIs like OpenGL, which with per-VM BO
Am 06.11.23 um 08:56 schrieb Tatsuyuki Ishi:
On Oct 31, 2023, at 23:07, Christian König
wrote:
Am 31.10.23 um 14:59 schrieb Bas Nieuwenhuizen:
On Tue, Oct 31, 2023 at 2:57 PM Christian König
wrote:
Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi:
> The current amdgpu_gem_va_update
Am 01.11.23 um 23:00 schrieb Felix Kuehling:
On 2023-10-31 11:18, Alex Deucher wrote:
On Tue, Oct 31, 2023 at 11:12 AM Christian König
wrote:
When clearing the root PD fails we need to properly release it again.
Signed-off-by: Christian König
Acked-by: Alex Deucher
Has this been submitted?
On 11/5/23 12:55, Guenter Roeck wrote:
On Mon, Oct 16, 2023 at 08:19:18AM -0600, Rodrigo Siqueira wrote:
This commit is the last part of the fix that reduces the stack size in
the DML2 code.
That does not really help when trying to build allmodconfig or allyesconfig
with gcc 11.4 or 12.3.
dr
On 11/6/2023 2:30 AM, Hunter Chasens wrote:
Resolves Sphinx unexpected indentation warning when compiling
documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
a literal block to keep vertical formatting of the
example power state list.
Signed-off-by: Hunter Chasens
Than
On Fri, 03 Nov 2023, Abhinav Singh wrote:
> sparse static analysis tools generate a warning with this message
> "Using plain integer as NULL pointer". In this case this warning is
> being shown because we are trying to intialize a pointer to NULL using
> integer value 0.
>
> Signed-off-by: Abhinav
[Why]
There will be a warning trace when cleaning up the gtt
drm_mm allocator during unloading driver since gang_ctx_bo
and wptr_bo do not get freed.
[How]
Free gang_ctx_bo and wptr_bo in pqm_uninit.
Signed-off-by: ZhenGuo Yin
---
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 8 +
On Mon, 06 Nov 2023, Bagas Sanjaya wrote:
> On Sun, Nov 05, 2023 at 09:26:26PM -0800, Randy Dunlap wrote:
>>
>>
>> On 11/5/23 21:15, Bagas Sanjaya wrote:
>> > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote:
>> >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
>> >> b/drivers/gp
Resolves Sphinx unexpected indentation warning when compiling
documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
a literal block to keep vertical formatting of the
example power state list.
Signed-off-by: Hunter Chasens
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 --
On 11/5/23 21:15, Bagas Sanjaya wrote:
> On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote:
>> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
>> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
>> index 517b9fb4624c..703fe2542258 100644
>> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
>> +++ b/dri
GCC 14 introduces a new -Walloc-size warning
(https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wno-alloc-size)
which triggers on the following amdgpu files:
"""
/var/tmp/portage/sys-kernel/gentoo-kernel-6.5.10/work/linux-6.5/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c:
In funct
On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote:
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..703fe2542258 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -990,11 +990
On Mon, Oct 16, 2023 at 08:19:18AM -0600, Rodrigo Siqueira wrote:
> This commit is the last part of the fix that reduces the stack size in
> the DML2 code.
>
That does not really help when trying to build allmodconfig or allyesconfig
with gcc 11.4 or 12.3.
drivers/gpu/drm/amd/amdgpu/../display/d
On 30/10/23 20:17, Bragatheswaran Manickavel wrote:
On 24/10/23 23:41, Bragatheswaran Manickavel wrote:
The member variable enable_hpo_pg_support is already initialized
and hence the reinitialization instruction can be removed. Issue
identified using the doubleinit.cocci Coccinelle semantic p
On Sun, Nov 05, 2023 at 09:26:26PM -0800, Randy Dunlap wrote:
>
>
> On 11/5/23 21:15, Bagas Sanjaya wrote:
> > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote:
> >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> >> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> >> index 517b9fb4624c..7
GCC 14 introduces a new -Walloc-size included in -Wextra which errors out
on various files in drivers/gpu/drm/amd/amdgpu like:
```
amdgpu_amdkfd_gfx_v8.c:241:15: error: allocation of insufficient size ‘4’ for
type ‘uint32_t[2]’ {aka ‘unsigned int[2]'} with size ‘8’ [-Werror=alloc-size]
```
This i
On Thu, 2 Nov 2023 at 22:53, Alex Deucher wrote:
>
> On Thu, Nov 2, 2023 at 1:07 PM Sudip Mukherjee
> wrote:
> >
> > On Thu, 2 Nov 2023 at 16:52, Alex Deucher wrote:
> > >
> > > On Thu, Nov 2, 2023 at 5:32 AM Sudip Mukherjee (Codethink)
> > > wrote:
> > > >
> > > > Hi All,
> > > >
> > > > The l
62 matches
Mail list logo
