Re: [PATCH v2 12/16] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 6:19 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> In order to provide GPU inputs to TA for the Smart PC solution to work, we >> need to have interface between the PMF driver and the AMDGPU driver. >> >> Add the initial code path for get interface fro

Re: [PATCH v2 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 5:53 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> PMF driver based on the output actions from the TA can request to update >> the system states like entering s0i3, lock screen etc. by generating >> an uevent. Based on the udev rules set in the usersp

Re: [PATCH v2 06/16] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 5:44 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> PMF driver sends changing inputs from each subystem to TA for evaluating >> the conditions in the policy binary. >> >> Add initial support of plumbing in the PMF driver for Smart PC to get >> informat

Re: [PATCH v2 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 5:30 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> PMF Policy binary is a encrypted and signed binary that will be part >> of the BIOS. PMF driver via the ACPI interface checks the existence >> of Smart PC bit. If the advertised bit is found, PMF driv

Re: [PATCH v2 01/16] platform/x86/amd/pmf: Add PMF TEE interface

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 4:20 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> AMD PMF driver loads the PMF TA (Trusted Application) into the AMD >> ASP's (AMD Security Processor) TEE (Trusted Execution Environment). >> >> PMF Trusted Application is a secured firmware placed und

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-08 Thread Xu, Feifei
[AMD Official Use Only - General] Hi, >> Based on your description, the above code should use "||" instead of "&&", && is to add more restriction here. To avoid skipping necessary TLB flush by return. For Asics < GFX11, !adev->gfx.is_poweron is always true (this paremeter is intrudoced from GF

[PATCH 5/9] drm/ci: clean up xfails (specially flakes list)

2023-10-08 Thread Helen Koike
Since the script that collected the list of the expectation files was bogus and placing test to the flakes list incorrectly, restart the expectation files with the correct script. This reduces a lot the number of tests in the flakes list. Signed-off-by: Helen Koike --- .../gpu/drm/ci/xfails/amd

RE: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-08 Thread Wang, Yang(Kevin)
-Original Message- From: amd-gfx On Behalf Of Feifei Xu Sent: Sunday, October 8, 2023 6:07 PM To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Xu, Feifei ; Koenig, Christian ; Zhang, Hawking Subject: [PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb To fix the gpu recover

[PATCH] drm/amdgpu:Check gfx poweron when skip flush_gpu_tlb

2023-10-08 Thread Feifei Xu
To fix the gpu recovery failed on GFX11 with gfxhub pagefault, flush gpu tlb after reset on GFX11. Gfxhub tlb flush need check if adev->gfx.is_poweron set. Fixes: d0c860f33553 ("drm/amdgpu: rework lock handling for flush_tlb v2") Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/amdgpu_gm

[PATCH] drm/amdgpu: Return -EINVAL when MMSCH init status incorrect

2023-10-08 Thread Lin . Cao
Return -EINVAL when MMSCH init fail which can be handle by function amdgpu_device_reset_sriov correctly. Signed-off-by: Lin.Cao --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c b/drivers/gpu

[PATCH] drm/amdgpu: fix SI failure due to doorbells allocation

2023-10-08 Thread Icenowy Zheng
SI hardware does not have doorbells at all, however currently the code will try to do the allocation and thus fail, makes SI AMDGPU not usable. Fix this failure by skipping doorbells allocation when doorbells count is zero. Fixes: 54c30d2a8def ("drm/amdgpu: create kernel doorbell pages") Signed-o