Re: [PATCH v2 2/2] drm/amdgpu: Create an option to disable soft recovery

2023-08-30 Thread Christian König
Am 31.08.23 um 00:08 schrieb André Almeida: Create a module option to disable soft recoveries on amdgpu, making every recovery go through the device reset path. This option makes easier to force device resets for testing and debugging purposes. Signed-off-by: André Almeida --- drivers/gpu/drm

Re: [PATCH v2 1/2] drm/amdgpu: Merge debug module parameters

2023-08-30 Thread Christian König
Am 31.08.23 um 00:08 schrieb André Almeida: Merge all developer debug options available as separated module parameters in one, making it obvious that are for developers. Drop the obsolete module options in favor of the new ones. Signed-off-by: André Almeida --- v2: - drop old module params

[PATCH v3] drm/amd/pm: only poweron/off vcn/jpeg when they are valid.

2023-08-30 Thread Yifan Zhang
If vcn is disabled in kernel parameters, don't touch vcn, otherwise it may cause vcn hang. v2: delete unnecessary logs v3: move "is_vcn_enabled" check to smu_dpm_setvcn/jpeg_enable (Evan) Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 24 +++ 1 fi

[V11 8/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

2023-08-30 Thread Evan Quan
Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello -- v10->v11: - downgrade the prompt level on message failure(Lijo) --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++ 1 file changed, 59 insertions(+

[V11 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-08-30 Thread Evan Quan
Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello -- v10->v11: - downgrade the prompt level on message failure(Lijo) --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h |

[V11 6/8] drm/amd/pm: add flood detection for wbrf events

2023-08-30 Thread Evan Quan
To protect PMFW from being overloaded. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 +++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/dr

[V11 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-30 Thread Evan Quan
With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). Signed-off-by: Evan Quan Reviewed-by: Mario

[V11 4/8] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

2023-08-30 Thread Evan Quan
Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +- .../amd/pm/swsmu/inc/pmfw

[V11 3/8] wifi: mac80211: Add support for WBRF features

2023-08-30 Thread Evan Quan
To support the WBRF mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated calls. So that, other drivers responding to the frequencies can take proper actions to mitigate possible interference. Co-devel

[V11 2/8] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-08-30 Thread Evan Quan
The newly added WBRF feature needs this interface for channel width calculation. Signed-off-by: Evan Quan -- v8->v9: - correct typo(Mhz -> MHz) (Johnson) --- include/net/cfg80211.h | 8 net/wireless/chan.c| 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/incl

[V11 1/8] ACPI: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-08-30 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has introduced a mechanism that devices can

[V11 0/8] Enable Wifi RFI interference mitigation feature support

2023-08-30 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI interference producers can advertise the

RE: [PATCH] drm/amd/pm: only poweron/off vcn/jpeg when they are valid.

2023-08-30 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Yifan > Sent: Thursday, August 31, 2023 2:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Ma, Li ; Zhang, > Yifan > Subject: [PATCH] drm/amd/pm: only poweron/off vcn/jpeg when they are > valid. > > If vcn

[PATCH v2] drm/amd/pm: only poweron/off vcn/jpeg when they are valid.

2023-08-30 Thread Yifan Zhang
If vcn is disabled in kernel parameters, don't touch vcn, otherwise it may cause vcn hang. v2: delete unnecessary logs Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 30 --- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[PATCH] drm/amd/pm: only poweron/off vcn/jpeg when they are valid.

2023-08-30 Thread Yifan Zhang
If vcn is disabled in kernel parameters, don't touch vcn, otherwise it may cause vcn hang. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 --- 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu

Re: [PATCH] Revert "drm/amd/pm: disable the SMU13 OD feature support temporarily"

2023-08-30 Thread Alex Deucher
On Wed, Aug 30, 2023 at 10:50 PM Evan Quan wrote: > > This reverts commit 3592cc20beeece83db4c50a0f400e2dd15139de9. > > The enablement for the new OD mechanism completed. Also, the support for > fan control related OD feature has been added via this new mechanism. > Thus, it is time to bring back

[PATCH] Revert "drm/amd/pm: disable the SMU13 OD feature support temporarily"

2023-08-30 Thread Evan Quan
This reverts commit 3592cc20beeece83db4c50a0f400e2dd15139de9. The enablement for the new OD mechanism completed. Also, the support for fan control related OD feature has been added via this new mechanism. Thus, it is time to bring back the SMU13 OD support. Signed-off-by: Evan Quan --- .../drm/

Re: [PATCH] drm/amdkfd: Use partial migrations in GPU page faults

2023-08-30 Thread Chen, Xiaogang
On 8/30/2023 3:56 PM, Felix Kuehling wrote: On 2023-08-30 15:39, Chen, Xiaogang wrote: On 8/28/2023 5:37 PM, Felix Kuehling wrote: On 2023-08-28 16:57, Chen, Xiaogang wrote: On 8/28/2023 2:06 PM, Felix Kuehling wrote: On 2023-08-24 18:08, Xiaogang.Chen wrote: From: Xiaogang Chen Thi

[PATCH v2 1/2] drm/amdgpu: Merge debug module parameters

2023-08-30 Thread André Almeida
Merge all developer debug options available as separated module parameters in one, making it obvious that are for developers. Drop the obsolete module options in favor of the new ones. Signed-off-by: André Almeida --- v2: - drop old module params - use BIT() macros - replace global var with adev

[PATCH v2 2/2] drm/amdgpu: Create an option to disable soft recovery

2023-08-30 Thread André Almeida
Create a module option to disable soft recoveries on amdgpu, making every recovery go through the device reset path. This option makes easier to force device resets for testing and debugging purposes. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/dr

[PATCH v2 0/2] Merge all debug module parameters

2023-08-30 Thread André Almeida
As suggested by Christian at [0], this patchset merges all debug modules parameters and creates a new one for disabling soft recovery: > Maybe we can overload the amdgpu_gpu_recovery module option with this. > Or even better merge all the developer module parameter into a > amdgpu_debug option.

Re: [PATCH] drm/amdkfd: Use partial migrations in GPU page faults

2023-08-30 Thread Felix Kuehling
On 2023-08-30 15:39, Chen, Xiaogang wrote: On 8/28/2023 5:37 PM, Felix Kuehling wrote: On 2023-08-28 16:57, Chen, Xiaogang wrote: On 8/28/2023 2:06 PM, Felix Kuehling wrote: On 2023-08-24 18:08, Xiaogang.Chen wrote: From: Xiaogang Chen This patch implements partial migration in gpu pa

Re: [PATCHv2] drm/amdkfd: Fix unaligned 64-bit doorbell warning

2023-08-30 Thread Felix Kuehling
On 2023-08-30 16:01, Mukul Joshi wrote: This patch fixes the following unaligned 64-bit doorbell warning seen when submitting packets on HIQ on GFX v9.4.3 by making the HIQ doorbell 64-bit aligned. The warning is seen when GPU is loaded in any mode other than SPX mode. [ +0.000301]

[PATCHv2] drm/amdkfd: Fix unaligned 64-bit doorbell warning

2023-08-30 Thread Mukul Joshi
This patch fixes the following unaligned 64-bit doorbell warning seen when submitting packets on HIQ on GFX v9.4.3 by making the HIQ doorbell 64-bit aligned. The warning is seen when GPU is loaded in any mode other than SPX mode. [ +0.000301] [ cut here ] [ +0.03] Una

Re: [PATCH] drm/amdkfd: Use partial migrations in GPU page faults

2023-08-30 Thread Chen, Xiaogang
On 8/28/2023 5:37 PM, Felix Kuehling wrote: On 2023-08-28 16:57, Chen, Xiaogang wrote: On 8/28/2023 2:06 PM, Felix Kuehling wrote: On 2023-08-24 18:08, Xiaogang.Chen wrote: From: Xiaogang Chen This patch implements partial migration in gpu page fault according to migration granularity(

RE: [PATCH] drm/amd/pm: Replace 1-element arrays with flexible array members

2023-08-30 Thread Deucher, Alexander
[Public] > -Original Message- > From: Samuel Holland > Sent: Wednesday, August 30, 2023 2:58 PM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > > Cc: Samuel Holland ; Daniel Vetter > ; David Airlie ; Pan, Xinhui > ; amd-gfx@lists.freedesktop.org; dri- > de...@lists.freedesk

[PATCH] drm/amd/pm: Replace 1-element arrays with flexible array members

2023-08-30 Thread Samuel Holland
Since commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3"), UBSAN_BOUNDS no longer pretends 1-element arrays are unbounded. The bounds check is tripped in smu7_get_pp_table_entry_callback_func_v1(), while reading from mclk_dep_table. For consistency, fix all affected struct definitions in

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-30 Thread Chia-I Wu
On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > From: Lang Yu > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] > > When using cpu to update page tables, vm update fences are unused. > Install stub fence into these fence pointers instead of NULL > to avoid NULL dereference w

Re: [PATCH] drm/amdkfd: Fix unaligned 64-bit doorbell warning

2023-08-30 Thread Felix Kuehling
+Shashank, FYI. I believe this is a regression from your patch "drm/amdgpu: use doorbell mgr for kfd kernel doorbells". On 2023-08-29 12:16, Mukul Joshi wrote: This patch fixes the following unaligned 64-bit doorbell warning seen when submitting packets on HIQ on GFX v9.4.3 by making the HIQ d

Re: [PATCH v3 0/7] GPU workload hints for better performance

2023-08-30 Thread Michel Dänzer
On 8/28/23 17:02, Lazar, Lijo wrote: > [AMD Official Use Only - General] > > > As mentioned with an older version of this series, this is an 'abuse' of > power profile interface. > > This series is oversimplifying what PMFW algorithms are supposed to be doing. > Whatever this series is doing,

[PATCH] drm/amd/display: remove useless check in should_enable_fbc()

2023-08-30 Thread Dembskiy Igor
It does not make sense to compare a pointer to array element with NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while enable fbc") Signed-off-by: Dembskiy Igor --- drivers/gpu/drm/amd/display/dc/dce110/d

Re: [V3 0/7] A new set of Linux OD interfaces

2023-08-30 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Wed, Aug 30, 2023 at 2:35 AM Evan Quan wrote: > > The existing OD interface `pp_od_clk_voltage` is unable to meet the growing > demands for more OD functionalities. Since the buf used within it comes with > size limit as one page. With more OD functionalit

Re: [PATCH v2 19/34] drm/amd/display: decouple steps for mapping CRTC degamma to DC plane

2023-08-30 Thread Michel Dänzer
On 8/28/23 10:17, Pekka Paalanen wrote: > On Fri, 25 Aug 2023 13:29:44 -0100 > Melissa Wen wrote: > >> On 08/22, Pekka Paalanen wrote: >>> On Thu, 10 Aug 2023 15:02:59 -0100 >>> Melissa Wen wrote: >>> The next patch adds pre-blending degamma to AMD color mgmt pipeline, but pre-blend

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-30 Thread Daniel Vetter
On Wed, Aug 30, 2023 at 10:29:46AM +0300, Jani Nikula wrote: > Upstream code should be reviewed in public. Yup -Sima -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-30 Thread Jani Nikula
On Tue, 29 Aug 2023, Alex Hung wrote: > On 2023-08-29 11:03, Jani Nikula wrote: >> On Tue, 29 Aug 2023, Jani Nikula wrote: >>> On Tue, 29 Aug 2023, Alex Deucher wrote: On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote: > > On Wed, 23 Aug 2023, Jani Nikula wrote: >> On Tue, 22

Re: [PATCH] drm/connector: mark enum counter value as private

2023-08-30 Thread Randy Dunlap
Hi, On 7/15/23 17:46, Randy Dunlap wrote: > Mark the DRM_MODE_COLORIMETRY_COUNT enum value as private in > kernel-doc to prevent a build warning: > > include/drm/drm_connector.h:527: warning: Enum value > 'DRM_MODE_COLORIMETRY_COUNT' not described in enum 'drm_colorspace' > > Fixes: c627087cb16