[PATCH] drm/amdkfd: Add missing gfx11 MQD manager callbacks

From: Jay Cornwall mqd_stride function was introduced in commit 129c7b6a0217 ("drm/amdkfd: Update MQD management on multi XCC setup") but not assigned for gfx11. Fixes a NULL dereference in debugfs. Signed-off-by: Jay Cornwall Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/amdk

Re: drm/amd/pm: workaround for the wrong ac power detection on smu 13.0.0

On 8/24/2023 22:19, Kenneth Feng wrote: workaround for the wrong ac power detection on smu 13.0.0 Signed-off-by: Kenneth Feng This workaround appears to be only necessary if you're missing these commits. a7fbfd44c020 ("usb: typec: ucsi: Mark dGPUs as DEVICE scope") 95339f40a8b6 ("power: su

[PATCH] drm/amdkfd: Checkpoint and restore queues on GFX11

The code in kfd_mqd_manager_v11.c to support criu dump and restore of queue state was missing. Added it; should be equivalent to kfd_mqd_manager_v10.c. CC: Felix Kuehling Signed-off-by: David Francis --- .../gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c | 41 +++ 1 file changed, 41

Re: [PATCH] drm/amd/display: Fix up kdoc format for 'dc_set_edp_power'

On 2023-08-25 06:38, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:5261: warning: Cannot understand *** Cc: Ian Chen Cc: Rodrigo Siqueira Cc: Harry Wentland Cc: Aurabindo

[PATCH] drm/amdkfd: Replace pr_err with dev_err

Replace pr_err with dev_err to show the bus-id of failing device with kfd queue errors Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../drm/amd/amdkfd/kfd_device_queue_manager.c | 116 +++--- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +- 2 files changed, 71 insert

Re: [PATCH v2 31/34] drm/amd/display: set stream gamut remap matrix to MPC for DCN301

On 08/22, Pekka Paalanen wrote: > On Thu, 10 Aug 2023 15:03:11 -0100 > Melissa Wen wrote: > > > dc->caps.color.mpc.gamut_remap says there is a post-blending color block > > for gamut remap matrix for DCN3 HW family and newer versions. However, > > those drivers still follow DCN10 programming that

Re: [PATCH v2 19/34] drm/amd/display: decouple steps for mapping CRTC degamma to DC plane

On 08/22, Pekka Paalanen wrote: > On Thu, 10 Aug 2023 15:02:59 -0100 > Melissa Wen wrote: > > > The next patch adds pre-blending degamma to AMD color mgmt pipeline, but > > pre-blending degamma caps (DPP) is currently in use to provide DRM CRTC > > atomic degamma or implict degamma on legacy gamm

Re: [PATCH v2 07/34] drm/amd/display: explicitly define EOTF and inverse EOTF

On 08/22, Pekka Paalanen wrote: > On Thu, 10 Aug 2023 15:02:47 -0100 > Melissa Wen wrote: > > > Instead of relying on color block names to get the transfer function > > intention regarding encoding pixel's luminance, define supported > > Electro-Optical Transfer Functions (EOTFs) and inverse EOTF

Re: [V10 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

On 8/25/2023 2:08 PM, Evan Quan wrote: Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +- drivers/gpu/drm/

Re: [V10 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

On 8/25/2023 2:08 PM, Evan Quan wrote: With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). S

Re: [PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2()

On Wed, Aug 23, 2023 at 03:16:44AM +, Lin, Wayne wrote: > [AMD Official Use Only - General] > > > -Original Message- > > From: Imre Deak > > Sent: Saturday, August 19, 2023 1:46 AM > > To: Lin, Wayne > > Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; > > ly...@re

RE: [PATCH 0/5] Add the pci_get_base_class() helper and use it

[Public] > -Original Message- > From: amd-gfx On Behalf Of Sui > Jingfeng > Sent: Friday, August 25, 2023 2:27 AM > To: Bjorn Helgaas > Cc: alsa-de...@alsa-project.org; Sui Jingfeng ; > nouv...@lists.freedesktop.org; linux-ker...@vger.kernel.org; dri- > de...@lists.freedesktop.org; amd-g

Re: [PATCH] drm/amd/pm: workaround for the wrong ac power detection on smu 13.0.0

On Fri, Aug 25, 2023 at 3:35 AM Kenneth Feng wrote: > > workaround for the wrong ac power detection on smu 13.0.0 Is this to work around the bug in the power supply code for USB controllers or something else? If so that was already fixed upstream so this is really more of a candidate for stable

[PATCH 0/5] Add the pci_get_base_class() helper and use it

From: Sui Jingfeng There is no function that can be used to get all PCI(e) devices in a system by matching against its the PCI base class code only, while keep the sub-class code and the programming interface ignored. Therefore, add the pci_get_base_class() function to suit the need. For example

[PATCH 4/5] drm/amdgpu: Use pci_get_base_class() to reduce duplicated code

From: Sui Jingfeng Should be no functional change. Cc: Alex Deucher Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 11 --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 20 +--- 2 files changed, 9 insertions(+), 22 deletions(-) diff --git a/dr

[PATCH 1/5] PCI: Add the pci_get_base_class() helper

From: Sui Jingfeng There is no function that can be used to get all PCI(e) devices in a system by matching against its the PCI base class code only, while keep the sub-class code and the programming interface ignored. Therefore, add the pci_get_base_class() function to suit the need. For example

[PATCH 2/5] ALSA: hda/intel: Use pci_get_base_class() to reduce duplicated code

From: Sui Jingfeng Should be no functional change Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Fred Oh Cc: Pierre-Louis Bossart Cc: Kai Vehmanen Cc: Bjorn Helgaas Signed-off-by: Sui Jingfeng --- sound/pci/hda/hda_intel.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-)

[PATCH 3/5] drm/nouveau: Use pci_get_base_class() to reduce duplicated code

From: Sui Jingfeng Should be no functional change. Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/nouveau/nouveau_acpi.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drive

[PATCH 5/5] drm/radeon: Use pci_get_base_class() to reduce duplicated code

From: Sui Jingfeng Should be no functional change. Cc: Alex Deucher Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/radeon/radeon_bios.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/rad

Re: [V2 3/8] drm/amd/pm: add fan mode OD setting support for SMU13

On Thu, Aug 24, 2023 at 10:02 PM Quan, Evan wrote: > > [AMD Official Use Only - General] > > > -Original Message- > > From: Alex Deucher > > Sent: Thursday, August 24, 2023 10:51 PM > > To: Quan, Evan > > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > > > > Subject: Re: [V2 3/8

Re: [PATCH 1/2] drm/amdgpu: Merge debug module parameters

Am 25.08.23 um 14:34 schrieb André Almeida: Em 25/08/2023 09:29, Christian König escreveu: Am 25.08.23 um 14:24 schrieb André Almeida: Em 25/08/2023 03:56, Christian König escreveu: > Am 24.08.23 um 18:25 schrieb André Almeida: >> Merge all developer debug options available as separated module

Re: [PATCH 1/2] drm/amdgpu: Merge debug module parameters

Em 25/08/2023 09:29, Christian König escreveu: Am 25.08.23 um 14:24 schrieb André Almeida: Em 25/08/2023 03:56, Christian König escreveu: > Am 24.08.23 um 18:25 schrieb André Almeida: >> Merge all developer debug options available as separated module >> parameters in one, making it obvious that

Re: [PATCH 1/2] drm/amdgpu: Merge debug module parameters

Am 25.08.23 um 14:24 schrieb André Almeida: Em 25/08/2023 03:56, Christian König escreveu: > Am 24.08.23 um 18:25 schrieb André Almeida: >> Merge all developer debug options available as separated module >> parameters in one, making it obvious that are for developers. >> >> Signed-off-by: André A

Re: [PATCH 1/2] drm/amdgpu: Merge debug module parameters

Em 25/08/2023 03:56, Christian König escreveu: > Am 24.08.23 um 18:25 schrieb André Almeida: >> Merge all developer debug options available as separated module >> parameters in one, making it obvious that are for developers. >> >> Signed-off-by: André Almeida >> --- >> drivers/gpu/drm/amd/amdgp

RE: [PATCH] drm/amdgpu: Add only valid firmware version nodes

[AMD Official Use Only - General] Reviewed-by: Asad Kamal asad.ka...@amd.com Thanks & Regards Asad From: amd-gfx On Behalf Of Wang, Yang(Kevin) Sent: Friday, August 25, 2023 4:46 PM To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Deucher, Alexander ; Zhang, Hawki

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

On 8/25/2023 4:48 PM, Yadav, Arvind wrote: On 8/22/2023 6:16 PM, Lazar, Lijo wrote: On 8/22/2023 5:41 PM, Yadav, Arvind wrote: Hi Lijo, The *_set function will set the GPU power profile and the *_put function will  schedule the smu_delayed_work task after 100ms delay. This smu_delayed_w

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

On 8/22/2023 6:16 PM, Lazar, Lijo wrote: On 8/22/2023 5:41 PM, Yadav, Arvind wrote: Hi Lijo, The *_set function will set the GPU power profile and the *_put function will  schedule the smu_delayed_work task after 100ms delay. This smu_delayed_work task will clear a GPU power profile if an

Re: [PATCH] drm/amdgpu: Add only valid firmware version nodes

[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin 发件人: amd-gfx 代表 Lijo Lazar 发送时间: 星期五, 八月 25, 2023 17:29 收件人: amd-gfx@lists.freedesktop.org 抄送: Deucher, Alexander ; Zhang, Hawking 主题: [PATCH] drm/amdgpu: Add only valid firmware v

[PATCH] drm/amd/display: Fix up kdoc format for 'dc_set_edp_power'

Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:5261: warning: Cannot understand *** Cc: Ian Chen Cc: Rodrigo Siqueira Cc: Harry Wentland Cc: Aurabindo Pillai Cc: Alex Deucher Signed-off-by: Srinivasan

[PATCH] drm/amdgpu: Add only valid firmware version nodes

Show only firmware version attributes that have valid version. Hide others. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 33 --- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gp

RE: [V9 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Friday, August 18, 2023 5:12 PM > To: Quan, Evan ; gre...@linuxfoundation.org; > raf...@kernel.org; l...@kernel.org; johan...@sipsolutions.net; > da...@davemloft.net; eduma...@google.com; k...@kernel.org; >

RE: [V9 4/9] wifi: mac80211: Add support for WBRF features

[AMD Official Use Only - General] > -Original Message- > From: Johannes Berg > Sent: Monday, August 21, 2023 5:44 PM > To: Quan, Evan ; gre...@linuxfoundation.org; > raf...@kernel.org; l...@kernel.org; da...@davemloft.net; > eduma...@google.com; k...@kernel.org; pab...@redhat.com; Deucher

[V10 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 3 + .../gpu/d

[V10 8/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c

[V10 6/8] drm/amd/pm: add flood detection for wbrf events

To protect PMFW from being overloaded. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 +++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/dr

[V10 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). Signed-off-by: Evan Quan Reviewed-by: Mario

[V10 3/8] wifi: mac80211: Add support for WBRF features

To support the WBRF mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated calls. So that, other drivers responding to the frequencies can take proper actions to mitigate possible interference. Co-devel

[V10 4/8] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +- .../amd/pm/swsmu/inc/pmfw

[V10 2/8] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

The newly added WBRF feature needs this interface for channel width calculation. Signed-off-by: Evan Quan -- v8->v9: - correct typo(Mhz -> MHz) (Johnson) --- include/net/cfg80211.h | 8 net/wireless/chan.c| 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/incl

[V10 1/8] ACPI: Add support for AMD ACPI based Wifi band RFI mitigation feature

Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has introduced a mechanism that devices can

[V10 0/8] Enable Wifi RFI interference mitigation feature support

Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI interference producers can advertise the

Re: [PATCH] drm/amd: Simplify the size check funciton

Am 25.08.23 um 07:22 schrieb Ma Jun: Simplify the code logic of size check function amdgpu_bo_validate_size Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 28 +- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd

Re: [PATCH 2/5] ALSA: hda/intel: Use pci_get_base_class() to reduce duplicated code

On Fri, 25 Aug 2023 08:27:11 +0200, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Should be no functional change > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Fred Oh > Cc: Pierre-Louis Bossart > Cc: Kai Vehmanen > Cc: Bjorn Helgaas > Signed-off-by: Sui Jingfeng > --- > sound/pci/hd

RE: [PATCH] drm/amdgpu: use read-modify-write mode for gfx v9_4_3 SQ setting

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Friday, August 25, 2023 15:24 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: use read-modify-write mo

[PATCH] drm/amdgpu: use read-modify-write mode for gfx v9_4_3 SQ setting

Instead of using direct update, avoid touching unrelated fields. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c index b4fd