[PATCH v2 7/7] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-20 Thread Arvind Yadav
This reverts commit 5ce71f59bb9bd3d8a09b96afdbc92975cb6dc303. Reason for revert: New amdgpu_workload_profile* api is added to switch on/off profile mode. These new api will allow to change the GPU power profile based on a submitted job. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher

[PATCH v2 6/7] drm/amdgpu: switch workload context to/from compute

2023-08-20 Thread Arvind Yadav
This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. Cc: Christian Koenig Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 +--- 1 file changed, 5 inserti

[PATCH v2 5/7] drm/amdgpu: Switch on/off GPU workload profile

2023-08-20 Thread Arvind Yadav
This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 + 1 file chang

[PATCH v2 4/7] drm/amdgpu: Add suspend function to clear the GPU power profile.

2023-08-20 Thread Arvind Yadav
This patch adds a suspend function that will clear the GPU power profile before going into suspend state. v2: - Add the new suspend function based on review comment. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_de

[PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-20 Thread Arvind Yadav
This patch adds a function which will clear the GPU power profile after job finished. This is how it works: - schedular will set the GPU power profile based on ring_type. - Schedular will clear the GPU Power profile once job finished. - Here, the *_workload_profile_set function will set the GPU

[PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-20 Thread Arvind Yadav
This patch adds a function which will change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. v2: - Splitting workload_profile_set and workload_profile_put into two separate patches. - Addressed review comment. Cc: Shashank Sharma

[PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-20 Thread Arvind Yadav
The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new fini function. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/Makefile

[PATCH v2 0/7] GPU workload hints for better performance

2023-08-20 Thread Arvind Yadav
AMDGPU SOCs supports dynamic workload based power profiles, which can provide fine-tuned performance for a particular type of workload. This patch series adds an interface to set/reset these power profiles based on the submitted job. The driver can dynamically switch the power profiles based on sub

Re: [PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()'

2023-08-20 Thread SHANMUGAM, SRINIVASAN
On 8/21/2023 11:59 AM, Kamal, Asad wrote: [AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Srinivasan Shanmugam Sent: Monday, August 21, 2023 11:36 AM To: Koenig, Christian ; Deucher, Alexander ; Chen, Guchun Cc: Pan, Xinhui ; SHANMUGAM, SRINIVASAN ;

RE: [PATCH 0/8] A new set of Linux OD interfaces

2023-08-20 Thread Quan, Evan
[AMD Official Use Only - General] Ping.. > -Original Message- > From: Quan, Evan > Sent: Tuesday, August 15, 2023 4:42 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: [PATCH 0/8] A new set of Linux OD interfaces > > The existing OD interface `pp

[PATCH] drm/amd/pm: fulfill the support for SMU13 `pp_dpm_dcefclk` interface

2023-08-20 Thread Evan Quan
Fulfill the incomplete SMU13 `pp_dpm_dcefclk` implementation. Reported-by: Guan Yu Signed-off-by: Evan Quan --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 27 +++ .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 27 +++ 2 files changed, 54 insertions(+) diff

[PATCH] drm/amd/pm: correct SMU13 gfx voltage related OD settings

2023-08-20 Thread Evan Quan
The voltage offset setting will be applied to the whole v/f curve line instead of per anchor point base. Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/amdgpu_pm.c| 45 +++ .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 31 ++--- .../drm/amd/pm/swsmu/smu

RE: [PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()'

2023-08-20 Thread Kamal, Asad
[AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Srinivasan Shanmugam Sent: Monday, August 21, 2023 11:36 AM To: Koenig, Christian ; Deucher, Alexander ; Chen, Guchun Cc: Pan, Xinhui ; SHANMUGAM, SRINIVASAN ; amd-gfx@lists.freedesktop.org Subject: [PATCH

[PATCH v2 4/4] drm/amdgpu: Bump amdgpu driver version.

2023-08-20 Thread Tatsuyuki Ishi
From: Bas Nieuwenhuizen For detection of the new explicit sync functionality without having to try the ioctl. Signed-off-by: Bas Nieuwenhuizen Signed-off-by: Tatsuyuki Ishi --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH v2 3/4] drm/amdgpu: Add option to disable implicit sync for a context.

2023-08-20 Thread Tatsuyuki Ishi
From: Bas Nieuwenhuizen This changes all BO usages in a submit to BOOKKEEP instead of READ, which effectively disables implicit sync for these submits. This is configured at a context level using the existing IOCTL. Signed-off-by: Bas Nieuwenhuizen Co-developed-by: Tatsuyuki Ishi Signed-off-b

[PATCH v2 2/4] drm/amdgpu: Allow explicit sync for VM ops.

2023-08-20 Thread Tatsuyuki Ishi
From: Bas Nieuwenhuizen This should be okay because moves themselves use KERNEL usage and hence still sync with BOOKKEEP usage. Then any later submits still wait on any pending VM operations. (i.e. we only made VM ops not wait on BOOKKEEP submits, not the other way around) Signed-off-by: Bas N

[PATCH v2 1/4] drm/amdgpu: Add separate mode for syncing DMA_RESV_USAGE_BOOKKEEP.

2023-08-20 Thread Tatsuyuki Ishi
From: Bas Nieuwenhuizen To prep for allowing different sync modes in a follow-up patch. Signed-off-by: Bas Nieuwenhuizen Signed-off-by: Tatsuyuki Ishi --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/am

[PATCH v2 0/4] amdgpu: Allow explicitly synchronized submissions.

2023-08-20 Thread Tatsuyuki Ishi
This adds a context option to use DMA_RESV_USAGE_BOOKKEEP for userspace submissions. This is a respin of [1] but rebased on top of the newly introduced drm_exec helpers. Disabling implicit sync is something we've wanted in RADV for a while for resolving some corner cases. A more immediate thing th

[PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()'

2023-08-20 Thread Srinivasan Shanmugam
The val is defined as unsigned int type, if(val<0) is invalid, hence modified its type to ssize_t Fixes the below: drivers/gpu/drm/amd/pm/amdgpu_pm.c:2800:5-8: WARNING: Unsigned expression compared with zero: val < 0 drivers/gpu/drm/amd/pm/amdgpu_pm.c:2813:5-8: WARNING: Unsigned expression comp

RE: [PATCH] drm/amd/pm: fix debugfs pm_info output

2023-08-20 Thread Chen, Guchun
[Public] Reviewed-by: Guchun Chen Regards, Guchun > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Saturday, August 19, 2023 3:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amd/pm: fix debugfs pm_info output > > Print