Re: [RESEND v3 1/5] drm/amdgpu: Create a module param to disable soft recovery

2023-08-14 Thread Christian König
Am 10.08.23 um 21:23 schrieb André Almeida: Create a module parameter to disable soft recoveries on amdgpu, making every recovery go through the device reset path. This option makes easier to force device resets for testing and debugging purposes. I'm still torn apart on this. On the one hand i

[PATCH] drm/amd: Drop USB-C PD F/W flashing support

2023-08-14 Thread Mario Limonciello
This support was introduced for pre-navi3x dGPUS. The interface that this was wired up to isn't usable by fwupd, and no devices had a need to release firmware into the wild. Navi3x dGPUs introduce an interface that can flash the entire IFWI image that is acceptable by userspace software like fwup

[PATCH 2/2] drm/amd: flush any delayed gfxoff on suspend entry

2023-08-14 Thread Tim Huang
From: Mario Limonciello DCN 3.1.4 is reported to hang on s2idle entry if graphics activity is happening during entry. This is because GFXOFF was scheduled as delayed but RLC gets disabled in s2idle entry sequence which will hang GFX IP if not already in GFXOFF. To help this problem, flush any d

[PATCH 1/2] drm/amdgpu: skip fence GFX interrupts disable/enable for S0ix

2023-08-14 Thread Tim Huang
GFX v11.0.1 reported fence fallback timer expired issue on SDMA and GFX rings after S0ix resume. This is generated by EOP interrupts are disabled when S0ix suspend but fails to re-enable when resume because of the GFX is in GFXOFF. [ 203.349571] [drm] Fence fallback timer expired on ring sdma0 [

[PATCH] drm/amd/display: If HPD fails probe EDID to decide if monitor is present

2023-08-14 Thread Mario Limonciello
Some monitors return that they're disconnected while powered off but the EDID can still be accessed. Before determining that a link is not available, try to access the EDID. Reported-and-suggested-by: dark_syl...@yahoo.com.ar Link: https://gitlab.freedesktop.org/drm/amd/-/issues/461 Signed-off-by

Re: [PATCH] drm/radeon: Use pci_dev_id() to simplify the code

2023-08-14 Thread Alex Deucher
Applied. Thanks! On Fri, Aug 11, 2023 at 9:45 AM Zheng Zengkai wrote: > > PCI core API pci_dev_id() can be used to get the BDF number for a pci > device. We don't need to compose it mannually. Use pci_dev_id() to > simplify the code a little bit. > > Signed-off-by: Zheng Zengkai > --- > driver

Re: [PATCH -next] drm/amdgpu: Remove duplicated includes

2023-08-14 Thread Alex Deucher
Applied. Thanks! On Thu, Aug 10, 2023 at 8:33 AM GUO Zihua wrote: > > Remove duplicated includes in amdgpu_amdkfd_gpuvm.c and amdgpu_ttm.c. > Resolves checkincludes message. > > Signed-off-by: GUO Zihua > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 1 - > drivers/gpu/drm/amd/amdgp

Re: [PATCH] drm/amd/pm: Clean up errors in amdgpu_smu.h

2023-08-14 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 5:30 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following enum go on the same line > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v11_0_pptable.h

2023-08-14 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 5:22 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > ERROR: open brace '{' following struct go on the same line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- >

Re: [PATCH 3/3] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-14 Thread Shashank Sharma
Ah, Thanks for pointing that out Alex. @Arvind, please refer to the patch (https://patchwork.freedesktop.org/patch/504854/?series=109060&rev=4) in previous series of SMU workload hints with UAPI (here: https://patchwork.freedesktop.org/series/109060/) Regards Shashank On 14/08/2023 17:20,

Re: [PATCH 3/3] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-14 Thread Alex Deucher
KFD also changes the profile when queues are active. Please make sure that is properly taken into account as well. Alex On Mon, Aug 14, 2023 at 3:36 AM Arvind Yadav wrote: > > This reverts commit 5ce71f59bb9bd3d8a09b96afdbc92975cb6dc303. > > Reason for revert: New amdgpu_smu* api is added to sw

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Shashank Sharma
Hey Arvind, On 14/08/2023 09:34, Arvind Yadav wrote: This patch adds a function which will allow to change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by:

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Andrew Lunn
On Mon, Aug 14, 2023 at 09:50:49AM +, Quan, Evan wrote: > [AMD Official Use Only - General] > > Hi Andrew, > > I sent out a new V8 series last week. > A kernel parameter `wbrf` was introduced there to decide the policy. > Please help to check whether that makes sense to you. > Please share yo

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Alex Deucher
On Mon, Aug 14, 2023 at 3:35 AM Arvind Yadav wrote: > > This patch adds a function which will allow to > change the GPU power profile based on a submitted job. > This can optimize the power performance when the > workload is on. A few minor comments inline below. One thing to double check is tha

RE: [PATCH] drm/amdgpu: Remove gfxoff check in GFX v9.4.3

2023-08-14 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Monday, August 14, 2023 22:28 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH] drm/amdgpu: Remove gfxoff check in GFX v9.4

[PATCH] drm/amdgpu: Remove gfxoff check in GFX v9.4.3

2023-08-14 Thread Lijo Lazar
GFXOFF feature is not there for GFX 9.4.3 ASICs. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c index 564770c3875e..4bbe9c5ed87f 100644 -

Re: [PATCH v3] drm/amdgpu: skip xcp drm device allocation when out of drm resource

2023-08-14 Thread Lazar, Lijo
On 8/14/2023 7:28 PM, James Zhu wrote: On 2023-08-12 13:00, Lazar, Lijo wrote: On 8/12/2023 6:14 PM, James Zhu wrote: On 2023-08-11 21:39, Lazar, Lijo wrote: [AMD Official Use Only - General] A dynamic partition switch could happen later.  The switch could still be successful in ter

Re: [PATCH v3] drm/amdgpu: skip xcp drm device allocation when out of drm resource

2023-08-14 Thread James Zhu
On 2023-08-12 13:00, Lazar, Lijo wrote: On 8/12/2023 6:14 PM, James Zhu wrote: On 2023-08-11 21:39, Lazar, Lijo wrote: [AMD Official Use Only - General] A dynamic partition switch could happen later.  The switch could still be successful in terms of hardware, [JZ] Only ignore render no

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Johannes Berg
On Tue, 2023-07-25 at 22:09 +0200, Andrew Lunn wrote: > > > It could well be that AMD based machine has a different ACPI extension > to indicate this policy to what Intel machine has. As far as i > understand it, you have not submitted this yet for formal approval, > this is all vendor specific,

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Yadav, Arvind
On 8/14/2023 5:35 PM, Christian König wrote: Am 14.08.23 um 09:34 schrieb Arvind Yadav: This patch adds a function which will allow to change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. Cc: Shashank Sharma Cc: Christian Koe

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Christian König
Am 14.08.23 um 09:34 schrieb Arvind Yadav: This patch adds a function which will allow to change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yad

Re: [PATCH 0/5] Add work pool to reset domain

2023-08-14 Thread Christian König
Am 12.08.23 um 19:08 schrieb Lazar, Lijo: On 8/12/2023 1:53 PM, Christian König wrote: Am 11.08.23 um 08:02 schrieb Lijo Lazar: Presently, there are multiple clients of reset like RAS, job timeout, KFD hang detection and debug method. Instead of each client maintaining a work item, reset work

Re: [PATCH] drm/amd/display: Replace ternary operator with min() in 'dm_helpers_parse_edid_caps'

2023-08-14 Thread Hamza Mahfooz
On 8/13/23 04:46, Srinivasan Shanmugam wrote: Fixes the following coccicheck: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:120:41-42: WARNING opportunity for min() Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam

Re: [PATCH] drm/amd/display: Fix unnecessary conversion to bool in 'amdgpu_dm_setup_replay'

2023-08-14 Thread Christian König
Am 13.08.23 um 10:36 schrieb Srinivasan Shanmugam: Fixes the following coccicheck: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:94:102-107: WARNING: conversion to bool not needed here drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:102:72-77: WARNING: conversion to bool no

Re: [PATCH v3 2/2] drm/amd/pm: Update pci link speed for smu v13.0.6

2023-08-14 Thread Lazar, Lijo
On 8/14/2023 3:47 PM, Asad Kamal wrote: Update pcie link speed registers for smu v13.0.6 & populate gpu metric table with pcie link speed rather than gen for smu v13_0_0, smu v13_0_6 & smu v13_0_7 v2: Update ESM register address Used macro to convert pcie gen to speed v3: Chaged macro to inl

[PATCH v3 2/2] drm/amd/pm: Update pci link speed for smu v13.0.6

2023-08-14 Thread Asad Kamal
Update pcie link speed registers for smu v13.0.6 & populate gpu metric table with pcie link speed rather than gen for smu v13_0_0, smu v13_0_6 & smu v13_0_7 v2: Update ESM register address Used macro to convert pcie gen to speed v3: Chaged macro to inline function for pcie gen to speed Signed-of

[PATCH v3 1/2] drm/amd/pm: Update pci link width for smu v13.0.6

2023-08-14 Thread Asad Kamal
Update addresses of PCIE link width registers, & link width format used to populate gpu metrics table for smu v13.0.6 v2: Removed ESM register update v3: Updated patch subject and message Signed-off-by: Asad Kamal --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 10 -- 1 file

Re: [PATCH v6] drm/doc: Document DRM device reset expectations

2023-08-14 Thread Michel Dänzer
On 8/11/23 20:55, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida [...] > +Robustness > +-- > + > +The only way to try to keep an application working after a reset is if it > +

RE: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] Hi Andrew, I sent out a new V8 series last week. A kernel parameter `wbrf` was introduced there to decide the policy. Please help to check whether that makes sense to you. Please share your insights there. BR, Evan > -Original Message- > From: Andrew Lun

Re: [PATCH] drm/amdgpu: Replace ternary operator with min() in 'amdgpu_iomem_read'

2023-08-14 Thread SHANMUGAM, SRINIVASAN
On 8/14/2023 2:45 PM, Christian König wrote: Am 12.08.23 um 16:47 schrieb Srinivasan Shanmugam: Fixes the following coccicheck: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2427:16-17: WARNING opportunity for min() min() macro is defined in include/linux/minmax.h. It avoids multiple evaluations

Re: [PATCH] drm/amdgpu: Replace ternary operator with min() in 'amdgpu_iomem_read'

2023-08-14 Thread Christian König
Am 12.08.23 um 16:47 schrieb Srinivasan Shanmugam: Fixes the following coccicheck: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2427:16-17: WARNING opportunity for min() min() macro is defined in include/linux/minmax.h. It avoids multiple evaluations of the arguments when non-constant and performs

RE: [PATCH V8 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Jeff Johnson > Sent: Thursday, August 10, 2023 10:06 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; johan...@sipsolu

RE: [PATCH V8 1/9] drivers core: Add support for Wifi band RF mitigations

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Randy Dunlap > Sent: Thursday, August 10, 2023 11:41 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; johan...@sipsolu

RE: [PATCH V8 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Friday, August 11, 2023 5:35 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; johan...@sipso

RE: [PATCH V8 2/9] drivers core: add ACPI based WBRF mechanism introduced by AMD

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Friday, August 11, 2023 5:38 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; johan...@sipso

[PATCH 3/3] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-14 Thread Arvind Yadav
This reverts commit 5ce71f59bb9bd3d8a09b96afdbc92975cb6dc303. Reason for revert: New amdgpu_smu* api is added to switch on/off profile mode. These new api will allow to change the GPU power profile based on a submitted job. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-b

[PATCH 2/3] drm/amdgpu: Switch on/off GPU workload profile

2023-08-14 Thread Arvind Yadav
This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 + 1 file chang

[PATCH 0/3] GPU workload hints for better performance

2023-08-14 Thread Arvind Yadav
AMDGPU SOCs supports dynamic workload based power profiles, which can provide fine-tuned performance for a particular type of workload. This patch series adds an interface to set/reset these power profiles based on the submitted job. The driver can dynamically switch the power profiles based on sub

[PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Arvind Yadav
This patch adds a function which will allow to change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/Makefile

Re: [PATCH -next 5/7] drm/virtio: Remove an unnecessary NULL value

2023-08-14 Thread Dmitry Osipenko
On 8/9/23 06:44, Ruan Jinjie wrote: > The NULL initialization of the pointer assigned by kzalloc() first is > not necessary, because if the kzalloc() failed, the pointer will be > assigned NULL, otherwise it works as usual. so remove it. > > Signed-off-by: Ruan Jinjie > --- > drivers/gpu/drm/vir