RE: [PATCH] drm/amdgpu/vkms: relax timer deactivation by hrtimer_try_to_cancel

2023-07-09 Thread Chen, Guchun
[Public] > -Original Message- > From: Chen, Guchun > Sent: Friday, July 7, 2023 9:06 AM > To: Koenig, Christian ; amd- > g...@lists.freedesktop.org; Deucher, Alexander > ; Zhang, Hawking > ; Milinkovic, Dusica > ; Prica, Nikola ; Cui, > Flora > Cc: sta...@vger.kernel.org > Subject: RE: [P

[PATCH v2] drm/amdgpu/vkms: relax timer deactivation by hrtimer_try_to_cancel

2023-07-09 Thread Guchun Chen
In below thousands of screen rotation loop tests with virtual display enabled, a CPU hard lockup issue may happen, leading system to unresponsive and crash. do { xrandr --output Virtual --rotate inverted xrandr --output Virtual --rotate right xrandr --output Virtual --rotat

Re: [PATCH 2/2] drm/amdgpu: use psp_execute_load_ip_fw instead

2023-07-09 Thread Lazar, Lijo
On 7/10/2023 8:40 AM, Lang Yu wrote: Replace the old ones with psp_execute_load_ip_fw. Suggested-by: Lijo Lazar Signed-off-by: Lang Yu Series is - Reviewed-by: Lijo Lazar Thanks, Lijo --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 13 - drivers/gpu/drm/amd/amdgpu

RE: [PATCH v3] drm/amdkfd: Fix stack size in 'amdgpu_amdkfd_unmap_hiq'

2023-07-09 Thread Chen, Guchun
[Public] Acked-by: Guchun Chen > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Monday, July 10, 2023 11:22 AM > To: Koenig, Christian ; Deucher, Alexander > ; Kuehling, Felix ; > Chen, Guchun > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > > Subject: [PATCH v3]

[PATCH v3] drm/amdkfd: Fix stack size in 'amdgpu_amdkfd_unmap_hiq'

2023-07-09 Thread Srinivasan Shanmugam
Allocate large local variable on heap to avoid exceeding the stack size: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c: In function ‘amdgpu_amdkfd_unmap_hiq’: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:868:1: warning: the frame size of 1280 bytes is larger than 1024 bytes [-Wframe-larger-than=] Sug

[PATCH 2/2] drm/amdgpu: use psp_execute_load_ip_fw instead

2023-07-09 Thread Lang Yu
Replace the old ones with psp_execute_load_ip_fw. Suggested-by: Lijo Lazar Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 13 - drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 2 -- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 15 +++ drivers/gpu/drm/amd/am

[PATCH 1/2] drm/amdgpu: rename psp_execute_non_psp_fw_load and make it global

2023-07-09 Thread Lang Yu
This will make this function more general, and then serve other IPs. Suggested-by: Lijo Lazar Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 12 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 3 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/dr

RE: [PATCH v2] drm/amdkfd: Fix stack size in 'amdgpu_amdkfd_unmap_hiq'

2023-07-09 Thread Chen, Guchun
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Sunday, July 9, 2023 11:05 PM > To: Koenig, Christian ; Deucher, Alexander > ; Kuehling, Felix > Cc: SHANMUGAM, SRINIVASAN ; > amd-gfx@lists.freedesktop.org > Subject: [PATCH v2] drm/amdkfd: Fix sta

RE: [PATCH 4/4] drm/amd: Drop amdgpu_device_aspm_support_quirk()

2023-07-09 Thread Quan, Evan
[AMD Official Use Only - General] Patch1, 2, 3 are reviewed-by: Evan Quan For patch4, it seems not quite right(at least for the naming). Since although the ASPM is the prerequisite for pcie/lclk dpm features. But the changes involved here are really for aspm feature disablement. I mean even if p

[PATCH v2] drm/amdkfd: Fix stack size in 'amdgpu_amdkfd_unmap_hiq'

2023-07-09 Thread Srinivasan Shanmugam
Allocate large local variable on heap to avoid exceeding the stack size: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c: In function ‘amdgpu_amdkfd_unmap_hiq’: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:868:1: warning: the frame size of 1280 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: