RE: [PATCH 1/2] drm/amd/pm: correct SMU13.0.7 pstate profiling clock settings

2023-04-09 Thread Feng, Kenneth
[AMD Official Use Only - General] Series is Reviewed-by: Kenneth Feng -Original Message- From: amd-gfx On Behalf Of Horatio Zhang Sent: Monday, April 10, 2023 10:03 AM To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Zhang, Horatio ; Quan, Evan Subject: [PATCH 1/2] drm/amd/pm: corr

[PATCH 2/2] drm/amd/pm: correct SMU13.0.7 max shader clock reporting

2023-04-09 Thread Horatio Zhang
Correct the max shader clock reporting on SMU 13.0.7. Signed-off-by: Horatio Zhang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 61 ++- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd

[PATCH 1/2] drm/amd/pm: correct SMU13.0.7 pstate profiling clock settings

2023-04-09 Thread Horatio Zhang
Correct the pstate standard/peak profiling mode clock settings for SMU13.0.7. Signed-off-by: Horatio Zhang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 22 +-- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt

RE: [PATCH] drm/amd/pm: remove unused num_of_active_display variable

2023-04-09 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Tom Rix > Sent: Saturday, April 1, 2023 12:41 AM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; nat...@kernel.org; > ndesaulni...@go

Re: [PATCH v3 0/9] AMDGPU Usermode queues

2023-04-09 Thread Bas Nieuwenhuizen
Hi Shashank, I tried writing a program to experiment with usermode queues and I found some weird behavior: The first run of the program works as expected, while subsequent runs don't seem to do anything (and I allocate everything in GTT, so it should be zero initialized consistently). Is this a kn

Re: [PATCH v3 3/9] drm/amdgpu: add new IOCTL for usermode queue

2023-04-09 Thread Bas Nieuwenhuizen
On Wed, Mar 29, 2023 at 6:05 PM Shashank Sharma wrote: > > From: Shashank Sharma > > This patch adds: > - A new IOCTL function to create and destroy > - A new structure to keep all the user queue data in one place. > - A function to generate unique index for the queue. > > V1: Worked on review co

Re: [PATCH v3 8/9] drm/amdgpu: map wptr BO into GART

2023-04-09 Thread Bas Nieuwenhuizen
On Wed, Mar 29, 2023 at 6:05 PM Shashank Sharma wrote: > > From: Arvind Yadav > > To support oversubscription, MES expects WPTR BOs to be mapped > to GART, before they are submitted to usermode queues. > > Cc: Alex Deucher > Cc: Christian Koenig > Cc: Shashank Sharma > Signed-off-by: Arvind Y

[PATCH] drm/amd/display : Log DP link training downspread info

2023-04-09 Thread Srinivasan Shanmugam
Update the existing log with DP LT downspread info: [Downstream devices shall support down spreading of the link clock. The down-spread amplitude shall either be disabled (0.0%) or up to 0.5%, as written by the upstream device to the DOWNSPREAD_CTRL register (DPCD 00107h). The modulation frequency

[PATCH v2 1/3] drm/amdgpu: Reject submissions with too many IBs.

2023-04-09 Thread Bas Nieuwenhuizen
Instead of failing somewhere in the scheduler after the ioctl has already succeeded. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2498 Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 5 + drivers

[PATCH v2 3/3] drm/amdgpu: Add support for querying the max ibs in a submission. (v2)

2023-04-09 Thread Bas Nieuwenhuizen
We need to introduce a new version of the info struct because libdrm_amdgpu forgot any versioning info in amdgpu_query_hw_ip_info so the mesa<->libdrm_amdgpu interface can't handle increasing the size. This info would be used by radv to figure out when we need to split a submission into multiple s

[PATCH v2 2/3] drm/amdgpu: Simplify amdgpu_hw_ip_info.

2023-04-09 Thread Bas Nieuwenhuizen
We have a list of all rings, so no sense writing the same loop N times. With how often this gets called and how small the ring list is the performance of this shouldn't matter. Note that some of the loops included some checking wrt harvesting. That is redundant now, as those rings never get initia

Re: [PATCH 3/3] drm/amdgpu: Add support for querying the max ibs in a submission.

2023-04-09 Thread Bas Nieuwenhuizen
On Sun, Apr 9, 2023, 5:50 PM Timur Kristóf wrote: > > > Christian König ezt írta (időpont: > 2023. ápr. 9., Vas 17:38): > >> Am 09.04.23 um 17:32 schrieb Bas Nieuwenhuizen: >> > On Sun, Apr 9, 2023 at 5:30 PM Christian König >> > wrote: >> >> Am 09.04.23 um 16:44 schrieb Bas Nieuwenhuizen: >> >

Re: [PATCH 3/3] drm/amdgpu: Add support for querying the max ibs in a submission.

2023-04-09 Thread Christian König
Am 09.04.23 um 17:32 schrieb Bas Nieuwenhuizen: On Sun, Apr 9, 2023 at 5:30 PM Christian König wrote: Am 09.04.23 um 16:44 schrieb Bas Nieuwenhuizen: We need to introduce a new version of the info struct because libdrm_amdgpu forgot any versioning info in amdgpu_query_hw_ip_info so the mesa<->

Re: [PATCH 3/3] drm/amdgpu: Add support for querying the max ibs in a submission.

2023-04-09 Thread Bas Nieuwenhuizen
On Sun, Apr 9, 2023 at 5:30 PM Christian König wrote: > > Am 09.04.23 um 16:44 schrieb Bas Nieuwenhuizen: > > We need to introduce a new version of the info struct because > > libdrm_amdgpu forgot any versioning info in amdgpu_query_hw_ip_info > > so the mesa<->libdrm_amdgpu interface can't handle

Re: [PATCH 3/3] drm/amdgpu: Add support for querying the max ibs in a submission.

2023-04-09 Thread Christian König
Am 09.04.23 um 16:44 schrieb Bas Nieuwenhuizen: We need to introduce a new version of the info struct because libdrm_amdgpu forgot any versioning info in amdgpu_query_hw_ip_info so the mesa<->libdrm_amdgpu interface can't handle increasing the size. Those are not forgotten, but simply unnecessa

Re: [PATCH 03/13] drm/amdgpu/UAPI: add new CS chunk for GFX shadow buffers

2023-04-09 Thread Christian König
We removed the GDS information because they were unnecessary. The GDS size was already part of the device info before we added the shadow info. But as far as I know the firmware needs valid VAs for all three buffers or won't work correctly. Christian. Am 06.04.23 um 17:01 schrieb Marek Olšák

[PATCH 1/3] drm/amdgpu: Reject submissions with too many IBs.

2023-04-09 Thread Bas Nieuwenhuizen
Instead of failing somewhere in the scheduler after the ioctl has already succeeded. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2498 Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 5 + drivers

[PATCH 3/3] drm/amdgpu: Add support for querying the max ibs in a submission.

2023-04-09 Thread Bas Nieuwenhuizen
We need to introduce a new version of the info struct because libdrm_amdgpu forgot any versioning info in amdgpu_query_hw_ip_info so the mesa<->libdrm_amdgpu interface can't handle increasing the size. This info would be used by radv to figure out when we need to split a submission into multiple s

[PATCH 2/3] drm/amdgpu: Simplify amdgpu_hw_ip_info.

2023-04-09 Thread Bas Nieuwenhuizen
We have a list of all rings, so no sense writing the same loop N times. With how often this gets called and how small the ring list is the performance of this shouldn't matter. Note that some of the loops included some checking wrt harvesting. That is redundant now, as those rings never get initia