RE: [PATCH] drm/amdgpu/gmc11: disable AGP aperture again

2023-02-08 Thread Quan, Evan
[AMD Official Use Only - General] Settings for gfxhub_v3_0_3.c seem missing. Evan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, February 9, 2023 12:25 PM > To: Zhang, Hawking > Cc: Deucher, Alexander ; amd- > g...@lists.freedesktop.org > Subject: Re:

RE: [PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

2023-02-08 Thread Zhang, Hawking
[AMD Official Use Only - General] Sorry, I made a mistake. There is no mmhub_v3_0_3. Only gfxhub_v3_0_3 need the same fix Regards, Hawking -Original Message- From: Zhang, Hawking Sent: Thursday, February 9, 2023 15:15 To: Zhang, Hawking ; Deucher, Alexander ; amd-gfx@lists.freedesktop

RE: [PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

2023-02-08 Thread Zhang, Hawking
[AMD Official Use Only - General] BTW, @Deucher, Alexander gfxhub_v3_0_3/mmhub_v3_0_3 also need similar fixes Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: Thursday, February 9, 2023 15:13 To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc:

RE: [PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

2023-02-08 Thread Zhang, Hawking
[AMD Official Use Only - General] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, February 9, 2023 12:46 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amd/display: mino

[PATCH v2] drm/amdkfd: To fix sdma page fault issue for GC 11.x

2023-02-08 Thread Ji, Ruili
From: Ruili Ji For the MQD memory, KMD would always allocate 4K memory, and mes scheduler would write to the end of MQD for unmap flag. Signed-off-by: Ruili Ji --- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 +++-- drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v11.c | 15 +

[pull] amdgpu drm-fixes-6.2

2023-02-08 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.2. The following changes since commit 04119ab1a49fc41cb70f0472be5455af268fa260: nvidiafb: detect the hardware support before removing console. (2023-02-07 08:42:29 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git t

[PATCH 2/2] drm/amd/display: minor cleanup of vm_setup

2023-02-08 Thread Alex Deucher
Use fb_start/end for consistency with gmc code for non- XGMI systems, they are equivalent to vram_start/end. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amd

[PATCH 1/2] drm/amdgpu/gmc11: fix system aperture set when AGP is enabled

2023-02-08 Thread Alex Deucher
Need to cover both FB and AGP apertures. Fixes: c6eafee038ed ("Revert "Revert "drm/amdgpu/gmc11: enable AGP aperture""") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/mmhub_v3_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1

Re: [PATCH] drm/amdgpu/gmc11: disable AGP aperture again

2023-02-08 Thread Alex Deucher
Actually, nevermind, I found the bug. New patch on the way. Alex On Wed, Feb 8, 2023 at 9:52 PM Zhang, Hawking wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Hawking Zhang > > Regards, > Hawking > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: T

Re: [PATCH v3] drm/amdkfd: Prevent user space using both svm and kfd api to register same user buffer

2023-02-08 Thread Felix Kuehling
Am 2023-02-08 um 18:26 schrieb Xiaogang.Chen: From: Xiaogang Chen When xnack is on user space can use svm page restore to set a vm range without setup it first, then use regular api to register. Currently kfd api and svm are not interoperable. We already have check on that, but for user buffer

RE: [PATCH] drm/amdgpu/gmc11: disable AGP aperture again

2023-02-08 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, February 9, 2023 05:24 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/gmc11: disable AGP apertu

[PATCH v3] drm/amdkfd: Prevent user space using both svm and kfd api to register same user buffer

2023-02-08 Thread Xiaogang . Chen
From: Xiaogang Chen When xnack is on user space can use svm page restore to set a vm range without setup it first, then use regular api to register. Currently kfd api and svm are not interoperable. We already have check on that, but for user buffer the mapping address is not same as buffer cpu v

[PATCH] drm/amdgpu/gmc11: disable AGP aperture again

2023-02-08 Thread Alex Deucher
It seems not all of the issues with SDMA firmware have been resolved leading to spurious GPU page faults on some variants. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c | 7 +++ drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c| 1 - drivers/gpu/drm/amd/amdgpu/mmhub_v3_0

Re: [PATCH v2] drm/amdkfd: Prevent user space using both svm and kfd api to register same user buffer

2023-02-08 Thread Felix Kuehling
Am 2023-02-08 um 14:57 schrieb Xiaogang.Chen: From: Xiaogang Chen When xnack is on user space can use svm page restore to set a vm range without setup it first, then use regular api to register. Currently kfd api and svm are not interoperable. We already have check on that, but for user buffer

Re: [PATCH] drm/amd/display: don't call dc_interrupt_set() for disabled crtcs

2023-02-08 Thread Harry Wentland
On 2/8/23 15:01, Hamza Mahfooz wrote: > As made mention of in commit 4ea7fc09539b ("drm/amd/display: Do not > program interrupt status on disabled crtc"), we shouldn't program > disabled crtcs. So, filter out disabled crtcs in dm_set_vupdate_irq() > and dm_set_vblank(). > > Fixes: 589d2739332d ("d

[PATCH] drm/amd/display: don't call dc_interrupt_set() for disabled crtcs

2023-02-08 Thread Hamza Mahfooz
As made mention of in commit 4ea7fc09539b ("drm/amd/display: Do not program interrupt status on disabled crtc"), we shouldn't program disabled crtcs. So, filter out disabled crtcs in dm_set_vupdate_irq() and dm_set_vblank(). Fixes: 589d2739332d ("drm/amd/display: Use crtc enable/disable_vblank hoo

[PATCH v2] drm/amdkfd: Prevent user space using both svm and kfd api to register same user buffer

2023-02-08 Thread Xiaogang . Chen
From: Xiaogang Chen When xnack is on user space can use svm page restore to set a vm range without setup it first, then use regular api to register. Currently kfd api and svm are not interoperable. We already have check on that, but for user buffer the mapping address is not same as buffer cpu v

Re: [PATCH] drm/amd/display: fix dm irq error message in gpu recover

2023-02-08 Thread Hamza Mahfooz
On 2/8/23 02:25, Tianci Yin wrote: From: tiancyin [Why] Variable adev->crtc_irq.num_types was initialized as the value of adev->mode_info.num_crtc at early_init stage, later at hw_init stage, the num_crtc changed due to the display pipe harvest on some SKUs, but the num_types was not updated ac

[linux-next:master] BUILD REGRESSION 38d2b86a665b5e86371a1a30228bce259aa6c101

2023-02-08 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 38d2b86a665b5e86371a1a30228bce259aa6c101 Add linux-next specific files for 20230208 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301300743.bp7dpazv-...@intel.com https

Re: [PATCH] drm/amd/display: fix dm irq error message in gpu recover

2023-02-08 Thread Harry Wentland
On 2/8/23 09:26, Alex Deucher wrote: On Wed, Feb 8, 2023 at 2:26 AM Tianci Yin wrote: From: tiancyin [Why] Variable adev->crtc_irq.num_types was initialized as the value of adev->mode_info.num_crtc at early_init stage, later at hw_init stage, the num_crtc changed due to the display pipe h

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-08 Thread Ville Syrjälä
On Wed, Feb 08, 2023 at 11:18:42AM +0200, Pekka Paalanen wrote: > On Fri, 3 Feb 2023 16:02:51 +0200 > Ville Syrjälä wrote: > > > On Fri, Feb 03, 2023 at 02:52:50PM +0100, Sebastian Wick wrote: > > > On Fri, Feb 3, 2023 at 2:35 PM Ville Syrjälä > > > wrote: > > > > > > > > On Fri, Feb 03, 2023

Re: [PATCH] drm/amd/display: fix dm irq error message in gpu recover

2023-02-08 Thread Alex Deucher
On Wed, Feb 8, 2023 at 2:26 AM Tianci Yin wrote: > > From: tiancyin > > [Why] > Variable adev->crtc_irq.num_types was initialized as the value of > adev->mode_info.num_crtc at early_init stage, later at hw_init stage, > the num_crtc changed due to the display pipe harvest on some SKUs, > but the

Re: [PATCH] drm/amdgpu: Fix the warning info when unload or remove amdgpu

2023-02-08 Thread Alex Deucher
On Wed, Feb 8, 2023 at 2:26 AM Ma Jun wrote: > > Checking INVOKE_CMD to fix the below warning info when > unload or remove amdgpu driver > > [ 319.489809] Call Trace: > [ 319.489810] > [ 319.489812] psp_ta_unload+0x9a/0xd0 [amdgpu] > [ 319.489926] ? smu_smc_hw_cleanup+0x2f6/0x360 [amdgpu]

Re: [PATCH 3/6] drm/ttm: Change the meaning of resource->start from pfn to bytes

2023-02-08 Thread Christian König
That finally starts to look sane. I'm going to make a few more adjustments and then send this out. Christian. Am 08.02.23 um 10:01 schrieb Somalapuram Amaranath: Change resource->start from pfn to bytes to allow allocating objects smaller than a page. Change all DRM drivers using ttm_resource

Re: [PATCH 2/6] drm/amdgpu: Remove TTM resource->start visible VRAM condition

2023-02-08 Thread Christian König
Am 08.02.23 um 10:01 schrieb Somalapuram Amaranath: Use amdgpu_bo_in_cpu_visible_vram() instead. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

Re: [PATCH] drm: Rename headers to match DP2.1 spec

2023-02-08 Thread Thierry Reding
On Mon, Feb 06, 2023 at 02:37:08PM -0500, jdhillon wrote: > This patch changes the headers defined in drm_dp.h to match > the DP 2.1 spec. > > Signed-off-by: Jasdeep Dhillon > --- > drivers/gpu/drm/tegra/dp.c | 2 +- > include/drm/display/drm_dp.h | 13 +++-- > 2 files changed, 8 inse

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-08 Thread Pekka Paalanen
On Mon, 6 Feb 2023 12:16:28 -0500 Harry Wentland wrote: > On 2/6/23 04:47, Ville Syrjälä wrote: > > On Sat, Feb 04, 2023 at 06:09:45AM +, Joshua Ashton wrote: > >> > >> > >> On 2/3/23 19:34, Ville Syrjälä wrote: > >>> On Fri, Feb 03, 2023 at 09:25:38PM +0200, Ville Syrjälä wrote: >

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-08 Thread Pekka Paalanen
On Fri, 3 Feb 2023 14:33:46 -0500 Harry Wentland wrote: > On 2/3/23 14:25, Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 08:56:55PM +0200, Ville Syrjälä wrote: > >> On Fri, Feb 03, 2023 at 01:28:20PM -0500, Harry Wentland wrote: > >>> > >>> > >>> On 2/3/23 11:00, Ville Syrjälä wrote: > >

[PATCH] drm/amdgpu: Revert programming GRBM_GFX_* in RLCG interface to support GFX9

2023-02-08 Thread Yifan Zha
[Why] Regression of commit a291321cce8e("drm/amdgpu: Remove writing GRBM_GFX_CNTL in RLCG interface under SRIOV") on GFX9. According to GFX9 VF using different method to access GC registers including MMIO(direct) and RLCG(indirect), removing GRBM_GFX_* writing would make PIPE/ME/VM/QUEUE selectio

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-08 Thread Pekka Paalanen
On Fri, 3 Feb 2023 02:07:44 + Joshua Ashton wrote: > Userspace has no way of controlling or knowing the pixel encoding > currently, so there is no way for it to ever get the right values here. > > When we do add pixel_encoding control from userspace,we can pick the > right value for the col

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-08 Thread Pekka Paalanen
On Fri, 3 Feb 2023 20:56:55 +0200 Ville Syrjälä wrote: > Anyways, sounds like what you're basically proposing is > getting rid of this property and starting from scratch. I would be happy with that (throwing "Colorspace" out and defining something new). Then we can start with enum values we care

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-08 Thread Pekka Paalanen
On Fri, 3 Feb 2023 18:00:44 +0200 Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > > > > > > On 2/3/23 10:19, Ville Syrjälä wrote: > > > On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: > > >> > > >> > > >> On 2/3/23 07:59, Sebastian Wi

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-08 Thread Pekka Paalanen
On Fri, 3 Feb 2023 16:02:51 +0200 Ville Syrjälä wrote: > On Fri, Feb 03, 2023 at 02:52:50PM +0100, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 2:35 PM Ville Syrjälä > > wrote: > > > > > > On Fri, Feb 03, 2023 at 01:59:07PM +0100, Sebastian Wick wrote: > > > > On Fri, Feb 3, 2023 at 11:4

[PATCH 6/6] drm/amdgpu: Cleanup the GDS, GWS and OA allocations

2023-02-08 Thread Somalapuram Amaranath
Change the size of GDS, GWS and OA from pages to bytes. The initialized gds_size, gws_size and oa_size in bytes, remove PAGE_SHIFT in amdgpu_ttm_init_on_chip(). : Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 12 ++-- drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 5/6] drm/ttm: Change the meaning of the fields in the drm_mm_nodes structure from pfn to bytes

2023-02-08 Thread Somalapuram Amaranath
Change the ttm_range_man_alloc() allocation from pages to size in bytes. Fix the dependent drm_mm_nodes start and size from pages to bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/i915/i915_scatterlist.c | 6 +++--- drivers/gpu/drm/ttm/ttm_range_manager.c | 15 +++

[PATCH 4/6] drm/ttm: Change the parameters of ttm_range_man_init() from pages to bytes

2023-02-08 Thread Somalapuram Amaranath
Change the parameters of ttm_range_man_init_nocheck() size from page size to byte size. Cleanup the PAGE_SHIFT operation on the depended caller functions. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- drivers/gpu/drm/drm_gem_vram_helper.c | 2 +- dr

[PATCH 3/6] drm/ttm: Change the meaning of resource->start from pfn to bytes

2023-02-08 Thread Somalapuram Amaranath
Change resource->start from pfn to bytes to allow allocating objects smaller than a page. Change all DRM drivers using ttm_resource start and size pfn to bytes. Change amdgpu_res_first() cur->start, cur->size from pfn to bytes. Replacing ttm_resource resource->start field with cursor.start. Change

[PATCH 2/6] drm/amdgpu: Remove TTM resource->start visible VRAM condition

2023-02-08 Thread Somalapuram Amaranath
Use amdgpu_bo_in_cpu_visible_vram() instead. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c i

[PATCH 1/6] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2023-02-08 Thread Somalapuram Amaranath
ttm_resource can allocate size in bytes to support less than page size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/drm_gem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 59a0bb5ebd85..ee8b5c2b6c60 100644 --- a/driv

Re: [PATCH 2/3] drm/connector: Add enum documentation to drm_colorspace

2023-02-08 Thread Pekka Paalanen
On Fri, 3 Feb 2023 02:07:43 + Joshua Ashton wrote: > To match the other enums, and add more information about these values. > > Signed-off-by: Joshua Ashton > > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Uma Shankar > Cc: Ville Syrjälä > Cc: Joshua Asht

Re: [PATCH 1/3] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2023-02-08 Thread Pekka Paalanen
On Fri, 3 Feb 2023 02:07:42 + Joshua Ashton wrote: > From: Harry Wentland > > This allows us to use strongly typed arguments. > > Signed-off-by: Harry Wentland > Reviewed-by: Simon Ser > > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Uma Shankar > Cc: V