[PATCH v2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-20 Thread Tim Huang
PMFW will handle that properly for gpu reset case. Driver involvement may cause some unexpected issues. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/

RE: [PATCH 2/2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-20 Thread Huang, Tim
[Public] Hi Mario, -Original Message- From: Limonciello, Mario Sent: Saturday, January 21, 2023 12:36 AM To: Huang, Tim ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Du, Xiaojian ; Ma, Li Subject: RE: [PATCH 2/2] drm/amd/pm: drop unneeded dpm features disable

[PATCH RESEND] drm/amdgpu: skip psp suspend for IMU enabled ASICs mode2 reset

2023-01-20 Thread Tim Huang
The psp suspend & resume should be skipped to avoid destroy the TMR and reload FWs again for IMU enabled APU ASICs. Signed-off-by: Tim Huang Acked-by: Alex Deucher Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 1 file changed, 12 insertions(+)

Re: [PATCH 2/2] drm/amdgpu: add AMDGPU_INFO_VM_STAT to return GPU VM

2023-01-20 Thread Marek Olšák
We badly need a way to query evicted memory usage. It's essential for investigating performance problems and it uncovered the buddy allocator disaster. Please either suggest an alternative, suggest changes, or review. We need it ASAP. Thanks, Marek On Tue, Jan 10, 2023 at 11:55 AM Marek Olšák wr

[pull] amdgpu, amdkfd, UAPI drm-next-6.3

2023-01-20 Thread Alex Deucher
Hi Dave, Daniel, More updates for 6.3. The following changes since commit 0c2dece8fb541ab07b68c3312a1065fa9c927a81: drm/amdkfd: Page aligned memory reserve size (2023-01-11 16:41:03 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-

Re: [PATCH 0/7] Fix MST on amdgpu

2023-01-20 Thread Lyude Paul
For the whole series: Reviewed-by: Lyude Paul So glad to have this fixed finally ♥ On Thu, 2023-01-19 at 18:51 -0500, Harry Wentland wrote: > MST has been broken on amdgpu after a refactor in drm_dp_mst > code that was aligning drm_dp_mst more closely with the atomic > model. > > The gitlab is

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Guenter Roeck
On 1/20/23 10:39, Limonciello, Mario wrote: [ ... ] Wayne is OOO for CNY, but let me update you. Harry has sent out this series which is a collection of proper fixes. https://patchwork.freedesktop.org/series/113125/ Once that's reviewed and accepted, 4 of them are applicable for 6.1. Thanks

Re: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1

2023-01-20 Thread Michael Karcher
Hello Adrian, Could you post a kernel patch for that? I would be happy to test it on my SH-7785CLR board. Also, I'm going to file a bug report against GCC. I filed the bug already. It's https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108483. The diff is attached. It's published as CC0 in case a

Re: [PATCHv2] drm/amdgpu: Enable IH retry CAM on GFX9

2023-01-20 Thread Felix Kuehling
Am 2023-01-19 um 16:59 schrieb Mukul Joshi: This patch enables the IH retry CAM on GFX9 series cards. This retry filter is used to prevent sending lots of retry interrupts in a short span of time and overflowing the IH ring buffer. This will also help reduce CPU interrupt workload. Signed-off-by

[PATCH 2/2] drm/amdgpu: always sending PSP messages LOAD_ASD and UNLOAD_TA

2023-01-20 Thread vitaly.prosyak
From: Vitaly Prosyak We allow sending PSP messages LOAD_ASD and UNLOAD_TA without acquiring a lock in drm_dev_enter during driver unload because we must call drm_dev_unplug as the beginning of unload driver sequence. Added WARNING if other PSP messages are sent without a lock. After this commit,

[PATCH 1/2] Revert "drm/amdgpu: TA unload messages are not actually sent to psp when amdgpu is uninstalled"

2023-01-20 Thread vitaly.prosyak
From: Vitaly Prosyak This reverts commit fac53471d0ea9693d314aa2df08d62b2e7e3a0f8. The following change: move the drm_dev_unplug call after amdgpu_driver_unload_kms in amdgpu_pci_remove. The reason is the following: amdgpu_pci_remove calls drm_dev_unregister and it should be called first to ensur

RE: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Friday, January 20, 2023 12:18 > To: Limonciello, Mario > Cc: Lin, Wayne ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.freedesktop.org; sta...@vger.kernel.org; > stanislav.lisovs...@intel.com; Z

Re: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1

2023-01-20 Thread Michael.Karcher
Hello! Can someone please file a GCC PR? With reduced testcase preferably. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108483 There you are. Kind regars,   Michael Karcher

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Guenter Roeck
Hi Mario, On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote: > On 1/20/2023 11:46, Guenter Roeck wrote: > > On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: > > > This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. > > > > > > [Why] > > > Changes cause regress

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Guenter Roeck
On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: > This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. > > [Why] > Changes cause regression on amdgpu mst. > E.g. > In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload > one by one and call fill_dc_mst_pa

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Limonciello, Mario
On 1/20/2023 11:46, Guenter Roeck wrote: On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. [Why] Changes cause regression on amdgpu mst. E.g. In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload one

Re: [PATCH] drm/amd/display: use a more appropriate return value in dp_retrieve_lttpr_cap()

2023-01-20 Thread Alex Deucher
Acked-by: Alex Deucher On Fri, Jan 20, 2023 at 12:31 PM Hamza Mahfooz wrote: > > Not all ASICs support LTTPR, however if they don't it doesn't mean that > we have encountered unexpected behaviour. So, use DC_NOT_SUPPORTED > instead of DC_ERROR_UNEXPECTED. > > Reviewed-by: Wenjing Liu > Signed-o

[PATCH] drm/amd/display: use a more appropriate return value in dp_retrieve_lttpr_cap()

2023-01-20 Thread Hamza Mahfooz
Not all ASICs support LTTPR, however if they don't it doesn't mean that we have encountered unexpected behaviour. So, use DC_NOT_SUPPORTED instead of DC_ERROR_UNEXPECTED. Reviewed-by: Wenjing Liu Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c | 2 +- 1

[linux-next:master] BUILD REGRESSION d514392f17fd4d386cfadde7f849d97db4ca1fb0

2023-01-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d514392f17fd4d386cfadde7f849d97db4ca1fb0 Add linux-next specific files for 20230120 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301191616.r33dvxk4-...@intel.com https

RE: [PATCH 1/2] drm/amdgpu: skip psp suspend for IMU enabled ASICs mode2 reset

2023-01-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Huang, Tim > Sent: Friday, January 20, 2023 10:29 > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhang, Yifan > ; Du, Xiaojian ; Ma, Li > ; Limonciello, Mario ; > Huang, Tim > Subject: [PATCH 1/2] drm/amdgpu: skip psp suspend for IM

RE: [PATCH 2/2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Huang, Tim > Sent: Friday, January 20, 2023 10:29 > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhang, Yifan > ; Du, Xiaojian ; Ma, Li > ; Limonciello, Mario ; > Huang, Tim > Subject: [PATCH 2/2] drm/amd/pm: drop unneeded dpm featu

Re: [PATCH 2/2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-20 Thread Alex Deucher
Series is: Acked-by: Alex Deucher On Fri, Jan 20, 2023 at 11:29 AM Tim Huang wrote: > > PMFW will handle that properly. Driver involvement may cause some > unexpected issues. > > Signed-off-by: Tim Huang > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 ++ > 1 file changed, 2 insertions(+

[PATCH 1/2] drm/amdgpu: skip psp suspend for IMU enabled ASICs mode2 reset

2023-01-20 Thread Tim Huang
The psp suspend & resume should be skipped to avoid destroy the TMR and reload FWs again for IMU enabled APU ASICs. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 2/2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11

2023-01-20 Thread Tim Huang
PMFW will handle that properly. Driver involvement may cause some unexpected issues. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c

RE: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1

2023-01-20 Thread David Laight
From: Segher Boessenkool > Sent: 20 January 2023 10:54 ... > > > I suggest to file a bug against gcc complaining about a "spurious > > > warning", and using "-Werror -Wno-error-sizeof-pointer-div" until gcc is > > > adapted to not emit the warning about the pointer division if the result > > > is n

Re: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1

2023-01-20 Thread John Paul Adrian Glaubitz
Hi Michael! On 1/19/23 23:11, Michael.Karcher wrote: I suggest to file a bug against gcc complaining about a "spurious warning", and using "-Werror -Wno-error-sizeof-pointer-div" until gcc is adapted to not emit the warning about the pointer division if the result is not used. Could you post a

Re: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1

2023-01-20 Thread Segher Boessenkool
On Thu, Jan 19, 2023 at 09:31:21PM -0600, Rob Landley wrote: > On 1/19/23 16:11, Michael.Karcher wrote: > > I don't see a clear bug at this point. We are talking about the C expression > > > >   __same_type((void*)0, (void*)0)? 0 : sizeof((void*)0)/sizeof(*((void*0)) (__same_type is a kernel mac

Re: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1

2023-01-20 Thread Rob Landley
On 1/19/23 16:11, Michael.Karcher wrote: > Isn't this supposed to be caught by this check: a, __same_type(a, NULL) ? >>> >>> Yeah, but gcc thinks it is smarter than us... >>> Probably it drops the test, assuming UB cannot happen. >> Hmm, sounds like a GGC bug to me t

Re: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1

2023-01-20 Thread Michael.Karcher
Isn't this supposed to be caught by this check: a, __same_type(a, NULL) ? Yeah, but gcc thinks it is smarter than us... Probably it drops the test, assuming UB cannot happen. Hmm, sounds like a GGC bug to me then. Not sure how to fix this then. I don't see a clear bug at this poi

RE: [PATCH 2/2] drm/amdgpu: declare firmware for new MES 11.0.4

2023-01-20 Thread Zhang, Yifan
[Public] This series is: Reviewed-by: Yifan Zhang -Original Message- From: Ma, Li Sent: Friday, January 20, 2023 4:09 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Yifan ; Huang, Tim ; Du, Xiaojian ; Deucher, Alexander ; Ma, Li Subject: [PATCH 2/2] drm/amdgpu: declare firmware f

[PATCH 2/2] drm/amdgpu: declare firmware for new MES 11.0.4

2023-01-20 Thread Li Ma
To support new mes ip block Signed-off-by: Li Ma --- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c index 00e64838bb8b..62cdd2113135 100644 --- a/drivers/gpu/drm/amd/amd

[PATCH 1/2] drm/amdgpu: enable imu firmware for GC 11.0.4

2023-01-20 Thread Li Ma
The GC 11.0.4 needs load IMU to power up GFX before loads GFX firmware. Signed-off-by: Li Ma --- drivers/gpu/drm/amd/amdgpu/imu_v11_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c b/drivers/gpu/drm/amd/amdgpu/imu_v11_0.c index ed0d368149aa..4ab90c7