Re: [PATCH 2/2] drm/amdgpu: add AMDGPU_INFO_VM_STAT to return GPU VM

2023-01-02 Thread Marek Olšák
What are you talking about? Is fdinfo in sysfs? Userspace drivers can't access sysfs. Marek On Mon, Jan 2, 2023, 10:56 Christian König wrote: > Well first of all don't mess with the VM internals outside of the VM code. > > Then why would we want to expose this through the IOCTL interface? We >

Re: [PATCH 1/2] drm/amdgpu: return the PCIe gen and lanes from the INFO

2023-01-02 Thread Marek Olšák
Userspace drivers can't access sysfs. Marek On Mon, Jan 2, 2023, 10:54 Christian König wrote: > That stuff is already available as current_link_speed and > current_link_width in sysfs. > > I'm a bit reluctant duplicating this information in the IOCTL interface. > > Christian. > > Am 30.12.22 um

Re: [RFC PATCH 1/3] drm/amdgpu: Add vm->notifier_lock

2023-01-02 Thread Christian König
Am 21.12.22 um 00:27 schrieb Felix Kuehling: This points to a mutex to serialize with MMU notifiers during page table updates. For graphics contexts, the notifier lock is per adev. For compute contexts the lock is per process. I don't think mixing the VM code into this is a good idea. Instead we

Re: [PATCH 2/2] drm/amdgpu: add AMDGPU_INFO_VM_STAT to return GPU VM

2023-01-02 Thread Christian König
Well first of all don't mess with the VM internals outside of the VM code. Then why would we want to expose this through the IOCTL interface? We already have this in the fdinfo. Christian. Am 30.12.22 um 23:07 schrieb Marek Olšák: To give userspace a detailed view about its GPU memory usage a

Re: [PATCH 1/2] drm/amdgpu: return the PCIe gen and lanes from the INFO

2023-01-02 Thread Christian König
That stuff is already available as current_link_speed and current_link_width in sysfs. I'm a bit reluctant duplicating this information in the IOCTL interface. Christian. Am 30.12.22 um 23:07 schrieb Marek Olšák: For computing PCIe bandwidth in userspace and troubleshooting PCIe bandwidth iss

Re: [PATCH v3 05/11] drm/amd: Request SDMA microcode during IP discovery

2023-01-02 Thread Christian König
Am 30.12.22 um 06:21 schrieb Mario Limonciello: If SDMA microcode is not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request from SDMA microcode into the IP discovery phase so that if it's not available, IP discove

Re: [RFC 2/7] drm/amdgpu: Add usermode queue for gfx work

2023-01-02 Thread Christian König
Am 29.12.22 um 18:41 schrieb Alex Deucher: On Fri, Dec 23, 2022 at 2:37 PM Shashank Sharma wrote: This patch adds skeleton code for usermode queue creation. It typically contains: - A new structure to keep all the user queue data in one place. - An IOCTL function to create/free a usermode queue

Re: [RFC 1/7] drm/amdgpu: UAPI for user queue management

2023-01-02 Thread Christian König
Am 23.12.22 um 20:36 schrieb Shashank Sharma: From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue. The userspace app will fill this structure and request the graphics driver to add a graphics work queue for it. The output of this UAPI is a queue id. This UAPI ma

Re: [RFC 2/7] drm/amdgpu: Add usermode queue for gfx work

2023-01-02 Thread Christian König
Hi Shashank, Am 26.12.22 um 11:41 schrieb Shashank Sharma: [SNIP]     /* df */   struct amdgpu_df    df; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h index 0fa0e56daf67..f7413859b14f 100644 --- a/drivers/gpu/drm/amd/amdgpu/

Re: [RFC 1/7] drm/amdgpu: UAPI for user queue management

2023-01-02 Thread Christian König
Am 27.12.22 um 17:58 schrieb Alex Deucher: On Sat, Dec 24, 2022 at 3:21 PM Bas Nieuwenhuizen wrote: On Fri, Dec 23, 2022 at 8:37 PM Shashank Sharma wrote: From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue. The userspace app will fill this structure and requ

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2023-01-02 Thread Dmitry Osipenko
On 1/1/23 21:29, youling257 wrote: > Linux 6.2-rc1 has memory leak on amdgpu, git bisect bad commit is > "drm/scheduler: rework entity flush, kill and fini". > git bisect start > # status: waiting for both good and bad commits > # good: [eb7081409f94a9a8608593d0fb63a1aa3d6f95d8] Linux 6.1-rc6 > gi