[PATCH v3 11/11] drm/amd: Request PSP microcode during IP discovery

2022-12-29 Thread Mario Limonciello
If PSP microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for PSP microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Limonci

[PATCH v3 08/11] drm/amd: Request GFX9 microcode during IP discovery

2022-12-29 Thread Mario Limonciello
If GFX9 microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for GFX9 microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Limon

[PATCH v3 09/11] drm/amd: Request GFX10 microcode during IP discovery

2022-12-29 Thread Mario Limonciello
If GFX10 microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for GFX10 microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Reviewed-by: Alex Deuche

[PATCH v3 10/11] drm/amd: Request GFX11 microcode during IP discovery

2022-12-29 Thread Mario Limonciello
If GFX11 microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for GFX11 microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Reviewed-by: Alex Deuche

[PATCH v3 06/11] drm/amd: Request VCN microcode during IP discovery

2022-12-29 Thread Mario Limonciello
If VCN microcode is not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for VCN microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Reviewed-by: Alex Deucher Signed-off-by:

[PATCH v3 07/11] drm/amd: Request MES microcode during IP discovery

2022-12-29 Thread Mario Limonciello
If MES microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for MES microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Reviewed-by: Alex Deucher S

[PATCH v3 03/11] drm/amd: Convert SMUv11 microcode init to use `amdgpu_ucode_ip_version_decode`

2022-12-29 Thread Mario Limonciello
Remove the special casing from SMU v11 code. No intended functional changes. Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 35 ++- 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

[PATCH v3 04/11] drm/amd: Convert SMUv13 to use `amdgpu_ucode_ip_version_decode`

2022-12-29 Thread Mario Limonciello
The special case for the one dGPU has been moved into `amdgpu_ucode_ip_version_decode`, so simplify this code. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff

[PATCH v3 05/11] drm/amd: Request SDMA microcode during IP discovery

2022-12-29 Thread Mario Limonciello
If SDMA microcode is not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request from SDMA microcode into the IP discovery phase so that if it's not available, IP discovery will fail. Signed-off-by: Mario Limonciello ---

[PATCH v3 02/11] drm/amd: Add a legacy mapping to "amdgpu_ucode_ip_version_decode"

2022-12-29 Thread Mario Limonciello
This will allow other parts of the driver that currently special case firmware file names to before IP version style naming to just have a single call to `amdgpu_ucode_ip_version_decode`. Signed-off-by: Mario Limonciello --- v2->v3: * Fixes for GFX9 SDMA --- drivers/gpu/drm/amd/amdgpu/amdgpu_uc

[PATCH v3 01/11] drm/amd: Delay removal of the firmware framebuffer

2022-12-29 Thread Mario Limonciello
Removing the firmware framebuffer from the driver means that even if the driver doesn't support the IP blocks in a GPU it will no longer be functional after the driver fails to initialize. This change will ensure that unsupported IP blocks at least cause the driver to work with the EFI framebuffer

[PATCH v3 00/11] Recover from failure to probe GPU

2022-12-29 Thread Mario Limonciello
One of the first thing that KMS drivers do during initialization is destroy the system firmware framebuffer by means of `drm_aperture_remove_conflicting_pci_framebuffers` This means that if for any reason the GPU failed to probe the user will be stuck with at best a screen frozen at the last thing

Re: [RFC 0/7] RFC: Usermode queue for AMDGPU driver

2022-12-29 Thread Alex Deucher
On Fri, Dec 23, 2022 at 2:37 PM Shashank Sharma wrote: > > This is a RFC series to implement usermode graphics queues for AMDGPU > driver (Navi 3X and above). The idea of usermode graphics queue is to > allow direct workload submission from a userspace graphics process who > has amdgpu graphics co

Re: [RFC 5/7] drm/amdgpu: Create context for usermode queue

2022-12-29 Thread Alex Deucher
On Fri, Dec 23, 2022 at 2:37 PM Shashank Sharma wrote: > > The FW expects us to allocate atleast one page as process > context space, and one for gang context space. This patch adds some > object for the same. This should be handled in the IP specific code for the MQD creation. Each IP may have d

Re: [RFC 6/7] drm/amdgpu: Map userqueue into HW

2022-12-29 Thread Alex Deucher
On Fri, Dec 23, 2022 at 2:37 PM Shashank Sharma wrote: > > This patch add the function to map/unmap the usermode queue into the HW, > using the prepared MQD and other objects. After this mapping, the queue > will be ready to accept the workload. This should also be a callback into IP specific cod

Re: [RFC 4/7] drm/amdgpu: Allocate doorbell slot for user queue

2022-12-29 Thread Alex Deucher
On Fri, Dec 23, 2022 at 2:37 PM Shashank Sharma wrote: > > This patch allocates a doorbell slot in the bar, for the usermode queue. > We are using the unique queue-id to get this slot from MES. We should manage the doorbell BAR just like VRAM. I had a set of patches to convert doorbell memory to

Re: [RFC 3/7] drm/amdgpu: Create MQD for userspace queue

2022-12-29 Thread Alex Deucher
On Fri, Dec 23, 2022 at 2:37 PM Shashank Sharma wrote: > > From: Arvind Yadav > > MQD describes the properies of a user queue to the HW, and allows it to > accurately configure the queue while mapping it in GPU HW. This patch > adds: > - A new header file which contains the MQD definition > - A n

Re: [RFC 2/7] drm/amdgpu: Add usermode queue for gfx work

2022-12-29 Thread Alex Deucher
On Fri, Dec 23, 2022 at 2:37 PM Shashank Sharma wrote: > > This patch adds skeleton code for usermode queue creation. It > typically contains: > - A new structure to keep all the user queue data in one place. > - An IOCTL function to create/free a usermode queue. > - A function to generate unique

Re: [PATCH v2 11/11] drm/amd: Request PSP microcode during IP discovery

2022-12-29 Thread Alex Deucher
On Wed, Dec 28, 2022 at 11:32 AM Mario Limonciello wrote: > > If PSP microcode is required but not available during early init, the > firmware framebuffer will have already been released and the screen will > freeze. > > Move the request for PSP microcode into the IP discovery phase > so that if i

Re: [PATCH v2 00/11] Recover from failure to probe GPU

2022-12-29 Thread Alex Deucher
Patches 1-10 are: Reviewed-by: Alex Deucher On Wed, Dec 28, 2022 at 11:31 AM Mario Limonciello wrote: > > One of the first thing that KMS drivers do during initialization is > destroy the system firmware framebuffer by means of > `drm_aperture_remove_conflicting_pci_framebuffers` > > This means

Re: [BUG] AMD Radeon Pro 5600M with 8GB of HBM2 memory shows blank screen on Linux

2022-12-29 Thread Alex Deucher
On Wed, Dec 28, 2022 at 5:47 PM Orlando Chamberlain wrote: > > On Mon, 26 Dec 2022 21:44:06 +1100 > "Aditya Garg" wrote: > > > The AMD Radeon Pro 5600M with 8GB of HBM2 memory GPU is found in > > MacBook Pro 16 inch, 2019 (MacBookPro16,4). > > > > The GPU fails to work on Linux, thus a blank blac

Re: [syzbot] WARNING: locking bug in inet_autobind

2022-12-29 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:1b929c02afd3 Linux 6.2-rc1 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=145c6a6848 kernel config: https://syzkaller.appspot.com/x/.config?x=2651619a26b4d687 dashboard link: https://

RE: [PATCH 08/18] fbdev/hyperv-fb: Do not set struct fb_info.apertures

2022-12-29 Thread Michael Kelley (LINUX)
From: Thomas Zimmermann Sent: Monday, December 19, 2022 8:05 AM > > Generic fbdev drivers use the apertures field in struct fb_info to > control ownership of the framebuffer memory and graphics device. Do > not set the values in hyperv-fb. > > Signed-off-by: Thomas Zimmermann > --- > drivers/

[PATCH] drm: amd: display: fix dc/core/dc.c kernel-doc

2022-12-29 Thread Randy Dunlap
Fix all kernel-doc warnings in dc/core/dc.c: dc.c:385: warning: missing initial short description on line: * dc_stream_adjust_vmin_vmax: dc.c:392: warning: contents before sections dc.c:399: warning: No description found for return value of 'dc_stream_adjust_vmin_vmax' dc.c:434: warning: Excess

Re: [PATCH v2 01/11] drm/amd: Delay removal of the firmware framebuffer

2022-12-29 Thread Javier Martinez Canillas
Hello Mario, On 12/28/22 17:30, Mario Limonciello wrote: > Removing the firmware framebuffer from the driver means that even > if the driver doesn't support the IP blocks in a GPU it will no > longer be functional after the driver fails to initialize. > > This change will ensure that unsupported