RE: [PATCH] drm/amdgpu: adjust the sequence to check soft reset

2022-12-20 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Gao, Likun Sent: Wednesday, December 21, 2022 14:37 To: amd-gfx list Subject: [PATCH] drm/amdgpu: adjust the sequence to check soft reset [AMD Official Use Only - General] From: Likun Gao 1.Dro

[PATCH] drm/amdgpu: adjust the sequence to check soft reset

2022-12-20 Thread Gao, Likun
[AMD Official Use Only - General] From: Likun Gao 1.Drop soft reset check when do should recover gpu check. (As it will skip gpu reset operation if some ip is hang but not support soft reset) 2.Check soft reset status before do soft reset when pre asic reset. a. If check soft reset return

Re: [PATCH 1/1] drm/amdkfd: Cleanup vm process info if init vm failed

2022-12-20 Thread Felix Kuehling
On 2022-12-20 15:36, Philip Yang wrote: If acquire_vm failed when initializing KFD vm, set vm->process_info to NULL and free process info, otherwise, the future acquire_vm will always fail as vm->process_info is not NULL. Pass avm as parameter to remove the duplicate code. Signed-off-by: Philip

[RFC PATCH 3/3] drm/amdkfd: Use per-process notifier_lock for SVM

2022-12-20 Thread Felix Kuehling
Use the process_info->notifier lock for validating and mapping SVM ranges. Take advantage of the locking done inside amdgpu_vm_ptes_update to fix a lock dependency issue with page table allocations. TODO: double check that prange->lock it not still needed somewhere inside the notifier lock because

[RFC PATCH 2/3] drm/amdgpu: Add range param to amdgpu_vm_update_range

2022-12-20 Thread Felix Kuehling
This allows page table updates to be coordinated with interval notifiers to avoid writing stale page table entries to the pabe table. Moving the critical section inside the page table update avoids lock dependencies with page table allocations under the notifier lock. Suggested-by: Christian König

[RFC PATCH 1/3] drm/amdgpu: Add vm->notifier_lock

2022-12-20 Thread Felix Kuehling
This points to a mutex to serialize with MMU notifiers during page table updates. For graphics contexts, the notifier lock is per adev. For compute contexts the lock is per process. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 +++ drivers/gpu/drm/amd/am

Re: [PATCH] drm/amdkfd: Fix kernel warning during topology setup

2022-12-20 Thread Felix Kuehling
On 2022-12-20 17:50, Mukul Joshi wrote: This patch fixes the following kernel warning seen during driver load by correctly initializing the p2plink attr before creating the sysfs file: [ +0.002865] [ cut here ] [ +0.002327] kobject: '(null)' (56260cfb): is not i

[PATCH] drm/amdkfd: Fix kernel warning during topology setup

2022-12-20 Thread Mukul Joshi
This patch fixes the following kernel warning seen during driver load by correctly initializing the p2plink attr before creating the sysfs file: [ +0.002865] [ cut here ] [ +0.002327] kobject: '(null)' (56260cfb): is not initialized, yet kobject_put() is being ca

[PATCH 1/1] drm/amdkfd: Cleanup vm process info if init vm failed

2022-12-20 Thread Philip Yang
If acquire_vm failed when initializing KFD vm, set vm->process_info to NULL and free process info, otherwise, the future acquire_vm will always fail as vm->process_info is not NULL. Pass avm as parameter to remove the duplicate code. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amd

[PATCH] drm/amdgpu: enable VCN DPG for GC IP v11.0.4

2022-12-20 Thread Saleemkhan Jamadar
Enable VCN Dynamic Power Gating control for GC IP v11.0.4. Signed-off-by: Saleemkhan Jamadar Reviewed-by: Veerabadhran Gopalakrishnan --- drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21

Re: [PATCH 18/18] drm/fbdev: Remove aperture handling and FBINFO_MISC_FIRMWARE

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > There are no users left of struct fb_info.apertures and the flag > FBINFO_MISC_FIRMWARE. Remove both and the aperture-ownership code > in the fbdev core. All code for aperture ownership is now located > in the fbdev drivers. > > Signed-off-by: Thomas Z

Re: [PATCH 17/18] fbdev/vga16fb: Do not use struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Acquire ownership of the firmware scanout buffer by calling Linux' > aperture helpers. Remove the use of struct fb_info.apertures and do > not set FBINFO_MISC_FIRMWARE; both of which previously configured > buffer ownership. > > Signed-off-by: Thomas Z

Re: [PATCH 16/18] fbdev/vesafb: Do not use struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Acquire ownership of the firmware scanout buffer by calling Linux' > aperture helpers. Remove the use of struct fb_info.apertures and do > not set FBINFO_MISC_FIRMWARE; both of which previously configured > buffer ownership. > > Signed-off-by: Thomas Z

Re: [PATCH 15/18] fbdev/vesafb: Remove trailing whitespaces

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Fix coding style. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 14/18] fbdev/simplefb: Do not use struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Acquire ownership of the firmware scanout buffer by calling Linux' > aperture helpers. Remove the use of struct fb_info.apertures and do > not set FBINFO_MISC_FIRMWARE; both of which previously configured > buffer ownership. > > Signed-off-by: Thomas Z

Re: [PATCH 13/18] fbdev/offb: Do not use struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Acquire ownership of the firmware scanout buffer by calling Linux' > aperture helpers. Remove the use of struct fb_info.apertures and do > not set FBINFO_MISC_FIRMWARE; both of which previously configured > buffer ownership. > > Signed-off-by: Thomas Z

Re: [PATCH 12/18] fbdev/offb: Allocate struct offb_par with framebuffer_alloc()

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Move the palette array into struct offb_par and allocate both via > framebuffer_alloc(), as intended by fbdev. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martine

Re: [PATCH 11/18] fbdev/efifb: Do not use struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Acquire ownership of the firmware scanout buffer by calling Linux' > aperture helpers. Remove the use of struct fb_info.apertures and do > not set FBINFO_MISC_FIRMWARE; both of which previously configured > buffer ownership. > > Signed-off-by: Thomas Z

Re: [PATCH 10/18] fbdev/efifb: Add struct efifb_par for driver data

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > The efifb_par structure holds the palette for efifb. It will also > be useful for storing the device's aperture range. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core

Re: [PATCH 09/18] vfio-mdev/mdpy-fb: Do not set struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
[adding Kirti Wankhede and k...@vger.kernel.org to Cc list] On 12/19/22 17:05, Thomas Zimmermann wrote: > Generic fbdev drivers use the apertures field in struct fb_info to > control ownership of the framebuffer memory and graphics device. Do > not set the values in mdpy-fb. > > Signed-off-by: Th

Re: [PATCH 08/18] fbdev/hyperv-fb: Do not set struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Generic fbdev drivers use the apertures field in struct fb_info to > control ownership of the framebuffer memory and graphics device. Do > not set the values in hyperv-fb. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canill

Re: [PATCH 07/18] fbdev/clps711x-fb: Do not set struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Generic fbdev drivers use the apertures field in struct fb_info to > control ownership of the framebuffer memory and graphics device. Do > not set the values in clps711x-fb. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Cani

Re: [PATCH 06/18] drm/fb-helper: Do not allocate unused apertures structure

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > The apertures field in struct fb_info is not used by DRM drivers. Do > not allocate it. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 05/18] drm/radeon: Do not set struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Generic fbdev drivers use the apertures field in struct fb_info to > control ownership of the framebuffer memory and graphics device. Do > not set the values in radeon. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas

Re: [PATCH 04/18] drm/i915: Do not set struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Generic fbdev drivers use the apertures field in struct fb_info to > control ownership of the framebuffer memory and graphics device. Do > not set the values in i915. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas

Re: [PATCH 03/18] drm/gma500: Do not set struct fb_info.apertures

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > Generic fbdev drivers use the apertures field in struct fb_info to > control ownership of the framebuffer memory and graphics device. Do > not set the values in gma500. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas

Re: [PATCH 02/18] Revert "fbcon: don't lose the console font across generic->chip driver switch"

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:05, Thomas Zimmermann wrote: > This reverts commit ae1287865f5361fa138d4d3b1b6277908b54eac9. > > Always free the console font when deinitializing the framebuffer > console. Subsequent framebuffer consoles will then use the default > font. Rely on userspace to load any user-configure

Re: [PATCH 01/18] fbcon: Remove trailing whitespaces

2022-12-20 Thread Javier Martinez Canillas
On 12/19/22 17:04, Thomas Zimmermann wrote: > Fix coding style. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat