Re: [PATCH 1/7] drm/amdgpu/gmc9: don't touch gfxhub registers during S0ix

2022-12-14 Thread Christian König
Am 14.12.22 um 23:16 schrieb Alex Deucher: gfxhub registers are part of gfx IP and should not need to be changed. Doing so without disabling gfxoff can hang the gfx IP. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 26 -- 1 file changed, 20

[PATCH 1/2] drm/amd/pm: add support for WINDOW3D profile mode on SMU13.0.0

2022-12-14 Thread Evan Quan
Add the support for WINDOW3D profile mode as for other profile modes. Signed-off-by: Evan Quan Change-Id: If05d1c7cbe5b6bc9f9c3c5036c01f6580d534164 --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/am

[PATCH 2/2] drm/amd/pm: bump SMU13.0.0 driver_if header to version 0x34

2022-12-14 Thread Evan Quan
To fit the latest PMFW and suppress the warning emerged on driver loading. Signed-off-by: Evan Quan Change-Id: Ia81ffdc8969a3b667454aa35c6d05d9de238ebcd --- .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 2 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h| 1

[RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-14 Thread Ma Jun
Add the missing declaration of struct drm_atomic_state to fix the compile error below: error: 'struct drm_atomic_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] Signed-off-by: Ma Jun --- include/drm/drm_plane_helper.h | 1 + 1 file c

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-14 Thread Robin Murphy
On 2022-12-14 22:02, Alex Deucher wrote: On Wed, Dec 14, 2022 at 4:54 PM Robin Murphy wrote: On 2022-12-12 02:08, Luben Tuikov wrote: Fix screen corruption on older 32-bit systems using AGP chips. On older systems with little memory, for instance 1.5 GiB, using an AGP chip, the device's DMA

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Alex Hung
On 2022-12-14 16:06, Alex Deucher wrote: On Wed, Dec 14, 2022 at 5:56 PM Alex Hung wrote: On 2022-12-14 15:35, Alex Deucher wrote: On Wed, Dec 14, 2022 at 5:25 PM Alex Hung wrote: On 2022-12-14 14:54, Alex Deucher wrote: On Wed, Dec 14, 2022 at 4:50 PM Alex Hung wrote: On 2022

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Alex Deucher
On Wed, Dec 14, 2022 at 5:56 PM Alex Hung wrote: > > > > On 2022-12-14 15:35, Alex Deucher wrote: > > On Wed, Dec 14, 2022 at 5:25 PM Alex Hung wrote: > >> > >> > >> > >> On 2022-12-14 14:54, Alex Deucher wrote: > >>> On Wed, Dec 14, 2022 at 4:50 PM Alex Hung wrote: > > > > O

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Alex Hung
On 2022-12-14 15:35, Alex Deucher wrote: On Wed, Dec 14, 2022 at 5:25 PM Alex Hung wrote: On 2022-12-14 14:54, Alex Deucher wrote: On Wed, Dec 14, 2022 at 4:50 PM Alex Hung wrote: On 2022-12-14 13:48, Alex Deucher wrote: On Wed, Dec 14, 2022 at 3:22 PM Aurabindo Pillai wrote: Fr

Re: [PATCH 2/2] drm/amdkfd: Fix double release compute pasid

2022-12-14 Thread Felix Kuehling
On 2022-12-14 10:42, Philip Yang wrote: If kfd_process_device_init_vm returns failure after vm is converted to compute vm and vm->pasid set to compute pasid, KFD will not take pdd->drm_file reference. As a result, drm close file handler maybe called to release the compute pasid before KFD process

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Alex Deucher
On Wed, Dec 14, 2022 at 5:25 PM Alex Hung wrote: > > > > On 2022-12-14 14:54, Alex Deucher wrote: > > On Wed, Dec 14, 2022 at 4:50 PM Alex Hung wrote: > >> > >> > >> > >> On 2022-12-14 13:48, Alex Deucher wrote: > >>> On Wed, Dec 14, 2022 at 3:22 PM Aurabindo Pillai > >>> wrote: > > Fr

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Alex Hung
On 2022-12-14 14:54, Alex Deucher wrote: On Wed, Dec 14, 2022 at 4:50 PM Alex Hung wrote: On 2022-12-14 13:48, Alex Deucher wrote: On Wed, Dec 14, 2022 at 3:22 PM Aurabindo Pillai wrote: From: Alex Hung [Why] When running IGT kms_bw test with DP monitor, some systems crash from msle

[PATCH 7/7] Revert "drm/amdgpu: force exit gfxoff on sdma resume for rmb s0ix"

2022-12-14 Thread Alex Deucher
This reverts commit e5d59cfa330523e47cba62a496864acc3948fc27. This is no longer needed since we no longer suspend SDMA during S0ix. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v

[PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-14 Thread Alex Deucher
SDMA 5.x is part of the GFX block so it's controlled via GFXOFF. Skip suspend as it should be handled the same as GFX. v2: drop SDMA 4.x. That requires special handling. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ 1 file changed, 6 insertions(+) dif

[PATCH 6/7] Revert "drm/amdgpu: disallow gfxoff until GC IP blocks complete s2idle resume"

2022-12-14 Thread Alex Deucher
This reverts commit f543d28687480fad06b708bc6e0b0b6ec953b078. This is no longer needed since we no longer touch SDMA 5.x for s0i3. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH 1/7] drm/amdgpu/gmc9: don't touch gfxhub registers during S0ix

2022-12-14 Thread Alex Deucher
gfxhub registers are part of gfx IP and should not need to be changed. Doing so without disabling gfxoff can hang the gfx IP. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/dri

[PATCH 3/7] drm/amdgpu/gmc11: don't touch gfxhub registers during S0ix

2022-12-14 Thread Alex Deucher
gfxhub registers are part of gfx IP and should not need to be changed. Doing so without disabling gfxoff can hang the gfx IP. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdg

[PATCH 2/7] drm/amdgpu/gmc10: don't touch gfxhub registers during S0ix

2022-12-14 Thread Alex Deucher
gfxhub registers are part of gfx IP and should not need to be changed. Doing so without disabling gfxoff can hang the gfx IP. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/dr

[PATCH 4/7] drm/amdgpu: don't mess with SDMA clock or powergating in S0ix

2022-12-14 Thread Alex Deucher
It's handled by GFXOFF for SDMA 5.x and SMU saves the state on SDMA 4.x. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amd

[PATCH 0/7] Improvde S0ix stability

2022-12-14 Thread Alex Deucher
This series improves S0ix stability by avoiding touching registers that should be handled as part of gfxoff. Alex Deucher (7): drm/amdgpu/gmc9: don't touch gfxhub registers during S0ix drm/amdgpu/gmc10: don't touch gfxhub registers during S0ix drm/amdgpu/gmc11: don't touch gfxhub registers d

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-14 Thread Alex Deucher
On Wed, Dec 14, 2022 at 4:54 PM Robin Murphy wrote: > > On 2022-12-12 02:08, Luben Tuikov wrote: > > Fix screen corruption on older 32-bit systems using AGP chips. > > > > On older systems with little memory, for instance 1.5 GiB, using an AGP > > chip, > > the device's DMA mask is 0x, bu

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2022-12-14 Thread Robin Murphy
On 2022-12-12 02:08, Luben Tuikov wrote: Fix screen corruption on older 32-bit systems using AGP chips. On older systems with little memory, for instance 1.5 GiB, using an AGP chip, the device's DMA mask is 0x, but the memory mask is 0x7FF, and subsequently dma_addressing_limited() r

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Alex Deucher
On Wed, Dec 14, 2022 at 4:50 PM Alex Hung wrote: > > > > On 2022-12-14 13:48, Alex Deucher wrote: > > On Wed, Dec 14, 2022 at 3:22 PM Aurabindo Pillai > > wrote: > >> > >> From: Alex Hung > >> > >> [Why] > >> When running IGT kms_bw test with DP monitor, some systems crash from > >> msleep no ma

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Alex Hung
On 2022-12-14 13:48, Alex Deucher wrote: On Wed, Dec 14, 2022 at 3:22 PM Aurabindo Pillai wrote: From: Alex Hung [Why] When running IGT kms_bw test with DP monitor, some systems crash from msleep no matter how long or short the time is. [How] To replace msleep with mdelay. Can you prov

Re: [PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Alex Deucher
On Wed, Dec 14, 2022 at 3:22 PM Aurabindo Pillai wrote: > > From: Alex Hung > > [Why] > When running IGT kms_bw test with DP monitor, some systems crash from > msleep no matter how long or short the time is. > > [How] > To replace msleep with mdelay. Can you provide a bit more info about the cra

[PATCH 16/18] drm/amd/display: Adding braces to prepare for future changes to behavior of if block

2022-12-14 Thread Aurabindo Pillai
From: Leo Chen [Why & How] For certain features, there will be more implementations needed in the if-block. Braces are added as part of the preparation. Acked-by: Aurabindo Pillai Signed-off-by: Leo Chen Reviewed-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/core/dc.c | 3 ++- 1 file c

[PATCH 17/18] drm/amd/display: Reorder dc_state fields to optimize clearing the struct

2022-12-14 Thread Aurabindo Pillai
From: Aric Cyr [why & how] By moving bw_ctx field to the end of the dc_state the state can be cleared more efficiently without resulting in large DML memcpy operations, resulting in better mode enumeration performance on some platforms. Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr Review

[PATCH 06/18] drm/amd/display: Refactor ABM code flow

2022-12-14 Thread Aurabindo Pillai
From: Leon Huang [Why&How] Recent ABM flow is highly coupled with backlight control on LCD, refactor ABM control flow to be extensible to support different panel types(e.g. LCD/OLED/miniLED) Acked-by: Aurabindo Pillai Signed-off-by: Leon Huang Reviewed-by: Chun-Liang Chang --- drivers/gpu/dr

[PATCH 18/18] drm/amd/display: 3.2.217

2022-12-14 Thread Aurabindo Pillai
From: Aric Cyr Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 2896157b37da..0f7b7ccfcb40 100644 --- a

[PATCH 14/18] drm/amd/display: Fix crash when setting ABM pipe/backlight

2022-12-14 Thread Aurabindo Pillai
From: Leon Huang [Why] Setting ABM pipe/backlight crashes the system when abm callback func pointers are NULL For some usecase, driver would like to control PWM level before ABM resource is ready. But recent flow refactor of ABM didn't consider that use case. [How] Rollback flow that sending inb

[PATCH 13/18] drm/amd/display: allow hpo and dio encoder switching during dp retrain test

2022-12-14 Thread Aurabindo Pillai
From: Wenjing Liu [why] During DP2.1 LL CTS if test equipment requests to change between DP2.1 and DP1.4 link rates, we need to swap between HPO and DIO encoders by remapping encoder resource. [how] Add a function dc resource to update encoder resources and toggle dpms state for all enabled stre

[PATCH 10/18] drm/amd/display: fix dc_get_edp_link_panel_inst to only consider links with panels

2022-12-14 Thread Aurabindo Pillai
From: Dmytro Laktyushkin This function is meant to be used on multi-edp systems and only makes sense if only links with connected panels are considered. Acked-by: Aurabindo Pillai Signed-off-by: Dmytro Laktyushkin --- drivers/gpu/drm/amd/display/dc/dc_link.h | 15 +-- 1 file chang

[PATCH 15/18] drm/amd/display: set ignore msa parameter only if freesync is enabled

2022-12-14 Thread Aurabindo Pillai
[Why&How] ignore_msa_timing_param is used by SubVP logic to determine if SubVP + DRR is possible. Linux does not support freesync on multi display config, which results in incorrect assumption of VRR support if we set this parameter when VRR is supported, but not enabled. Signed-off-by: Aurabindo

[PATCH 12/18] drm/amd/display: update pixel rate div in enable stream

2022-12-14 Thread Aurabindo Pillai
From: Wenjing Liu [why] Pixel rate div depends on the type of encoder that we are enabling stream with. If we swap between HPO and DIO encoder at the time we call enable stream for the new encoder, we must reprogram pixel rate div based on the new encoder type. Acked-by: Aurabindo Pillai Signed

[PATCH 09/18] drm/amd/display: Defer DIG FIFO disable after VID stream enable

2022-12-14 Thread Aurabindo Pillai
From: Nicholas Kazlauskas [Why] On some monitors we see a brief flash of corruption during the monitor disable sequence caused by FIFO being disabled in the middle of an active DP stream. [How] Wait until DP vid stream is disabled before turning off the FIFO. The FIFO reset on DP unblank should

[PATCH 11/18] drm/amd/display: move dccg programming from link hwss hpo dp to hwss

2022-12-14 Thread Aurabindo Pillai
From: Wenjing Liu [why] dccg clock programming shouldn't be part of link hwss programming sequence. The scope of link hwss is limited to encoder and phy programming. Acked-by: Aurabindo Pillai Signed-off-by: Wenjing Liu Reviewed-by: Jun Lei --- .../display/dc/dce110/dce110_hw_sequencer.c |

[PATCH 07/18] drm/amd/display: Turn on phantom OTG before disabling phantom pipe

2022-12-14 Thread Aurabindo Pillai
From: "Lee, Alvin" [Description] - Proper phantom pipe disable sequence was missing in commit_planes_for_stream - If disabling phantom pipe, turn on phantom OTG first, and turn off the phantom OTG after the plane is disabled - Also update sequence for enabling / disabling phantom streams (a

[PATCH 05/18] drm/amd/display: Use mdelay to avoid crashes

2022-12-14 Thread Aurabindo Pillai
From: Alex Hung [Why] When running IGT kms_bw test with DP monitor, some systems crash from msleep no matter how long or short the time is. [How] To replace msleep with mdelay. Acked-by: Aurabindo Pillai Signed-off-by: Alex Hung Reviewed-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/

[PATCH 04/18] drm/amd/display: Improvements in secure display

2022-12-14 Thread Aurabindo Pillai
From: Alan Liu [Why] - Need error message when failing to allocating secure_display_ctx. - Need to check if secure display context in psp is initialized or not before using it. [How] - Add error message when memory allocation fail. - Add check before accessing psp secure display context. Acked-

[PATCH 08/18] drm/amd/display: patch cases with unknown plane state to prevent warning

2022-12-14 Thread Aurabindo Pillai
From: Swapnil Patel [Why] DCN301 resource function is missing function pointer to handle cases with unknown plane state. This causes assertion when global state is validated while using swizzle parameter as “DC_UNKNOWN” [How] Add function pointer to handle and patch cases when plane state is unk

[PATCH 03/18] drm/amd/display: Uninitialized variables causing 4k60 UCLK to stay at DPM1 and not DPM0

2022-12-14 Thread Aurabindo Pillai
From: Samson Tam [Why] SwathSizePerSurfaceY[] and SwathSizePerSurfaceC[] values are uninitialized because we are using += instead of = operator. [How] Assign values in loop with = operator. Acked-by: Aurabindo Pillai Signed-off-by: Samson Tam Reviewed-by: Aric Cyr --- .../drm/amd/display/d

[PATCH 02/18] drm/amd/display: phase3 mst hdcp for multiple displays

2022-12-14 Thread Aurabindo Pillai
From: hersen wu [Why] multiple display hdcp are enabled within event_property_validate, event_property_update by looping all displays on mst hub. when one of display on mst hub in unplugged or disabled, hdcp are disabled for all displays on mst hub within hdcp_reset_display by looping all display

[PATCH 01/18] drm/amd/display: save restore hdcp state when display is unplugged from mst hub

2022-12-14 Thread Aurabindo Pillai
From: hersen wu [Why] connector hdcp properties are lost after display is unplgged from mst hub. connector is destroyed with dm_dp_mst_connector_destroy. when display is plugged back, hdcp is not desired and it wouldnt be enabled. [How] save hdcp properties into hdcp_work within amdgpu_dm_atomic

[PATCH 00/18] DC Patches for Dec 19, 2022

2022-12-14 Thread Aurabindo Pillai
This DC patchset brings improvements in multiple areas. In summary, we have: * Fixes for various features like SubVP, ABM, HDCP, Secure display * Fix a stability issue when running IGT test suite * Improvements for eDP panels - Alan Liu (1): drm/amd/display: Improvements in secure display

Re: [PATCH 06/16] drm/connector: Allow drivers to pass list of supported colorspaces

2022-12-14 Thread Alex Deucher
On Wed, Dec 14, 2022 at 3:56 AM Pekka Paalanen wrote: > > On Tue, 13 Dec 2022 11:32:01 -0500 > Harry Wentland wrote: > > > On 12/13/22 05:23, Pekka Paalanen wrote: > > > On Mon, 12 Dec 2022 13:21:27 -0500 > > > Harry Wentland wrote: > > > > > >> Drivers might not support all colorspaces defined

Re: [PATCH 06/16] drm/connector: Allow drivers to pass list of supported colorspaces

2022-12-14 Thread Harry Wentland
On 12/14/22 03:55, Pekka Paalanen wrote: > On Tue, 13 Dec 2022 11:32:01 -0500 > Harry Wentland wrote: > >> On 12/13/22 05:23, Pekka Paalanen wrote: >>> On Mon, 12 Dec 2022 13:21:27 -0500 >>> Harry Wentland wrote: >>> Drivers might not support all colorspaces defined in dp_colorsp

[linux-next:master] BUILD REGRESSION 663397d1b469ff57f216d499b74a0b0183a508b8

2022-12-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 663397d1b469ff57f216d499b74a0b0183a508b8 Add linux-next specific files for 20221214 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211242120.mzzvguln-...@intel.com https

Re: [PATCH 1/1] drm/amdgpu: Fix double release KFD pasid

2022-12-14 Thread Philip Yang
On 2022-12-13 12:58, Felix Kuehling wrote: On 2022-12-13 10:57, Christian König wrote: Am 13.12.22 um 16:49 schrieb Philip Yang: If amdgpu_amdkfd_gpuvm_acquire_process_vm returns failed after vm is converted to KFD vm and vm->pasid set to KFD pasid, KFD will not take pdd->drm_file reference,

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-14 Thread Alex Deucher
On Wed, Dec 14, 2022 at 4:01 AM Pekka Paalanen wrote: > > On Tue, 13 Dec 2022 18:20:59 +0100 > Michel Dänzer wrote: > > > On 12/12/22 19:21, Harry Wentland wrote: > > > This will let us pass kms_hdr.bpc_switch. > > > > > > I don't see any good reasons why we still need to > > > limit bpc to 8 bpc

[PATCH 2/2] drm/amdkfd: Fix double release compute pasid

2022-12-14 Thread Philip Yang
If kfd_process_device_init_vm returns failure after vm is converted to compute vm and vm->pasid set to compute pasid, KFD will not take pdd->drm_file reference. As a result, drm close file handler maybe called to release the compute pasid before KFD process destroy worker to release the same pasid

[PATCH 1/2] drm/amdkfd: Fix kfd_process_device_init_vm error handling

2022-12-14 Thread Philip Yang
Should only destroy the ib_mem and let process cleanup worker to free the outstanding BOs. Reset the pointer in pdd->qpd structure, to avoid NULL pointer access in process destroy worker. BUG: kernel NULL pointer dereference, address: 0010 Call Trace: amdgpu_amdkfd_gpuvm_unmap_gtt_

Re: [PATCH] drm/amd/display: fix some coding style issues

2022-12-14 Thread Harry Wentland
On 10/26/22 07:48, Srinivasan Shanmugam wrote: > Fix the following checkpatch checks in amdgpu_dm.c > > CHECK: Prefer kernel type 'u8' over 'uint8_t' > CHECK: Prefer kernel type 'u32' over 'uint32_t' > CHECK: Prefer kernel type 'u64' over 'uint64_t' > CHECK: Prefer kernel type 's32' over 'int32

[PATCH 2/2] drm/amdgpu: Add poison mode query for df v4_3

2022-12-14 Thread Candice Li
Add poison mode query support on df v4_3. Signed-off-by: Candice Li Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 ++ drivers/gpu/drm/amd/amdgpu/df_v4_3.c | 61 +++ drivers/gpu/dr

[PATCH 1/2] drm/amdgpu: Add df v4_3 headers

2022-12-14 Thread Candice Li
Add df v4_3 header files. Signed-off-by: Candice Li Reviewed-by: Hawking Zhang --- .../amd/include/asic_reg/df/df_4_3_offset.h | 30 .../amd/include/asic_reg/df/df_4_3_sh_mask.h | 157 ++ 2 files changed, 187 insertions(+) create mode 100644 drivers/gpu/drm/amd/include

Re: [PATCH] drm/amdgpu: Remove unnecessary domain argument

2022-12-14 Thread Christian König
Am 14.12.22 um 10:05 schrieb Luben Tuikov: Remove the "domain" argument to amdgpu_bo_create_kernel_at() since this function takes an "offset" argument which is the offset off of VRAM, and as such allocation always takes place in VRAM. Thus, the "domain" argument is unnecessary. Cc: Alex Deucher

Re: [PATCH v4] drm/amdgpu: Fix size validation for non-exclusive domains (v4)

2022-12-14 Thread Christian König
Am 14.12.22 um 10:41 schrieb Luben Tuikov: Fix amdgpu_bo_validate_size() to check whether the TTM domain manager for the requested memory exists, else we get a kernel oops when dereferencing "man". v2: Make the patch standalone, i.e. not dependent on local patches. v3: Preserve old behaviour and

[PATCH v4] drm/amdgpu: Fix size validation for non-exclusive domains (v4)

2022-12-14 Thread Luben Tuikov
Fix amdgpu_bo_validate_size() to check whether the TTM domain manager for the requested memory exists, else we get a kernel oops when dereferencing "man". v2: Make the patch standalone, i.e. not dependent on local patches. v3: Preserve old behaviour and just check that the manager pointer is not

[PATCH] drm/amdgpu: Remove unnecessary domain argument

2022-12-14 Thread Luben Tuikov
Remove the "domain" argument to amdgpu_bo_create_kernel_at() since this function takes an "offset" argument which is the offset off of VRAM, and as such allocation always takes place in VRAM. Thus, the "domain" argument is unnecessary. Cc: Alex Deucher Cc: Christian König Cc: AMD Graphics Signe

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-14 Thread Pekka Paalanen
On Tue, 13 Dec 2022 18:20:59 +0100 Michel Dänzer wrote: > On 12/12/22 19:21, Harry Wentland wrote: > > This will let us pass kms_hdr.bpc_switch. > > > > I don't see any good reasons why we still need to > > limit bpc to 8 bpc and doing so is problematic when > > we enable HDR. > > > > If I reme

Re: [PATCH 04/16] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2022-12-14 Thread Pekka Paalanen
On Tue, 13 Dec 2022 11:41:08 -0500 Harry Wentland wrote: > On 12/13/22 05:39, Pekka Paalanen wrote: > > On Mon, 12 Dec 2022 13:21:25 -0500 > > Harry Wentland wrote: > > > >> This allows us to use strongly typed arguments. > >> > >> Signed-off-by: Harry Wentland > >> Cc: Pekka Paalanen > >>

Re: [PATCH 06/16] drm/connector: Allow drivers to pass list of supported colorspaces

2022-12-14 Thread Pekka Paalanen
On Tue, 13 Dec 2022 11:32:01 -0500 Harry Wentland wrote: > On 12/13/22 05:23, Pekka Paalanen wrote: > > On Mon, 12 Dec 2022 13:21:27 -0500 > > Harry Wentland wrote: > > > >> Drivers might not support all colorspaces defined in > >> dp_colorspaces and hdmi_colorspaces. This results in > >> und