Re: [PATCH] drm: amd: clean up dcn32_fpu.c kernel-doc

2022-10-03 Thread Rodrigo Siqueira Jordao
On 2022-10-01 00:33, Randy Dunlap wrote: Rectify multiple kernel-doc warnings in dcn32_fpu.c. E.g.: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:247: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Re: [PATCH v5] drm/amd/display: Fix vblank refcount in vrr transition

2022-10-03 Thread Rodrigo Siqueira Jordao
On 2022-09-21 17:20, Yunxiang Li wrote: manage_dm_interrupts disable/enable vblank using drm_crtc_vblank_off/on which causes drm_crtc_vblank_get in vrr_transition to fail, and later when drm_crtc_vblank_put is called the refcount on vblank will be messed up. Therefore move the call to after ma

[PATCH] drm/amd/amdgpu: Update debugfs SRBM/GRBM logic

2022-10-03 Thread Tom St Denis
Currently our debugfs bank selection logic only supports a single GC instance. This updates the functions amdgpu_gfx_select_se_sh() and amdgpu_gfx_select_me_pipe_q() to support a GC instance parameter and ultimately a GC instance selection via the IOCTL to debugfs. Signed-off-by: Tom St Denis --

Re: [PATCH] drm/amd/display: Enable dpia support for dcn314

2022-10-03 Thread Limonciello, Mario
On 10/3/2022 13:00, roman...@amd.com wrote: From: Roman Li [Why] DCN 3.1.4 supports DPIA. [How] - Set dpia_supported flag for dcn314 in dmub_hw_init() - Remove comment that becomes irrelevant after this change. Signed-off-by: Roman Li Reviewed-by: Nicholas Kazlauskas FYI As this is ju

[PATCH] drm/amd/display: Enable dpia support for dcn314

2022-10-03 Thread Roman.Li
From: Roman Li [Why] DCN 3.1.4 supports DPIA. [How] - Set dpia_supported flag for dcn314 in dmub_hw_init() - Remove comment that becomes irrelevant after this change. Signed-off-by: Roman Li Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 f

Re: [PATCH v2 1/8] mm/memory.c: Fix race when faulting a device private page

2022-10-03 Thread Felix Kuehling
Am 2022-10-02 um 20:53 schrieb Alistair Popple: Felix Kuehling writes: On 2022-09-28 08:01, Alistair Popple wrote: When the CPU tries to access a device private page the migrate_to_ram() callback associated with the pgmap for the page is called. However no reference is taken on the faulting p

[PATCH 1/1] drm/amdgpu: Set vmbo destroy after pt bo is created

2022-10-03 Thread Philip Yang
Under VRAM usage pression, map to GPU may fail to create pt bo and vmbo->shadow_list is not initialized, then ttm_bo_release calling amdgpu_bo_vm_destroy to access vmbo->shadow_list generates below dmesg and NULL pointer access backtrace: Set vmbo destroy callback to amdgpu_bo_vm_destroy only afte

Re: [PATCH] drm/amd/display: disable psr whenever applicable

2022-10-03 Thread S, Shirish
Ping! Regards, Shirish S On 9/30/2022 7:17 PM, S, Shirish wrote: On 9/30/2022 6:59 PM, Harry Wentland wrote: +Leo On 9/30/22 06:27, Shirish S wrote: [Why] psr feature continues to be enabled for non capable links. Do you have more info on what issues you're seeing with this? Code wise

[PATCH] drm: amd: clean up dcn32_fpu.c kernel-doc

2022-10-03 Thread Randy Dunlap
Rectify multiple kernel-doc warnings in dcn32_fpu.c. E.g.: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:247: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Finds dummy_latency_index when MCLK switching

Re: [PATCH v2 1/8] mm/memory.c: Fix race when faulting a device private page

2022-10-03 Thread Alistair Popple
Felix Kuehling writes: > On 2022-09-28 08:01, Alistair Popple wrote: >> When the CPU tries to access a device private page the migrate_to_ram() >> callback associated with the pgmap for the page is called. However no >> reference is taken on the faulting page. Therefore a concurrent >> migratio

Re: [RFC PATCH 1/1] drm/amdgpu: Fix null-ptr-deref in amdgpu_device_fini_sw()

2022-10-03 Thread Steven J Abner
I had done more delving into this also, thankfully was not forgotten. Additional info to solve blackout, was going to contact AMD: The problem as far as I could trace occurs in amdgpu_psp.c in function psp_cmd_submit_buf(). Normal counter 'timeout' seems to use a max of about 400 with usleep_ran

RE: [PATCH 1/2] drm/amdkfd: correct RB_SIZE in SDMA0_QUEUE0_RB_CNTL

2022-10-03 Thread Zhang, Yifan
[AMD Official Use Only - General] Hi Felix, Yes, I just realized ffs start counting from 1. Sorry for the noise. Best Regards, Yifan -Original Message- From: Kuehling, Felix Sent: Friday, September 30, 2022 10:55 PM To: Zhang, Yifan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexand

Re: KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-10-03 Thread Ville Syrjälä
On Mon, Oct 03, 2022 at 11:48:49AM +0300, Pekka Paalanen wrote: > On Fri, 30 Sep 2022 18:45:09 +0300 > Ville Syrjälä wrote: > > > On Fri, Sep 30, 2022 at 06:37:00PM +0300, Pekka Paalanen wrote: > > > On Fri, 30 Sep 2022 18:09:55 +0300 > > > Ville Syrjälä wrote: > > > > > > > That would active

Re: KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-10-03 Thread Pekka Paalanen
On Fri, 30 Sep 2022 18:45:09 +0300 Ville Syrjälä wrote: > On Fri, Sep 30, 2022 at 06:37:00PM +0300, Pekka Paalanen wrote: > > On Fri, 30 Sep 2022 18:09:55 +0300 > > Ville Syrjälä wrote: > > > > > That would actively discourage people from even attempting the > > > "just dump all the state int