[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
From: amd-gfx on behalf of Alex Deucher
Date: Saturday, September 10, 2022 at 05:40
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander , kernel test robot
Subject: [PATCH] drm/amdgpu: fix warning about miss
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
From: amd-gfx on behalf of Candice Li
Date: Saturday, September 10, 2022 at 06:45
To: amd-gfx@lists.freedesktop.org
Cc: Li, Candice
Subject: [PATCH] drm/amdgpu: Add EEPROM I2C address for smu v13_0_0
Set correct E
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
From: amd-gfx on behalf of Candice Li
Date: Saturday, September 10, 2022 at 06:46
To: amd-gfx@lists.freedesktop.org
Cc: Li, Candice
Subject: [PATCH] drm/amdgpu: Skip reset error status for psp v13_0_0
No need to r
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
From: amd-gfx on behalf of Candice Li
Date: Saturday, September 10, 2022 at 07:00
To: amd-gfx@lists.freedesktop.org
Cc: Li, Candice , Clements, John
Subject: [PATCH] drm/amdgpu: added support for ras driver loadin
On Wed, Sep 7, 2022 at 12:40 AM Daniel Vetter wrote:
>
> On Sun, Sep 04, 2022 at 03:41:05PM -0600, Jim Cromie wrote:
> > In order to use dynamic-debug's jump-label optimization in drm-debug,
> > its clarifying to refine drm_debug_enabled into 3 uses:
> >
> > 1. drm_debug_enabled - legacy, public
From: John Clements
copy ras driver to psp if present
Signed-off-by: John Clements
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 15 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 6 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 +
drivers/gpu/drm/amd/amdgpu/psp_v13_0.c
No need to reset error status since only umc ras supported on psp v13_0_0.
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.
Set correct EEPROM I2C address for smu v13_0_0.
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
index c428
for imu_v11_0_3_program_rlc_ram(). Include imu_v11_0_3.h
in imu_v11_0_3.c.
Reported-by: kernel test robot
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/imu_v11_0_3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/imu_v11_0_3.c
b/drivers/gpu/drm/amd/
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 9a82ccda91ed2b40619cb3c10d446ae1f97bab6e Add linux-next specific
files for 20220909
Error/Warning reports:
https://lore.kernel.org/linux-mm/202209042337.fqi69rlv-...@intel.com
https
Applied. Thanks,
Alex
On Fri, Sep 9, 2022 at 3:54 PM Jingyu Wang wrote:
>
> Remove "default n" options. If the "default" line is removed, it
> defaults to 'n'.
>
> Signed-off-by: Jingyu Wang
> ---
> drivers/gpu/drm/amd/display/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/
Already fixed a few days ago. Thanks for the patch.
Alex
On Thu, Sep 8, 2022 at 4:51 AM Jocelyn Falempe wrote:
>
> The variable i is already declared as uint32_t in the same function.
>
> This fixes the following error, when compiling this code on older kernel:
> drivers/gpu/drm/amd/amdgpu/../d
Applied. Thanks!
On Wed, Sep 7, 2022 at 12:11 AM Jilin Yuan wrote:
>
> Delete the redundant word 'in'.
>
> Signed-off-by: Jilin Yuan
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc
Applied. Thanks!
Alex
On Tue, Sep 6, 2022 at 2:48 PM Deucher, Alexander
wrote:
>
> [Public]
>
>
> Yeah, seems to be a mix. I don't have a strong opinion as long as it has MIT.
>
> Alex
>
>
> From: Kuehling, Felix
> Sent: Tuesday, September 6, 2022 9:46 AM
> To
Applied. Thanks!
On Mon, Sep 5, 2022 at 3:57 AM Jingyu Wang wrote:
>
> Fix everything checkpatch.pl complained about in amdgpu_amdkfd.c
>
> Signed-off-by: Jingyu Wang
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/a
Applied. Thanks!
Alex
On Mon, Sep 5, 2022 at 2:29 AM Jingyu Wang wrote:
>
> This is a patch to the amdgpu_sync.c file that fixes some warnings found by
> the checkpatch.pl tool
>
> Signed-off-by: Jingyu Wang
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 4 +++-
> 1 file changed, 3 inser
Applied. Thanks!
Alex
On Mon, Sep 5, 2022 at 2:29 AM Jingyu Wang wrote:
>
> Fix everything checkpatch.pl complained about in amdgpu_acpi.c
>
> Signed-off-by: Jingyu Wang
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> di
On Mon, Sep 5, 2022 at 3:04 AM Yury Zhuravlev wrote:
>
> Hello,
>
> During the setup, the fan manager https://github.com/markusressel/fan2go I
> found that my Vega56 was not working correctly. This fan manager expects what
> read PWM value should be the same as you wrote before, but it's not the
Applied. Thanks!
Alex
On Fri, Sep 2, 2022 at 4:04 AM wrote:
>
> From: zhang songyi
>
> Return the sdma_v6_0_start() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot
> Signed-off-by: zhang songyi
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 5 +-
Applied. Thanks!
Alex
On Fri, Sep 2, 2022 at 3:33 AM wrote:
>
> From: ye xingchen
>
> Return the value radeon_drm_ioctl() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot
> Signed-off-by: ye xingchen
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 5
Applied. Thanks!
On Fri, Sep 2, 2022 at 3:32 AM wrote:
>
> From: ye xingchen
>
> Return the value ci_load_smc_ucode() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot
> Signed-off-by: ye xingchen
> ---
> drivers/gpu/drm/radeon/ci_dpm.c | 6 ++
>
On Wed, Sep 7, 2022 at 12:19 PM Jason Baron wrote:
>
>
>
> On 9/4/22 17:40, Jim Cromie wrote:
> > Add module-to-class validation:
> >
> > #> echo class DRM_UT_KMS +p > /proc/dynamic_debug/control
> >
> > If a query has "class FOO", then ddebug_find_valid_class(), called
> > from ddebug_change(),
Applied. Thanks!
Alex
On Thu, Sep 1, 2022 at 4:34 AM Yang Li wrote:
>
> Conditional statements have no effect to next process.So remove it.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2028
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
> ---
> .../drm/amd/display/dc/dml/dcn
Applied. Thanks!
On Thu, Sep 1, 2022 at 4:11 AM Yang Li wrote:
>
> The result of relational operation is Boolean, and the question mark
> expression is redundant.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2027
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
> ---
> .../gpu/
Applied. Thanks!
Alex
On Thu, Sep 1, 2022 at 3:57 AM Yang Li wrote:
>
> This if statement is the content of the for statement above it. It
> should be indented.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2026
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
> ---
> drivers/g
Am 2022-09-09 um 14:25 schrieb Philip Yang:
Free page table BO from vm resv unlocked context generate below
warnings.
Add a free_work in vm_bo base of each page table BO, pass vm resv
unlock status from page table update caller, and schedule the
work if calling with vm resv unlocked.
WARNING:
On Fri, Sep 09, 2022 at 01:11:54PM +0530, Lazar, Lijo wrote:
>
>
> On 9/8/2022 11:27 PM, Bjorn Helgaas wrote:
> > On Thu, Sep 08, 2022 at 04:42:38PM +, Lazar, Lijo wrote:
> > > I am not sure if ASPM settings can be generalized by PCIE core.
> > > Performance vs Power savings when ASPM is enab
On Wed, Sep 7, 2022 at 12:13 AM Daniel Vetter wrote:
>
> On Sun, Sep 04, 2022 at 03:41:00PM -0600, Jim Cromie wrote:
> > Use DECLARE_DYNDBG_CLASSMAP across DRM:
> >
> > - in .c files, since macro defines/initializes a record
> >
> > - in drivers, $mod_{drv,drm,param}.c
> >ie where param setu
Free page table BO from vm resv unlocked context generate below
warnings.
Add a free_work in vm_bo base of each page table BO, pass vm resv
unlock status from page table update caller, and schedule the
work if calling with vm resv unlocked.
WARNING: CPU: 12 PID: 3238 at
drivers/gpu/drm/ttm/ttm_
On 9/2/22 19:26, Ruhl, Michael J wrote:
>> 02.09.2022 13:31, Dmitry Osipenko пишет:
>>> 01.09.2022 17:02, Ruhl, Michael J пишет:
>>> ...
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -331,7 +331,19 @@ static void __i915_gem_fr
On Fri, Sep 9, 2022 at 1:17 PM Lazar, Lijo wrote:
>
>
>
> On 9/9/2022 10:17 PM, Alex Deucher wrote:
> > This is where it is used, so move it into gmc init so
>
> It's only the *side effect* of GMC IP init process, but that doesn't
> mean these IPs are interlinked. Any IP init process which require
On 9/9/2022 10:17 PM, Alex Deucher wrote:
This is where it is used, so move it into gmc init so
It's only the *side effect* of GMC IP init process, but that doesn't
mean these IPs are interlinked. Any IP init process which requires HDP
flush also would need this. It is not a good idea to c
[AMD Official Use Only - General]
Looks good to me .
-Original Message-
From: Chander, Vignesh
Sent: Friday, September 9, 2022 12:52 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Shaoyun ; Chander, Vignesh
Subject: [PATCH] drm/amdgpu: Fix hive reference count leak
both get_xgmi_hive a
On 2022-09-08 21:50, jiadong@amd.com wrote:
From: "Jiadong.Zhu"
Trigger MCBP according to the priroty of the
software rings and the hw fence signaling
condition.
The muxer records some lastest locations from the
software ring which is used to resubmit packages
in preemption scenarios.
v
both get_xgmi_hive and put_xgmi_hive can be skipped since the
reset domain is not necessary for VF
Signed-off-by: Vignesh Chander
Reviewed-by: Shaoyun Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/a
Really can't say to much here as I am not really familiar with queues
map/unmap...
Andrey
On 2022-09-08 21:50, jiadong@amd.com wrote:
From: "Jiadong.Zhu"
1. Modify the unmap_queue package on gfx9.
Add trailing fence to track the preemption done.
2. Modify emit_ce_meta emit_de_meta fu
This is where it is used, so move it into gmc init so
that it will always be initialized in the right order.
We already do this for other nbio and hdp callbacks so
it's consistent with what we do on other IPs.
This fixes the Unsupported Request error reported through
AER during driver load. The er
This is not strictly necessary at this point since
we moved the HDP remap into GMC HW init, but at this
point it doesn't seem to cause any problems and it may
be beneficial to initialize the the common stuff before
GMC.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |
This mirrors what we do for other asics and this way we are
sure the ih doorbell range is properly initialized.
There is a comment about the way doorbells on gfx9 work that
requires that they are initialized for other IPs before GFX
is initialized. In this case IH is initialized before GFX,
so th
This mirrors what we do for other asics and this way we are
sure the sdma doorbell range is properly initialized.
There is a comment about the way doorbells on gfx9 work that
requires that they are initialized for other IPs before GFX
is initialized. However, the statement says that it applies to
Was missing before and would have resulted in a write to
a non-existant register. Normally APUs don't use HDP, but
other asics could use this code and APUs do use the HDP
when used in passthrough.
Reviewed-by: Lijo Lazar
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c | 9
This is where it is used, so move it into gmc init so
that it will always be initialized in the right order.
We already do this for other nbio and hdp callbacks so
it's consistent with what we do on other IPs.
This fixes the Unsupported Request error reported through
AER during driver load. The er
The first 3 patches fix the actual PCI AER issue by moving
the nbio HDP remap callback to the GMC code where it is used.
Lijo prefered calling the common hw init early, but that
ran into additional problems on vega systems because it
depends on doorbell apertures having been set up for IH
and SDMA
This is where it is used, so move it into gmc init so
that it will always be initialized in the right order.
We already do this for other nbio and hdp callbacks so
it's consistent with what we do on other IPs.
This fixes the Unsupported Request error reported through
AER during driver load. The er
Acked-by: Andrey Grodzovsky
Andrey
On 2022-09-08 21:50, jiadong@amd.com wrote:
From: "Jiadong.Zhu"
Set ring functions with software ring callbacks
on gfx9.
The software ring could be tested by debugfs_test_ib
case.
v2: set sw_ring 2 to enable software ring by default.
v3: remove the pa
On 2022-09-08 21:50, jiadong@amd.com wrote:
From: "Jiadong.Zhu"
The software ring is created to support priority
context while there is only one hardware queue
for gfx.
Every software rings has its fence driver and could
be used as an ordinary ring for the gpu_scheduler.
Multiple softwar
Am 2022-09-09 um 11:42 schrieb Philip Yang:
On 2022-09-09 11:13, Felix Kuehling wrote:
Am 2022-09-09 um 09:12 schrieb Philip Yang:
migrate_vma_setup shows below warning because we don't hold another
process mm mmap_lock. We should use current vmf->vma->vm_mm instead,
the
caller already hold
On 2022-09-09 11:13, Felix Kuehling wrote:
Am 2022-09-09 um 09:12 schrieb Philip Yang:
migrate_vma_setup shows below warning because we don't hold another
process mm mmap_lock. We should use current vmf->vma->vm_mm instead, the
caller already hold current mmap lock inside CPU page fault handle
Am 2022-09-09 um 09:12 schrieb Philip Yang:
migrate_vma_setup shows below warning because we don't hold another
process mm mmap_lock. We should use current vmf->vma->vm_mm instead, the
caller already hold current mmap lock inside CPU page fault handler.
WARNING: CPU: 10 PID: 3054 at include/li
[AMD Official Use Only - General]
Series is
Reviewed-by: Hawking Zhang
Regards,
Hawking
From: Chai, Thomas
Date: Thursday, September 8, 2022 at 16:43
To: amd-gfx@lists.freedesktop.org
Cc: Chai, Thomas , Zhang, Hawking ,
Zhou1, Tao , Wang, Yang(Kevin) ,
Chai, Thomas
Subject: [PATCH V3 3/3]
Andrey and Luben please take a look at this set here and help with
reviewing it.
Thanks,
Christian.
Am 09.09.22 um 03:50 schrieb jiadong@amd.com:
From: "Jiadong.Zhu"
The software ring is created to support priority
context while there is only one hardware queue
for gfx.
Every software r
migrate_vma_setup shows below warning because we don't hold another
process mm mmap_lock. We should use current vmf->vma->vm_mm instead, the
caller already hold current mmap lock inside CPU page fault handler.
WARNING: CPU: 10 PID: 3054 at include/linux/mmap_lock.h:155 find_vma
Call Trace:
wal
1MiB still sounds like quite a lot. Is that really the hardware requirement?
On the other hand feel free to add my acked-by since it is certainly an
improvement.
Christian.
Am 09.09.22 um 05:51 schrieb Zhang, Hawking:
[AMD Official Use Only - General]
Thanks Kevin!
Reviewed-by: Hawking Z
Hi James,
please use to_amdgpu_ring(entity->rq->sched) for this.
That's the scheduler which was actually picked for this entity.
Regards,
Christian.
Am 08.09.22 um 15:19 schrieb James Zhu:
Hi Christian
I need use entity->sched_list to track ring (ring =
container_of(sched, struct amdgpu_rin
On 9/8/2022 11:27 PM, Bjorn Helgaas wrote:
On Thu, Sep 08, 2022 at 04:42:38PM +, Lazar, Lijo wrote:
I am not sure if ASPM settings can be generalized by PCIE core.
Performance vs Power savings when ASPM is enabled will require some
additional tuning and that will be device specific.
Can
55 matches
Mail list logo
