Re: [PATCH v3 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-16 Thread Christian König
Hi Philip, Am 16.06.22 um 00:41 schrieb philip yang: [SNIP] +    ret = amdgpu_bo_pin(bo, AMDGPU_GEM_DOMAIN_GTT); +    if (ret) { +    pr_err("Failed to pin bo. ret %d\n", ret); +    goto err_pin_bo_failed; +    } Oh! Is that something we do for every MQD? When yes that here is pretty

Re: [RFC 0/3] drm/amd/display: Introduce KUnit to Display Mode Library

2022-06-16 Thread Maíra Canal
Hi David, Thank you for your feedback! On 6/16/22 11:39, David Gow wrote: > On Wed, Jun 8, 2022 at 9:08 AM Maíra Canal wrote: >> >> As kunit_test_suites() defines itself as an init_module(), it conflicts with >> the existing one at amdgpu_drv. So, if we use kunit_test_suites(), we won't >> be a

Re: [PATCH 2/3] Documentation/gpu: Add an explanation about the DCN pipeline

2022-06-16 Thread Rodrigo Siqueira Jordao
On 2022-06-15 07:12, Pekka Paalanen wrote: On Mon, 13 Jun 2022 16:01:11 -0400 Rodrigo Siqueira wrote: In the DCN code, we constantly talk about hardware pipeline, pipeline, or even just pipes, which is a concept that is not obvious to everyone. For this reason, this commit expands the DCN o

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-16 Thread Alex Deucher
On Thu, Jun 16, 2022 at 5:48 PM Yann Dirson wrote: > > > > > > On 2022-06-15 10:34, Yann Dirson wrote: > > > Nice! > > > > > >> diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv > > >> b/Documentation/gpu/amdgpu/apu-asic-info-table.csv > > > ... > > >> +Ryzen 3000 series / AMD Ryzen Em

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-16 Thread Yann Dirson
> > On 2022-06-15 10:34, Yann Dirson wrote: > > Nice! > > > >> diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv > >> b/Documentation/gpu/amdgpu/apu-asic-info-table.csv > > ... > >> +Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega > >> Gfx, > >> RAVEN/PICASSO, DCN 1.

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-16 Thread Alex Deucher
On Thu, Jun 16, 2022 at 5:31 PM Rodrigo Siqueira Jordao wrote: > > > > On 2022-06-15 10:13, Alex Deucher wrote: > > On Wed, Jun 15, 2022 at 3:47 AM Simon Ser wrote: > >> > >> On Tuesday, June 14th, 2022 at 20:30, Alex Deucher > >> wrote: > >> > >>> On Tue, Jun 14, 2022 at 2:16 PM Simon Ser cont

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-16 Thread Rodrigo Siqueira Jordao
On 2022-06-15 10:34, Yann Dirson wrote: Nice! diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv b/Documentation/gpu/amdgpu/apu-asic-info-table.csv ... +Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx, RAVEN/PICASSO, DCN 1.0, 9.1.0, VCN 1.0, 4.1.0 ... +Ryze

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-16 Thread Rodrigo Siqueira Jordao
On 2022-06-15 10:13, Alex Deucher wrote: On Wed, Jun 15, 2022 at 3:47 AM Simon Ser wrote: On Tuesday, June 14th, 2022 at 20:30, Alex Deucher wrote: On Tue, Jun 14, 2022 at 2:16 PM Simon Ser cont...@emersion.fr wrote: On Monday, June 13th, 2022 at 22:01, Rodrigo Siqueira rodrigo.sique.

[PATCH] drm/amdgpu: fix adev variable used in amdgpu_device_gpu_recover()

2022-06-16 Thread Alex Deucher
Use the correct adev variable for the drm_fb_helper in amdgpu_device_gpu_recover(). Noticed by inspection. Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up AMD own's.") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file chang

Re: [PATCH] drm/amd/display: add missing reg defs for DCN3x HUBBUB

2022-06-16 Thread Rodrigo Siqueira Jordao
On 2022-06-16 17:08, Aurabindo Pillai wrote: [Why&How] The omitted register definition caused call traces like: [3.811215] WARNING: CPU: 7 PID: 794 at drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c:120 set_reg_field_values.constprop.0+0xc7/0xe0 [amdgpu] [3.811406] Modules link

[PATCH] drm/amd/display: add missing reg defs for DCN3x HUBBUB

2022-06-16 Thread Aurabindo Pillai
[Why&How] The omitted register definition caused call traces like: [3.811215] WARNING: CPU: 7 PID: 794 at drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c:120 set_reg_field_values.constprop.0+0xc7/0xe0 [amdgpu] [3.811406] Modules linked in: amdgpu(+) drm_ttm_helper ttm iommu_v2 gpu_

[PATCH] drm/amdgpu/display: drop set but unused variable

2022-06-16 Thread Alex Deucher
Fixes: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9143:27: warning: variable 'abo' set but not used [-Wunused-but-set-variable] Fixes: 047de3f17a83 ("drm/amdgpu: switch DM to atomic fence helpers v2") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_

[linux-next:master] BUILD REGRESSION c6d7e3b385f19869ab96e9404c92ff1abc34f2c8

2022-06-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: c6d7e3b385f19869ab96e9404c92ff1abc34f2c8 Add linux-next specific files for 20220616 Error/Warning reports: https://lore.kernel.org/lkml/202206071511.fi7wldzo-...@intel.com Error/Warning

Re: [PATCH v3 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-16 Thread Alex Deucher
On Wed, Jun 15, 2022 at 6:41 PM philip yang wrote: > > > On 2022-06-15 10:06, Christian König wrote: > > Am 15.06.22 um 15:17 schrieb Sider, Graham: > > [AMD Official Use Only - General] > > -Original Message- > From: Koenig, Christian > Sent: Wednesday, June 15, 2022 3:29 AM > To: Sider,

RE: [PATCH] drm/amd: Don't show warning on reading vbios values for SMU13 3.1

2022-06-16 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Quan, Evan > Sent: Wednesday, June 15, 2022 22:37 > To: Alex Deucher ; Limonciello, Mario > ; Feng, Kenneth > Cc: amd-gfx list > Subject: RE: [PATCH] drm/amd: Don't show warning on reading vbios values > for SMU13 3.1 > >

RE: [PATCH] drm/amd: Revert "drm/amd/display: keep eDP Vdd on when eDP stream is already enabled"

2022-06-16 Thread Limonciello, Mario
[Public] + people associated with original patch being reverted for comments > -Original Message- > From: Limonciello, Mario > Sent: Wednesday, June 15, 2022 17:30 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Aaron Ma > > Subject: [PATCH] drm/amd: Revert "drm/amd/displ

Re: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active

2022-06-16 Thread Eric Huang
Does it break the case of q->gws with q->properties.is_active == true? Regards, Eric On 2022-06-15 17:56, Philip Yang wrote: We remove the user queue from MES scheduler to update queue properties. If the queue becomes active after updating, add the user queue to MES scheduler, to be able to han

RE: [PATCH Review 1/1] drm/amdgpu/pm: adjust EccInfo_t struct

2022-06-16 Thread Zhang, Hawking
[AMD Official Use Only - General] I see. Thanks for the clarification, Stanley. Regards, Hawking -Original Message- From: Yang, Stanley Sent: Thursday, June 16, 2022 12:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Li, Candice ; Quan, Evan Subject: 回复: [PATCH Re

Re: [linux-next:master] BUILD REGRESSION 8cb8311e95e3bb58bd84d6350365f14a718faa6d

2022-06-16 Thread Chen, Rong A
On 5/26/2022 4:32 PM, Arnd Bergmann wrote: On Wed, May 25, 2022 at 11:35 PM kernel test robot wrote: .__mulsi3.o.cmd: No such file or directory Makefile:686: arch/h8300/Makefile: No such file or directory Makefile:765: arch/h8300/Makefile: No such file or directory arch/Kconfig:10: can't ope