[PATCH] drm/amdgpu/cs: make commands with 0 chunks illegal behaviour.

2022-05-22 Thread Dave Airlie
From: Dave Airlie Submitting a cs with 0 chunks, causes an oops later, found trying to execute the wrong userspace driver. MESA_LOADER_DRIVER_OVERRIDE=v3d glxinfo [172536.665184] BUG: kernel NULL pointer dereference, address: 01d8 [172536.665188] #PF: supervisor read access in kerne

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-22 Thread Alex Deucher
On Sun, May 22, 2022 at 4:03 AM Christian König wrote: > > Well, it's not arguing. I'm just pointing out the problems. > > Those issues were discovered because I'm trying to raise the limit for a > couple of years now. I think simply retesting the problematic tests on a modern system should be e

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-22 Thread Christoph Hellwig
How about just turning the MMIO/PIO accessors on m68k into inline functions as they are on most other architectures?

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-22 Thread Luc Van Oostenryck
On Fri, May 20, 2022 at 02:40:20PM +0200, Geert Uytterhoeven wrote: > Hi Günter > > On Thu, May 19, 2022 at 8:48 AM Guenter Roeck wrote: > > This is getting tiresome. Every driver using outb() on m68k will > > experience that "problem". As far as I can see, it is caused by > > > > #define out_8(a

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-22 Thread Luc Van Oostenryck
On Fri, May 20, 2022 at 02:46:20PM +0200, Geert Uytterhoeven wrote: > > The "(void)" makes sure there is no return value. > > Which matters if the result of a function returning void is propagated > > to another function returning void. > > Which, FTR, sparse also doesn't like: > > error: ret

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size

2022-05-22 Thread Christian König
Well, it's not arguing. I'm just pointing out the problems. Those issues were discovered because I'm trying to raise the limit for a couple of years now. I've also already hacked together the necessary functionality, but upstreaming them has caused other issues which I don't have time to solv