RE: [PATCH v4 0/6] VCN and JPEG RAS poison detection

2022-03-27 Thread Ziya, Mohammad zafar
[AMD Official Use Only] Dear Paul, Thank for review. Added comment inline. Regards, Mohammad >-Original Message- >From: Paul Menzel >Sent: Monday, March 28, 2022 12:09 PM >To: Ziya, Mohammad zafar >Cc: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; >Lazar, Lijo ; Zhang, Hawking > >Subje

Re: [PATCH 1/2] drm/amd/display: detach fpu operations from dcn10_validate_bandwidth in calcs

2022-03-27 Thread Christian König
Am 26.03.22 um 21:24 schrieb Melissa Wen: dcn10_validate_bandwidth is only used on dcn10 files, but is declared in dcn_calcs files. Rename dcn10_* to dcn_* in calcs, remove DC_FP_* wrapper inside DML folder and create an specific dcn10_validate_bandwidth in dcn10_resources that calls dcn_validate

Re: [PATCH v4 2/6] drm/amdgpu/vcn: Add vcn ras support

2022-03-27 Thread Paul Menzel
Dear Mohammad, Thank you for your patch. Am 28.03.22 um 08:24 schrieb Mohammad Zafar Ziya: VCN block ras feature support addition V2: default ras callback removed Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 10 ++ 1

Re: [PATCH v4 0/6] VCN and JPEG RAS poison detection

2022-03-27 Thread Paul Menzel
Dear Mahommad, Am 28.03.22 um 08:24 schrieb Mohammad Zafar Ziya: VCN and JPEG RAS poison detection It’d be great if you extended this a little bit. Especially, how it can be tested. Mohammad Zafar Ziya (6): drm/amdgpu: Add vcn and jpeg ras support flag drm/amdgpu/vcn: Add vcn ras su

[PATCH v4 6/6] drm/amdgpu/jpeg: jpeg ras error query support

2022-03-27 Thread Mohammad Zafar Ziya
RAS error query support addition for JPEG 2.6 V2: removed unused options and corrected comment format. Moved register definition to header file. V3: poison query status check added. Removed the error query support V4: Return statement refactored. Signed-off-by: Mohammad Zafar Ziya Reviewed-by:

[PATCH v4 4/6] drm/amdgpu/vcn: vcn and jpeg ver 2.6 ras register definition

2022-03-27 Thread Mohammad Zafar Ziya
Adding vcn and jpeg ver 2.6 ras register definition Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- .../amd/include/asic_reg/vcn/vcn_2_5_offset.h | 13 ++ .../include/asic_reg/vcn/vcn_2_5_sh_mask.h| 24 +++ 2 files changed, 37 insertions(+) diff --

[PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-27 Thread Mohammad Zafar Ziya
RAS error query support addition for VCN 2.6 V2: removed unused option and corrected comment format Moved the register definition under header file V3: poison query status check added. Removed error query interface V4: MMSCH poison check option removed, return true/false refactored. Signed-off-

[PATCH v4 3/6] drm/amdgpu/jpeg: Add jpeg block ras support

2022-03-27 Thread Mohammad Zafar Ziya
Ras support addition for JPEG block V2: removed default callback Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h b/drivers/gpu/drm/am

[PATCH v4 2/6] drm/amdgpu/vcn: Add vcn ras support

2022-03-27 Thread Mohammad Zafar Ziya
VCN block ras feature support addition V2: default ras callback removed Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h b/drivers/g

[PATCH v4 1/6] drm/amdgpu: Add vcn and jpeg ras support flag

2022-03-27 Thread Mohammad Zafar Ziya
Add vcn and jpeg ras support options V2: vcn and jpeg ras flag enabled for aldebaran asic only V3: vcn and jpeg ras flag disabled for error counter query Generic poison query interface added VCN and JPEG ras enabled based on IP version check V4: vcn and jpeg ras flag moved under ecc flag for dGP

[PATCH v4 0/6] VCN and JPEG RAS poison detection

2022-03-27 Thread Mohammad Zafar Ziya
VCN and JPEG RAS poison detection Mohammad Zafar Ziya (6): drm/amdgpu: Add vcn and jpeg ras support flag drm/amdgpu/vcn: Add vcn ras support drm/amdgpu/jpeg: Add jpeg block ras support drm/amdgpu/vcn: vcn and jpeg ver 2.6 ras register definition drm/amdgpu/vcn: VCN ras error query suppor

Re: [PATCH 01/13] drm/amd/display: HDCP SEND AKI INIT error

2022-03-27 Thread Paul Menzel
Dear Alex, Am 25.03.22 um 21:43 schrieb Hung, Alex: Thanks for your feedback. Thank you for your reply. For the future, it’d be great if you could use interleaved style [1], when replying, or when it’s a new topic, do not cite the previous message. I fixed many errors and typos you highl

RE: [PATCH V2] drm/amdgpu: fix incorrect GCR_GENERAL_CNTL address

2022-03-27 Thread Liu, Aaron
Reviewed-by: Aaron Liu -- Best Regards Aaron Liu > -Original Message- > From: amd-gfx On Behalf Of Ji, Ruili > Sent: Monday, March 28, 2022 12:59 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Yifan ; Liu, Aaron > ; Liang, Prike ; Huang, Ray > ; Deucher, Alexander > ; Ji, Ruili >

[PATCH V2] drm/amdgpu: fix incorrect GCR_GENERAL_CNTL address

2022-03-27 Thread Ji, Ruili
From: Ruili Ji gfx10.3.3/gfx10.3.6/gfx10.3.7 shall use 0x1580 address for GCR_GENERAL_CNTL Signed-off-by: Ruili Ji --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/

RE: [PATCH] drm/amdgpu: fix incorrect GCR_GENERAL_CNTL address

2022-03-27 Thread Liu, Aaron
[AMD Official Use Only] Thanks Ruili. Please remove Change-Id. With this fixed, Reviewed-by: Aaron Liu > -Original Message- > From: Ji, Ruili > Sent: Monday, March 28, 2022 11:47 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Huang, Ray > ; Liu, Aaron ; Zhang, Yifan >

[PATCH] drm/amdgpu: fix incorrect GCR_GENERAL_CNTL address

2022-03-27 Thread Ji, Ruili
From: Ruili Ji RMB shall use 0x1580 address for GCR_GENERAL_CNTL Signed-off-by: Ruili Ji Change-Id: I10a85891986f31411f85fa3db46970aaa8a5bd03 --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_

Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

2022-03-27 Thread Yin, Tianci (Rico)
[AMD Official Use Only] Thank you very much for your suggestion, but I have already submitted. Regards, Rico From: Chen, Guchun Sent: Monday, March 28, 2022 10:17 To: Chen, Guchun ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Wang, Yu (Charlie) ; Zh

RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

2022-03-27 Thread Chen, Guchun
Hi Tianci, I think we shall improve the subject a bit like "drm/amdgpu: fix incorrect instance id passing when stopping dpg mode". How do you think? Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Chen, Guchun Sent: Monday, March 28, 2022 9:26 AM To: Yin, Tianci (Rico) ;

RE: [PATCH v2 3/25] drm/amdgpu: Disable ABM when AC mode

2022-03-27 Thread Lin, Tsung-hua (Ryan)
[AMD Official Use Only] Hi Harry, I have been reminded to do some modifications to the patch format. So the 3/25 it's the date I resent the mail v2. If the mail title usage is not correct, please let me know. And about the questions: " This file lives in DC, which is shared code between Windows

RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

2022-03-27 Thread Chen, Guchun
Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Tianci Yin Sent: Sunday, March 27, 2022 7:19 PM To: amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Zhu, James ; Wang, Yu (Charlie) ; Yin, Tianci (Rico) Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0 From:

Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

2022-03-27 Thread Yin, Tianci (Rico)
[AMD Official Use Only] Thank you James! Rico From: Zhu, James Sent: Sunday, March 27, 2022 21:47 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Wang, Yu (Charlie) Subject: Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0 [AMD

Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

2022-03-27 Thread Zhu, James
[AMD Official Use Only] This patch is Reviewed-by: James Zhu From: Tianci Yin Sent: Sunday, March 27, 2022 7:18 AM To: amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Zhu, James ; Wang, Yu (Charlie) ; Yin, Tianci (Rico) Subject: [PATCH] drm/amd/vcn: fix an e

[PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

2022-03-27 Thread Tianci Yin
From: tiancyin Some video card has more than one vcn instance, passing 0 to vcn_v3_0_pause_dpg_mode is incorrect. Error msg: Register(1) [mmUVD_POWER_STATUS] failed to reach value 0x0001 != 0x0002 Signed-off-by: tiancyin --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +- 1 file changed

[PATCH 3/5] umr: Add command line support for "--gpu-metrics"

2022-03-27 Thread Luben Tuikov
Add command line support for --gpu-metrics, to fall in line with the rest of the command line arguments' format. Cc: Tom StDenis Cc: Jinzhou.Su Signed-off-by: Luben Tuikov --- src/app/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/app/main.c b/src/app/main.c

[PATCH 1/5] umr: Add support for "--ppt-read"

2022-03-27 Thread Luben Tuikov
Add support for "--ppt-read" to fall in line with the way rest of the command line options are formatted. The old "--ppt_read" is still supported. Cc: Tom StDenis Cc: Jinzhou.Su Signed-off-by: Luben Tuikov --- src/app/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 4/5] umr: Document new format command line options

2022-03-27 Thread Luben Tuikov
Document new format command line options in the manual page: "--ppt-read" and "--gpu-metrics". The old format using underscores is still supported in the main app, in case it is used in scripts, and so on. Cc: Tom StDenis Cc: Jinzhou.Su Signed-off-by: Luben Tuikov --- doc/umr.1 | 4 ++-- 1 fil

[PATCH 5/5] umr: Completion: update new format options

2022-03-27 Thread Luben Tuikov
Update completion for "--ppt-read" and "--gpu-metrics". Cc: Tom StDenis Cc: Jinzhou.Su Signed-off-by: Luben Tuikov --- scripts/umr-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/umr-completion.bash b/scripts/umr-completion.bash index 0e1444357c82a9.

[PATCH 2/5] umr: Reorg and print the message on ppt-read

2022-03-27 Thread Luben Tuikov
Reorganize the logic and actually print the error message when the ASIC doesn't support the power-play table feature. Cc: Tom StDenis Cc: Jinzhou.Su Signed-off-by: Luben Tuikov --- src/app/pp_table.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --