RE: [PATCH V3 12/12] drm/amdgpu: Removed redundant ras code

2021-12-28 Thread Zhang, Hawking
[AMD Official Use Only] Thank you Thomas. V3 looks good to me. @Zhou1, Tao/@Clements, John/@Yang, Stanley please also take a look and raise concern if any. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of yipechai Sent: Wednesday, December 29, 2021 14:32 To: amd-gfx@lists

[PATCH V3 12/12] drm/amdgpu: Removed redundant ras code

2021-12-28 Thread yipechai
Removed redundant ras code. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 82 ++--- 1 file changed, 20 insertions(+), 62 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 21765e05b003..1

[PATCH V3 11/12] drm/amdgpu: Adjust error inject function code style in amdgpu_ras.c

2021-12-28 Thread yipechai
1. Move xgmi special error inject function from amdgpu_ras.c to xgmi block. 2. Support to use psp_ras_trigger_error as default error inject function in amdgpu_ras.c. If .ras_error_inject isn't defined in ras block, default error inject function will take effect. Signed-off-by: yipechai --- dri

[PATCH V3 09/12] drm/amdgpu: Modify sdma block to fit for the unified ras block data and ops

2021-12-28 Thread yipechai
1.Modify sdma block to fit for the unified ras block data and ops. 2.Change amdgpu_sdma_ras_funcs to amdgpu_sdma_ras, and the corresponding variable name remove _funcs suffix. 3.Remove the const flag of sdma ras variable so that sdma ras block can be able to be inserted into amdgpu device ras blo

[PATCH V3 10/12] drm/amdgpu: Modify mca block to fit for the unified ras block data and ops

2021-12-28 Thread yipechai
1.Modify mca block to fit for the unified ras block data and ops. 2.Define special .ras_block_match function for mca block to identify itself. 3.Change amdgpu_mca_ras_funcs to amdgpu_mca_ras_block(amdgpu_mca_ras had been used), and the corresponding variable name remove _funcs suffix. 4.Remove the

[PATCH V3 08/12] drm/amdgpu: Modify umc block to fit for the unified ras block data and ops

2021-12-28 Thread yipechai
1.Modify umc block to fit for the unified ras block data and ops. 2.Change amdgpu_umc_ras_funcs to amdgpu_umc_ras, and the corresponding variable name remove _funcs suffix. 3.Remove the const flag of umc ras variable so that umc ras block can be able to be inserted into amdgpu device ras block li

[PATCH V3 07/12] drm/amdgpu: Modify nbio block to fit for the unified ras block data and ops

2021-12-28 Thread yipechai
1.Modify nbio block to fit for the unified ras block data and ops. 2.Change amdgpu_nbio_ras_funcs to amdgpu_nbio_ras, and the corresponding variable name remove _funcs suffix. 3.Remove the const flag of mmhub ras variable so that nbio ras block can be able to be inserted into amdgpu device ras bl

[PATCH V3 03/12] drm/amdgpu: Modify gfx block to fit for the unified ras block data and ops

2021-12-28 Thread yipechai
1.Modify gfx block to fit for the unified ras block data and ops. 2.Change amdgpu_gfx_ras_funcs to amdgpu_gfx_ras, and the corresponding variable name remove _funcs suffix. 3.Remove the const flag of gfx ras variable so that gfx ras block can be able to be inserted into amdgpu device ras block li

[PATCH V3 06/12] drm/amdgpu: Modify mmhub block to fit for the unified ras block data and ops

2021-12-28 Thread yipechai
1.Modify mmhub block to fit for the unified ras block data and ops. 2.Change amdgpu_mmhub_ras_funcs to amdgpu_mmhub_ras, and the corresponding variable name remove _funcs suffix. 3.Remove the const flag of mmhub ras variable so that mmhub ras block can be able to be inserted into amdgpu device ra

[PATCH V3 05/12] drm/amdgpu: Modify hdp block to fit for the unified ras block data and ops

2021-12-28 Thread yipechai
1.Modify hdp block to fit for the unified ras block data and ops. 2.Change amdgpu_hdp_ras_funcs to amdgpu_hdp_ras, and the corresponding variable name remove _funcs suffix. 3.Remove the const flag of hdp ras variable so that hdp ras block can be able to be inserted into amdgpu device ras block li

[PATCH V3 02/12] drm/amdgpu: Modify the compilation failed problem when other ras blocks' .h include amdgpu_ras.h

2021-12-28 Thread yipechai
Modify the compilation failed problem when other ras blocks' .h include amdgpu_ras.h. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 22 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 23 --- 2 files changed, 26 insertions(+), 19 dele

[PATCH V3 04/12] drm/amdgpu: Modify xgmi block to fit for the unified ras block data and ops

2021-12-28 Thread yipechai
1.Modify gmc block to fit for the unified ras block data and ops. 2.Change amdgpu_xgmi_ras_funcs to amdgpu_xgmi_ras, and the corresponding variable name remove _funcs suffix. 3.Remove the const flag of gmc ras variable so that gmc ras block can be able to be inserted into amdgpu device ras block

[PATCH V3 01/12] drm/amdgpu: Unify ras block interface for each ras block

2021-12-28 Thread yipechai
1. Define unified ops interface for each block. 2. Add ras_block_match function pointer in ops interface, each ras block can customize specail match function to identify itself. 3. Add amdgpu_ras_block_match_default new function. If a ras block doesn't define .ras_block_match, default execute amd

RE: [PATCH] drm/amdkfd: enable sdma ecc interrupt event can be handled by event_interrupt_wq_v9

2021-12-28 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of yipechai Sent: Wednesday, December 29, 2021 10:39 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Zhang, Hawking ; Clements, John ; Chai, Thomas ; Chai, Thomas Subject

[PATCH] drm/amdkfd: enable sdma ecc interrupt event can be handled by event_interrupt_wq_v9

2021-12-28 Thread yipechai
Enable sdma ecc interrupt event can be handled by event_interrupt_wq_v9. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v