RE: [PATCH] drm/amdgpu: avoid NULL pointer dereference

2021-12-27 Thread Chen, Guchun
[Public] Hello Hawking, Any comment to this patch? Regards, Guchun -Original Message- From: Chen, Guchun Sent: Wednesday, December 22, 2021 10:20 PM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Zhou1, Tao ; Clements, John ; Lazar, Lijo Cc: Chen, Guchun Subject: [PATCH] drm/

RE: [PATCH] drm/amdgpu: no DC support for headless chips

2021-12-27 Thread Chen, Guchun
[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, December 28, 2021 1:12 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Tareque Md . Hanif Subject: [PATCH] drm/amdgpu: no DC support for headless

RE: [PATCH] drm/amdgpu: no DC support for headless chips

2021-12-27 Thread Quan, Evan
[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, December 28, 2021 1:12 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Tareque Md . > Hanif > Subject: [PATCH] drm/amdgpu: no DC support fo

[PATCH 1/2] fbdev: fbmem: add a helper to determine if an aperture is used by a fw fb

2021-12-27 Thread Alex Deucher
Add a function for drivers to check if the a firmware initialized fb is corresponds to their aperture. This allows drivers to check if the device corresponds to what the firmware set up as the display device. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=215203 Bug: https://gitlab.freedesktop.

[PATCH 2/2] drm/amdgpu: disable runpm if we are the primary adapter

2021-12-27 Thread Alex Deucher
If we are the primary adapter (i.e., the one used by the firwmare framebuffer), disable runtime pm. This fixes a regression caused by commit 55285e21f045 which results in the displays waking up shortly after they go to sleep due to teh device coming out of runtime suspend and sending a hotplug uev

[PATCH 2/2] drm/amdgpu: disable runpm if we are the primary adapter

2021-12-27 Thread Alex Deucher
If we are the primary adapter (i.e., the one used by the firwmare framebuffer), disable runtime pm. This fixes a regression caused by commit 55285e21f045 which results in the displays waking up shortly after they go to sleep due to teh device coming out of runtime suspend and sending a hotplug uev

[PATCH 1/2] fbdev: fbmem: add a helper to determine if an aperture is used by a fw fb

2021-12-27 Thread Alex Deucher
Add a function for drivers to check if the a firmware initialized fb is corresponds to their aperture. This allows drivers to check if the device corresponds to what the firmware set up as the display device. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=215203 Bug: https://gitlab.freedesktop.

Re: [PATCH v2] drm/amd/display: fix dereference before NULL check

2021-12-27 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Dec 26, 2021 at 6:16 AM José Expósito wrote: > > The "plane_state" pointer was access before checking if it was NULL. > > Avoid a possible NULL pointer dereference by accessing the plane > address after the check. > > Addresses-Coverity-ID: 1493892 ("Dereference be

[PATCH] drm/amdgpu: no DC support for headless chips

2021-12-27 Thread Alex Deucher
Chips with no display hardware should return false for DC support. v2: drop Arcturus and Aldebaran Fixes: f7f12b25823c0d ("drm/amdgpu: default to true in amdgpu_device_asic_has_dc_support") Reported-by: Tareque Md.Hanif Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.

[PATCH v2] drm/amd/display: fix dereference before NULL check

2021-12-27 Thread José Expósito
The "plane_state" pointer was access before checking if it was NULL. Avoid a possible NULL pointer dereference by accessing the plane address after the check. Addresses-Coverity-ID: 1493892 ("Dereference before null check") Fixes: 3f68c01be9a22 ("drm/amd/display: add cyan_skillfish display suppor