Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Lazar, Lijo
On 12/2/2021 8:42 AM, Yu, Lang wrote: [AMD Official Use Only] -Original Message- From: Quan, Evan Sent: Thursday, December 2, 2021 10:48 AM To: Yu, Lang ; Koenig, Christian ; Christian König ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Huang, Ray Subject

Re: [PATCH V3 01/17] drm/amd/pm: do not expose implementation details to other blocks out of power

2021-12-01 Thread Lazar, Lijo
On 12/2/2021 11:48 AM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Thursday, December 2, 2021 1:12 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Feng, Kenneth Subject: Re: [PATCH V3 01/17] d

RE: [PATCH V3 01/17] drm/amd/pm: do not expose implementation details to other blocks out of power

2021-12-01 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, December 2, 2021 1:12 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Feng, Kenneth > Subject: Re: [PATCH V3 01/17] drm/amd/pm: do not expose implemen

Re: [PATCH V3 01/17] drm/amd/pm: do not expose implementation details to other blocks out of power

2021-12-01 Thread Lazar, Lijo
On 12/2/2021 10:22 AM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Thursday, December 2, 2021 12:13 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Feng, Kenneth Subject: Re: [PATCH V3 01/17]

[PATCH] drm/amdgpu: Fix null pointer access of BO

2021-12-01 Thread xinhui pan
TTM want bo->resource to be valid during BO's life. But ttm_bo_mem_space might fail and bo->resource point to NULL. Many code touch bo->resource and hit panic then. As old and new mem might overlap, move ttm_resource_free after ttm_bo_mem_space is not an option. We could assign one sysmem node to

RE: [PATCH V3 01/17] drm/amd/pm: do not expose implementation details to other blocks out of power

2021-12-01 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, December 2, 2021 12:13 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Feng, Kenneth > Subject: Re: [PATCH V3 01/17] drm/amd/pm: do not expose impleme

Re: [PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.16-rc3] [cannot apply to drm/drm-next drm-tip/drm-tip next-20211201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH V3 01/17] drm/amd/pm: do not expose implementation details to other blocks out of power

2021-12-01 Thread Lazar, Lijo
On 12/2/2021 8:39 AM, Evan Quan wrote: Those implementation details(whether swsmu supported, some ppt_funcs supported, accessing internal statistics ...)should be kept internally. It's not a good practice and even error prone to expose implementation details. Signed-off-by: Evan Quan Change-

[PATCH V3 13/17] drm/amd/pm: do not expose the smu_context structure used internally in power

2021-12-01 Thread Evan Quan
This can cover the power implementation details. And as what did for powerplay framework, we hook the smu_context to adev->powerplay.pp_handle. Signed-off-by: Evan Quan Change-Id: I3969c9f62a8b63dc6e4321a488d8f15022ffeb3d -- v1->v2: - drop smu_ppt_limit_type used internally from kgd_pp_interfac

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Quan, Evan >Sent: Thursday, December 2, 2021 10:48 AM >To: Yu, Lang ; Koenig, Christian >; Christian König >; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Lazar, Lijo >; Huang, Ray >Subject: RE: [PATCH] drm/amdgpu: add suppo

[PATCH V3 14/17] drm/amd/pm: relocate the power related headers

2021-12-01 Thread Evan Quan
Instead of centralizing all headers in the same folder. Separate them into different folders and place them among those source files those who really need them. Signed-off-by: Evan Quan Change-Id: Id74cb4c7006327ca7ecd22daf17321e417c4aa71 --- drivers/gpu/drm/amd/pm/Makefile | 10 ++

[PATCH V3 16/17] drm/amd/pm: revise the performance level setting APIs

2021-12-01 Thread Evan Quan
Avoid cross callings which make lock protection enforcement on amdgpu_dpm_force_performance_level() impossible. Signed-off-by: Evan Quan Change-Id: Ie658140f40ab906ce2ec47576a086062b61076a6 --- drivers/gpu/drm/amd/pm/amdgpu_pm.c| 29 --- .../gpu/drm/amd/pm/legacy-dpm/

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: amd-gfx On Behalf Of Yu, > Lang > Sent: Wednesday, December 1, 2021 7:37 PM > To: Koenig, Christian ; Christian König > ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Lazar, Lijo > ; Huang, Ray > Subject: RE: [PATCH] drm/

[PATCH V3 17/17] drm/amd/pm: unified lock protections in amdgpu_dpm.c

2021-12-01 Thread Evan Quan
As the only entry point, it's now safe and reasonable to enforce the lock protections in amdgpu_dpm.c. And with this, we can drop other internal used power locks. Signed-off-by: Evan Quan Change-Id: Iad228cad0b3d8c41927def08965a52525f3f51d3 --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c| 719 ++

[PATCH V3 15/17] drm/amd/pm: drop unnecessary gfxoff controls

2021-12-01 Thread Evan Quan
Those gfxoff controls added for some specific ASICs are unnecessary. The functionalities are not affected without them. Also to align with other ASICs, they should also be dropped. Signed-off-by: Evan Quan Change-Id: Ia8475ef9e97635441aca5e0a7693e2a515498523 --- drivers/gpu/drm/amd/pm/swsmu/amdg

[PATCH V3 11/17] drm/amd/pm: correct the usage for amdgpu_dpm_dispatch_task()

2021-12-01 Thread Evan Quan
We should avoid having multi-function APIs. It should be up to the caller to determine when or whether to call amdgpu_dpm_dispatch_task(). Signed-off-by: Evan Quan Change-Id: I78ec4eb8ceb6e526a4734113d213d15a5fbaa8a4 --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 18 ++ drivers/gpu/dr

[PATCH V3 12/17] drm/amd/pm: drop redundant or unused APIs and data structures

2021-12-01 Thread Evan Quan
Drop those unused APIs and data structures. Signed-off-by: Evan Quan Change-Id: I57d2a03dcda02d0b5d9c5ffbdd37bffe49945407 --- drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 49 - drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h | 4 ++ 2 files changed, 4 insertions(+), 49 deletions(-)

[PATCH V3 10/17] drm/amd/pm: move those code piece used by Stoney only to smu8_hwmgr.c

2021-12-01 Thread Evan Quan
Instead of putting them in amdgpu_dpm.c. Signed-off-by: Evan Quan Change-Id: Ieb7ed5fb6140401a7692b401c5a42dc53da92af8 --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c| 14 -- drivers/gpu/drm/amd/pm/inc/hwmgr.h | 3 --- .../gpu/drm/amd/pm/powerplay/hwmgr/smu8_

[PATCH V3 09/17] drm/amd/pm: optimize the amdgpu_pm_compute_clocks() implementations

2021-12-01 Thread Evan Quan
Drop cross callings and multi-function APIs. Also avoid exposing internal implementations details. Signed-off-by: Evan Quan Change-Id: I55e5ab3da6a70482f5f5d8c256eed2f754feae20 --- .../gpu/drm/amd/include/kgd_pp_interface.h| 2 +- drivers/gpu/drm/amd/pm/Makefile | 2 +- dri

[PATCH V3 07/17] drm/amd/pm: create a new holder for those APIs used only by legacy ASICs(si/kv)

2021-12-01 Thread Evan Quan
Those APIs are used only by legacy ASICs(si/kv). They cannot be shared by other ASICs. So, we create a new holder for them. Signed-off-by: Evan Quan Change-Id: I555dfa37e783a267b1d3b3a7db5c87fcc3f1556f -- v1->v2: - rename amdgpu_pm_compute_clocks as amdgpu_dpm_compute_clocks(Lijo) --- drivers/

[PATCH V3 08/17] drm/amd/pm: move pp_force_state_enabled member to amdgpu_pm structure

2021-12-01 Thread Evan Quan
As it lables an internal pm state and amdgpu_pm structure is the more proper place than amdgpu_device structure for it. Signed-off-by: Evan Quan Change-Id: I7890e8fe7af2ecd8591d30442340deb8773bacc3 --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 +++

[PATCH V3 06/17] drm/amd/pm: do not expose the API used internally only in kv_dpm.c

2021-12-01 Thread Evan Quan
Move it to kv_dpm.c instead. Signed-off-by: Evan Quan Change-Id: I554332b386491a79b7913f72786f1e2cb1f8165b -- v1->v2: - rename the API with "kv_" prefix(Alex) --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 23 - drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 2 -- drivers/gp

[PATCH V3 05/17] drm/amd/pm: do not expose those APIs used internally only in si_dpm.c

2021-12-01 Thread Evan Quan
Move them to si_dpm.c instead. Signed-off-by: Evan Quan Change-Id: I288205cfd7c6ba09cfb22626ff70360d61ff0c67 -- v1->v2: - rename the API with "si_" prefix(Alex) v2->v3: - rename other data structures used only in si_dpm.c(Lijo) --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 25 - drive

[PATCH V3 04/17] drm/amd/pm: do not expose those APIs used internally only in amdgpu_dpm.c

2021-12-01 Thread Evan Quan
Move them to amdgpu_dpm.c instead. Signed-off-by: Evan Quan Change-Id: I59fe0efcb47c18ec7254f3624db7a2eb78d91b8c --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 25 +++-- drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 23 --- 2 files changed, 23 insertions(+), 25

[PATCH V3 03/17] drm/amd/pm: do not expose power implementation details to display

2021-12-01 Thread Evan Quan
Display is another client of our power APIs. It's not proper to spike into power implementation details there. Signed-off-by: Evan Quan Change-Id: Ic897131e16473ed29d3d7586d822a55c64e6574a --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +- .../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c |

[PATCH V3 02/17] drm/amd/pm: do not expose power implementation details to amdgpu_pm.c

2021-12-01 Thread Evan Quan
amdgpu_pm.c holds all the user sysfs/hwmon interfaces. It's another client of our power APIs. It's not proper to spike into power implementation details there. Signed-off-by: Evan Quan Change-Id: I397853ddb13eacfce841366de2a623535422df9a -- v1->v2: - drop unneeded "return;" in amdgpu_dpm_get_cu

[PATCH V3 01/17] drm/amd/pm: do not expose implementation details to other blocks out of power

2021-12-01 Thread Evan Quan
Those implementation details(whether swsmu supported, some ppt_funcs supported, accessing internal statistics ...)should be kept internally. It's not a good practice and even error prone to expose implementation details. Signed-off-by: Evan Quan Change-Id: Ibca3462ceaa26a27a9145282b60c6ce5deca775

[PATCH V3 00/17] Unified entry point for other blocks to interact with power

2021-12-01 Thread Evan Quan
There are several problems with current power implementations: 1. Too many internal details are exposed to other blocks. Thus to interact with power, they need to know which power framework is used(powerplay vs swsmu) or even whether some API is implemented. 2. A lot of cross callings exist w

RE: [PATCH] drm/amdgpu: handle SRIOV VCN revision parsing

2021-12-01 Thread Chen, Guchun
[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, December 2, 2021 5:36 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: handle SRIOV VCN revision parsing For SR-IOV, th

Re: [PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.16-rc3] [cannot apply to drm/drm-next drm-tip/drm-tip next-20211201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-12-01 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit d58071a8a76d779eedab38033ae4c821c30295a5: Linux 5.16-rc3 (2021-11-28 14:09:19 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.16-2021-12-01 for you to fe

[PATCH] drm/amdgpu: handle SRIOV VCN revision parsing

2021-12-01 Thread Alex Deucher
For SR-IOV, the IP discovery revision number encodes additional information. Handle that case here. v2: drop additional IP versions Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 17 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 -- drive

Re: [PATCH] drm/amd/display: fix mixed declaration and code

2021-12-01 Thread Harry Wentland
On 2021-12-01 15:33, Alex Deucher wrote: > Reorder the code to fix the warning. > > Fixes: 8808f3ffb14d79 ("drm/amd/display: Add DP-HDMI FRL PCON Support in DC") > Cc: Fangzhi Zuo > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/

[PATCH] drm/amd/display: fix mixed declaration and code

2021-12-01 Thread Alex Deucher
Reorder the code to fix the warning. Fixes: 8808f3ffb14d79 ("drm/amd/display: Add DP-HDMI FRL PCON Support in DC") Cc: Fangzhi Zuo Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

Re: [PATCH] drm/radeon/radeon_connectors: Fix a NULL pointer dereference in radeon_fp_native_mode()

2021-12-01 Thread Alex Deucher
On Tue, Nov 30, 2021 at 9:49 AM Zhou Qingyang wrote: > > In radeon_fp_native_mode(), the return value of drm_mode_duplicate() is > assigned to mode and there is a dereference of it in > radeon_fp_native_mode(), which could lead to a NULL pointer > dereference on failure of drm_mode_duplicate(). >

Re: [PATCH] fix a NULL pointer dereference in amdgpu_connector_lcd_native_mode()

2021-12-01 Thread Alex Deucher
On Tue, Nov 30, 2021 at 6:24 AM Zhou Qingyang wrote: > > In amdgpu_connector_lcd_native_mode(), the return value of > drm_mode_duplicate() is assigned to mode, and there is a dereference > of it in amdgpu_connector_lcd_native_mode(), which will lead to a NULL > pointer dereference on failure of dr

Re: [PATCH v2] drm/amdgpu: update fw_load_type module parameter doc to match code

2021-12-01 Thread Alex Deucher
Applied. Thanks! On Mon, Nov 29, 2021 at 3:09 PM Yann Dirson wrote: > > amdgpu_ucode_get_load_type() does not interpret this parameter as > documented. It is ignored for many ASIC types (which presumably > only support one load_type), and when not ignored it is only used > to force direct loadi

Re: [v3] drm/amdgpu: reset asic after system-wide suspend aborted (v3)

2021-12-01 Thread Alex Deucher
On Wed, Dec 1, 2021 at 1:46 PM Limonciello, Mario wrote: > > On 11/24/2021 23:48, Prike Liang wrote: > > Do ASIC reset at the moment Sx suspend aborted behind of amdgpu suspend > > to keep AMDGPU in a clean reset state and that can avoid re-initialize > > device improperly error. Currently,we just

Re: [v3] drm/amdgpu: reset asic after system-wide suspend aborted (v3)

2021-12-01 Thread Limonciello, Mario
On 11/24/2021 23:48, Prike Liang wrote: Do ASIC reset at the moment Sx suspend aborted behind of amdgpu suspend to keep AMDGPU in a clean reset state and that can avoid re-initialize device improperly error. Currently,we just always do asic reset in the amdgpu resume until sort out the PM abort c

[PATCH v4 5/6] drm/amdgpu: move vram inline functions into a header

2021-12-01 Thread Arunpravin
Move shared vram inline functions and structs into a header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 51 1 file changed, 51 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h diff --git a/drivers/gpu/drm/a

[PATCH v4 6/6] drm/amdgpu: add drm buddy support to amdgpu

2021-12-01 Thread Arunpravin
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls

[PATCH v4 4/6] drm: implement a method to free unused pages

2021-12-01 Thread Arunpravin
On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim - replace input argument name 'actual_siz

[PATCH v4 3/6] drm: implement top-down allocation method

2021-12-01 Thread Arunpravin
Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver requests address at a low specific range,

[PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-01 Thread Arunpravin
- Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation and memory alignment logic from i915 drive

[PATCH v4 1/6] drm: move the buddy allocator from i915 into common drm

2021-12-01 Thread Arunpravin
Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix header file dependencies - Fix alignment issues

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Andrey Grodzovsky
On 2021-12-01 8:11 a.m., Christian König wrote: Adding Andrey as well. Am 01.12.21 um 12:37 schrieb Yu, Lang: [SNIP] + BUG_ON(unlikely(smu->smu_debug_mode) && res); BUG_ON() really crashes the kernel and is only allowed if we prevent further data corruption with that. Most of the time WARN

Re: [PATCH v5] drm/radeon/radeon_kms: Fix a NULL pointer dereference in radeon_driver_open_kms()

2021-12-01 Thread Christian König
Am 01.12.21 um 16:13 schrieb Zhou Qingyang: In radeon_driver_open_kms(), radeon_vm_bo_add() is assigned to vm->ib_bo_va and passes and used in radeon_vm_bo_set_addr(). In radeon_vm_bo_set_addr(), there is a dereference of vm->ib_bo_va, which could lead to a NULL pointer dereference on failure of

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Christian König
Adding Andrey as well. Am 01.12.21 um 12:37 schrieb Yu, Lang: [SNIP] + BUG_ON(unlikely(smu->smu_debug_mode) && res); BUG_ON() really crashes the kernel and is only allowed if we prevent further data corruption with that. Most of the time WARN_ON() is more appropriate, but I can't fully

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Koenig, Christian >Sent: Wednesday, December 1, 2021 7:29 PM >To: Yu, Lang ; Christian König >; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Lazar, Lijo >; Huang, Ray >Subject: Re: [PATCH] drm/amdgpu: add support to SMU debu

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Christian König
Am 01.12.21 um 12:20 schrieb Yu, Lang: [AMD Official Use Only] -Original Message- From: Christian König Sent: Wednesday, December 1, 2021 6:49 PM To: Yu, Lang ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Huang, Ray Subject: Re: [PATCH] drm

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Christian König >Sent: Wednesday, December 1, 2021 6:49 PM >To: Yu, Lang ; Koenig, Christian >; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Lazar, Lijo >; Huang, Ray >Subject: Re: [PATCH] drm/amdgpu: add support to SMU debu

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Lazar, Lijo >Sent: Wednesday, December 1, 2021 6:46 PM >To: Yu, Lang ; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Huang, Ray >; Koenig, Christian >Subject: Re: [PATCH] drm/amdgpu: add support to SMU debug option > > > >On

[PATCH V2 11/11] drm/amdgpu: Move error inject function from amdgpu_ras.c to each block

2021-12-01 Thread yipechai
Move each block error inject function from amdgpu_ras.c to each block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 62 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 28 +++ drivers/gpu/drm/amd/amdgpu/mca_v3_0.c| 18 +++ drivers/gpu

[PATCH V2 10/11] drm/amdgpu: Modify mca block to fit for the unified ras block data and ops

2021-12-01 Thread yipechai
1.Modify mca block to fit for the unified ras block data and ops. 2.Implement .ras_block_match function pointer for mca block to identify itself. 3.Change amdgpu_mca_ras_funcs to amdgpu_mca_ras_block(amdgpu_mca_ras had been used), and the corresponding variable name remove _funcs suffix. 4.Remove

[PATCH V2 09/11] drm/amdgpu: Modify sdma block to fit for the unified ras block data and ops

2021-12-01 Thread yipechai
1.Modify sdma block to fit for the unified ras block data and ops. 2.Implement .ras_block_match function pointer for sdma block to identify itself. 3.Change amdgpu_sdma_ras_funcs to amdgpu_sdma_ras, and the corresponding variable name remove _funcs suffix. 4.Remove the const flag of sdma ras varia

[PATCH V2 08/11] drm/amdgpu: Modify umc block to fit for the unified ras block data and ops

2021-12-01 Thread yipechai
1.Modify umc block to fit for the unified ras block data and ops. 2.Implement .ras_block_match function pointer for umc block to identify itself. 3.Change amdgpu_umc_ras_funcs to amdgpu_umc_ras, and the corresponding variable name remove _funcs suffix. 4.Remove the const flag of umc ras variable s

[PATCH V2 07/11] drm/amdgpu: Modify nbio block to fit for the unified ras block data and ops

2021-12-01 Thread yipechai
1.Modify nbio block to fit for the unified ras block data and ops. 2.Implement .ras_block_match function pointer for nbio block to identify itself. 3.Change amdgpu_nbio_ras_funcs to amdgpu_nbio_ras, and the corresponding variable name remove _funcs suffix. 4.Remove the const flag of mmhub ras vari

[PATCH V2 06/11] drm/amdgpu: Modify mmhub block to fit for the unified ras block data and ops

2021-12-01 Thread yipechai
1.Modify mmhub block to fit for the unified ras block data and ops. 2.Implement .ras_block_match function pointer for mmhub block to identify itself. 3.Change amdgpu_mmhub_ras_funcs to amdgpu_mmhub_ras, and the corresponding variable name remove _funcs suffix. 4.Remove the const flag of mmhub ras

[PATCH V2 04/11] drm/amdgpu: Modify gmc block to fit for the unified ras block data and ops

2021-12-01 Thread yipechai
1.Modify gmc block to fit for the unified ras block data and ops 2.Implement .ras_block_match function pointer for gmc block to identify itself. 3.Change amdgpu_xgmi_ras_funcs to amdgpu_xgmi_ras, and the corresponding variable name remove _funcs suffix. 4.Remove the const flag of gmc ras variable

[PATCH V2 05/11] drm/amdgpu: Modify hdp block to fit for the unified ras block data and ops

2021-12-01 Thread yipechai
1.Modify hdp block to fit for the unified ras block data and ops. 2.Implement .ras_block_match function pointer for hdp block to identify itself. 3.Change amdgpu_hdp_ras_funcs to amdgpu_hdp_ras, and the corresponding variable name remove _funcs suffix. 4.Remove the const flag of hdp ras variable s

[PATCH V2 03/11] drm/amdgpu: Modify gfx block to fit for the unified ras block data and ops

2021-12-01 Thread yipechai
1.Modify gfx block to fit for the unified ras block data and ops 2.Implement .ras_block_match function pointer for gfx block to identify itself. 3.Change amdgpu_gfx_ras_funcs to amdgpu_gfx_ras, and the corresponding variable name remove _funcs suffix. 4.Remove the const flag of gfx ras variable so

[PATCH V2 02/11] drm/amdgpu: Modify the compilation failed problem when other ras blocks' .h include amdgpu_ras.h

2021-12-01 Thread yipechai
Modify the compilation failed problem when other ras blocks' .h include amdgpu_ras.h. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 22 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 23 --- 2 files changed, 26 insertions(+), 19 dele

[PATCH V2 01/11] drm/amdgpu: Unify ras block interface for each ras block

2021-12-01 Thread yipechai
1. Define unified ops interface for each block. 2. Add ras_block_match function pointer in ops interface for each ras block to identify itself. 3. Define unified basic ras block data for each ras block. 4. Create dedicated amdgpu device ras block link list to manage all of the ras blocks. 5. Add

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Christian König
Am 01.12.21 um 11:44 schrieb Yu, Lang: [AMD Official Use Only] -Original Message- From: Koenig, Christian Sent: Wednesday, December 1, 2021 5:30 PM To: Yu, Lang ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Huang, Ray Subject: Re: [PATCH] drm/amdgpu: add sup

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Lazar, Lijo
On 12/1/2021 4:08 PM, Yu, Lang wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Wednesday, December 1, 2021 5:47 PM To: Yu, Lang ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: add s

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Koenig, Christian >Sent: Wednesday, December 1, 2021 5:30 PM >To: Yu, Lang ; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Lazar, Lijo >; Huang, Ray >Subject: Re: [PATCH] drm/amdgpu: add support to SMU debug option > >Am 01.1

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Lazar, Lijo >Sent: Wednesday, December 1, 2021 5:47 PM >To: Yu, Lang ; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Huang, Ray >; Koenig, Christian >Subject: Re: [PATCH] drm/amdgpu: add support to SMU debug option > > > >On

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Lazar, Lijo
On 12/1/2021 2:54 PM, Lang Yu wrote: To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug debugfs file. When enabled, it makes SMU errors fatal. It is disabled

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Huang Rui
On Wed, Dec 01, 2021 at 05:24:58PM +0800, Yu, Lang wrote: > To maintain system error state when SMU errors occurred, > which will aid in debugging SMU firmware issues, add SMU > debug option support. > > It can be enabled or disabled via amdgpu_smu_debug > debugfs file. When enabled, it makes SMU

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Christian König
Am 01.12.21 um 10:24 schrieb Lang Yu: To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug debugfs file. When enabled, it makes SMU errors fatal. It is disabled b

[PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Lang Yu
To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug debugfs file. When enabled, it makes SMU errors fatal. It is disabled by default. == Command Guide == 1, enab

Re: [PATCH] drm/amdgpu: add SMU debug option support

2021-12-01 Thread Lazar, Lijo
On 12/1/2021 1:48 PM, Yu, Lang wrote: [AMD Official Use Only] -Original Message- From: amd-gfx On Behalf Of Yu, Lang Sent: Wednesday, December 1, 2021 3:58 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Koenig, Christian Subject: RE: [PAT

RE: [PATCH] drm/amdgpu: add SMU debug option support

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: amd-gfx On Behalf Of Yu, Lang >Sent: Wednesday, December 1, 2021 3:58 PM >To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Huang, Ray >; Koenig, Christian >Subject: RE: [PATCH] drm/amdgpu: add SMU debug option