[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Monday, November 22, 2021 11:48 PM
> To: Liang, Prike
> Cc: Lazar, Lijo ; Deucher, Alexander
> ; Christian König
> ; Huang, Ray ;
> amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: reset asic after system-wide sus
Am 2021-11-19 um 5:29 p.m. schrieb Philip Yang:
> kfd_process_wq_release drain retry fault to ensure no retry fault comes
> after removing kfd process from the hash table, otherwise svm page fault
> handler will fail to recover the fault and dump GPU vm fault log.
>
> Refactor deferred list work to
[Public]
Modprobe -r amdgpu get oops in amdgpu_vkms_sw_fini()
for (i = 0; i < adev->mode_info.num_crtc; i++)
if (adev->mode_info.crtcs[i])
hrtimer_cancel(&adev->mode_info.crtcs[i]->vblank_timer);
adev->mode_info
On Mon, Nov 22, 2021 at 2:02 AM Pekka Paalanen wrote:
>
> On Fri, 19 Nov 2021 11:21:36 -0500
> Jason Baron wrote:
>
> > On 11/18/21 10:24 AM, Pekka Paalanen wrote:
> > > On Thu, 18 Nov 2021 09:29:27 -0500
> > > Jason Baron wrote:
> > >
> > >> On 11/16/21 3:46 AM, Pekka Paalanen wrote:
> > >>> On
Print the error on command submission immediately after submitting to
the SMU. This is rate-limited. It helps to immediately know there was an
error on command submission, rather than leave it up to clients to report
the error, as sometimes they do not.
Cc: Alex Deucher
Signed-off-by: Luben Tuiko
Add a print in sienna_cichlid_run_btc() to help debug and to mirror other
platforms, as no print is present in the caller, smu_smc_hw_setup().
Cc: Alex Deucher
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 8 +++-
1 file changed, 7 insertions(+),
Add prints where there are none and none are printed in the callee.
Remove the word "previous" from comment and print to make it shorter and
avoid confusion in various prints.
Cc: Alex Deucher
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 8 +---
drivers/gpu/d
On 2021-11-17 16:54, Alex Deucher wrote:
> On Wed, Nov 17, 2021 at 1:56 PM Luben Tuikov wrote:
>> Add prints where there are none and none are printed in the callee.
>>
>> Add a print in sienna_cichlid_run_btc() to help debug and to mirror other
>> platforms, as no print is present in the caller,
documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
base: git://anongit.freedesktop.org/drm/drm drm-next
config: x86_64-randconfig-a015-20211121 (attached
Am 2021-11-21 um 12:41 p.m. schrieb Christophe JAILLET:
> The 'doorbell_bitmap' bitmap has just been allocated. So we can use the
> non-atomic '__set_bit()' function to save a few cycles as no concurrent
> access can happen.
>
> Signed-off-by: Christophe JAILLET
Thank you for the patches. I think
I sent my RB, last week, but maybe it never made it to the list?
Reviewed-by: Alex Deucher
On Mon, Nov 22, 2021 at 2:58 PM Errabolu, Ramesh
wrote:
>
> [AMD Official Use Only]
>
> Request review
>
> Regards,
> Ramesh
>
> -Original Message-
> From: amd-gfx On Behalf Of Ramesh
> Errabolu
[AMD Official Use Only]
Request review
Regards,
Ramesh
-Original Message-
From: amd-gfx On Behalf Of Ramesh
Errabolu
Sent: Thursday, November 18, 2021 4:12 PM
To: amd-gfx@lists.freedesktop.org
Cc: Errabolu, Ramesh ; kernel test robot
Subject: [PATCH] drm/amdgpu: Declare Unpin BO api
On Wed, Nov 17, 2021 at 5:33 PM Surbhi Kakarya wrote:
>
> Fill voltage fields in metrics table. This patch is
> based on an existing patch I9e15971919b88e54fe5fbee5b784293eaf18025c.
This seems to be an invalid commit hash.
>
> Signed-off-by: Surbhi Kakarya
> Change-Id: I701110d78a85c092f5dda167
Am 2021-11-22 um 11:16 a.m. schrieb Liu, Shaoyun:
> [AMD Official Use Only]
>
> Thanks for the review .
> The hash for the previous change from gerrirgit/amd-staging-drm-next branch
> is 7079e7d5c6bf248bff, so there is another drm-next branch that not in the
> gerritgit for upstream ?
Yes. am
Am 2021-11-22 um 10:25 a.m. schrieb Sider, Graham:
> [AMD Official Use Only]
>
>> -Original Message-
>> From: Kuehling, Felix
>> Sent: Friday, November 19, 2021 4:20 PM
>> To: Sider, Graham ; amd-
>> g...@lists.freedesktop.org
>> Cc: Deucher, Alexander
>> Subject: Re: [PATCH v2 2/4] drm/a
Am 2021-11-21 um 9:40 p.m. schrieb Alistair Popple:
diff --git a/mm/migrate.c b/mm/migrate.c
index 1852d787e6ab..f74422a42192 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -362,7 +362,7 @@ static int expected_page_refs(struct address_space
*mapping, struct page *pag
[Public]
Hi Alex,
Thank you for the advice! Last week's DC candidate has in fact already been
merged to upstream, but I will bring up your suggestion to the patch author for
review.
Thank you,
Lillian
From: Deucher, Alexander
Sent: Monday, November 22, 2021 10:38 AM
To: Zhuo, Qingqing (Lillia
Am 2021-11-22 um 7:39 a.m. schrieb Christian König:
> Partially revert commit 5f319c5c21b5909abb43d8aadc92a8aa549ee443.
>
> First of all this is illegal use of RCU to call
> dma_fence_enable_sw_signaling()
> since we don't hold a reference to the fence in question and can crash badly.
>
> Then the
[Public]
Acked-by: Alex Deucher
From: amd-gfx on behalf of Flora Cui
Sent: Monday, November 22, 2021 4:03 AM
To: amd-gfx@lists.freedesktop.org ; Chen, Guchun
Cc: Cui, Flora
Subject: [PATCH 2/2] drm/amdgpu: check atomic flag to differeniate with legacy
path
[Public]
Can you explain how the current code is failing? It's not immediately obvious
to me. I'm not opposed to this change, it's just not clear to me where the
current code fails.
Alex
From: Chen, Guchun
Sent: Monday, November 22, 2021 8:49 AM
To: Cui, Flo
Am 2021-11-20 um 9:58 p.m. schrieb Philip Yang:
> IH ring1 is used to process GPU retry fault, overflow is enabled to
> drain retry fault because we want receive other interrupts while
> handling retry fault to recover range. There is no overflow flag set
> when wptr pass rptr. Use timestamp of rpt
[AMD Official Use Only]
Thanks for the review .
The hash for the previous change from gerrirgit/amd-staging-drm-next branch is
7079e7d5c6bf248bff, so there is another drm-next branch that not in the
gerritgit for upstream ?
Thanks
Shaoyun.liu
-Original Message-
From: Kuehling, Fel
IH ring1 is used to process GPU retry fault, overflow is enabled to
drain retry fault because we want receive other interrupts while
handling retry fault to recover range. There is no overflow flag set
when wptr pass rptr. Use timestamp of rptr and wptr to handle overflow
and drain retry fault.
Ad
On 2021-11-22 6:34 a.m., Christian
König wrote:
Am
21.11.21 um 03:13 schrieb philip yang:
On 2021-11-19 5:59 p.m., Felix Kuehling wrote:
On 2021-11-19 3:22 p.m., Philip Yang
wrote:
On Mon, Nov 22, 2021 at 9:23 AM Liang, Prike wrote:
>
> [Public]
>
> > -Original Message-
> > From: Alex Deucher
> > Sent: Friday, November 19, 2021 12:18 AM
> > To: Lazar, Lijo
> > Cc: Deucher, Alexander ; Christian König
> > ; Liang, Prike ;
> > Huang, Ray ; amd-gfx@lists.freedesktop.o
Am 2021-11-18 um 11:57 a.m. schrieb shaoyunl:
> For sriov XGMI configuration, the host driver will handle the hive reset,
> so in guest side, the reset_sriov only be called once on one device. This will
> make kfd post_reset unblanced with kfd pre_reset since kfd pre_reset already
> been moved out
[Public]
Do you want to change the ASICREV_IS_BEIGE_GOBY_P() check to else if as well?
maybe something like:
if (ASICREV_IS_SIENNA_CICHLID_P(clk_mgr_base->ctx->asic_id.hw_internal_rev) ||
ASICREV_IS_DIMGREY_CAVEFISH_P(clk_mgr_base->ctx->asic_id.hw_internal_rev) ||
ASICREV_IS_BEIGE_GOBY
[AMD Official Use Only]
> -Original Message-
> From: Kuehling, Felix
> Sent: Friday, November 19, 2021 4:30 PM
> To: Sider, Graham ; amd-
> g...@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH v2 3/4] drm/amdkfd: move to dynamic device_info
> creation
>
> On 2021-11
[AMD Official Use Only]
> -Original Message-
> From: Kuehling, Felix
> Sent: Friday, November 19, 2021 4:20 PM
> To: Sider, Graham ; amd-
> g...@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH v2 2/4] drm/amdkfd: add kfd_device_info_init function
>
> On 2021-11-19 2
[AMD Official Use Only]
ping
-Original Message-
From: Liu, Shaoyun
Sent: Thursday, November 18, 2021 10:08 PM
To: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amd/amdgpu: move kfd post_reset out of reset_sriov
function
[AMD Official Use Only]
Ping
-Original Message
[AMD Official Use Only]
Hi all,
This week this patchset was tested on the following systems:
Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display
types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C
to DP/HDMI), 1680*1050 60hz (via USB-C to D
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Friday, November 19, 2021 12:18 AM
> To: Lazar, Lijo
> Cc: Deucher, Alexander ; Christian König
> ; Liang, Prike ;
> Huang, Ray ; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: reset asic after system-wide suspe
[Public]
> -Original Message-
> From: Lazar, Lijo
> Sent: Thursday, November 18, 2021 10:28 PM
> To: Alex Deucher
> Cc: Christian König ; Liang, Prike
> ; Deucher, Alexander
> ; Huang, Ray ;
> amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: reset asic after system-wide s
[Public]
Series is:
Reviewed-by: Guchun Chen
+Alex to comment this series as well.
Regards,
Guchun
-Original Message-
From: Cui, Flora
Sent: Monday, November 22, 2021 5:04 PM
To: amd-gfx@lists.freedesktop.org; Chen, Guchun
Cc: Cui, Flora
Subject: [PATCH 1/2] drm/amdgpu: fix vkms hr
Partially revert commit 5f319c5c21b5909abb43d8aadc92a8aa549ee443.
First of all this is illegal use of RCU to call dma_fence_enable_sw_signaling()
since we don't hold a reference to the fence in question and can crash badly.
Then the code doesn't seem to have the intended effect since only the
exc
Am 21.11.21 um 03:13 schrieb philip yang:
On 2021-11-19 5:59 p.m., Felix Kuehling wrote:
On 2021-11-19 3:22 p.m., Philip Yang wrote:
IH ring1 is used to process GPU retry fault, overflow is enabled to
drain retry fault because we want receive other interrupts while
handling retry fault to rec
> >> diff --git a/mm/migrate.c b/mm/migrate.c
> >> index 1852d787e6ab..f74422a42192 100644
> >> --- a/mm/migrate.c
> >> +++ b/mm/migrate.c
> >> @@ -362,7 +362,7 @@ static int expected_page_refs(struct address_space
> >> *mapping, struct page *page)
> >> * Device private pages have an extra ref
On Fri, 19 Nov 2021 15:46:31 -0700
jim.cro...@gmail.com wrote:
> > So I could see us supporting subsystem specific trace buffer output
> > via dynamic debug here. We could add new dev_debug() variants that
> > allow say a trace buffer to be supplied. So in that way subsystems
> > could 'opt-out'
'doorbell_bitmap' is a bitmap. So use 'bitmap_zalloc()' to simplify code,
improve the semantic and avoid some open-coded arithmetic in allocator
arguments.
Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
consistency.
Signed-off-by: Christophe JAILLET
---
drivers/gpu/drm/amd
The 'doorbell_bitmap' bitmap has just been allocated. So we can use the
non-atomic '__set_bit()' function to save a few cycles as no concurrent
access can happen.
Signed-off-by: Christophe JAILLET
---
bitmap_set() could certainly also be use, but range checking would be
tricky.
---
drivers/gpu/d
since vkms support atomic KMS interface
Signed-off-by: Flora Cui
Reviewed-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device
otherwise adev->mode_info.crtcs[] is NULL
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 38
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.h | 5 ++--
2 files changed, 28 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vk
On Fri, 19 Nov 2021 11:21:36 -0500
Jason Baron wrote:
> On 11/18/21 10:24 AM, Pekka Paalanen wrote:
> > On Thu, 18 Nov 2021 09:29:27 -0500
> > Jason Baron wrote:
> >
> >> On 11/16/21 3:46 AM, Pekka Paalanen wrote:
> >>> On Fri, 12 Nov 2021 10:08:41 -0500
> >>> Jason Baron wrote:
> >>>
43 matches
Mail list logo
