Re: [Intel-gfx] [PATCH v7 5/8] drm_print: add choice to use dynamic debug in drm-debug

2021-09-03 Thread jim . cromie
On Fri, Sep 3, 2021 at 5:15 AM Tvrtko Ursulin wrote: > > > On 31/08/2021 21:21, Jim Cromie wrote: > > drm's debug system writes 10 distinct categories of messages to syslog > > using a small API[1]: drm_dbg*(10 names), DRM_DEV_DEBUG*(3 names), > > DRM_DEBUG*(8 names). There are thousands of these

Re: [Intel-gfx] [PATCH v7 3/8] i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories

2021-09-03 Thread jim . cromie
On Fri, Sep 3, 2021 at 5:07 AM Tvrtko Ursulin wrote: > > > On 31/08/2021 21:21, Jim Cromie wrote: > > The gvt component of this driver has ~120 pr_debugs, in 9 categories > > quite similar to those in DRM. Following the interface model of > > drm.debug, add a parameter to map bits to these catego

Re: [PATCH 2/2] drm/amdgpu: cleanup debugfs for amdgpu rings

2021-09-03 Thread Das, Nirmoy
Hi Shashank, On 9/3/2021 5:51 PM, Das, Nirmoy wrote: On 9/3/2021 5:26 PM, Sharma, Shashank wrote: On 9/3/2021 1:39 PM, Das, Nirmoy wrote: On 9/3/2021 8:36 AM, Sharma, Shashank wrote: On 9/2/2021 5:14 PM, Nirmoy Das wrote: Use debugfs_create_file_size API for creating ring debugfs file,

Re: [PATCH 2/2] drm/amdgpu: cleanup debugfs for amdgpu rings

2021-09-03 Thread Das, Nirmoy
On 9/3/2021 5:26 PM, Sharma, Shashank wrote: On 9/3/2021 1:39 PM, Das, Nirmoy wrote: On 9/3/2021 8:36 AM, Sharma, Shashank wrote: On 9/2/2021 5:14 PM, Nirmoy Das wrote: Use debugfs_create_file_size API for creating ring debugfs file, also cleanup surrounding code. Signed-off-by: Nirmoy

Re: [PATCH 1/2] drm/amdgpu: use IS_ERR for debugfs APIs

2021-09-03 Thread Sharma, Shashank
On 9/3/2021 1:47 PM, Christian König wrote: Yeah, sounds logical to me as well. Feel free to stick my rb on that as well. Christian. Am 03.09.21 um 10:13 schrieb Das, Nirmoy: Hi Christian and Shashank, Please review the v2 : https://patchwork.freedesktop.org/patch/452175/ In v2, I am re

Re: [PATCH 2/2] drm/amdgpu: cleanup debugfs for amdgpu rings

2021-09-03 Thread Sharma, Shashank
On 9/3/2021 1:39 PM, Das, Nirmoy wrote: On 9/3/2021 8:36 AM, Sharma, Shashank wrote: On 9/2/2021 5:14 PM, Nirmoy Das wrote: Use debugfs_create_file_size API for creating ring debugfs file, also cleanup surrounding code. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu_d

Re: [Intel-gfx] [PATCH v7 5/8] drm_print: add choice to use dynamic debug in drm-debug

2021-09-03 Thread Tvrtko Ursulin
On 31/08/2021 21:21, Jim Cromie wrote: drm's debug system writes 10 distinct categories of messages to syslog using a small API[1]: drm_dbg*(10 names), DRM_DEV_DEBUG*(3 names), DRM_DEBUG*(8 names). There are thousands of these callsites, each categorized in this systematized way. These callsi

Re: [Intel-gfx] [PATCH v7 3/8] i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories

2021-09-03 Thread Tvrtko Ursulin
On 31/08/2021 21:21, Jim Cromie wrote: The gvt component of this driver has ~120 pr_debugs, in 9 categories quite similar to those in DRM. Following the interface model of drm.debug, add a parameter to map bits to these categorizations. DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug,

Re: [PATCH] drm/amdgpu: use generic fb helpers instead of setting up AMD own's.

2021-09-03 Thread Christian König
Am 03.09.21 um 08:37 schrieb Evan Quan: With the shadow buffer support from generic framebuffer emulation, it's possible now to have runpm kicked when no update for console. Change-Id: I285472c9100ee6f649d3f3f3548f402b9cd34eaf Signed-off-by: Evan Quan That's a really nice cleanup, but somebod

Re: [PATCH 1/2] drm/amdgpu: use IS_ERR for debugfs APIs

2021-09-03 Thread Christian König
Yeah, sounds logical to me as well. Feel free to stick my rb on that as well. Christian. Am 03.09.21 um 10:13 schrieb Das, Nirmoy: Hi Christian and Shashank, Please review the v2 : https://patchwork.freedesktop.org/patch/452175/ In v2, I am returning "PTR_ERR(ent)" instead of -EIO which I t

Re: [PATCH 1/2] drm/amdgpu: use IS_ERR for debugfs APIs

2021-09-03 Thread Das, Nirmoy
Hi Christian and Shashank, Please review the v2 : https://patchwork.freedesktop.org/patch/452175/ In v2, I am returning "PTR_ERR(ent)" instead of -EIO which I think makes more sense. Regards, Nirmoy On 9/3/2021 9:53 AM, Christian König wrote: Am 02.09.21 um 13:44 schrieb Nirmoy Das: debugf

Re: [PATCH 2/2] drm/amdgpu: cleanup debugfs for amdgpu rings

2021-09-03 Thread Das, Nirmoy
On 9/3/2021 8:36 AM, Sharma, Shashank wrote: On 9/2/2021 5:14 PM, Nirmoy Das wrote: Use debugfs_create_file_size API for creating ring debugfs file, also cleanup surrounding code. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |  4 +---   drivers/gpu/drm/amd/am

Re: [PATCH 1/2] drm/amdgpu: use IS_ERR for debugfs APIs

2021-09-03 Thread Christian König
Am 02.09.21 um 13:44 schrieb Nirmoy Das: debugfs APIs returns encoded error so use IS_ERR for checking return value. References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686 Signed-off-by: Nirmoy Das Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6