[PATCH] drm/amdgpu: use generic fb helpers instead of setting up AMD own's.

With the shadow buffer support from generic framebuffer emulation, it's possible now to have runpm kicked when no update for console. Change-Id: I285472c9100ee6f649d3f3f3548f402b9cd34eaf Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu

Re: [PATCH 2/2] drm/amdgpu: cleanup debugfs for amdgpu rings

On 9/2/2021 5:14 PM, Nirmoy Das wrote: Use debugfs_create_file_size API for creating ring debugfs file, also cleanup surrounding code. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c| 16 +--- d

Re: [PATCH][next] drm/amdgpu: sdma: clean up identation

Am 02.09.21 um 23:51 schrieb Colin King: From: Colin Ian King There is a statement that is indented incorrectly. Clean it up. Signed-off-by: Colin Ian King Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 8 1 file changed, 4 insertions(+), 4 deletion

Re: [PATCH][next] drm/amdgpu: clean up inconsistent indenting

Am 02.09.21 um 23:45 schrieb Colin King: From: Colin Ian King There are a couple of statements that are indented one character too deeply, clean these up. Signed-off-by: Colin Ian King Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +++ 1 file changed

[PATCH][next] drm/amdgpu: sdma: clean up identation

From: Colin Ian King There is a statement that is indented incorrectly. Clean it up. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/am

[PATCH][next] drm/amdgpu: clean up inconsistent indenting

From: Colin Ian King There are a couple of statements that are indented one character too deeply, clean these up. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH v2 1/1] drm/amdkfd: make needs_pcie_atomics FW-version dependent

On some GPUs the PCIe atomic requirement for KFD depends on the MEC firmware version. Add a firmware version check for this. The minimum firmware version that works without atomics can be updated in the device_info structure for each GPU type. Signed-off-by: Felix Kuehling Reviewed-by: Oak Zeng

Re: [PATCH v1 03/14] mm: add iomem vma selection for memory migration

On Thu, Sep 2, 2021 at 1:18 AM Christoph Hellwig wrote: > > On Wed, Sep 01, 2021 at 11:40:43AM -0400, Felix Kuehling wrote: > > >>> It looks like I'm totally misunderstanding what you are adding here > > >>> then. Why do we need any special treatment at all for memory that > > >>> has normal stru

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

Hi Monk, On Thu, 2 Sept 2021 at 06:52, Liu, Monk wrote: > I didn't mean your changes on AMD driver need my personal approval or review > ... and I'm totally already get used that our driver is not 100% under > control by AMDers, > but supposedly any one from community (including you) who tend

Re: [PATCH] drm/amd/amdgpu: Increase HWIP_MAX_INSTANCE to 10

Applied. Thanks! Alex On Thu, Sep 2, 2021 at 3:50 AM Ernst Sjöstrand wrote: > > Seems like newer cards can have even more instances now. > Found by UBSAN: array-index-out-of-bounds in > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:318:29 > index 8 is out of range for type 'uint32_t *[8]' > > B

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

On Thu, Sep 2, 2021 at 1:00 PM Christian König wrote: > > Hi Monk, > > Am 02.09.21 um 07:52 schrieb Liu, Monk: > > [AMD Official Use Only] > > > > I'm not sure I can add much to help this along, I'm sure Alex has some > > internal training, > > Once your driver is upstream, it belongs to upstream

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

On 2021-09-02 10:28 a.m., Daniel Vetter wrote: On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: On 2021-08-31 9:11 a.m., Daniel Vetter wrote: On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: O

Re: [PATCH 1/2] drm/amdgpu: use IS_ERR for debugfs APIs

On 9/2/2021 5:14 PM, Nirmoy Das wrote: debugfs APIs returns encoded error so use IS_ERR for checking return value. References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686 Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++ drivers/gpu/drm/amd/amdg

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: > > On 2021-08-31 9:11 a.m., Daniel Vetter wrote: > > On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: > > > On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-19 5:30 a.m., Daniel V

[PATCH v2 1/2] drm/amdgpu: use IS_ERR for debugfs APIs

debugfs APIs returns encoded error so use IS_ERR for checking return value. v2: return PTR_ERR(ent) References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686 Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 10 -- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.

[PATCH 2/2] drm/amdgpu: cleanup debugfs for amdgpu rings

Use debugfs_create_file_size API for creating ring debugfs file, also cleanup surrounding code. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c| 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h|

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

On Thu, Sep 2, 2021 at 1:52 AM Liu, Monk wrote: > > [AMD Official Use Only] > > >>> > I'm not sure I can add much to help this along, I'm sure Alex has some > internal training, > Once your driver is upstream, it belongs to upstream, you can maintain it, > but you no longer control it 100%, it's

Re: [PATCH v1 03/14] mm: add iomem vma selection for memory migration

On Wed, Sep 01, 2021 at 11:40:43AM -0400, Felix Kuehling wrote: > >>> It looks like I'm totally misunderstanding what you are adding here > >>> then. Why do we need any special treatment at all for memory that > >>> has normal struct pages and is part of the direct kernel map? > >> The pages are l

[PATCH 2/2] drm/amdgpu: cleanup debugfs for amdgpu rings

Use debugfs_create_file_size API for creating ring debugfs file, also cleanup surrounding code. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c| 16 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h| 8

[PATCH 1/2] drm/amdgpu: use IS_ERR for debugfs APIs

debugfs APIs returns encoded error so use IS_ERR for checking return value. References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686 Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c| 2 +- 2 files changed,

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

Hi Monk, Am 02.09.21 um 07:52 schrieb Liu, Monk: [AMD Official Use Only] I'm not sure I can add much to help this along, I'm sure Alex has some internal training, Once your driver is upstream, it belongs to upstream, you can maintain it, but you no longer control it 100%, it's a tradeoff, it'

[PATCH] drm/amd/amdgpu: Increase HWIP_MAX_INSTANCE to 10

Seems like newer cards can have even more instances now. Found by UBSAN: array-index-out-of-bounds in drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:318:29 index 8 is out of range for type 'uint32_t *[8]' Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1697 Cc: sta...@vger.kernel.org Signed-of