Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-17 Thread Andrey Grodzovsky
On 2021-08-02 1:16 a.m., Guchun Chen wrote: In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence related failure will arrive after resume. To fix this and for a better clean up, move drm_sched_fini from fence_hw_fini to fence_sw_fini, as

Re: [PATCH v3 2/2] drm/amdkfd: fix KFDSVMRangeTest.PartialUnmapSysMemTest fails

2021-08-17 Thread Felix Kuehling
Am 2021-08-17 um 11:12 p.m. schrieb Yifan Zhang: > [ RUN ] KFDSVMRangeTest.PartialUnmapSysMemTest > /home/yifan/brahma/libhsakmt/tests/kfdtest/src/KFDTestUtil.cpp:245: Failure > Value of: (hsaKmtAllocMemory(m_Node, m_Size, m_Flags, &m_pBuf)) > Actual: 1 > Expected: HSAKMT_STATUS_SUCCESS > Wh

[PATCH v3 2/2] drm/amdkfd: fix KFDSVMRangeTest.PartialUnmapSysMemTest fails

2021-08-17 Thread Yifan Zhang
[ RUN ] KFDSVMRangeTest.PartialUnmapSysMemTest /home/yifan/brahma/libhsakmt/tests/kfdtest/src/KFDTestUtil.cpp:245: Failure Value of: (hsaKmtAllocMemory(m_Node, m_Size, m_Flags, &m_pBuf)) Actual: 1 Expected: HSAKMT_STATUS_SUCCESS Which is: 0 /home/yifan/brahma/libhsakmt/tests/kfdtest/src/KFDT

[PATCH v3 1/2] drm/amdkfd: export svm_range_list_lock_and_flush_work

2021-08-17 Thread Yifan Zhang
export svm_range_list_lock_and_flush_work to make other kfd parts be able to sync svm_range_list. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-17 Thread Mike Lothian
Hi I've just noticed something similar when starting weston, I still see it with this patch, but not on linus's tree I'll confirm for sure tomorrow and send the stack trace if I can save it Cheers Mike On Tue, 3 Aug 2021 at 02:56, Chen, Guchun wrote: > [Public] > > Hi Alex, > > I submitted t

Re: [PATCH v6 02/13] mm: remove extra ZONE_DEVICE struct page refcount

2021-08-17 Thread Felix Kuehling
Am 2021-08-17 um 8:01 p.m. schrieb Ralph Campbell: > On 8/12/21 11:31 PM, Alex Sierra wrote: >> From: Ralph Campbell >> >> ZONE_DEVICE struct pages have an extra reference count that >> complicates the >> code for put_page() and several places in the kernel that need to >> check the >> reference

Re: [PATCH v6 02/13] mm: remove extra ZONE_DEVICE struct page refcount

2021-08-17 Thread Ralph Campbell
On 8/12/21 11:31 PM, Alex Sierra wrote: From: Ralph Campbell ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need to check the reference count to see that a page is not being used (gup, compaction, migration,

Re: [PATCH][next] drm/amd/pm: Fix spelling mistake "firwmare" -> "firmware"

2021-08-17 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Aug 17, 2021 at 10:35 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a dev_err error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH v2 06/12] x86/sev: Replace occurrences of sev_active() with prot_guest_has()

2021-08-17 Thread Borislav Petkov
On Tue, Aug 17, 2021 at 10:26:18AM -0500, Tom Lendacky wrote: > >>/* > >> - * If SME is active we need to be sure that kexec pages are > >> - * not encrypted because when we boot to the new kernel the > >> + * If host memory encryption is active we need to be sure that kexec > >> + * pa

Re: [PATCH v2 05/12] x86/sme: Replace occurrences of sme_active() with prot_guest_has()

2021-08-17 Thread Borislav Petkov
On Tue, Aug 17, 2021 at 09:46:58AM -0500, Tom Lendacky wrote: > I'm ok with letting the TDX folks make changes to these calls to be SME or > SEV specific, if necessary, later. Yap, exactly. Let's add the specific stuff only when really needed. Thx. -- Regards/Gruss, Boris. https://people.k

Re: [PATCH v2 03/12] x86/sev: Add an x86 version of prot_guest_has()

2021-08-17 Thread Borislav Petkov
On Tue, Aug 17, 2021 at 10:22:52AM -0500, Tom Lendacky wrote: > I can change it to be an AMD/HYGON check... although, I'll have to check > to see if any (very) early use of the function will work with that. We can always change it later if really needed. It is just that I'm not a fan of such "pre

[PATCH][next] drm/amd/pm: Fix spelling mistake "firwmare" -> "firmware"

2021-08-17 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gp

[PATCH] drm/amdgpu: fix radv vulkan fps drop after s3 resume

2021-08-17 Thread Mohan Marimuthu, Yogesh
[Public] [Why] After s3, In radv there is huge fps drop in games. This is because when memory is allocated using radv_amdgpu_winsys_bo_create() with both AMDGPU_GEM_DOMAIN_VRAM and AMDGPU_GEM_DOMAIN_GTT domains set, the kernel memory management after resume fails to move the data back to VRAM. In

Re: [PATCH 2/2] drm/amdkfd: fix KFDSVMRangeTest.PartialUnmapSysMemTest fails

2021-08-17 Thread Felix Kuehling
Am 2021-08-17 um 5:17 a.m. schrieb Yifan Zhang: > [ RUN ] KFDSVMRangeTest.PartialUnmapSysMemTest > /home/yifan/brahma/libhsakmt/tests/kfdtest/src/KFDTestUtil.cpp:245: Failure > Value of: (hsaKmtAllocMemory(m_Node, m_Size, m_Flags, &m_pBuf)) > Actual: 1 > Expected: HSAKMT_STATUS_SUCCESS > Whi

[PATCH v2 6/6] drm/amd/display: Add DP 2.0 SST DC Support

2021-08-17 Thread Fangzhi Zuo
1. Retrieve 128/132b link cap. 2. 128/132b link training and payload allocation. 3. UHBR10 link rate support. Signed-off-by: Fangzhi Zuo --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c |6 + drivers/gpu/drm/amd/display/dc/core/dc.c | 17 + drivers/gpu/drm/amd/display/dc/core/dc_link

[PATCH v2 5/6] drm/amd/display: Add DP 2.0 BIOS and DMUB Support

2021-08-17 Thread Fangzhi Zuo
Parse DP2 encoder caps and hpo instance from bios Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c| 8 drivers/gpu/drm/amd/display/dc/bios/command_table2.c | 6 ++ .../gpu/drm/amd/display/dc/dcn30/dcn30_dio_link_encoder.c | 4 drive

[PATCH v2 4/6] drm/amd/display: Add DP 2.0 DCCG

2021-08-17 Thread Fangzhi Zuo
HW Blocks: ++ +-+ +--+ | OPTC | | HDA | | HUBP | ++ +-+ +--+ | || | || HPO |==|| | | v| | | +-+ |

[PATCH v2 3/6] drm/amd/display: Add DP 2.0 HPO Link Encoder

2021-08-17 Thread Fangzhi Zuo
HW Blocks: ++ +-+ +--+ | OPTC | | HDA | | HUBP | ++ +-+ +--+ | || | || HPO |==|| | | v| | | +-+ |

[PATCH v2 2/6] drm/amd/display: Add DP 2.0 HPO Stream Encoder

2021-08-17 Thread Fangzhi Zuo
HW Blocks: ++ +-+ +--+ | OPTC | | HDA | | HUBP | ++ +-+ +--+ | || | || HPO |==|| | | v| | | +-+ |

[PATCH v2 1/6] drm/amd/display: Add DP 2.0 Audio Package Generator

2021-08-17 Thread Fangzhi Zuo
HW Blocks: +-+ | HDA | +-+ | | HPO ===|= | v | +-+ | | APG | v +-+ Signe

[PATCH v2 0/6] Add DP 2.0 SST Support

2021-08-17 Thread Fangzhi Zuo
The patch series adds SST UHBR10 support Fangzhi Zuo (6): drm/amd/display: Add DP 2.0 Audio Package Generator drm/amd/display: Add DP 2.0 HPO Stream Encoder drm/amd/display: Add DP 2.0 HPO Link Encoder drm/amd/display: Add DP 2.0 DCCG drm/amd/display: Add DP 2.0 BIOS and DMUB Support d

Re: [PATCH] drm/amd/amdgpu:flush ttm delayed work before cancel_sync

2021-08-17 Thread Andrey Grodzovsky
Looks reasonable to me. Reviewed-by: Andrey Grodzovsky Andrey On 2021-08-17 5:50 a.m., YuBiao Wang wrote: [Why] In some cases when we unload driver, warning call trace will show up in vram_mgr_fini which claims that LRU is not empty, caused by the ttm bo inside delay deleted queue. [How] We

Re: [PATCH 2/6] drm/amd/display: Add DP 2.0 HPO Stream Encoder

2021-08-17 Thread Kazlauskas, Nicholas
On 2021-08-16 4:59 p.m., Fangzhi Zuo wrote: HW Blocks: ++ +-+ +--+ | OPTC | | HDA | | HUBP | ++ +-+ +--+ | || | || HPO |==|| | |

Re: [PATCH] drm/amdgpu: increase max xgmi physical node for aldebaran

2021-08-17 Thread Alex Deucher
Acked-by: Alex Deucher On Tue, Aug 17, 2021 at 12:30 AM Hawking Zhang wrote: > > aldebaran supports up to 16 xgmi physical nodes. > > Signed-off-by: Hawking Zhang > Reviewed-by: John Clements > --- > drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 dele

Re: [PATCH v6 08/13] mm: call pgmap->ops->page_free for DEVICE_GENERIC pages

2021-08-17 Thread Felix Kuehling
Am 2021-08-17 um 1:50 a.m. schrieb Christoph Hellwig: > On Mon, Aug 16, 2021 at 03:00:49PM -0400, Felix Kuehling wrote: >> Am 2021-08-15 um 11:40 a.m. schrieb Christoph Hellwig: >>> On Fri, Aug 13, 2021 at 01:31:45AM -0500, Alex Sierra wrote: Add MEMORY_DEVICE_GENERIC case to free_zone_device_

Re: [PATCH v2 09/12] mm: Remove the now unused mem_encrypt_active() function

2021-08-17 Thread Tom Lendacky
On 8/17/21 5:24 AM, Borislav Petkov wrote: > On Tue, Aug 17, 2021 at 12:22:33PM +0200, Borislav Petkov wrote: >> This one wants to be part of the previous patch. > > ... and the three following patches too - the treewide patch does a > single atomic :) replacement and that's it. Ok, I'll squash t

Re: [PATCH v2 06/12] x86/sev: Replace occurrences of sev_active() with prot_guest_has()

2021-08-17 Thread Tom Lendacky
On 8/17/21 5:02 AM, Borislav Petkov wrote: > On Fri, Aug 13, 2021 at 11:59:25AM -0500, Tom Lendacky wrote: >> diff --git a/arch/x86/kernel/machine_kexec_64.c >> b/arch/x86/kernel/machine_kexec_64.c >> index 8e7b517ad738..66ff788b79c9 100644 >> --- a/arch/x86/kernel/machine_kexec_64.c >> +++ b/arch

Re: [PATCH v2 03/12] x86/sev: Add an x86 version of prot_guest_has()

2021-08-17 Thread Tom Lendacky
On 8/15/21 9:39 AM, Borislav Petkov wrote: > On Sun, Aug 15, 2021 at 08:53:31AM -0500, Tom Lendacky wrote: >> It's not a cross-vendor thing as opposed to a KVM or other hypervisor >> thing where the family doesn't have to be reported as AMD or HYGON. > > What would be the use case? A HV starts a g

Re: [PATCH v2 05/12] x86/sme: Replace occurrences of sme_active() with prot_guest_has()

2021-08-17 Thread Tom Lendacky
On 8/17/21 4:00 AM, Borislav Petkov wrote: > On Fri, Aug 13, 2021 at 11:59:24AM -0500, Tom Lendacky wrote: >> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c >> index edc67ddf065d..5635ca9a1fbe 100644 >> --- a/arch/x86/mm/mem_encrypt.c >> +++ b/arch/x86/mm/mem_encrypt.c >> @@ -14

Re: [PATCH v2 04/12] powerpc/pseries/svm: Add a powerpc version of prot_guest_has()

2021-08-17 Thread Tom Lendacky
On 8/17/21 3:35 AM, Borislav Petkov wrote: > On Fri, Aug 13, 2021 at 11:59:23AM -0500, Tom Lendacky wrote: >> Introduce a powerpc version of the prot_guest_has() function. This will >> be used to replace the powerpc mem_encrypt_active() implementation, so >> the implementation will initially only s

Re: [PATCH] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-17 Thread Christian König
Am 17.08.21 um 15:37 schrieb Andrey Grodzovsky: On 2021-08-17 12:28 a.m., Jingwen Chen wrote: [Why] for bailing job, this commit will delete it from pending list thus the bailing job will never have a chance to be resubmitted even in advance tdr mode. [How] after embeded hw_fence into amdgpu

Re: [PATCH] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-17 Thread Andrey Grodzovsky
On 2021-08-17 12:28 a.m., Jingwen Chen wrote: [Why] for bailing job, this commit will delete it from pending list thus the bailing job will never have a chance to be resubmitted even in advance tdr mode. [How] after embeded hw_fence into amdgpu_job is done, the race condition that this commit tr

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 5:19 PM, Lazar, Lijo wrote: On 8/17/2021 4:36 PM, Michel Dänzer wrote: On 2021-08-17 12:37 p.m., Lazar, Lijo wrote: On 8/17/2021 3:29 PM, Michel Dänzer wrote: On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m

Re: [PATCH v2 09/12] mm: Remove the now unused mem_encrypt_active() function

2021-08-17 Thread Borislav Petkov
On Fri, Aug 13, 2021 at 11:59:28AM -0500, Tom Lendacky wrote: > The mem_encrypt_active() function has been replaced by prot_guest_has(), > so remove the implementation. > > Reviewed-by: Joerg Roedel > Signed-off-by: Tom Lendacky > --- > include/linux/mem_encrypt.h | 4 > 1 file changed, 4

Re: [PATCH v2 07/12] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

2021-08-17 Thread Borislav Petkov
On Fri, Aug 13, 2021 at 11:59:26AM -0500, Tom Lendacky wrote: > Replace occurrences of sev_es_active() with the more generic > prot_guest_has() using PATTR_GUEST_PROT_STATE, except for in > arch/x86/kernel/sev*.c and arch/x86/mm/mem_encrypt*.c where PATTR_SEV_ES > will be used. If future support is

Re: [PATCH v2 04/12] powerpc/pseries/svm: Add a powerpc version of prot_guest_has()

2021-08-17 Thread Borislav Petkov
On Fri, Aug 13, 2021 at 11:59:23AM -0500, Tom Lendacky wrote: > Introduce a powerpc version of the prot_guest_has() function. This will > be used to replace the powerpc mem_encrypt_active() implementation, so > the implementation will initially only support the PATTR_MEM_ENCRYPT > attribute. > > C

Re: [PATCH v2 06/12] x86/sev: Replace occurrences of sev_active() with prot_guest_has()

2021-08-17 Thread Borislav Petkov
On Fri, Aug 13, 2021 at 11:59:25AM -0500, Tom Lendacky wrote: > diff --git a/arch/x86/kernel/machine_kexec_64.c > b/arch/x86/kernel/machine_kexec_64.c > index 8e7b517ad738..66ff788b79c9 100644 > --- a/arch/x86/kernel/machine_kexec_64.c > +++ b/arch/x86/kernel/machine_kexec_64.c > @@ -167,7 +167,7

Re: [PATCH v2 05/12] x86/sme: Replace occurrences of sme_active() with prot_guest_has()

2021-08-17 Thread Borislav Petkov
On Fri, Aug 13, 2021 at 11:59:24AM -0500, Tom Lendacky wrote: > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c > index edc67ddf065d..5635ca9a1fbe 100644 > --- a/arch/x86/mm/mem_encrypt.c > +++ b/arch/x86/mm/mem_encrypt.c > @@ -144,7 +144,7 @@ void __init sme_unmap_bootdata(char

Re: [PATCH v2 04/12] powerpc/pseries/svm: Add a powerpc version of prot_guest_has()

2021-08-17 Thread Michael Ellerman
Tom Lendacky writes: > Introduce a powerpc version of the prot_guest_has() function. This will > be used to replace the powerpc mem_encrypt_active() implementation, so > the implementation will initially only support the PATTR_MEM_ENCRYPT > attribute. > > Cc: Michael Ellerman > Cc: Benjamin Herre

Re: [PATCH v2 09/12] mm: Remove the now unused mem_encrypt_active() function

2021-08-17 Thread Borislav Petkov
On Tue, Aug 17, 2021 at 12:22:33PM +0200, Borislav Petkov wrote: > This one wants to be part of the previous patch. ... and the three following patches too - the treewide patch does a single atomic :) replacement and that's it. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-a

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 4:36 PM, Michel Dänzer wrote: On 2021-08-17 12:37 p.m., Lazar, Lijo wrote: On 8/17/2021 3:29 PM, Michel Dänzer wrote: On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: On 8/17/2021 1:53 P

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
On 2021-08-17 12:37 p.m., Lazar, Lijo wrote: > > > On 8/17/2021 3:29 PM, Michel Dänzer wrote: >> On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: >>> >>> >>> On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: > > > On 8/17/2021 1:53 PM, Michel Dän

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 3:29 PM, Michel Dänzer wrote: On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: On 8/17/2021 1:53 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the

Re: [PATCH] drm/amdgpu: properly powergate Polaris12 UVD/VCE on suspend

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 3:13 PM, Quan, Evan wrote: [AMD Official Use Only] +Leo to share his insights -Original Message- From: Lazar, Lijo Sent: Tuesday, August 17, 2021 3:28 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Chen, Guchun ; Pan, Xinhui Subject: Re: [P

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
On 2021-08-17 11:37 a.m., Lazar, Lijo wrote: > > > On 8/17/2021 2:56 PM, Michel Dänzer wrote: >> On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: >>> >>> >>> On 8/17/2021 1:53 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was alre

[PATCH] drm/amd/amdgpu:flush ttm delayed work before cancel_sync

2021-08-17 Thread YuBiao Wang
[Why] In some cases when we unload driver, warning call trace will show up in vram_mgr_fini which claims that LRU is not empty, caused by the ttm bo inside delay deleted queue. [How] We should flush delayed work to make sure the delay deleting is done. Signed-off-by: YuBiao Wang --- drivers/gpu

RE: [PATCH] drm/amdgpu: properly powergate Polaris12 UVD/VCE on suspend

2021-08-17 Thread Quan, Evan
[AMD Official Use Only] +Leo to share his insights > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, August 17, 2021 3:28 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Chen, Guchun > ; Pan, Xinhui > Subject: Re: [PATCH] drm/amdgpu: properly power

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 2:56 PM, Michel Dänzer wrote: On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: On 8/17/2021 1:53 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms a

RE: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Quan, Evan
[AMD Official Use Only] Thanks! This seems fine to me. Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Michel Dänzer > Sent: Tuesday, August 17, 2021 4:23 PM > To: Deucher, Alexander ; Koenig, Christian > > Cc: Liu, Leo ; Zhu, James ; amd- > g...@lists.freede

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
On 2021-08-17 11:12 a.m., Lazar, Lijo wrote: > > > On 8/17/2021 1:53 PM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> schedule_delayed_work does not push back the work if it was already >> scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms >> after the first time GFXOFF was

RE: [PATCH] drm/amd: consolidate TA shared memory structures

2021-08-17 Thread Clements, John
[AMD Official Use Only] Reviewed-by: John Clements -Original Message- From: Li, Candice Sent: Tuesday, August 17, 2021 5:11 PM To: amd-gfx@lists.freedesktop.org Cc: Clements, John ; Li, Candice Subject: [PATCH] drm/amd: consolidate TA shared memory structures Change-Id: I81be5a824fce

[PATCH 2/2] drm/amdkfd: fix KFDSVMRangeTest.PartialUnmapSysMemTest fails

2021-08-17 Thread Yifan Zhang
[ RUN ] KFDSVMRangeTest.PartialUnmapSysMemTest /home/yifan/brahma/libhsakmt/tests/kfdtest/src/KFDTestUtil.cpp:245: Failure Value of: (hsaKmtAllocMemory(m_Node, m_Size, m_Flags, &m_pBuf)) Actual: 1 Expected: HSAKMT_STATUS_SUCCESS Which is: 0 /home/yifan/brahma/libhsakmt/tests/kfdtest/src/KFDT

[PATCH 1/2] drm/amdkfd: export svm_range_list_lock_and_flush_work

2021-08-17 Thread Yifan Zhang
export svm_range_list_lock_and_flush_work to make other kfd parts be able to sync svm_range_list. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

RE: [PATCH] drm/amdkfd: fix KFDSVMRangeTest.PartialUnmapSysMemTest fails

2021-08-17 Thread Zhang, Yifan
[AMD Official Use Only] Hi Felix, Thanks for comments. I will send Patch V2. BRs, Yifan -Original Message- From: Kuehling, Felix Sent: Tuesday, August 17, 2021 9:16 AM To: Zhang, Yifan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdkfd: fix KFDSVMRangeTest.PartialUnmapSy

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 1:53 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-e

[PATCH] drm/amd: consolidate TA shared memory structures

2021-08-17 Thread Candice Li
Change-Id: I81be5a824fced3d2244cf209444c2391f6bc6c50 Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 218 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 68 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c | 4 +- .../gpu/drm/amd/amdgpu/amd

Re: [PATCH v3] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
On 2021-08-17 10:17 a.m., Lazar, Lijo wrote: > On 8/17/2021 1:21 PM, Quan, Evan wrote: >>> -Original Message- >>> From: amd-gfx On Behalf Of >>> Michel Dänzer >>> Sent: Monday, August 16, 2021 6:35 PM >>> To: Deucher, Alexander ; Koenig, Christian >>> >>> Cc: Liu, Leo ; Zhu, James ; amd-

[PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Michel Dänzer
From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-enabled again during those 100 ms. This resulted

Re: [PATCH v3] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 1:21 PM, Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: amd-gfx On Behalf Of Michel Dänzer Sent: Monday, August 16, 2021 6:35 PM To: Deucher, Alexander ; Koenig, Christian Cc: Liu, Leo ; Zhu, James ; amd- g...@lists.freedesktop.org; dri-de...@list

RE: [PATCH v3] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-17 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: amd-gfx On Behalf Of > Michel Dänzer > Sent: Monday, August 16, 2021 6:35 PM > To: Deucher, Alexander ; Koenig, Christian > > Cc: Liu, Leo ; Zhu, James ; amd- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: [

Re: [PATCH] drm/amdgpu: properly powergate Polaris12 UVD/VCE on suspend

2021-08-17 Thread Lazar, Lijo
On 8/17/2021 12:10 PM, Evan Quan wrote: If the powergating of UVD/VCE is in process, wait for its completion before proceeding(suspending). This can fix some hangs observed on suspending when UVD/VCE still using(e.g. issue "pm-suspend" when video is still playing). Change-Id: I36f39d9731e0a96

Re: [PATCH v6 08/13] mm: call pgmap->ops->page_free for DEVICE_GENERIC pages

2021-08-17 Thread Christoph Hellwig
On Mon, Aug 16, 2021 at 03:00:49PM -0400, Felix Kuehling wrote: > > Am 2021-08-15 um 11:40 a.m. schrieb Christoph Hellwig: > > On Fri, Aug 13, 2021 at 01:31:45AM -0500, Alex Sierra wrote: > >> Add MEMORY_DEVICE_GENERIC case to free_zone_device_page callback. > >> Device generic type memory case is

Re: [PATCH v6 05/13] drm/amdkfd: generic type as sys mem on migration to ram

2021-08-17 Thread Christoph Hellwig
On Mon, Aug 16, 2021 at 02:53:18PM -0500, Sierra Guiza, Alejandro (Alex) wrote: > For above’s condition equal to connected_to_cpu , we’re explicitly > migrating from > device memory to system memory with device generic type. In this type, > device PTEs are > present in CPU page table. > > During

Re: [PATCH v6 04/13] drm/amdkfd: add SPM support for SVM

2021-08-17 Thread Christoph Hellwig
On Mon, Aug 16, 2021 at 02:54:30PM -0400, Felix Kuehling wrote: > I think you're right. We only need the start and end address from > lookup_resource and we already know that anyway. It means we can drop > patch 3 from the series. > > Just to be sure, we'll confirm that the end address determined