Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

On 8/13/21 12:08 PM, Tom Lendacky wrote: On 8/12/21 5:07 AM, Kirill A. Shutemov wrote: On Wed, Aug 11, 2021 at 10:52:55AM -0500, Tom Lendacky wrote: On 8/11/21 7:19 AM, Kirill A. Shutemov wrote: On Tue, Aug 10, 2021 at 02:48:54PM -0500, Tom Lendacky wrote: On 8/10/21 1:45 PM, Kuppuswamy, Sath

RE: [PATCH] drm/amd/display: Use DCN30 watermark calc for DCN301

[Public] > -Original Message- > From: Liu, Zhan > Sent: 2021/August/13, Friday 3:21 PM > To: amd-gfx@lists.freedesktop.org > Cc: Cornij, Nikola ; Liu, Zhan > ; Logush, Oliver > Subject: [PATCH] drm/amd/display: Use DCN30 watermark calc for DCN301 > > > [why] > dcn301_calculate_wm_and_dl(

[PATCH] drm/amd/display: Use DCN30 watermark calc for DCN301

[AMD Official Use Only] [why] dcn301_calculate_wm_and_dl() causes flickering when external monitor is connected. This issue has been fixed before by commit 0e4c0ae59d7e ("drm/amdgpu/display: drop dcn301_calculate_wm_and_dl for now"), however part of the fix was gone after commit 2cbcb78c9ee5 ("Me

Re: [PATCH v2 00/12] Implement generic prot_guest_has() helper function

On 8/13/21 11:59 AM, Tom Lendacky wrote: This patch series provides a generic helper function, prot_guest_has(), to replace the sme_active(), sev_active(), sev_es_active() and mem_encrypt_active() functions. It is expected that as new protected virtualization technologies are added to the kernel

Re: [PATCH v5 2/9] moduleparam: add data member to struct kernel_param

On Fri, Aug 13, 2021 at 9:44 AM Andy Shevchenko wrote: > > On Fri, Aug 13, 2021 at 09:17:10AM -0600, Jim Cromie wrote: > > Add a const void* data member to the struct, to allow attaching > > private data that will be used soon by a setter method (via kp->data) > > to perform more elaborate actions

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

On 8/12/21 5:07 AM, Kirill A. Shutemov wrote: On Wed, Aug 11, 2021 at 10:52:55AM -0500, Tom Lendacky wrote: On 8/11/21 7:19 AM, Kirill A. Shutemov wrote: On Tue, Aug 10, 2021 at 02:48:54PM -0500, Tom Lendacky wrote: On 8/10/21 1:45 PM, Kuppuswamy, Sathyanarayanan wrote: ... Looking at code a

[PATCH v2 12/12] s390/mm: Remove the now unused mem_encrypt_active() function

The mem_encrypt_active() function has been replaced by prot_guest_has(), so remove the implementation. Since the default implementation of the prot_guest_has() matches the s390 implementation of mem_encrypt_active(), prot_guest_has() does not need to be implemented in s390 (the config option ARCH_H

[PATCH v2 11/12] powerpc/pseries/svm: Remove the now unused mem_encrypt_active() function

The mem_encrypt_active() function has been replaced by prot_guest_has(), so remove the implementation. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Signed-off-by: Tom Lendacky --- arch/powerpc/include/asm/mem_encrypt.h | 5 - 1 file changed, 5 deletions(-) diff --gi

[PATCH v2 10/12] x86/sev: Remove the now unused mem_encrypt_active() function

The mem_encrypt_active() function has been replaced by prot_guest_has(), so remove the implementation. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Reviewed-by: Joerg Roedel Signed-off-by: Tom Lendacky --- arch/x86/include/asm/mem_encrypt.h | 5 - 1 file changed, 5 deletions(-

[PATCH v2 09/12] mm: Remove the now unused mem_encrypt_active() function

The mem_encrypt_active() function has been replaced by prot_guest_has(), so remove the implementation. Reviewed-by: Joerg Roedel Signed-off-by: Tom Lendacky --- include/linux/mem_encrypt.h | 4 1 file changed, 4 deletions(-) diff --git a/include/linux/mem_encrypt.h b/include/linux/mem_enc

[PATCH v2 08/12] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

Replace occurrences of mem_encrypt_active() with calls to prot_guest_has() with the PATTR_MEM_ENCRYPT attribute. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxi

[PATCH v2 07/12] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

Replace occurrences of sev_es_active() with the more generic prot_guest_has() using PATTR_GUEST_PROT_STATE, except for in arch/x86/kernel/sev*.c and arch/x86/mm/mem_encrypt*.c where PATTR_SEV_ES will be used. If future support is added for other memory encyrption techonologies, the use of PATTR_GUE

[PATCH v2 06/12] x86/sev: Replace occurrences of sev_active() with prot_guest_has()

Replace occurrences of sev_active() with the more generic prot_guest_has() using PATTR_GUEST_MEM_ENCRYPT, except for in arch/x86/mm/mem_encrypt*.c where PATTR_SEV will be used. If future support is added for other memory encryption technologies, the use of PATTR_GUEST_MEM_ENCRYPT can be updated, as

[PATCH v2 05/12] x86/sme: Replace occurrences of sme_active() with prot_guest_has()

Replace occurrences of sme_active() with the more generic prot_guest_has() using PATTR_HOST_MEM_ENCRYPT, except for in arch/x86/mm/mem_encrypt*.c where PATTR_SME will be used. If future support is added for other memory encryption technologies, the use of PATTR_HOST_MEM_ENCRYPT can be updated, as r

[PATCH v2 04/12] powerpc/pseries/svm: Add a powerpc version of prot_guest_has()

Introduce a powerpc version of the prot_guest_has() function. This will be used to replace the powerpc mem_encrypt_active() implementation, so the implementation will initially only support the PATTR_MEM_ENCRYPT attribute. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Signe

[PATCH v2 03/12] x86/sev: Add an x86 version of prot_guest_has()

Introduce an x86 version of the prot_guest_has() function. This will be used in the more generic x86 code to replace vendor specific calls like sev_active(), etc. While the name suggests this is intended mainly for guests, it will also be used for host memory encryption checks in place of sme_acti

[PATCH v2 02/12] mm: Introduce a function to check for virtualization protection features

In prep for other protected virtualization technologies, introduce a generic helper function, prot_guest_has(), that can be used to check for specific protection attributes, like memory encryption. This is intended to eliminate having to add multiple technology-specific checks to the code (e.g. if

[PATCH v2 01/12] x86/ioremap: Selectively build arch override encryption functions

In prep for other uses of the prot_guest_has() function besides AMD's memory encryption support, selectively build the AMD memory encryption architecture override functions only when CONFIG_AMD_MEM_ENCRYPT=y. These functions are: - early_memremap_pgprot_adjust() - arch_memremap_can_ram_remap() Add

[PATCH v2 00/12] Implement generic prot_guest_has() helper function

This patch series provides a generic helper function, prot_guest_has(), to replace the sme_active(), sev_active(), sev_es_active() and mem_encrypt_active() functions. It is expected that as new protected virtualization technologies are added to the kernel, they can all be covered by a single funct

[pull] amdgpu, amdkfd drm-next-5.15

Hi Dave, Daniel, Updates for 5.15. Mostly bug fixes and cleanups. The following changes since commit a43e2a0e11491b73e2acaa27ee74d6c3b86deac0: drm/amdkfd: Allow querying SVM attributes that are clear (2021-08-06 16:12:32 -0400) are available in the Git repository at: https://gitlab.freed

Re: [PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks

On Fri, Aug 13, 2021 at 06:51:05PM +0300, Andy Shevchenko wrote: > On Fri, Aug 13, 2021 at 09:17:11AM -0600, Jim Cromie wrote: > > +int param_set_dyndbg(const char *instr, const struct kernel_param *kp) > > +{ > > + unsigned long inbits; > > + int rc, i, chgct = 0, totct = 0; > > + char query

Re: [PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks

On Fri, Aug 13, 2021 at 09:17:11AM -0600, Jim Cromie wrote: > DEFINE_DYNAMIC_DEBUG_CATEGORIES(name, var, bitmap_desc, @bit_descs) > allows users to define a drm.debug style (bitmap) sysfs interface, and > to specify the desired mapping from bits[0-N] to the format-prefix'd > pr_debug()s to be contr

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

On 2021-08-13 5:07 p.m., Lazar, Lijo wrote: > > > On 8/13/2021 8:10 PM, Michel Dänzer wrote: >> On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: >>> On 8/13/2021 7:04 PM, Michel Dänzer wrote: On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: > On 8/13/2021 3:59 PM, Michel Dänzer wrote: >> From:

Re: [PATCH v5 2/9] moduleparam: add data member to struct kernel_param

On Fri, Aug 13, 2021 at 09:17:10AM -0600, Jim Cromie wrote: > Add a const void* data member to the struct, to allow attaching > private data that will be used soon by a setter method (via kp->data) > to perform more elaborate actions. > > To attach the data at compile time, add new macros: > > mo

[PATCH v5 9/9] dyndbg: RFC add tracer facility RFC

Sean Paul seanp...@chromium.org proposed, in https://patchwork.freedesktop.org/series/78133/ drm/trace: Mirror DRM debug logs to tracefs That patchset's goal is to be able to duplicate the debug stream to a tracing destination, by splitting drm_debug_enabled() into syslog & trace flavors, and enab

[PATCH v5 8/9] amdgpu_ucode: reduce number of pr_debug calls

There are blocks of DRM_DEBUG calls, consolidate their args into single calls. With dynamic-debug in use, each callsite consumes 56 bytes of ro callsite data, and this patch removes about 65 calls, so it saves ~3.5kb. no functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/amd/amd

[PATCH v5 7/9] drm_print: add choice to use dynamic debug in drm-debug

drm's debug system writes 10 distinct categories of messages to syslog using a small API[1]: drm_dbg*(10 names), DRM_DEBUG*(8 names), DRM_DEV_DEBUG*(3 names). There are thousands of these callsites, each categorized by their authors. These callsites can be enabled at runtime by their category, ea

[PATCH v5 6/9] amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized pr_debugs

logger_types.h defines many DC_LOG_*() categorized debug wrappers. Most of these use DRM debug API, so are controllable using drm.debug, but others use bare pr_debug("$prefix: .."), each with a different class-prefix matching "^\[\w+\]:" Use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create a /sys debug_d

[PATCH v5 5/9] i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories

The gvt component of this driver has ~120 pr_debugs, in 9 categories quite similar to those in DRM. Following the interface model of drm.debug, add a parameter to map bits to these categorizations. DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug, "dyndbg bitmap desc", { "gv

[PATCH v5 4/9] i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes

Taking embedded spaces out of existing prefixes makes them better class-prefixes; simplifying the nested quoting needed otherwise: $> echo "format '^gvt: core:' +p" >control Dropping the internal spaces means any trailing space in a query will more clearly terminate the prefix being searched fo

[PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks

DEFINE_DYNAMIC_DEBUG_CATEGORIES(name, var, bitmap_desc, @bit_descs) allows users to define a drm.debug style (bitmap) sysfs interface, and to specify the desired mapping from bits[0-N] to the format-prefix'd pr_debug()s to be controlled. DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug,

[PATCH v5 2/9] moduleparam: add data member to struct kernel_param

Add a const void* data member to the struct, to allow attaching private data that will be used soon by a setter method (via kp->data) to perform more elaborate actions. To attach the data at compile time, add new macros: module_param_cbd() derives from module_param_cb(), adding data param, and la

[PATCH v5 1/9] drm/print: fixup spelling in a comment

s/prink/printk/ - no functional changes Signed-off-by: Jim Cromie --- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 9b66be54dd16..15a089a87c22 100644 --- a/include/drm/drm_print.h +++ b/include/

[PATCH v5 0/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and use in DRM

hi Jason, Greg, Daniel, dri-everyone, drm_debug_enabled() is called a lot (by drm-debug api) to do unlikely bit-tests to selectively enable debug printing; this is a good job for DYNAMIC_DEBUG, IFF it is built with JUMP_LABEL. This patchset enables the use of dynamic-debug to avoid those drm_deb

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

On 8/13/2021 8:10 PM, Michel Dänzer wrote: On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: On 8/13/2021 7:04 PM, Michel Dänzer wrote: On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: On 8/13/2021 3:59 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work i

Re: [PATCH] drm: radeon: r600_dma: Replace cpu_to_le32() by lower_32_bits()

On 2021-08-13 10:54 a.m., zhaoxiao wrote: > This patch fixes the following sparse errors: > drivers/gpu/drm/radeon/r600_dma.c:247:30: warning: incorrect type in > assignment (different base types) > drivers/gpu/drm/radeon/r600_dma.c:247:30:expected unsigned int volatile > [usertype] > drivers

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: > On 8/13/2021 7:04 PM, Michel Dänzer wrote: >> On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: >>> On 8/13/2021 3:59 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already schedul

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

On 8/13/2021 7:04 PM, Michel Dänzer wrote: On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: On 8/13/2021 3:59 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms af

Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily

On Fri, Aug 13, 2021 at 9:54 AM Alex Deucher wrote: > > Acked-by: Alex Deucher > > On Fri, Aug 13, 2021 at 4:09 AM Evan Quan wrote: > > > > We have a S3 issue on that SKU with BACO enabled. Will bring back this > > when that root caused. > > Actually it might be worth checking the SSIDs as well

Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily

Acked-by: Alex Deucher On Fri, Aug 13, 2021 at 4:09 AM Evan Quan wrote: > > We have a S3 issue on that SKU with BACO enabled. Will bring back this > when that root caused. > > Change-Id: I56d4830e6275e20a415808896eecbadfe944070b > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/vi.

[PATCH] drm: radeon: r600_dma: Replace cpu_to_le32() by lower_32_bits()

This patch fixes the following sparse errors: drivers/gpu/drm/radeon/r600_dma.c:247:30: warning: incorrect type in assignment (different base types) drivers/gpu/drm/radeon/r600_dma.c:247:30:expected unsigned int volatile [usertype] drivers/gpu/drm/radeon/r600_dma.c:247:30:got restricted _

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: > > > On 8/13/2021 3:59 PM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> schedule_delayed_work does not push back the work if it was already >> scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms >> after the first time GFXOFF was

RE: [PATCH] drm/amd/amdgpu: remove unnecessary RAS context field

[Public] Reviewed-by: John Clements From: Li, Candice Sent: Friday, August 13, 2021 7:46 PM To: amd-gfx@lists.freedesktop.org Cc: Clements, John ; Li, Candice Subject: [PATCH] drm/amd/amdgpu: remove unnecessary RAS context field [Public] Delete ras_if->name in the RAS ctx structure and remo

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

On 8/13/2021 3:59 PM, Michel Dänzer wrote: From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-e

[PATCH] drm/amd/amdgpu: remove unnecessary RAS context field

[Public] Delete ras_if->name in the RAS ctx structure and remove related lines. Signed-off-by: Candice Li candice...@amd.com --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c | 1

Re: [PATCH 2/2] drm/amdgpu: Use mod_delayed_work in JPEG/UVD/VCE/VCN ring_end_use hooks

On 8/13/2021 4:01 PM, Michel Dänzer wrote: On 2021-08-13 6:23 a.m., Lazar, Lijo wrote: On 8/12/2021 10:24 PM, Michel Dänzer wrote: On 2021-08-12 1:33 p.m., Lazar, Lijo wrote: On 8/12/2021 1:41 PM, Michel Dänzer wrote: On 2021-08-12 7:55 a.m., Koenig, Christian wrote: Hi James, Evan see

Re: [PATCH 2/2] drm/amdgpu: Use mod_delayed_work in JPEG/UVD/VCE/VCN ring_end_use hooks

On 2021-08-13 6:23 a.m., Lazar, Lijo wrote: > > > On 8/12/2021 10:24 PM, Michel Dänzer wrote: >> On 2021-08-12 1:33 p.m., Lazar, Lijo wrote: >>> On 8/12/2021 1:41 PM, Michel Dänzer wrote: On 2021-08-12 7:55 a.m., Koenig, Christian wrote: > Hi James, > > Evan seems to have underst

[PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

From: Michel Dänzer schedule_delayed_work does not push back the work if it was already scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms after the first time GFXOFF was disabled and re-enabled, even if GFXOFF was disabled and re-enabled again during those 100 ms. This resulted

RE: [PATCH 2/2] drm/amd/pm: change the workload type for some cards

[AMD Official Use Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kenneth Feng Sent: Friday, August 13, 2021 16:48 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth Subject: [PATCH 2/2] drm/amd/pm: change the workload type for s

[PATCH 2/2] drm/amd/pm: change the workload type for some cards

change the workload type for some cards as it is needed. Signed-off-by: Kenneth Feng --- .../gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/

[PATCH 1/2] Revert "drm/amd/pm: fix workload mismatch on vega10"

This reverts commit 0979d43259e13846d86ba17e451e17fec185d240. Revert this because it does not apply to all the cards. Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/p

[PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily

We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused. Change-Id: I56d4830e6275e20a415808896eecbadfe944070b Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/dr

Re: [Mesa-dev] Requests For Proposals for hosting XDC 2022 are now open

Deadline is at the end of this month. Do not forget to submit your XDC 2022 hosting proposal! Sam On Thu, 2021-07-29 at 21:01 +0200, Samuel Iglesias Gonsálvez wrote: > Remember before enjoying your holiday that the deadline for XDC 2022 > proposals is *September 1st, 2021* :-) > > Feel free to s

[PATCH] drivers:gpu:drm:amd:amdgpu:fix a potential use-after-free

in line 1503, "dma_fence_put(fence);" drop the reference to fence and may cause fence to be released. However, fence is used subsequently in line 1510 "fence->error". This may result in an use-after-free bug. It can be fixed by recording fence->error in an variable before dropping the reference to