Re: Req: about Polaris with RKL platform

On Mon, Aug 9, 2021 at 9:37 AM Alex Deucher wrote: > On Mon, Aug 9, 2021 at 9:59 AM Koba Ko wrote: > > > > Previously, AMD had an issue about noise with AMD-DG on the RKL platform > > AMD provided a parameter. > > #modprobe amdgpu ppfeaturemask=0xfff7bffb > > > > I thought it's better to check

Re: Req: about Polaris with RKL platform

On Tue, Aug 10, 2021 at 12:45 PM Mario Limonciello wrote: > > > > On Mon, Aug 9, 2021 at 9:37 AM Alex Deucher wrote: >> >> On Mon, Aug 9, 2021 at 9:59 AM Koba Ko wrote: >> > >> > Previously, AMD had an issue about noise with AMD-DG on the RKL platform >> > AMD provided a parameter. >> > #modpro

Re: [PATCHv2 2/2] drm/amd/amdgpu: add tdr support for embeded hw_fence

On Mon Aug 09, 2021 at 12:24:37PM -0400, Andrey Grodzovsky wrote: > > On 2021-08-05 4:31 a.m., Jingwen Chen wrote: > > [Why] > > After embeded hw_fence to amdgpu_job, we need to add tdr support > > for this feature. > > > > [How] > > 1. Add a resubmit_flag for resubmit jobs. > > 2. Clear job fenc

[PATCH] drm/amdkfd: fix random KFDSVMRangeTest.SetGetAttributesTest test failure

KFDSVMRangeTest.SetGetAttributesTest randomly fails in stress test. Note: Google Test filter = KFDSVMRangeTest.* [==] Running 18 tests from 1 test case. [--] Global test environment set-up. [--] 18 tests from KFDSVMRangeTest [ RUN ] KFDSVMRangeTest.BasicSystemMemTest [

Re: [PATCH v2] drm/amdkfd: AIP mGPUs best prefetch location for xnack on

Am 2021-08-09 um 6:21 p.m. schrieb Philip Yang: > For xnack on, if range ACCESS or ACCESS_IN_PLACE (AIP) by single GPU, or > range is ACCESS_IN_PLACE by mGPUs and all mGPUs connection on xgmi same > hive, the best prefetch location is prefetch_loc GPU. Otherwise, the best > prefetch location is alw

[PATCH v4] drm/amd/amdgpu embed hw_fence into amdgpu_job

From: Jack Zhang Why: Previously hw fence is alloced separately with job. It caused historical lifetime issues and corner cases. The ideal situation is to take fence to manage both job and fence's lifetime, and simplify the design of gpu-scheduler. How: We propose to embed hw_fence into amdgpu_j

RE: [PATCH] drm/amdgpu: handle VCN instances when harvesting (v2)

[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, August 10, 2021 11:03 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhu, James Subject: [PATCH] drm/amdgpu: handle VCN instances when harvesting

[PATCH] drm/amdgpu: handle VCN instances when harvesting (v2)

There may be multiple instances and only one is harvested. v2: fix typo in commit message Fixes: 83a0b8639185 ("drm/amdgpu: add judgement when add ip blocks (v2)") Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1673 Reviewed-by: James Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/a

RE: [PATCH] drm/amdgpu: handle VCN instances when harvesting

[Public] A spelling typo in commit body. There may be multiple instances an only one is harvested. s/an/and Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, August 10, 2021 10:05 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhu

[PATCH] drm/amd/display: remove variable backlight

The variable backlight is being initialized with a value that is never read, it is being re-assigned immediately afterwards. Clean up the code by removing the need for variable backlight. Signed-off-by: zhaoxiao --- drivers/gpu/drm/amd/display/dc/dce/dce_abm.c | 6 ++ 1 file changed, 2 inser

Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

On 8/9/21 2:59 PM, Tom Lendacky wrote: Not sure how TDX will handle AP booting, are you sure it needs this special setup as well? Otherwise a check for SEV-ES would be better instead of the generic PATTR_GUEST_PROT_STATE. Yes, I'm not sure either. I figure that change can be made, if needed,

[PATCH] drm/amdgpu: handle VCN instances when harvesting

There may be multiple instances an only one is harvested. Fixes: 83a0b8639185 ("drm/amdgpu: add judgement when add ip blocks (v2)") Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1673 Reviewed-by: James Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 12

[PATCH v2] drm/amdkfd: AIP mGPUs best prefetch location for xnack on

For xnack on, if range ACCESS or ACCESS_IN_PLACE (AIP) by single GPU, or range is ACCESS_IN_PLACE by mGPUs and all mGPUs connection on xgmi same hive, the best prefetch location is prefetch_loc GPU. Otherwise, the best prefetch location is always CPU because GPU can not map vram of other GPUs throu

Re: [PATCH 00/11] Implement generic prot_guest_has() helper function

On 8/8/21 8:41 PM, Kuppuswamy, Sathyanarayanan wrote: > Hi Tom, > > On 7/27/21 3:26 PM, Tom Lendacky wrote: >> This patch series provides a generic helper function, prot_guest_has(), >> to replace the sme_active(), sev_active(), sev_es_active() and >> mem_encrypt_active() functions. >> >> It is ex

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

On 8/2/21 7:42 AM, Christophe Leroy wrote: > > > Le 28/07/2021 à 00:26, Tom Lendacky a écrit : >> Replace occurrences of mem_encrypt_active() with calls to prot_guest_has() >> with the PATTR_MEM_ENCRYPT attribute. > > > What about > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2

Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

On 8/2/21 5:45 AM, Joerg Roedel wrote: > On Tue, Jul 27, 2021 at 05:26:09PM -0500, Tom Lendacky wrote: >> @@ -48,7 +47,7 @@ static void sme_sev_setup_real_mode(struct >> trampoline_header *th) >> if (prot_guest_has(PATTR_HOST_MEM_ENCRYPT)) >> th->flags |= TH_FLAGS_SME_ACTIVE; >>

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

On 7/30/21 5:34 PM, Sean Christopherson wrote: > On Tue, Jul 27, 2021, Tom Lendacky wrote: >> @@ -451,7 +450,7 @@ void __init mem_encrypt_free_decrypted_mem(void) >> * The unused memory range was mapped decrypted, change the encryption >> * attribute from decrypted to encrypted before f

[PATCH] drm/amdkfd: CWSR with software scheduler

This patch adds support to program trap handler settings when loading driver with software scheduler (sched_policy=2). Signed-off-by: Mukul Joshi Suggested-by: Jay Cornwall --- .../drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c| 31 + .../drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10_3.c |

Re: [PATCH] drm/amdgpu: Removed unnecessary if statement

On Mon, Aug 9, 2021 at 9:59 AM Sergio Miguéns Iglesias wrote: > > There was an "if" statement that did nothing so it was removed. > > Signed-off-by: Sergio Miguéns Iglesias Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 --- > 1 file changed, 3 deletions(-) > > diff

Re: [PATCH 0/4] Replace usage of sprintf with sysfs_emit in hwmgr powerplay

On Sun, Aug 8, 2021 at 1:33 AM Darren Powell wrote: > > > === Description === > Replace usage of sprintf with sysfs_emit in hwmgr powerplay > > === Test System === > * DESKTOP(AMD FX-8350 + VEGA10(687F/c3), BIOS: F2) > + ISO(Ubuntu 20.04.2 LTS) > + Kernel(5.13.0-gb1d634be9673-fdoagd5f) > > > ===

Re: [PATCH v2 0/3] Replace usage of sprintf with sysfs_emit in swsmu powerplay

On Sun, Aug 8, 2021 at 1:30 AM Darren Powell wrote: > > > === Description === > Replace usage of sprintf with sysfs_emit in swsmu powerplay > > v2: rebased on 2f56b0d631eb > > === Test System === > * DESKTOP(AMD FX-8350 + NAVI10(731F/ca), BIOS: F2) > + ISO(Ubuntu 20.04.2 LTS) > + Kernel(5.13.0

Re: [PATCH] drm/amdgpu: fix kernel-doc warnings on non-kernel-doc comments

On Sat, Aug 7, 2021 at 7:38 PM Randy Dunlap wrote: > > Don't use "begin kernel-doc notation" (/**) for comments that are > not kernel-doc. This eliminates warnings reported by the 0day bot. > > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:89: warning: This comment starts with > '/**', but isn't a kern

Re: [PATCH] drm/amd/display: use do-while-0 for DC_TRACE_LEVEL_MESSAGE()

On Sun, Aug 8, 2021 at 10:52 PM Randy Dunlap wrote: > > Building with W=1 complains about an empty 'else' statement, so use the > usual do-nothing-while-0 loop to quieten this warning. > > ../drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:53: warning: > suggest braces around empty bo

Re: [PATCHv2 2/2] drm/amd/amdgpu: add tdr support for embeded hw_fence

On 2021-08-05 4:31 a.m., Jingwen Chen wrote: [Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature. [How] 1. Add a resubmit_flag for resubmit jobs. 2. Clear job fence from RCU and force complete vm flush fences in pre_asic_reset 3. skip dma_fence_get for r

Re: Req: about Polaris with RKL platform

On Mon, Aug 9, 2021 at 9:59 AM Koba Ko wrote: > > Previously, AMD had an issue about noise with AMD-DG on the RKL platform > AMD provided a parameter. > #modprobe amdgpu ppfeaturemask=0xfff7bffb > > I thought it's better to check and assign values in amd gpu. > Have a trouble determining the typ

Fwd: Req: about Polaris with RKL platform

Previously, AMD had an issue about noise with AMD-DG on the RKL platform AMD provided a parameter. #modprobe amdgpu ppfeaturemask=0xfff7bffb I thought it's better to check and assign values in amd gpu. Have a trouble determining the type of pch(RKL or else), search in amd drm driver and can't fi

Patch "drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled" has been added to the 5.13-stable tree

This is a note to let you know that I've just added the patch titled drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled to the 5.13-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

[PATCH] drm/amdgpu: Removed unnecessary if statement

There was an "if" statement that did nothing so it was removed. Signed-off-by: Sergio Miguéns Iglesias --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c index 09b048647

RE: [PATCH 00/13] DC Patches Aug 6, 2021

[Public] Hi all,   This week this patchset was tested on the following systems:   HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA)   AMD

Re: [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled

Hi, Thomas: Thomas Zimmermann 於 2021年6月25日 週五 下午4:22寫道： > > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in mediatek. > Acked-by: Chun-Kuang Hu > Signed-off-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > Acked-by: Daniel

RE: [PATCH] drm/amd/amdgpu: skip locking delayed work if not initialized.

[AMD Official Use Only] Reviewed-by: Emily.Deng >-Original Message- >From: amd-gfx On Behalf Of >YuBiao Wang >Sent: Thursday, August 5, 2021 10:38 AM >To: amd-gfx@lists.freedesktop.org >Cc: Grodzovsky, Andrey ; Quan, Evan >; Chen, Horace ; Tuikov, >Luben ; Koenig, Christian >; Deucher,

[PATCH] drm/amdgpu: Add MB_REQ_MSG_READY_TO_RESET response when VF get FLR notification.

From: Jiange Zhao When guest received FLR notification from host, it would lock adapter into reset state. There will be no more job submission and hardware access after that. Then it should send a response to host that it has prepared for host reset. Signed-off-by: Jiange Zhao Signed-off-by: P

Re: [PATCHv2 1/2] drm/amd/amdgpu embed hw_fence into amdgpu_job

On Mon Aug 09, 2021 at 10:18:37AM +0800, Jingwen Chen wrote: > On Fri Aug 06, 2021 at 11:48:04AM +0200, Christian König wrote: > > > > > > Am 06.08.21 um 07:52 schrieb Jingwen Chen: > > > On Thu Aug 05, 2021 at 05:13:22PM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-05 4:31 a.m., Jingwen Ch

[PATCH] drm/amd/display: use do-while-0 for DC_TRACE_LEVEL_MESSAGE()

Building with W=1 complains about an empty 'else' statement, so use the usual do-nothing-while-0 loop to quieten this warning. ../drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:53: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] 113 |

[PATCH] drm/amdgpu: fix kernel-doc warnings on non-kernel-doc comments

Don't use "begin kernel-doc notation" (/**) for comments that are not kernel-doc. This eliminates warnings reported by the 0day bot. drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:89: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

VA-API Regression in Kernel 5.13 for RX 6700 XT

Hi, I've encountered a bug as a user of Fedora, that's also mirrored by this Arch Linux bug report. The vast majority of VA-API hardware video decoders have disappeared for the RX 6700 XT GPU. It

Re: [PATCH 00/11] Implement generic prot_guest_has() helper function

Hi Tom, On 7/27/21 3:26 PM, Tom Lendacky wrote: This patch series provides a generic helper function, prot_guest_has(), to replace the sme_active(), sev_active(), sev_es_active() and mem_encrypt_active() functions. It is expected that as new protected virtualization technologies are added to th

[PATCH] drm/amd/display/dc/dce112/dce112_resource: Drop redundant null-pointer check in bw_calcs_data_update_from_pplib()

The variable dc->bw_vbios is guaranteed to be not NULL by its callers. Thus the null-pointer check can be dropped. Reported-by: TOTE Robot Signed-off-by: Tuo Li --- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver