Re: [PATCH 3/4] drm/amdkfd: report pcie bandwidth as number of lanes

2021-07-09 Thread Felix Kuehling
On 2021-06-21 3:23 p.m., Jonathan Kim wrote: Similar to xGMI reporting the min/max bandwidth as the number of links between peers, PCIe will report the min/max bandwidth as the number of supported lanes. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 24 +

Re: [PATCH 2/4] drm/amdkfd: report num xgmi links between direct peers to the kfd

2021-07-09 Thread Felix Kuehling
On 2021-06-21 3:23 p.m., Jonathan Kim wrote: Since Min/Max bandwidth was never used, it will repurposed to report the number of xgmi links between direct peers to the KFD topology. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 15 +++ drivers/gpu/d

[PATCH 1/1] drm/ttm: Fix COW check

2021-07-09 Thread Felix Kuehling
KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. is_cow_mapping returns true for these mappings. Add a check for vm_flags & VM_WRITE to avoid mmap failures on private read-only or PROT_NONE mappings. v2: protect against mprotect making a mapping writable after the fact Fixes: f91142

Re: [PATCH 2/2] drm/ttm: Fix COW check

2021-07-09 Thread Felix Kuehling
On 2021-07-09 3:37 p.m., Christian König wrote: Am 09.07.21 um 21:31 schrieb Felix Kuehling: On 2021-07-09 2:38 a.m., Christian König wrote: Am 08.07.21 um 21:36 schrieb Alex Deucher: From: Felix Kuehling KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. is_cow_mapping return

RE: [PATCH 4/4] drm/amdkfd: add direct link flag to link properties

2021-07-09 Thread Kasiviswanathan, Harish
[AMD Official Use Only] This series Acked-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Jonathan Kim Sent: Monday, June 21, 2021 3:24 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kim, Jonathan ; Zhang, Hawking Subject: [PATCH 4/4] drm/amdkfd: a

RE: [PATCH 00/12] DC Patches June 29, 2021

2021-07-09 Thread Wheeler, Daniel
[Public] Hi all and sorry for the delay,   This patchset was tested on the following systems:   HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to D

Re: [PATCH 2/2] drm/ttm: Fix COW check

2021-07-09 Thread Felix Kuehling
On 2021-07-09 2:38 a.m., Christian König wrote: Am 08.07.21 um 21:36 schrieb Alex Deucher: From: Felix Kuehling KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. is_cow_mapping returns true for these mappings. Add a check for vm_flags & VM_WRITE to avoid mmap failures on private

Re: [PATCH 2/2] drm/ttm: Fix COW check

2021-07-09 Thread Christian König
Am 09.07.21 um 21:31 schrieb Felix Kuehling: On 2021-07-09 2:38 a.m., Christian König wrote: Am 08.07.21 um 21:36 schrieb Alex Deucher: From: Felix Kuehling KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. is_cow_mapping returns true for these mappings. Add a check for vm_flag

RE: [PATCH] drm/amd/pm: Fix BACO state setting for Beige_Goby

2021-07-09 Thread Chen, Guchun
[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Chengming Gui Sent: Friday, July 9, 2021 4:29 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Chen, Jiansong (Simon) ; Chen, Guchun ; Feng, Kenneth ; Zhang, Hawking ; Gui, Jack Subject: [PATCH] drm/am

RE: [PATCH] drm/amd/pm: Fix BACO state setting for Beige_Goby

2021-07-09 Thread Chen, Jiansong (Simon)
[AMD Official Use Only] Reviewed-by: Jiansong Chen -Original Message- From: Chengming Gui Sent: Friday, July 9, 2021 4:29 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Chen, Jiansong (Simon) ; Chen, Guchun ; Feng, Kenneth ; Zhang, Hawking ; Gui, Jack Subject: [PATCH] drm/amd

[PATCH] drm/amdgpu: return error type when programing registers fails

2021-07-09 Thread Roy Sun
Signed-off-by: Roy Sun --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index bc4347a72301..af92c6f63dee 100644 --- a/drivers/gpu/

RE: [PATCH] drm/amdkfd: Only apply heavy-weight TLB flush on Aldebaran

2021-07-09 Thread Chen, Guchun
[Public] Original patch will cause regressions on Aldebaran as well, so this workaround is still invalid. Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Eric Huang Sent: Friday, July 9, 2021 3:54 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, JinHuiEric ; Kuehling, Feli

Re: [PATCH 2/2] drm/ttm: Fix COW check

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 8:38 AM Christian König wrote: > > > > Am 08.07.21 um 21:36 schrieb Alex Deucher: > > From: Felix Kuehling > > > > KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. > > is_cow_mapping returns true for these mappings. Add a check for > > vm_flags & VM_WRITE to a