[PATCH 1/2] drm/amd/pm: Add I2C quirk table to Aldebaran

2021-07-02 Thread Luben Tuikov
Add I2C quirk table to Aldebaran. Cc: Alexander Deucher Cc: Andrey Grodzovsky Cc: Lijo Lazar Cc: John Clements Cc: Hawking Zhang Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/am

[PATCH 2/2] drm/amdgpu: The I2C IP doesn't support 0 writes/reads

2021-07-02 Thread Luben Tuikov
The I2C IP doesn't support writes or reads of 0 bytes. In order for a START/STOP transaction to take place on the bus, the data written/read has to be at least one byte. That is, you cannot generate a write with 0 bytes, just to get the ACK from a device, just so you can probe that device if it i

[PATCH] drm/amdgpu: Return error if no RAS

2021-07-02 Thread Luben Tuikov
In amdgpu_ras_query_error_count() return an error if the device doesn't support RAS. This prevents that function from having to always set the values of the integer pointers (if set), and thus prevents function side effects--always to have to set values of integers if integer pointers set, regardle

Re: [PATCH] drm/amdgpu: initialize amdgpu_ras_query_error_count() error count parameters

2021-07-02 Thread Luben Tuikov
That's a good find, but I'd rather functions have no side effects. I'll follow up with a patch which correctly fixes this. Regards, Luben On 2021-07-02 3:52 p.m., t...@redhat.com wrote: > From: Tom Rix > > Static analysis reports this problem > amdgpu_ras.c:2324:2: warning: 2nd function call ar

Re: [PATCH 1/2] drm/amdgpu: use xarray for storing pasid in vm

2021-07-02 Thread Christian König
Am 02.07.21 um 11:25 schrieb Nirmoy Das: Replace idr with xarray as we actually need hash functionality. Cleanup code related to vm pasid by adding helper function. Signed-off-by: Nirmoy Das Acked-by: Felix Kuehling Reviewed-by: Christian König for the series. --- drivers/gpu/drm/amd/am

[PATCH 2/2] drm/amdgpu: separate out vm pasid assignment

2021-07-02 Thread Nirmoy Das
Use new helper function amdgpu_vm_set_pasid() to assign vm pasid value. This also ensures that we don't free a pasid from vm code as pasids are allocated somewhere else. Signed-off-by: Nirmoy Das Acked-by: Felix Kuehling --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 13 - drivers/

[PATCH 1/2] drm/amdgpu: use xarray for storing pasid in vm

2021-07-02 Thread Nirmoy Das
Replace idr with xarray as we actually need hash functionality. Cleanup code related to vm pasid by adding helper function. Signed-off-by: Nirmoy Das Acked-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 149 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 6

Re: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc

2021-07-02 Thread Das, Nirmoy
Please describe bit more with a commit message. On 7/1/2021 6:37 AM, Emily Deng wrote: Signed-off-by: Emily Deng Signed-off-by: Victor --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b

[PATCH v4] drm/amdgpu: Restore msix after FLR

2021-07-02 Thread Peng Ju Zhou
From: "Emily.Deng" After FLR, the msix will be cleared, so need to re-enable it. Signed-off-by: Emily.Deng Signed-off-by: Peng Ju Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/dri