Re: [PATCH 1/6] drm/amd/pm: Add ASIC independent throttle bits

2021-05-23 Thread Lijo Lazar
There are duplicates in this list. It's better to classify as Power/Temperature/Current/Others and map; maybe, allocate 16 bit each in a 64-bit mask. Also, keep the naming consistent and start with "SMU_", that's what we do for others like SMU messages. Power throttlers - #def

Re: [PATCH] drm/amdkfd: use resource cursor in svm_migrate_copy_to_vram

2021-05-23 Thread Christian König
Am 21.05.21 um 21:28 schrieb philip yang: This simply the logic, several comments inline. Thanks, Philip On 2021-05-21 9:52 a.m., Christian König wrote: Access to the mm_node is now forbidden. So instead of hand wiring that use the cursor functionality. Signed-off-by: Christian König ---

Re: [PATCH] drm/amdgpu: Fix a BUG_ON due to resv trylock fails

2021-05-23 Thread Christian König
Am 22.05.21 um 04:57 schrieb Felix Kuehling: When the BO gets individualized, there is an assumption that nobody is accessing it any more. See this comment in ttm_bo_individualize_resv: /* This works because the BO is about to be destroyed and nobody * referen

RE: [PATCH v5 09/10] drm/amdgpu: Use PSP to program IH_RB_CNTL* registers

2021-05-23 Thread Zhou, Peng Ju
[AMD Official Use Only - Internal Distribution Only] Hi Alex/Emily I noticed our team member have merged this patch, so discard this one. -- BW Pengju Zhou > -Original Message- > From: Deng, Emily > Sent: Friday, Ma