In SRIOV environment, KMD should access GC registers
with RLCG if GC indirect access flag enabled.
Change GC register access from MMIO to RLCG.
Signed-off-by: Peng Ju Zhou
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(
use psp to program IH_RB_CNTL* if indirect access
for ih enabled in SRIOV environment.
Signed-off-by: Victor
Signed-off-by: Peng Ju Zhou
---
drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 19 +--
drivers/gpu/drm/amd/amdgpu/nv.c| 2 +-
2 files changed, 18 insertions(+), 3 dele
In SRIOV environment, KMD should access GC registers
with RLCG if GC indirect access flag enabled.
Change GC register access from MMIO to RLCG.
Signed-off-by: Peng Ju Zhou
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 36
1 file changed, 18 insertions(+), 18 deletions(
In SRIOV environment, KMD should access GC registers
with RLCG if GC indirect access flag enabled.
Change GC register access from MMIO to RLCG.
Signed-off-by: Peng Ju Zhou
---
.../drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c| 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 4 +-
drivers/g
In SRIOV environment, KMD should access GC registers
with RLCG if GC indirect access flag enabled.
Change GC register access from MMIO to RLCG.
Signed-off-by: Peng Ju Zhou
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 38 ---
In SRIOV environment, KMD should access GC registers
with RLCG if GC indirect access flag enabled.
Change GC register access from MMIO to RLCG.
Signed-off-by: Peng Ju Zhou
---
drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 78 ++
1 file changed, 42 insertions(+), 36 deletions(
In SRIOV environment, KMD should access GC registers
with RLCG if GC indirect access flag enabled.
Change GC register access from MMIO to RLCG.
Signed-off-by: Peng Ju Zhou
---
.../drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c| 38 ++--
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 205 +
From: pengzhou
In SRIOV environment, KMD should access MMHUB registers
with RLCG if MMHUB indirect access bit enabled.
Change MMHUB register access from MMIO to RLCG.
Signed-off-by: pengzhou
---
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 12 ++--
drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 3
Hi Dave, Daniel,
Fixes for 5.12.
The following changes since commit 6fdb8e5aba6a33fe5f1a0bd1bcf0cf2884437ead:
Merge tag 'imx-drm-fixes-2021-04-01' of
git://git.pengutronix.de/git/pza/linux into drm-fixes (2021-04-02 04:53:16
+1000)
are available in the Git repository at:
https://gitlab.f
Hi
Am 07.04.21 um 21:49 schrieb Felix Kuehling:
On 2021-04-07 3:34 p.m., Felix Kuehling wrote:
On 2021-04-07 7:25 a.m., Christian König wrote:
+ /*
+ * Don't verify access for KFD BOs. They don't have a GEM
+ * object associated with them.
+ */
+ if (bo->kfd_bo)
+ goto
[AMD Public Use]
Reviewed-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Wednesday, April 7, 2021 9:39 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH] drm/amdgpu/smu7: fix CAC setting on TOPAZ
>
> We need to en
[AMD Public Use]
Reviewed-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of
> charles sun
> Sent: Thursday, April 8, 2021 11:42 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Su, Jinzhou (Joe)
> ; Liu, Zhan ; Sun, Charles
>
> Subject: [0001-increase-tim
when do S3 stress, low rate that PowerUpVcn message will get response
more than 1s, so here increase the timeout to 2s
Signed-off-by: Sun, Charles charles@amd.com
Acked-by: Deucher, Alexander alexander.deuc...@amd.com
---
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 2 +-
1 file changed, 1 insert
[AMD Official Use Only - Internal Distribution Only]
You wrote the patch, it should be signed-off-by you, not me 🙂 E.g.,
Signed-off-by: Charles Sun
From: Sun, Charles
Sent: Wednesday, April 7, 2021 11:32 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexan
when do S3 stress, low rate that PowerUpVcn message will get response
more than 1s, so here increase the timeout to 2s
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
This shortcut is no longer needed with access managed progerly by KFD.
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 936b
DRM allows access automatically when it creates a GEM handle for a BO.
KFD BOs don't have GEM handles, so KFD needs to manage access manually.
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 3 ++-
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 19
ROCm user mode has acquired VMs from DRM file descriptors for as long
as it supported the upstream KFD. Legacy code to support older versions
of ROCm is not needed any more.
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 4 --
.../gpu/drm/amd/amdgpu/amdgpu_amd
amdgpu_amdkfd_gpuvm_alloc_memory_of_gpu needs the drm_priv to allow mmap
to access the BO through the corresponding file descriptor.
Signed-off-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 14 ++--
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 69 +++
Our driver supports overlay planes, and as expected, some userspace
compositor takes advantage of these features. If the userspace is not
enabling the cursor, they can use multiple planes as they please.
Nevertheless, we start to have constraints when userspace tries to
enable hardware cursor with
On Tue, Apr 6, 2021 at 10:13 AM Carlis wrote:
>
> From: Xuezhi Zhang
>
> Fix the following coccicheck warning:
> drivers/gpu/drm/amd/pm//amdgpu_pm.c:1940:8-16:
> WARNING: use scnprintf or sprintf
> drivers/gpu/drm/amd/pm//amdgpu_pm.c:1978:8-16:
> WARNING: use scnprintf or sprintf
> drivers/gpu/dr
On 2021-04-07 3:34 p.m., Felix Kuehling wrote:
On 2021-04-07 7:25 a.m., Christian König wrote:
+ /*
+ * Don't verify access for KFD BOs. They don't have a GEM
+ * object associated with them.
+ */
+ if (bo->kfd_bo)
+ goto out;
Who does the access verification now?
This
On 2021-04-07 6:28 a.m., Christian König wrote:
Hi Andrey,
Am 06.04.21 um 23:22 schrieb Andrey Grodzovsky:
Hey Christian, Denis, see bellow -
On 2021-04-06 6:34 a.m., Christian König wrote:
Hi Andrey,
well good question. My job is to watch over the implementation and
design and while I al
On 2021-04-07 7:25 a.m., Christian König wrote:
+ /*
+ * Don't verify access for KFD BOs. They don't have a GEM
+ * object associated with them.
+ */
+ if (bo->kfd_bo)
+ goto out;
Who does the access verification now?
This is somewhat confusing.
I took this check as-is
On Wed, Apr 7, 2021 at 3:23 AM Dave Airlie wrote:
>
> On Wed, 7 Apr 2021 at 06:54, Alex Deucher wrote:
> >
> > On Fri, Apr 2, 2021 at 12:22 PM Christian König
> > wrote:
> > >
> > > Hey Alex,
> > >
> > > the TTM and scheduler changes should already be in the drm-misc-next
> > > branch (not 100%
On Wed, 7 Apr 2021 at 15:46, Christian König
wrote:
>
> What hardware are you using
$ inxi -bM
System:Host: fedora Kernel: 5.12.0-0.rc6.184.fc35.x86_64+debug
x86_64 bits: 64 Desktop: GNOME 40.0
Distro: Fedora release 35 (Rawhide)
Machine: Type: Desktop Mobo: ASUSTeK model: ROG ST
On 4/6/21 5:09 AM, Thomas Zimmermann wrote:
Vmwgfx is the only user of the TTM's verify_access callback. Inline
the call and avoid the indirection through the function pointer.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 -
drivers/gpu/drm/vmwg
On 4/6/21 5:09 AM, Thomas Zimmermann wrote:
The vmwgfx driver is the only remaining user of ttm_bo_mmap(). Inline
the code. The internal helper ttm_bo_vm_lookup() is now also part of
vmwgfx as vmw_bo_vm_lookup().
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c |
+ dri-devel since GPU scheduler is a shared component.
On Wed, Apr 7, 2021 at 9:31 AM Roy Sun wrote:
>
> Update the timestamp of scheduled fence on HW
> completion of the previous fences
>
> This allow more accurate tracking of the fence
> execution in HW
>
> Signed-off-by: David M Nieto
> Signe
On 2021-04-07 4:34 a.m., Jude Shih wrote:
[Why & How]
We use outbox interrupt that allows us to do the AUX via DMUB
Therefore, we need to add some irq source related definition
in the header files;
Signed-off-by: Jude Shih
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/amdgpu
Alex Deucher (1):
amdgpu: update marketing names
Alistair Delva (1):
xf86drm: fix null pointer deref in drmGetBufInfo
Ashutosh Dixit (1):
intel: Keep libdrm working without pread/pwrite ioctls
Emil Velikov (3):
xf86drm: cap number of reported devices by drmGetDevice(2)
Am 07.04.21 um 15:31 schrieb Roy Sun:
Tracking devices, process info and fence info using
/proc/pid/fdinfo
Signed-off-by: David M Nieto
Signed-off-by: Roy Sun
---
drivers/gpu/drm/amd/amdgpu/Makefile| 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
drivers/gpu/drm/amd/amd
Am 07.04.21 um 15:31 schrieb Roy Sun:
Update the timestamp of scheduled fence on HW
completion of the previous fences
This allow more accurate tracking of the fence
execution in HW
Signed-off-by: David M Nieto
Signed-off-by: Roy Sun
---
drivers/gpu/drm/scheduler/sched_main.c | 11
Am 07.04.21 um 15:04 schrieb xinhui pan:
ttm->num_pages is uint32. Hit overflow when << PAGE_SHIFT directly
Fix: 230c079fd (drm/ttm: make num_pages uint32_t)
Signed-off-by: xinhui pan
Reviewed-by: Christian König for the series.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 fil
We need to enable MC CAC for mclk switching to work.
Fixes: d765129a719f ("drm/amd/pm: correct sclk/mclk dpm enablement")
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1561
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 3 ++-
1 file changed, 2 inser
Update the timestamp of scheduled fence on HW
completion of the previous fences
This allow more accurate tracking of the fence
execution in HW
Signed-off-by: David M Nieto
Signed-off-by: Roy Sun
---
drivers/gpu/drm/scheduler/sched_main.c | 11 +--
1 file changed, 9 insertions(+), 2 del
Tracking devices, process info and fence info using
/proc/pid/fdinfo
Signed-off-by: David M Nieto
Signed-off-by: Roy Sun
---
drivers/gpu/drm/amd/amdgpu/Makefile| 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 5 +-
drivers/gpu/d
ttm->num_pages is uint32. Hit overflow when << PAGE_SHIFT directly
Signed-off-by: xinhui pan
---
drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c
b/drivers/gpu/drm/radeon/radeon_ttm.c
index 2a61cff325
ttm->num_pages is uint32. Hit overflow when << PAGE_SHIFT directly
Fix: 230c079fd (drm/ttm: make num_pages uint32_t)
Signed-off-by: xinhui pan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
We need this for radeon too.
On 4/7/21 2:00 PM, Christian König wrote:
Am 07.04.21 um 13:35 schrieb xinhui pan:
ttm->num_pages is uint32. Hit overflow when << PAGE_SHIFT directly
Fix: 230c079fd (drm/ttm: make num_pages uint32_t)
Signed-off-by: xinhui pan
---
drivers/gpu/drm/amd/amdgpu/amdg
Am 07.04.21 um 13:35 schrieb xinhui pan:
ttm->num_pages is uint32. Hit overflow when << PAGE_SHIFT directly
Fix: 230c079fd (drm/ttm: make num_pages uint32_t)
Signed-off-by: xinhui pan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
ttm->num_pages is uint32. Hit overflow when << PAGE_SHIFT directly
Fix: 230c079fd (drm/ttm: make num_pages uint32_t)
Signed-off-by: xinhui pan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
Hi,
Am 06.04.21 um 17:27 schrieb Felix Kuehling:
Am 2021-04-06 um 6:38 a.m. schrieb Thomas Zimmermann:
Hi
Am 06.04.21 um 11:35 schrieb Christian König:
Am 06.04.21 um 11:08 schrieb Thomas Zimmermann:
Moving the driver-specific mmap code into a GEM object function allows
for using DRM helpers
Am 06.04.21 um 16:11 schrieb Carlis:
From: Xuezhi Zhang
Fix the following coccicheck warning:
drivers/gpu/drm/amd/pm//amdgpu_pm.c:1940:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm//amdgpu_pm.c:1978:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/amd/pm//amdgpu_pm.c:202
What hardware are you using and how do you exactly trigger this?
Thanks,
Christian.
Am 07.04.21 um 11:30 schrieb Mikhail Gavrilov:
Hi!
During the 5.12 testing cycle I observed the repeatable bug when
launching heavy graphic applications.
The kernel log is flooded with the message "Unexpected mu
Yes, that was the one I was talking about.
Ok, good to know that this is fixed.
Regards,
Christian.
Am 07.04.21 um 10:50 schrieb Chen, Guchun:
[AMD Public Use]
Hi Felix and Christian,
If the regression you are talking about is the NULL pointer problem when
running KFD tests, it should fixed
Hi Andrey,
Am 06.04.21 um 23:22 schrieb Andrey Grodzovsky:
Hey Christian, Denis, see bellow -
On 2021-04-06 6:34 a.m., Christian König wrote:
Hi Andrey,
well good question. My job is to watch over the implementation and
design and while I always help I can adjust anybodies schedule.
Is th
Am 01.04.21 um 20:22 schrieb Alex Deucher:
On Thu, Apr 1, 2021 at 10:08 AM Smith John wrote:
Hi, when I killed an OpenCL host process, the kernels it launched were not
terminated, and still run.
My OpenCL runtime is AMDGPU-PRO 20.20. OS Ubuntu 18.04.5 with Linux Kernel
5.4.53
I was wond
Hi!
During the 5.12 testing cycle I observed the repeatable bug when
launching heavy graphic applications.
The kernel log is flooded with the message "Unexpected multihop in
swaput - likely driver bug.".
Trace:
[ 8707.814899] [ cut here ]
[ 8707.814920] Unexpected multihop
Am 07.04.21 um 09:47 schrieb Daniel Gomez:
On Tue, 6 Apr 2021 at 22:56, Alex Deucher wrote:
On Mon, Mar 22, 2021 at 6:34 AM Christian König
wrote:
Hi Daniel,
Am 22.03.21 um 10:38 schrieb Daniel Gomez:
On Fri, 19 Mar 2021 at 21:29, Felix Kuehling wrote:
This caused a regression in kfdtest
[AMD Public Use]
Hi Felix and Christian,
If the regression you are talking about is the NULL pointer problem when
running KFD tests, it should fixed by below patch in this series.
drm/amdgpu: fix NULL pointer dereference
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of C
[Why & How]
We use outbox interrupt that allows us to do the AUX via DMUB
Therefore, we need to add some irq source related definition
in the header files;
Signed-off-by: Jude Shih
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/include/ivsrcid/dcn/irqsrc
[AMD Public Use]
Reviewed-by: Evan Quan
> -Original Message-
> From: Du, Xiaojian
> Sent: Wednesday, April 7, 2021 4:26 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Huang, Ray ; Quan, Evan
> ; Wang, Kevin(Yang) ; Du,
> Xiaojian
> Subject: [PATCH] drm/amd/pm: add the callback to get vbi
This patch is to add the callback to get vbios bootup values for
vangogh, it will get the bootup values of gfxclk, mclk, socclk and so
on.
Signed-off-by: Xiaojian Du
---
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 1 +
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 1 +
2 files change
On Tue, 6 Apr 2021 at 22:56, Alex Deucher wrote:
>
> On Mon, Mar 22, 2021 at 6:34 AM Christian König
> wrote:
> >
> > Hi Daniel,
> >
> > Am 22.03.21 um 10:38 schrieb Daniel Gomez:
> > > On Fri, 19 Mar 2021 at 21:29, Felix Kuehling
> > > wrote:
> > >> This caused a regression in kfdtest in a lar
On Wed, 7 Apr 2021 at 06:54, Alex Deucher wrote:
>
> On Fri, Apr 2, 2021 at 12:22 PM Christian König
> wrote:
> >
> > Hey Alex,
> >
> > the TTM and scheduler changes should already be in the drm-misc-next
> > branch (not 100% sure about the TTM patch, need to double check next week).
> >
>
> The
From: Yingjie Wang
In radeon_dp_mst_detect(), We should check whether or not @connector
has been unregistered from userspace. If the connector is unregistered,
we should return disconnected status.
Fixes: 9843ead08f18 ("drm/radeon: add DisplayPort MST support (v2)")
Signed-off-by: Yingjie Wang
57 matches
Mail list logo