Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-02-07 Thread Daniel Vetter
On Mon, Feb 8, 2021 at 6:59 AM Andrey Grodzovsky wrote: > > > On 1/20/21 10:59 AM, Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 3:20 PM Andrey Grodzovsky > > wrote: > >> > >> On 1/20/21 4:05 AM, Daniel Vetter wrote: > >>> On Tue, Jan 19, 2021 at 01:18:15PM -0500, Andrey Grodzovsky wrote: > >>

Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-02-07 Thread Andrey Grodzovsky
On 1/20/21 10:59 AM, Daniel Vetter wrote: On Wed, Jan 20, 2021 at 3:20 PM Andrey Grodzovsky wrote: On 1/20/21 4:05 AM, Daniel Vetter wrote: On Tue, Jan 19, 2021 at 01:18:15PM -0500, Andrey Grodzovsky wrote: On 1/19/21 1:08 PM, Daniel Vetter wrote: On Tue, Jan 19, 2021 at 6:31 PM Andrey Gro

[PATCH] drm/amdgpu: extend MAX_KIQ_REG_TRY to 1000

2021-02-07 Thread Jiawei Gu
Extend retry times of KIQ to avoid starvation situation caused by long time full access of GPU by other VFs. Signed-off-by: Jiawei Gu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm

Re: [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal

2021-02-07 Thread Daniel Vetter
On Sun, Feb 7, 2021 at 10:28 PM Andrey Grodzovsky wrote: > > > > On 2/5/21 5:10 PM, Daniel Vetter wrote: > > On Fri, Feb 5, 2021 at 5:22 PM Andrey Grodzovsky > > wrote: > >> > >> Daniel, ping. Also, please refer to the other thread with Bjorn from > >> pci-dev > >> on the same topic I added you

Re: [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal

2021-02-07 Thread Andrey Grodzovsky
On 2/5/21 5:10 PM, Daniel Vetter wrote: On Fri, Feb 5, 2021 at 5:22 PM Andrey Grodzovsky wrote: Daniel, ping. Also, please refer to the other thread with Bjorn from pci-dev on the same topic I added you to. Summarizing my take over there for here plus maybe some more clarification. There's

RE: [PATCH] drm/amdgpu: fix CGTS_TCC_DISABLE register offset on gfx10.3

2021-02-07 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking From: amd-gfx On Behalf Of Marek Olšák Sent: Saturday, February 6, 2021 08:47 To: amd-gfx mailing list Subject: [PATCH] drm/amdgpu: fix CGTS_TCC_DISABLE register offset on gfx10.3 Please review. Thanks, Marek __

[PATCH] drm/amd/pm: Remove unnecessary conversion to bool

2021-02-07 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:907:47-52: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 2 +- 1 file changed, 1 ins

RE: [PATCH] drm/amdgpu: enable gpu recovery for dimgrey_cavefish

2021-02-07 Thread Chen, Jiansong (Simon)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Jiansong Chen -Original Message- From: Zhou1, Tao Sent: Sunday, February 7, 2021 4:52 PM To: Chen, Jiansong (Simon) ; Gui, Jack ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgp

Re: [PATCH] drm/amd/pm: Remove unnecessary conversion to bool

2021-02-07 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] if possible, please correct the same issue in navi10_ppt.c Reviewed-by: Kevin Wang Best Regards, Kevin From: Jiapeng Chong Sent: Sunday, February 7, 2021 4:49 PM To: Deucher, Alexander Cc: Koenig, Christian

[PATCH] drm/amdgpu: enable gpu recovery for dimgrey_cavefish

2021-02-07 Thread Tao Zhou
As dimgrey_cavefish driver is stable enough, set gpu recovery as default in HW hang for dimgrey_cavefish. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/a

Re: [PATCH 2/2] drm/amd/pm: add support for hwmon control of slow and fast PPT limit on vangogh

2021-02-07 Thread Huang Rui
On Fri, Feb 05, 2021 at 08:39:24PM +0800, Hou, Xiaomeng (Matthew) wrote: > Implement hwmon API for reading/setting slow and fast PPT limit. > > APU power is managed to system-level requirements through the PPT > (package power tracking) feature. PPT is intended to limit power to the > requirements