Re: [PATCH] drm/amd/pm: correct string parsing for extra separator characters case

On Thu, Jan 21, 2021 at 3:41 AM Evan Quan wrote: > > Supplement of previous fix "2d873f24dfaf drm/amdgpu/pm: Account for extra > separator characters in sysfs interface". > > Change-Id: Ie9e9a78ad8530ba4b46ea27e28559d5dcda5c033 > Signed-off-by: Evan Quan Acked-by: Alex Deucher > --- > drivers

RE: [PATCH 00/12] DC Patches Jan 22, 2021

[AMD Public Use] Disregard the tested by portion. Forgot to remove it from my email template, sorry for the confusion. To confirm, please do not apply this patch set. Thank you, Dan Wheeler Technologist  |  AMD SW Display O +(1) 905-882-2600 ext. 74665

RE: [PATCH 00/12] DC Patches Jan 22, 2021

[AMD Public Use] Hi all, This week I tested on an AMD Radeon RX 6800, and a HP Envy 360 with an AMD Ryzen 5 4500U APU. This week we are not recommending a promotion due to multiple visual impacts with MST. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist  |  AMD SW Display O +

Re: [PATCH 2/2] drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work

On 1/19/2021 4:29 PM, Grodzovsky, Andrey wrote: On 1/15/21 2:21 AM, Chen, Xiaogang wrote: On 1/14/2021 1:24 AM, Grodzovsky, Andrey wrote: On 1/14/21 12:11 AM, Chen, Xiaogang wrote: On 1/12/2021 10:54 PM, Grodzovsky, Andrey wrote: On 1/4/21 1:01 AM, Xiaogang.Chen wrote: From: Xiaogang Chen

[PATCH 08/12] drm/amd/display: Add more Clock Sources to DCN2.1

From: Sung Lee [WHY] When enabling HDMI on ComboPHY, there is not enough clock sources to complete display detection. [HOW] Initialize more clock sources. Signed-off-by: Sung Lee Reviewed-by: Tony Cheng Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 10 +++

[PATCH 09/12] drm/amd/display: [FW Promotion] Release 0.0.49

From: Anthony Koo - Add field for passing line time for a frame Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/d

[PATCH 07/12] drm/amd/display: correct some hdcp variable naming

From: Wenjing Liu [why] In HDCP update stream config interface, some variables are named as xxx_supported, but in fact the variable indicates whether or not xxx_enabled. Correct the naming so it is less confusing to read the code. Signed-off-by: Wenjing Liu Reviewed-by: George Shen Acked-by: A

[PATCH 11/12] drm/amd/display: fix calculation for the pwl backlight curve

From: Anthony Koo [Why] The PWL backlight curve is used by the firmware to convert between brightness and linear PWM value. Driver has a backlight LUT, but the firmware holds a PWL curve and interpolates between points. The calculations are incorrect leading to slightly off backlight values bein

[PATCH 05/12] drm/amd/display: reuse current context instead of recreating one

From: Bhawanpreet Lakha [Why] Currently we discard the current context and recreate it. The current context is what is applied to the HW so we should be re-using this rather than creating a new context. Recreating the context can lead to mismatch between new context and the current context For

[PATCH 02/12] drm/amd/display: Fix DPCD translation for LTTPR AUX_RD_INTERVAL

From: George Shen [Why] The translation between the DPCD value and the specified AUX_RD_INTERVAL in the DP spec do not match. [How] Update values to match the spec. Signed-off-by: George Shen Reviewed-by: Wenjing Liu Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

[PATCH 10/12] drm/amd/display: 3.2.120

From: Aric Cyr This DC update brings improvements in multiple areas. In summary, we highlight: - Fix display detection on HDMI ComboPHY - Drop SOC bounding box hookup - Fix DPCD values Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/d

[PATCH 01/12] drm/amd/display: Drop SOC bounding box hookup in DM/DC

From: Nicholas Kazlauskas [Why] There aren't any ASIC where we use these binaries and they aren't useful for future use since it's inconvenient to extend and maintain these structures. [How] Drop the support from DM and DC for now. Signed-off-by: Nicholas Kazlauskas Reviewed-by: Roman Li Acke

[PATCH 00/12] DC Patches Jan 22, 2021

This DC patchset brings improvements in multiple areas. In summary, we have: * Fix display detection on HDMI ComboPHY * FiX PWL backlight calculations * Drop SOC bounding box hookup * Fix DPCD values * Reverted a change that caused memory leak after sleep(S3) state on 4K HDMI displays Anthony K

[PATCH 12/12] drm/amd/display: revert "drm/amd/display: Fix EDID parsing after resume from suspend"

From: Stylon Wang This reverts commit b24bdc37d03a0478189e20a50286092840f414fa. It caused memory leak after S3 on 4K HDMI displays. Signed-off-by: Stylon Wang Reviewed-by: Rodrigo Siqueira Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 de

[PATCH 04/12] drm/amd/display: Add null pointer check to is_dig_enabled func

From: Michael Strauss [WHY] Safeguarding as pointer may be null in diagnostic environment Signed-off-by: Michael Strauss Reviewed-by: Sung Lee Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[PATCH 06/12] drm/amd/display: Set power gated default to true in seamless boot pipe

From: Lewis Huang [Why] OS sequence will cause this flag didn't clear. In seamless boot but without flip case. This flag didn't clear when reset path mode because the plane_state is null 1. OS call setting with clone/extended 2. Reset path mode to remove edp. [How] Set power gated default to tru

[PATCH 03/12] drm/amd/display: initialize i2c speed if not initialized in dcnxxx__resource.c

From: Brendan Steve Leder Some dcnxxx__resource.c do not initialize the i2c speed; this patch adds the required initialization at dc_construct(). Signed-off-by: Brendan Steve Leder Reviewed-by: Charlene Liu Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 1 file c

Re: [PATCH] drm/amd/display: 64-bit division on 32-bit arch issue

[AMD Public Use] Thanks for the fix. Reviewed-by: Bhawanpreet Lakha Thanks, Bhawan From: Yu, Lang Sent: January 22, 2021 7:35 AM To: Chen, Guchun ; Huang, Ray Cc: Deucher, Alexander ; Lakha, Bhawanpreet ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH]

[PATCH][next] drm/amdgpu: Fix masking binary not operator on two mask operations

From: Colin Ian King Currently the ! operator is incorrectly being used to flip bits on mask values. Fix this by using the bit-wise ~ operator instead. Addresses-Coverity: ("Logical vs. bitwise operator") Fixes: 3c9a7b7d6e75 ("drm/amdgpu: update mmhub mgcg&ls for mmhub_v2_3") Signed-off-by: Coli

Re: [PATCH] tests/amdgpu/vcn: clean abundant codes

Please open a libdrm MR for libdrm updates. Alex On Fri, Jan 22, 2021 at 10:05 AM Sonny Jiang wrote: > > Remove useless codes. > > Signed-off-by: Sonny Jiang > --- > tests/amdgpu/vcn_tests.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_t

Re: [PATCH 0/3] Experimental freesync video mode optimization

On Fri, Jan 22, 2021 at 4:43 AM Daniel Vetter wrote: > > On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > > On Tue, 19 Jan 2021 10:50:26 -0500 > > Aurabindo Pillai wrote: > > > > > Changes in V5 > > > = > > > > > > * More info in commit messages on the rationale of ch

Re: [PATCH] tests/amdgpu/vcn: clean abundant codes

Am 22.01.21 um 16:04 schrieb Sonny Jiang: Remove useless codes. Signed-off-by: Sonny Jiang Reviewed-by: Christian König --- tests/amdgpu/vcn_tests.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c index 0f5b4241..1ca66297 100644 -

[PATCH] tests/amdgpu/vcn: clean abundant codes

Remove useless codes. Signed-off-by: Sonny Jiang --- tests/amdgpu/vcn_tests.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c index 0f5b4241..1ca66297 100644 --- a/tests/amdgpu/vcn_tests.c +++ b/tests/amdgpu/vcn_tests.c @@ -102,8 +102,6 @@

RE: [PATCH] drm/amd/display: 64-bit division on 32-bit arch issue

[AMD Public Use] The header has been included by dm_services.h. The following is the sequence, dm_services.h -> dm_services_types.h -> os_types.h -> drm/drm_print.h -> linux/device.h -> linux/pm.h -> linux/timer.h -> linux/time.h -> linux/jiffies.h -> linux/math64.h Regards, Lang ---

Re: [PATCH 0/3] Experimental freesync video mode optimization

On Fri, Jan 22, 2021 at 10:42:53AM +0100, Daniel Vetter wrote: > On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > > On Tue, 19 Jan 2021 10:50:26 -0500 > > Aurabindo Pillai wrote: > > > > > Changes in V5 > > > = > > > > > > * More info in commit messages on the ration

Re: [PATCH 0/3] Experimental freesync video mode optimization

On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > On Tue, 19 Jan 2021 10:50:26 -0500 > Aurabindo Pillai wrote: > > > Changes in V5 > > = > > > > * More info in commit messages on the rationale of changes being added > > to the kernel. > > * Minor fixes > > Hi, > > t

RE: [PATCH] drm/amd/display: 64-bit division on 32-bit arch issue

[AMD Public Use] Maybe it's good to modify subject to " drm/amd/display: fix 64-bit division issue on 32-bit OS" And if header should be included? Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Huang Rui Sent: Friday, January 22, 2021 5:04 PM To: Yu, Lang Cc: Deucher,

Re: [PATCH] drm/amd/display: 64-bit division on 32-bit arch issue

On Fri, Jan 22, 2021 at 05:00:59PM +0800, Yu, Lang wrote: > Replace "/" with div_u64 for 32-bit arch. On 32-bit arch, > the use of "/" for 64-bit division will cause build error, > i.e. "__udivdi3/__divdi3 undefined!". > > Fixes: 27755cdf83f1 > drm/amd/display: Update dcn30_apply_idle_power_optimi

[PATCH] drm/amd/display: 64-bit division on 32-bit arch issue

Replace "/" with div_u64 for 32-bit arch. On 32-bit arch, the use of "/" for 64-bit division will cause build error, i.e. "__udivdi3/__divdi3 undefined!". Fixes: 27755cdf83f1 drm/amd/display: Update dcn30_apply_idle_power_optimizations() code Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/displ

Re: [PATCH 0/3] Experimental freesync video mode optimization

On Tue, 19 Jan 2021 10:50:26 -0500 Aurabindo Pillai wrote: > Changes in V5 > = > > * More info in commit messages on the rationale of changes being added > to the kernel. > * Minor fixes Hi, thank you for adding the explanations in the commit messages I asked for. It is now up to D