[PATCH] drm/amdgpu: Use PSP for IH programming on Navi SRIOV

2021-01-21 Thread Rohit Khaire
New policy will disable direct mmio access of this register on VF Signed-off-by: Rohit Khaire --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/gpu/drm/amd/amd

[PATCH v2 01/11] drm/atomic: Pass the full state to planes async atomic check and update

2021-01-21 Thread Maxime Ripard
The current atomic helpers have either their object state being passed as an argument or the full atomic state. The former is the pattern that was done at first, before switching to the latter for new hooks or when it was needed. Let's start convert all the remaining helpers to provide a consiste

[PATCH v2 02/11] drm: Rename plane atomic_check state names

2021-01-21 Thread Maxime Ripard
Most drivers call the argument to the plane atomic_check hook simply state, which is going to conflict with the global atomic state in a later rework. Let's rename it to new_plane_state (or new_state depending on the convention used in the driver). This was done using the coccinelle script below,

[PATCH v2 04/11] drm/atomic: Pass the full state to planes atomic_check

2021-01-21 Thread Maxime Ripard
The current atomic helpers have either their object state being passed as an argument or the full atomic state. The former is the pattern that was done at first, before switching to the latter for new hooks or when it was needed. Let's convert all the remaining helpers to provide a consistent int

[PATCH v2 05/11] drm: Use the state pointer directly in planes atomic_check

2021-01-21 Thread Maxime Ripard
Now that atomic_check takes the global atomic state as a parameter, we don't need to go through the pointer in the plane state. This was done using the following coccinelle script: @ plane_atomic_func @ identifier helpers; identifier func; @@ static struct drm_plane_helper_funcs helpers = {

Re: [PATCH 3/3] drm/amd/display: Skip modeset for front porch change

2021-01-21 Thread Kazlauskas, Nicholas
On 2021-01-19 10:50 a.m., Aurabindo Pillai wrote: [Why] A seamless transition between modes can be performed if the new incoming mode has the same timing parameters as the optimized mode on a display with a variable vtotal min/max. Smooth video playback usecases can be enabled with this seamless

Re: [PATCH] drm/amdgpu: race issue when jobs on 2 ring timeout

2021-01-21 Thread Andrey Grodzovsky
Looks good to me Reviewed-by: Andrey Grodzovsky Andrey On 1/21/21 5:21 AM, Horace Chen wrote: Fix a racing issue when jobs on 2 rings timeout simultaneously. If 2 rings timed out at the same time, the amdgpu_device_gpu_recover will be reentered. Then the adev->gmc.xgmi.head will be grabbed b

Re: [PATCH -stable] drm/amdgpu/display: drop DCN support for aarch64

2021-01-21 Thread Harry Wentland
On 2021-01-21 4:20 a.m., Ard Biesheuvel wrote: From: Alex Deucher commit c241ed2f0ea549c18cff62a3708b43846b84dae3 upstream. From Ard: "Simply disabling -mgeneral-regs-only left and right is risky, given that the standard AArch64 ABI permits the use of FP/SIMD registers anywhere, and GCC is k

Re: [PATCH v2] Revert "drm/amd/display: Tune min clk values for MPO for RV"

2021-01-21 Thread Harry Wentland
On 2021-01-20 11:51 p.m., Pratik Vishwakarma wrote: This reverts commit 6f3fca64cfb91fedf9b34ea27b2581e88d48c9b2. Original issue of flash line when MPO enabled on idle screen was fixed by raising clocks. This had negative effect of extra power being drained. With the upstream commit 9d03bb1020

[pull] amdgpu drm-fixes-5.11

2021-01-21 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.11. The following changes since commit c8f6364f35f32786dd40336cfa35b9166d91b8ab: Merge branch '04.00-ampere-lite-fixes' of git://github.com/skeggsb/linux into drm-fixes (2021-01-15 13:26:44 +1000) are available in the Git repository at: https://gitlab.freedesk

[PATCH 03/11] drm/vblank: Annotate with dma-fence signalling section

2021-01-21 Thread Daniel Vetter
This is rather overkill since currently all drivers call this from hardirq (or at least timers). But maybe in the future we're going to have thread irq handlers and what not, doesn't hurt to be prepared. Plus this is an easy start for sprinkling these fence annotations into shared code. Cc: linux-

[PATCH 02/11] drm/vkms: Annotate vblank timer

2021-01-21 Thread Daniel Vetter
This is needed to signal the fences from page flips, annotate it accordingly. We need to annotate entire timer callback since if we get stuck anywhere in there, then the timer stops, and hence fences stop. Just annotating the top part that does the vblank handling isn't enough. Tested-by: Melissa

[PATCH 01/11] drm/atomic-helper: Add dma-fence annotations

2021-01-21 Thread Daniel Vetter
This is a bit disappointing since we need to split the annotations over all the different parts. I was considering just leaking the critical section into the ->atomic_commit_tail callback of each driver. But that would mean we need to pass the fence_cookie into each driver (there's a total of 13 i

RE: [PATCH v2] Revert "drm/amd/display: Tune min clk values for MPO for RV"

2021-01-21 Thread Wu, Hersen
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Hersen Wu -Original Message- From: Vishwakarma, Pratik Sent: Wednesday, January 20, 2021 11:52 PM To: Wu, Hersen ; Wentland, Harry ; amd-gfx@lists.freedesktop.org Cc: Vishwakarma, Pratik Subject: [PATCH v2] Revert "d

Re: [PATCH -stable] drm/amdgpu/display: drop DCN support for aarch64

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 10:20:40AM +0100, Ard Biesheuvel wrote: > From: Alex Deucher > > commit c241ed2f0ea549c18cff62a3708b43846b84dae3 upstream. > > >From Ard: > > "Simply disabling -mgeneral-regs-only left and right is risky, given that > the standard AArch64 ABI permits the use of FP/SIMD r

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v3)

2021-01-21 Thread Steven Price
On 20/01/2021 20:09, Luben Tuikov wrote: This patch does not change current behaviour. The driver's job timeout handler now returns status indicating back to the DRM layer whether the device (GPU) is no longer available, such as after it's been unplugged, or whether all is normal, i.e. current b

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-21 Thread Christian König
I still have no idea what's going on here. The KASAN messages from the DC code are completely unrelated. Please add the full dmesg to your bug report. Christian. Am 20.01.21 um 01:59 schrieb Mikhail Gavrilov: On Fri, 15 Jan 2021 at 03:43, Mikhail Gavrilov wrote: In rc4, the number of warning

Re: [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device.

2021-01-21 Thread Daniel Vetter
On Wed, Jan 20, 2021 at 8:16 PM Andrey Grodzovsky wrote: > > > On 1/20/21 3:38 AM, Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 5:21 AM Andrey Grodzovsky > > wrote: > >> > >> On 1/19/21 5:01 PM, Daniel Vetter wrote: > >>> On Tue, Jan 19, 2021 at 10:22 PM Andrey Grodzovsky > >>> wrote: >

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v3)

2021-01-21 Thread Christian König
Am 20.01.21 um 21:09 schrieb Luben Tuikov: This patch does not change current behaviour. The driver's job timeout handler now returns status indicating back to the DRM layer whether the device (GPU) is no longer available, such as after it's been unplugged, or whether all is normal, i.e. current

Re: [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device.

2021-01-21 Thread Christian König
Am 20.01.21 um 20:38 schrieb Andrey Grodzovsky: Ping Andrey On 1/20/21 12:01 AM, Andrey Grodzovsky wrote: On 1/19/21 3:48 AM, Christian König wrote: Am 18.01.21 um 22:01 schrieb Andrey Grodzovsky: Handle all DMA IOMMU gropup related dependencies before the group is removed. Signed-off-by:

[PATCH -stable] drm/amdgpu/display: drop DCN support for aarch64

2021-01-21 Thread Ard Biesheuvel
From: Alex Deucher commit c241ed2f0ea549c18cff62a3708b43846b84dae3 upstream. >From Ard: "Simply disabling -mgeneral-regs-only left and right is risky, given that the standard AArch64 ABI permits the use of FP/SIMD registers anywhere, and GCC is known to use SIMD registers for spilling, and may

[PATCH] drm/amd/pm: correct string parsing for extra separator characters case

2021-01-21 Thread Evan Quan
Supplement of previous fix "2d873f24dfaf drm/amdgpu/pm: Account for extra separator characters in sysfs interface". Change-Id: Ie9e9a78ad8530ba4b46ea27e28559d5dcda5c033 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/g

Re: [PATCH 1/1] drm/amdgpu: Make contiguous pinning optional

2021-01-21 Thread Christian König
Am 21.01.21 um 06:08 schrieb Felix Kuehling: Enable pinning of VRAM without forcing it to be contiguous. When memory is already pinned, make sure it's contiguous if requested. Suggested-by: Christian König Signed-off-by: Felix Kuehling Reviewed-by: Christian König --- drivers/gpu/drm/am