RE: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds

2021-01-06 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Sorry, reply the wrong message. Reviewed-by: Emily.Deng >-Original Message- >From: amd-gfx On Behalf Of Deng, >Emily >Sent: Thursday, January 7, 2021 2:26 PM >To: Zhao, Victor ; amd-gfx@lists.freedesktop.org >Cc: Zhao, Victor >Subjec

RE: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds

2021-01-06 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan >-Original Message- >From: amd-gfx On Behalf Of Victor >Zhao >Sent: Tuesday, January 5, 2021 3:51 PM >To: amd-gfx@lists.freedesktop.org >Cc: Zhao, Victor >Subject: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cm

[PATCH v2] drm/amdgpu:Limit the resolution for virtual_display

2021-01-06 Thread Emily Deng
From: "Emily.Deng" Limit the resolution not bigger than 16384, which means dev->mode_info.num_crtc * common_modes[i].w not bigger than 16384. v2: Refine the code Signed-off-by: Emily.Deng --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(

Re: radeon kernel driver not suppressing ACPI_VIDEO_NOTIFY_PROBE events when it should

2021-01-06 Thread Hans de Goede
Hi, On 1/6/21 9:38 PM, Alex Deucher wrote: > On Wed, Jan 6, 2021 at 3:04 PM Hans de Goede wrote: >> >> Hi, >> >> On 1/6/21 8:33 PM, Alex Deucher wrote: >>> On Wed, Jan 6, 2021 at 1:10 PM Hans de Goede wrote: Hi, On 1/6/21 6:07 PM, Alex Deucher wrote: > On Wed, Jan 6, 2021

[PATCH 34/35] drm/amdkfd: add svm range validate timestamp

2021-01-06 Thread Felix Kuehling
From: Philip Yang With xnack on, add validate timestamp in order to handle GPU vm fault from multiple GPUs. If GPU retry fault need migrate the range to the best restore location, use range validate timestamp to record system timestamp after range is restored to update GPU page table. Because m

[PATCH 35/35] drm/amdkfd: multiple gpu migrate vram to vram

2021-01-06 Thread Felix Kuehling
From: Philip Yang If prefetch range to gpu with acutal location is another gpu, or GPU retry fault restore pages to migrate the range with acutal location is gpu, then migrate from one gpu to another gpu. Use system memory as bridge because sdma engine may not able to access another gpu vram, us

[PATCH 33/35] drm/amdkfd: refine migration policy with xnack on

2021-01-06 Thread Felix Kuehling
From: Philip Yang With xnack on, GPU vm fault handler decide the best restore location, then migrate range to the best restore location and update GPU mapping to recover the GPU vm fault. Signed-off-by: Philip Yang Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/

[PATCH 31/35] drm/amdgpu: reserve fence slot to update page table

2021-01-06 Thread Felix Kuehling
From: Philip Yang Forgot to reserve a fence slot to use sdma to update page table, cause below kernel BUG backtrace to handle vm retry fault while application is exiting. [ 133.048143] kernel BUG at /home/yangp/git/compute_staging/kernel/drivers/dma-buf/dma-resv.c:281! [ 133.048487] Workqueue

[PATCH 32/35] drm/amdgpu: enable retry fault wptr overflow

2021-01-06 Thread Felix Kuehling
From: Philip Yang If xnack is on, VM retry fault interrupt send to IH ring1, and ring1 will be full quickly. IH cannot receive other interrupts, this causes deadlock if migrating buffer using sdma and waiting for sdma done while handling retry fault. Remove VMC from IH storm client, enable ring1

[PATCH 30/35] drm/amdgpu: add svm_bo eviction to enable_signal cb

2021-01-06 Thread Felix Kuehling
From: Alex Sierra Add to amdgpu_amdkfd_fence.enable_signal callback, support for svm_bo fence eviction. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a

[PATCH 21/35] drm/amdkfd: HMM migrate ram to vram

2021-01-06 Thread Felix Kuehling
From: Philip Yang Register svm range with same address and size but perferred_location is changed from CPU to GPU or from GPU to CPU, trigger migration the svm range from ram to vram or from vram to ram. If svm range prefetch location is GPU with flags KFD_IOCTL_SVM_FLAG_HOST_ACCESS, validate th

[PATCH 23/35] drm/amdkfd: invalidate tables on page retry fault

2021-01-06 Thread Felix Kuehling
From: Alex Sierra GPU page tables are invalidated by unmapping prange directly at the mmu notifier, when page fault retry is enabled through amdgpu_noretry global parameter. The restore page table is performed at the page fault handler. If xnack is on, we need update GPU mapping after prefetch m

[PATCH 24/35] drm/amdkfd: page table restore through svm API

2021-01-06 Thread Felix Kuehling
From: Alex Sierra Page table restore implementation in SVM API. This is called from the fault handler at amdgpu_vm. To update page tables through the page fault retry IH. Signed-off-by: Alex Sierra Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_sv

[PATCH 27/35] drm/amdgpu: add param bit flag to create SVM BOs

2021-01-06 Thread Felix Kuehling
From: Alex Sierra Add CREATE_SVM_BO define bit for SVM BOs. Another define flag was moved to concentrate these KFD type flags in one include file. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 7 ++- drivers/gpu/drm/amd/amd

[PATCH 29/35] drm/amdgpu: svm bo enable_signal call condition

2021-01-06 Thread Felix Kuehling
From: Alex Sierra [why] To support svm bo eviction mechanism. [how] If the BO crated has AMDGPU_AMDKFD_CREATE_SVM_BO flag set, enable_signal callback will be called inside amdgpu_evict_flags. This also causes gutting of the BO by removing all placements, so that TTM won't actually do an eviction

[PATCH 28/35] drm/amdkfd: add svm_bo eviction mechanism support

2021-01-06 Thread Felix Kuehling
From: Alex Sierra svm_bo eviction mechanism is different from regular BOs. Every SVM_BO created contains one eviction fence and one worker item for eviction process. SVM_BOs can be attached to one or more pranges. For SVM_BO eviction mechanism, TTM will start to call enable_signal callback for ev

[PATCH 26/35] drm/amdkfd: add svm_bo reference for eviction fence

2021-01-06 Thread Felix Kuehling
From: Alex Sierra [why] As part of the SVM functionality, the eviction mechanism used for SVM_BOs is different. This mechanism uses one eviction fence per prange, instead of one fence per kfd_process. [how] A svm_bo reference to amdgpu_amdkfd_fence to allow differentiate between SVM_BO or regula

[PATCH 25/35] drm/amdkfd: SVM API call to restore page tables

2021-01-06 Thread Felix Kuehling
From: Alex Sierra Use SVM API to restore page tables when retry fault and compute context are enabled. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/

[PATCH 22/35] drm/amdkfd: HMM migrate vram to ram

2021-01-06 Thread Felix Kuehling
From: Philip Yang If CPU page fault happens, HMM pgmap_ops callback migrate_to_ram start migrate memory from vram to ram in steps: 1. migrate_vma_pages get vram pages, and notify HMM to invalidate the pages, HMM interval notifier callback evict process queues 2. Allocate system memory pages 3. U

[PATCH 19/35] drm/amdkfd: support xgmi same hive mapping

2021-01-06 Thread Felix Kuehling
From: Philip Yang amdgpu_gmc_get_vm_pte use bo_va->is_xgmi same hive information to set pte flags to update GPU mapping. Add local structure variable bo_va, and update bo_va.is_xgmi, pass it to mapping->bo_va while mapping to GPU. Assuming xgmi pstate is hi after boot. Signed-off-by: Philip Yan

[PATCH 18/35] drm/amdkfd: validate vram svm range from TTM

2021-01-06 Thread Felix Kuehling
From: Philip Yang If svm range perfetch location is not zero, use TTM to alloc amdgpu_bo vram nodes to validate svm range, then map vram nodes to GPUs. Use offset to sub allocate from the same amdgpu_bo to handle overlap vram range while adding new range or unmapping range. svm_bo has ref count

[PATCH 15/35] drm/amdkfd: add xnack enabled flag to kfd_process

2021-01-06 Thread Felix Kuehling
From: Alex Sierra This flag is useful at cpu invalidation page table decision. Between select queue eviction or page fault. Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 4 +++ drivers/gpu/drm/amd/amdkfd/kfd_process.c | 36 +++

[PATCH 17/35] drm/amdkfd: register HMM device private zone

2021-01-06 Thread Felix Kuehling
From: Philip Yang Register vram memory as MEMORY_DEVICE_PRIVATE type resource, to allocate vram backing pages for page migration. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 + drivers/gpu/drm/amd/amdkfd/Makefile| 3 +

[PATCH 20/35] drm/amdkfd: copy memory through gart table

2021-01-06 Thread Felix Kuehling
From: Philip Yang Use sdma linear copy to migrate data between ram and vram. The sdma linear copy command uses kernel buffer function queue to access system memory through gart table. Use reserved gart table window 0 to map system page address, and vram page address is direct mapping. Use the sa

[PATCH 14/35] drm/amdkfd: svm range eviction and restore

2021-01-06 Thread Felix Kuehling
From: Philip Yang HMM interval notifier callback notify CPU page table will be updated, stop process queues if the updated address belongs to svm range registered in process svms objects tree. Scheduled restore work to update GPU page table using new pages address in the updated svm range. svm r

[PATCH 16/35] drm/amdkfd: add ioctl to configure and query xnack retries

2021-01-06 Thread Felix Kuehling
From: Alex Sierra Xnack retries are used for page fault recovery. Some AMD chip families support continuously retry while page table entries are invalid. The driver must handle the page fault interrupt and fill in a valid entry for the GPU to continue. This ioctl allows to enable/disable XNACK r

[PATCH 13/35] drm/amdkfd: map svm range to GPUs

2021-01-06 Thread Felix Kuehling
From: Philip Yang Use amdgpu_vm_bo_update_mapping to update GPU page table to map or unmap svm range system memory pages address to GPUs. Signed-off-by: Philip Yang Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 232 +++

[PATCH 11/35] drm/amdkfd: deregister svm range

2021-01-06 Thread Felix Kuehling
From: Philip Yang When application explicitly call unmap or unmap from mmput when application exit, driver will receive MMU_NOTIFY_UNMAP event to remove svm range from process svms object tree and list first, unmap from GPUs (in the following patch). Split the svm ranges to handle unmap partial

[PATCH 12/35] drm/amdgpu: export vm update mapping interface

2021-01-06 Thread Felix Kuehling
From: Philip Yang It will be used by kfd to map svm range to GPU, because svm range does not have amdgpu_bo and bo_va, cannot use amdgpu_bo_update interface, use amdgpu vm update interface directly. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 07/35] drm/amdkfd: add svm ioctl GET_ATTR op

2021-01-06 Thread Felix Kuehling
From: Philip Yang Get the intersection of attributes over all memory in the given range Signed-off-by: Philip Yang Signed-off-by: Alex Sierra Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 175 ++- 1 file changed, 173 insertions(+), 2 deletio

[PATCH 10/35] drm/amdkfd: register overlap system memory range

2021-01-06 Thread Felix Kuehling
From: Philip Yang No overlap range interval [start, last] exist in svms object interval tree. If process registers new range which has overlap with old range, the old range split into 2 ranges depending on the overlap happens at head or tail part of old range. Signed-off-by: Philip Yang Signed-

[PATCH 09/35] drm/amdkfd: validate svm range system memory

2021-01-06 Thread Felix Kuehling
From: Philip Yang Use HMM to get system memory pages address, which will be used to map to GPUs or migrate to vram. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 88 +++

[PATCH 08/35] drm/amdgpu: add common HMM get pages function

2021-01-06 Thread Felix Kuehling
From: Philip Yang Move the HMM get pages function from amdgpu_ttm and to amdgpu_mn. This common function will be used by new svm APIs. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 83 + drivers/gpu/drm/amd/amdgp

[PATCH 03/35] drm/amdkfd: helper to convert gpu id and idx

2021-01-06 Thread Felix Kuehling
From: Alex Sierra svm range uses gpu bitmap to store which GPU svm range maps to. Application pass driver gpu id to specify GPU, the helper is needed to convert gpu id to gpu bitmap idx. Access through kfd_process_device pointers array from kfd_process. Signed-off-by: Alex Sierra Signed-off-by

[PATCH 06/35] drm/amdkfd: register svm range

2021-01-06 Thread Felix Kuehling
From: Philip Yang svm range structure stores the range start address, size, attributes, flags, prefetch location and gpu bitmap which indicates which GPU this range maps to. Same virtual address is shared by CPU and GPUs. Process has svm range list which uses both interval tree and list to store

[PATCH 05/35] drm/amdkfd: Add SVM API support capability bits

2021-01-06 Thread Felix Kuehling
From: Philip Yang SVMAPISupported property added to HSA_CAPABILITY, the value match HSA_CAPABILITY defined in Thunk spec: SVMAPISupported: it will not be supported on older kernels that don't have HMM or on GFXv8 or older GPUs without support for 48-bit virtual addresses. CoherentHostAccess pro

[PATCH 04/35] drm/amdkfd: add svm ioctl API

2021-01-06 Thread Felix Kuehling
From: Philip Yang Add svm (shared virtual memory) ioctl data structure and API definition. The svm ioctl API is designed to be extensible in the future. All operations are provided by a single IOCTL to preserve ioctl number space. The arguments structure ends with a variable size array of attrib

[PATCH 02/35] drm/amdgpu: replace per_device_list by array

2021-01-06 Thread Felix Kuehling
From: Alex Sierra Remove per_device_list from kfd_process and replace it with a kfd_process_device pointers array of MAX_GPU_INSTANCES size. This helps to manage the kfd_process_devices binded to a specific kfd_process. Also, functions used by kfd_chardev to iterate over the list were removed, si

[PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-06 Thread Felix Kuehling
This is the first version of our HMM based shared virtual memory manager for KFD. There are still a number of known issues that we're working through (see below). This will likely lead to some pretty significant changes in MMU notifier handling and locking on the migration code paths. So don't get

[PATCH 01/35] drm/amdkfd: select kernel DEVICE_PRIVATE option

2021-01-06 Thread Felix Kuehling
From: Philip Yang DEVICE_PRIVATE kernel config option is required for HMM page migration, to register vram (GPU device memory) as DEVICE_PRIVATE zone memory. Enabling this option recompiles kernel. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/Kconfig

RE: [PATCH 2/3] drm/amdgpu: Correct the read sclk for navi10

2021-01-06 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] Hello Emily, The average clock value is a little different from the 'current clock' value. May I know what's the purpose of this patch to display the average clock? Any issue or any customer requirement? Thanks. Best Regards Kenneth -Ori

[PATCH v2] drm/amdgpu: Decrease compute timeout to 10 s for sriov multiple VF

2021-01-06 Thread Emily Deng
From: "Emily.Deng" For multiple VF, after engine hang,as host driver will first encounter FLR, so has no meanning to set compute to 60s. v2: Refine the patch and comment Signed-off-by: Emily.Deng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 - 1 file changed, 4 insertions(+), 1 d

[PATCH] drm/amdgpu: Decrease compute timeout to 10 s for sriov multiple VF

2021-01-06 Thread Emily Deng
From: "Emily.Deng" For multiple VF, after engine hang,as host driver will first encounter FLR, so has no meanning to set compute to 60s. Signed-off-by: Emily.Deng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/

RE: [PATCH 2/3] drm/amdgpu: Correct the read sclk for navi10

2021-01-06 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Emily.Deng Sent: Wednesday, January 6, 2021 9:05 AM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: [PATCH 2/3] drm/amdgpu: Correct the read sclk for nav

RE: [PATCH] drm/amdgpu: For sriov multiple VF, set compute timeout to 10s

2021-01-06 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] >-Original Message- >From: Paul Menzel >Sent: Wednesday, January 6, 2021 8:54 PM >To: Deng, Emily >Cc: amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH] drm/amdgpu: For sriov multiple VF, set compute timeout >to 10s > >Dear Emily, >

RE: [PATCH 3/3] drm/amdgpu:Limit the resolution for virtual_display

2021-01-06 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] >-Original Message- >From: Michel Dänzer >Sent: Wednesday, January 6, 2021 11:25 PM >To: Deng, Emily ; Alex Deucher > >Cc: amd-gfx list >Subject: Re: [PATCH 3/3] drm/amdgpu:Limit the resolution for virtual_display > >On 2021-01-06 11:4

RE: [PATCH] drm/amd/pm: add swsmu init documentation

2021-01-06 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Ryan Taylor Sent: Thursday, January 7, 2021 7:45 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Taylor, Ryan Subject: [PATCH] drm/amd/pm: add swsmu

[PATCH] drm/amd/pm: add swsmu init documentation

2021-01-06 Thread Ryan Taylor
Documents functions used in swsmu initialization. Signed-off-by: Ryan Taylor Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 94 ++- 1 file changed, 93 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/g

[pull] amdgpu drm-fixes-5.11

2021-01-06 Thread Alex Deucher
Hi Dave, Daniel, New URL. FDO ran out of disk space, so I'm attempting to move to gitlab. Let me know if you run into any issues. Thanks The following changes since commit 5b2fc08c455bbf749489254a81baeffdf4c0a693: Merge tag 'amd-drm-fixes-5.11-2020-12-23' of git://people.freedesktop.org/~ag

Re: Couple of issues with amdgpu on my WX4100

2021-01-06 Thread Maxim Levitsky
On Mon, 2021-01-04 at 12:34 +0100, Christian König wrote: > Hi Maxim, > > I can't help with the display related stuff. Probably best approach to get > this fixes would be to open up a bug tracker for this on FDO. Done, bugs are opened https://gitlab.freedesktop.org/drm/amd/-/issues/1429 https://

Re: radeon kernel driver not suppressing ACPI_VIDEO_NOTIFY_PROBE events when it should

2021-01-06 Thread Alex Deucher
On Wed, Jan 6, 2021 at 3:04 PM Hans de Goede wrote: > > Hi, > > On 1/6/21 8:33 PM, Alex Deucher wrote: > > On Wed, Jan 6, 2021 at 1:10 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 1/6/21 6:07 PM, Alex Deucher wrote: > >>> On Wed, Jan 6, 2021 at 11:25 AM Hans de Goede wrote: > > H

Re: radeon kernel driver not suppressing ACPI_VIDEO_NOTIFY_PROBE events when it should

2021-01-06 Thread Hans de Goede
Hi, On 1/6/21 6:07 PM, Alex Deucher wrote: > On Wed, Jan 6, 2021 at 11:25 AM Hans de Goede wrote: >> >> Hi All, >> >> I get Cc-ed on all Fedora kernel bugs and this one stood out to me: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1911763 >> >> Since I've done a lot of work on the acpi-video

Re: radeon kernel driver not suppressing ACPI_VIDEO_NOTIFY_PROBE events when it should

2021-01-06 Thread Hans de Goede
Hi, On 1/6/21 8:33 PM, Alex Deucher wrote: > On Wed, Jan 6, 2021 at 1:10 PM Hans de Goede wrote: >> >> Hi, >> >> On 1/6/21 6:07 PM, Alex Deucher wrote: >>> On Wed, Jan 6, 2021 at 11:25 AM Hans de Goede wrote: Hi All, I get Cc-ed on all Fedora kernel bugs and this one stood ou

Re: Couple of issues with amdgpu on my WX4100

2021-01-06 Thread Maxim Levitsky
On Mon, 2021-01-04 at 09:45 -0700, Alex Williamson wrote: > On Mon, 4 Jan 2021 12:34:34 +0100 > Christian König wrote: > > > Hi Maxim, > > > > I can't help with the display related stuff. Probably best approach to > > get this fixes would be to open up a bug tracker for this on FDO. > > > > Bu

Re: [PATCH v3 3/3] drm/amd/display: Skip modeset for front porch change

2021-01-06 Thread Kazlauskas, Nicholas
On 2021-01-04 4:08 p.m., Aurabindo Pillai wrote: [Why&How] Inorder to enable freesync video mode, driver adds extra modes based on preferred modes for common freesync frame rates. When commiting these mode changes, a full modeset is not needed. If the change in only in the front porch timing valu

Re: [PATCH 2/3] drm/amdgpu: Correct the read sclk for navi10

2021-01-06 Thread Alex Deucher
On Tue, Jan 5, 2021 at 8:05 PM Emily.Deng wrote: > > According to hw, after navi10,it runs in dfll mode, and should > read sclk from AverageGfxclkFrequency. > > Signed-off-by: Emily.Deng Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 2 +- > 1 file changed, 1

Re: [PATCH 1/3] drm/amdgpu: Add new mode 2560x1440

2021-01-06 Thread Alex Deucher
On Tue, Jan 5, 2021 at 8:05 PM Emily.Deng wrote: > > Add one more 2k resolution which appears frequently in market. > > Signed-off-by: Emily.Deng Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: radeon kernel driver not suppressing ACPI_VIDEO_NOTIFY_PROBE events when it should

2021-01-06 Thread Alex Deucher
On Wed, Jan 6, 2021 at 1:10 PM Hans de Goede wrote: > > Hi, > > On 1/6/21 6:07 PM, Alex Deucher wrote: > > On Wed, Jan 6, 2021 at 11:25 AM Hans de Goede wrote: > >> > >> Hi All, > >> > >> I get Cc-ed on all Fedora kernel bugs and this one stood out to me: > >> > >> https://bugzilla.redhat.com/sho

Patch "Revert "drm/amd/display: Fix memory leaks in S3 resume"" has been added to the 5.4-stable tree

2021-01-06 Thread gregkh
This is a note to let you know that I've just added the patch titled Revert "drm/amd/display: Fix memory leaks in S3 resume" to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "Revert "drm/amd/display: Fix memory leaks in S3 resume"" has been added to the 5.10-stable tree

2021-01-06 Thread gregkh
This is a note to let you know that I've just added the patch titled Revert "drm/amd/display: Fix memory leaks in S3 resume" to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: radeon kernel driver not suppressing ACPI_VIDEO_NOTIFY_PROBE events when it should

2021-01-06 Thread Alex Deucher
On Wed, Jan 6, 2021 at 11:25 AM Hans de Goede wrote: > > Hi All, > > I get Cc-ed on all Fedora kernel bugs and this one stood out to me: > > https://bugzilla.redhat.com/show_bug.cgi?id=1911763 > > Since I've done a lot of work on the acpi-video code I thought I should > take a look. I've managed t

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Joshua Ashton
On 1/6/21 2:59 PM, Christian König wrote: Am 06.01.21 um 15:18 schrieb Joshua Ashton: [SNIP] For Vulkan we (both RADV and AMDVLK) use GTT as the total size. Usage in modern games is essentially "bindless" so there is no way to track at a per-submission level what memory needs to be resident

radeon kernel driver not suppressing ACPI_VIDEO_NOTIFY_PROBE events when it should

2021-01-06 Thread Hans de Goede
Hi All, I get Cc-ed on all Fedora kernel bugs and this one stood out to me: https://bugzilla.redhat.com/show_bug.cgi?id=1911763 Since I've done a lot of work on the acpi-video code I thought I should take a look. I've managed to help the user with a kernel-commandline option which stops video.ko

Re: [PATCH] drm/amdkfd: check more client ids in interrupt handler

2021-01-06 Thread Felix Kuehling
Thanks for catching and fixing this. Reviewed-by: Felix Kuehling Am 2021-01-06 um 1:13 a.m. schrieb Tao Zhou: > Add check for SExSH clients in kfd interrupt handler. > > Signed-off-by: Tao Zhou > --- > drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 12 ++-- > 1 file changed, 10 inse

Re: [PATCH 3/3] drm/amdgpu:Limit the resolution for virtual_display

2021-01-06 Thread Michel Dänzer
On 2021-01-06 11:40 a.m., Deng, Emily wrote: From: Alex Deucher On Tue, Jan 5, 2021 at 3:37 AM Emily.Deng wrote: Limit the resolution not bigger than 16384, which means dev->mode_info.num_crtc * common_modes[i].w not bigger than 16384. Signed-off-by: Emily.Deng --- drivers/gpu/drm/amd/amd

RE: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-06 Thread Liu, Zhan
[AMD Official Use Only - Internal Distribution Only] > -Original Message- > From: Liu, Zhan > Sent: 2021/January/04, Monday 3:46 PM > To: Bas Nieuwenhuizen ; Mario Kleiner > > Cc: dri-devel ; amd-gfx list g...@lists.freedesktop.org>; Deucher, Alexander > ; Daniel Vetter ; > Kazlauskas,

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Christian König
Am 06.01.21 um 15:18 schrieb Joshua Ashton: [SNIP] For Vulkan we (both RADV and AMDVLK) use GTT as the total size. Usage in modern games is essentially "bindless" so there is no way to track at a per-submission level what memory needs to be resident. (and even with tracking applications are al

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Joshua Ashton
On 1/6/21 1:45 PM, Christian König wrote: Am 06.01.21 um 14:17 schrieb Joshua Ashton: On 1/6/21 1:05 PM, Christian König wrote: Am 06.01.21 um 14:02 schrieb Bas Nieuwenhuizen: On Wed, Jan 6, 2021 at 1:54 PM Christian König mailto:christian.koe...@amd.com>> wrote:     Am 06.01.21 um 13

Re: [PATCH] drm/amdkfd: check more client ids in interrupt handler

2021-01-06 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: Zhou1, Tao Sent: Wednesday, January 6, 2021 1:13 AM To: Deucher, Alexander ; Kuehling, Felix ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdkfd: check

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Christian König
Am 06.01.21 um 14:17 schrieb Joshua Ashton: On 1/6/21 1:05 PM, Christian König wrote: Am 06.01.21 um 14:02 schrieb Bas Nieuwenhuizen: On Wed, Jan 6, 2021 at 1:54 PM Christian König mailto:christian.koe...@amd.com>> wrote:     Am 06.01.21 um 13:47 schrieb Joshua Ashton:     >     >     >

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Joshua Ashton
On 1/6/21 1:05 PM, Christian König wrote: Am 06.01.21 um 14:02 schrieb Bas Nieuwenhuizen: On Wed, Jan 6, 2021 at 1:54 PM Christian König mailto:christian.koe...@amd.com>> wrote: Am 06.01.21 um 13:47 schrieb Joshua Ashton: > > > On 1/6/21 7:52 AM, Christian König wrote:

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Joshua Ashton
On 1/6/21 12:54 PM, Christian König wrote: Am 06.01.21 um 13:47 schrieb Joshua Ashton: On 1/6/21 7:52 AM, Christian König wrote: Am 05.01.21 um 23:31 schrieb Joshua Ashton: On 1/5/21 10:10 PM, Alex Deucher wrote: On Tue, Jan 5, 2021 at 5:05 PM Joshua Ashton wrote: Since commit 24562523

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Christian König
Am 06.01.21 um 14:02 schrieb Bas Nieuwenhuizen: On Wed, Jan 6, 2021 at 1:54 PM Christian König mailto:christian.koe...@amd.com>> wrote: Am 06.01.21 um 13:47 schrieb Joshua Ashton: > > > On 1/6/21 7:52 AM, Christian König wrote: >> Am 05.01.21 um 23:31 schrieb Joshua Ashto

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Bas Nieuwenhuizen
On Wed, Jan 6, 2021 at 1:54 PM Christian König wrote: > Am 06.01.21 um 13:47 schrieb Joshua Ashton: > > > > > > On 1/6/21 7:52 AM, Christian König wrote: > >> Am 05.01.21 um 23:31 schrieb Joshua Ashton: > >>> On 1/5/21 10:10 PM, Alex Deucher wrote: > On Tue, Jan 5, 2021 at 5:05 PM Joshua Ash

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Christian König
Am 06.01.21 um 13:47 schrieb Joshua Ashton: On 1/6/21 7:52 AM, Christian König wrote: Am 05.01.21 um 23:31 schrieb Joshua Ashton: On 1/5/21 10:10 PM, Alex Deucher wrote: On Tue, Jan 5, 2021 at 5:05 PM Joshua Ashton wrote: Since commit 24562523688b ("Revert "drm/amd/amdgpu: set gtt size ac

Re: [PATCH] drm/amdgpu: For sriov multiple VF, set compute timeout to 10s

2021-01-06 Thread Paul Menzel
Dear Emily, Am 06.01.21 um 12:41 schrieb Emily.Deng: Could you please remove the dot your name in your git configuration? git config --global user.name "Emily Deng" For the summary, maybe amend it to: Decrease compute timeout to 10 s for sriov multiple VF For multiple VF, after eng

Re: [PATCH] drm/amdgpu: don't limit gtt size on apus

2021-01-06 Thread Joshua Ashton
On 1/6/21 7:52 AM, Christian König wrote: Am 05.01.21 um 23:31 schrieb Joshua Ashton: On 1/5/21 10:10 PM, Alex Deucher wrote: On Tue, Jan 5, 2021 at 5:05 PM Joshua Ashton wrote: Since commit 24562523688b ("Revert "drm/amd/amdgpu: set gtt size according to system memory size only""), the GT

[PATCH] drm/amdgpu: For sriov multiple VF, set compute timeout to 10s

2021-01-06 Thread Emily . Deng
For multiple VF, after engine hang,as host driver will first encounter FLR, so has no meanning to set compute to 60s. Signed-off-by: Emily.Deng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

RE: [PATCH 3/3] drm/amdgpu:Limit the resolution for virtual_display

2021-01-06 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] >-Original Message- >From: Alex Deucher >Sent: Wednesday, January 6, 2021 1:23 AM >To: Deng, Emily >Cc: amd-gfx list >Subject: Re: [PATCH 3/3] drm/amdgpu:Limit the resolution for virtual_display > >On Tue, Jan 5, 2021 at 3:37 AM Emily