RE: [PATCH] drm/amdgpu: fix a memory protection fault when remove amdgpu device

[AMD Public Use] Hi Dennis, It is a good idea to leverage asd_ucode_size, instead of asd_fw to resolve this issue. I'm fine to go with your patch first. As a follow up action, I think we shall consider to retired asd firmware related members like asd_fw/asd_ucode_size from psp strcutrue finall

RE: [PATCH] drm/amdgpu: fix a memory protection fault when remove amdgpu device

[AMD Official Use Only - Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Dennis Li Sent: Wednesday, December 30, 2020 2:46 PM To: amd-gfx@lists.freedesktop.org; Clements, John ; Zhang, Hawking ; Koenig, Christian Cc: Li, Dennis Subject: [PATCH] drm/amdgpu: fi

[PATCH] drm/amdgpu: fix a memory protection fault when remove amdgpu device

ASD and TA share the same firmware in SIENNA_CICHLID and only TA firmware is requested during boot, so only need release TA firmware when remove device. [ 83.877150] general protection fault, probably for non-canonical address 0x1269f97e6ed04095: [#1] SMP PTI [ 83.888076] CPU: 0 PID: 131

[PATCH v2] drm/amdgpu: Do not change amdgpu framebuffer format during page flip

[Why] Driver cannot change amdgpu framebuffer (afb) format while doing page flip. Force system doing so will cause ioctl error, and result in breaking several functionalities including FreeSync. If afb format is forced to change during page flip, following message will appear in dmesg.log: "[drm:

[PATCH] drm/amd/display: Initialize stack variable

From: Wesley Chalmers The stack variable "val" is potentially unpopulate it, so initialize it with the value 0xf (indicating an invalid mux). Cc: Alex Deucher Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazlauskas Cc: Hersen Wu Cc: Dave Airlie Cc: Josip Pavic Cc: Bindu Ramamurthy Si

Re: [PATCH] drm/amd/display: fix sysfs amdgpu_current_backlight_pwm NULL pointer issue

[AMD Public Use] Acked-by: Alex Deucher From: Wang, Kevin(Yang) Sent: Tuesday, December 29, 2020 1:21 AM To: amd-gfx@lists.freedesktop.org ; Wentland, Harry Cc: Deucher, Alexander ; Wang, Kevin(Yang) Subject: [PATCH] drm/amd/display: fix sysfs amdgpu_current_

Re: [bug] Radeon 3900XT not switch to graphic mode on kernel 5.10

[AMD Public Use] It looks like the driver is not able to access the firmware for some reason. Please make sure it is available in your initrd or compiled into the kernel depending on your config. Alex From: amd-gfx on behalf of Mikhail Gavrilov Sent: Sunday

Re: [PATCH AUTOSEL 5.4 006/130] drm/amd/display: Do not silently accept DCC for multiplane formats.

[AMD Public Use] I don't know if these fixes related to modifiers make sense in the pre-modifier code base. Bas, Nick? Alex From: amd-gfx on behalf of Sasha Levin Sent: Tuesday, December 22, 2020 9:16 PM To: linux-ker...@vger.kernel.org ; sta...@vger.kernel.

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel wrote: > > > > > > This reverts commit c38d444e44badc557cf29fdfdfb823604890ccfa. > > > > > > Simply disabling -mgeneral-regs-only left

Re: [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

Am 27.12.20 um 11:53 schrieb Paul Menzel: Dear Christian, Am 27.12.20 um 10:38 schrieb Christian König: Am 26.12.20 um 14:16 schrieb Paul Menzel: Am 26.12.20 um 09:56 schrieb Chenyang Li: Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H". Fixes: d38ceaf99ed0 ("drm/amdgpu: add

[PATCH] drm/amd/display: fix comparison pointer to bool warning in dc.c

Fixes coccicheck warning: drivers/gpu/drm/amd/display/dc/core/dc.c:1543:12-19: WARNING: Comparison to bool drivers/gpu/drm/amd/display/dc/core/dc.c:1496:14-42: WARNING: Comparison to bool drivers/gpu/drm/amd/display/dc/core/dc.c:971:15-48: WARNING: Comparison to bool drivers/gpu/drm/amd/display/dc/