Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 9:07 PM Andrey Grodzovsky wrote: > > > On 11/17/20 2:49 PM, Daniel Vetter wrote: > > On Tue, Nov 17, 2020 at 02:18:49PM -0500, Andrey Grodzovsky wrote: > >> On 11/17/20 1:52 PM, Daniel Vetter wrote: > >>> On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: >

[PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with multiply

2020-11-17 Thread Bernard Zhao
Fix check_patch.pl warning: WARNING: Prefer kmalloc_array over kmalloc with multiply +bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL); WARNING: Prefer kmalloc_array over kmalloc with multiply +bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo), GFP_KERNEL); kmalloc_array has multi

[PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg

2020-11-17 Thread Bernard Zhao
Fix check_patch.pl warning: kmalloc_array uses number as first arg, sizeof is generally wrong. +fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL); Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

RE: [PATCH] drm/amd/pm: support runtime PPTable update for dimgrey_cavefish

2020-11-17 Thread Chen, Jiansong (Simon)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Jiansong Chen -Original Message- From: Zhou1, Tao Sent: Tuesday, November 17, 2020 3:33 PM To: Chen, Jiansong (Simon) ; Gui, Jack ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amd

RE: [PATCH 2/2] drm/amd/pm: fix the crash after runtime pm resume

2020-11-17 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] [AMD Official Use Only - Internal Distribution Only] Hi Evan/Alex, In the process of baco enter/exit, smu disables all features, so smu_disable_dpms is not needed. And the sequential steps in smu_smc_hw_setup after function smu_is_dpm_running

RE: [PATCH 2/2] drm/amd/pm: fix the crash after runtime pm resume

2020-11-17 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] I suspect "smu_is_dpm_running" reports a wrong result due to "smu_system_features_control(smu, false)" was skipped for SIENNA_CICHLID in smu_disable_dpms(). That is outdated cached values were used for "smu_is_dpm_running". If that's true, a f

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Luben Tuikov
On 2020-11-17 2:49 p.m., Daniel Vetter wrote: > On Tue, Nov 17, 2020 at 02:18:49PM -0500, Andrey Grodzovsky wrote: >> >> On 11/17/20 1:52 PM, Daniel Vetter wrote: >>> On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: On 6/22/20 5:53 AM, Daniel Vetter wrote: > On Sun, Jun 2

[pull] amdgpu, amdkfd, radeon, scheduler drm-next-5.11

2020-11-17 Thread Alex Deucher
Hi Dave, Daniel, Updates for 5.11. The following changes since commit 512bce50a41c528fa15c4c014293e7bebf018658: Merge v5.10-rc3 into drm-next (2020-11-10 14:36:36 +0100) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-next-5.11-2020-11-17 for

[PATCH 2/2] drm/amdgpu: add DID for dimgrey_cavefish

2020-11-17 Thread Alex Deucher
From: Tao Zhou Add device id for dimgrey_cavefish. Signed-off-by: Tao Zhou Reviewed-by: Jiansong Chen Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/a

[PATCH 1/2] drm/amdgpu: add device ID for navy_flounder (v2)

2020-11-17 Thread Alex Deucher
From: Tao Zhou add device ID for navy_flounder v2: squash in updates Signed-off-by: Tao Zhou Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Andrey Grodzovsky
On 11/17/20 2:49 PM, Daniel Vetter wrote: On Tue, Nov 17, 2020 at 02:18:49PM -0500, Andrey Grodzovsky wrote: On 11/17/20 1:52 PM, Daniel Vetter wrote: On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: On 6/22/20 5:53 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:08A

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 02:18:49PM -0500, Andrey Grodzovsky wrote: > > On 11/17/20 1:52 PM, Daniel Vetter wrote: > > On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: > > > On 6/22/20 5:53 AM, Daniel Vetter wrote: > > > > On Sun, Jun 21, 2020 at 02:03:08AM -0400, Andrey Grodzovsky

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Andrey Grodzovsky
On 11/17/20 1:52 PM, Daniel Vetter wrote: On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: On 6/22/20 5:53 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:08AM -0400, Andrey Grodzovsky wrote: No point to try recovery if device is gone, just messes up things. Signed-o

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Daniel Vetter
On Tue, Nov 17, 2020 at 01:38:14PM -0500, Andrey Grodzovsky wrote: > > On 6/22/20 5:53 AM, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 02:03:08AM -0400, Andrey Grodzovsky wrote: > > > No point to try recovery if device is gone, just messes up things. > > > > > > Signed-off-by: Andrey Grodzov

Re: [PATCH][next] drm/amd/pm: fix spelling mistakes in dev_warn messages

2020-11-17 Thread Alex Deucher
On Tue, Nov 17, 2020 at 8:11 AM Colin King wrote: > > From: Colin Ian King > > There are two spelling mistakes in dev_warn messages. Fix these. > > Signed-off-by: Colin Ian King Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 4 ++-- > 1 file changed, 2 inse

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-17 Thread Andrey Grodzovsky
On 6/22/20 5:53 AM, Daniel Vetter wrote: On Sun, Jun 21, 2020 at 02:03:08AM -0400, Andrey Grodzovsky wrote: No point to try recovery if device is gone, just messes up things. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 16 drivers/gpu/drm

[PATCH 2/2] drm/amd/display: Add comments to hdcp property change code

2020-11-17 Thread Bhawanpreet Lakha
[Why] These comments are helpful in understanding which case each if statement handles. [How] Add comments for state transitions (9 possible cases) Signed-off-by: Bhawanpreet Lakha Reviewed-by: Zhan Liu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +-- 1 file changed,

[PATCH 1/2] drm/amd/display: Add display only once.

2020-11-17 Thread Bhawanpreet Lakha
[Why] We call add display multiple times because DESIRED->ENABLED cannot happen instantaneously. We can't compare the new_state/old_state to avoid this because on unplug we set the state to DESIRED and on hotplug the state will still be DESIRED. [How] Add a flag to dm_connector_state to keep track

Re: [PATCH] drm/amd/display: Always get CRTC updated constant values inside commit tail

2020-11-17 Thread Harry Wentland
On 2020-11-17 10:51 a.m., Rodrigo Siqueira wrote: We recently improved our display atomic commit and tail sequence to avoid some issues related to concurrency. One of the major changes consisted of moving the interrupt disable and the stream release from our atomic commit to our atomic tail (c

Re: [PATCH] drm/amd/pm: support runtime PPTable update for dimgrey_cavefish

2020-11-17 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Tao Zhou Sent: Tuesday, November 17, 2020 2:32 AM To: Chen, Jiansong (Simon) ; Gui, Jack ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao S

[PATCH] drm/amd/display: Always get CRTC updated constant values inside commit tail

2020-11-17 Thread Rodrigo Siqueira
We recently improved our display atomic commit and tail sequence to avoid some issues related to concurrency. One of the major changes consisted of moving the interrupt disable and the stream release from our atomic commit to our atomic tail (commit 6d90a208cfff ("drm/amd/display: Move disable inte

[PATCH][next] drm/amd/pm: fix spelling mistakes in dev_warn messages

2020-11-17 Thread Colin King
From: Colin Ian King There are two spelling mistakes in dev_warn messages. Fix these. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/d

Re: [PATCH 2/2] drm/amd/pm: fix the crash after runtime pm resume

2020-11-17 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Series is: Reviewed-by: Alex Deucher Does the same thing need to be applied to navy flounder and dimgrey cavefish? Alex From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, November 17, 2020 8:30 AM To:

[PATCH 1/2] drm/amd/amdgpu: fix null pointer in runtime pm

2020-11-17 Thread Kenneth Feng
fix the null pointer issue when runtime pm is triggered. Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c ind

[PATCH 2/2] drm/amd/pm: fix the crash after runtime pm resume

2020-11-17 Thread Kenneth Feng
Some features are still disabled after runtime pm resume. This can take the hardware back. Unlike other projects, this doesn't need pptable retransfer. Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --

[PATCH 0/2] runtime pm fix

2020-11-17 Thread Kenneth Feng
this 2 patches fix the runtime pm problems on SIENNA_CICHLID. Kenneth Feng (2): drm/amd/amdgpu: fix null pointer in runtime pm drm/amd/pm: fix the crash after runtime pm resume drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 +-- 2 fil

Re: [PATCH 01/43] drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location

2020-11-17 Thread Lee Jones
On Mon, 16 Nov 2020, Alex Deucher wrote: > On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous > > prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototype