[PATCH] drm/amd/amdgpu: Fix incorrect logic to increment VCN doorbell index

2020-11-06 Thread Bokun Zhang
- The original logic uses a counter based index assignment, which is incorrect if we only assign VCN1 to this VF but no VCN0 The doorbell index is absolute, so we can calculate it by using index variable i and j Change-Id: Ica36b2bc80efa896f3753f2f2e2539ca2ca6649f Signed-off-by: Bokun Zhang

[PATCH 07/14] drm/amd/display: force use sRGB for video TF is sRGB or BT709

2020-11-06 Thread Bindu R
From: Jing Zhou [Why] When mpo enabled, video comes is 709. Desktop use sRGB. So color change easily noticeable especially when switch between mpo/non-mpo. [How] Force use sRGB for video TF is sRGB or BT709. DCN1/DCN2 use predefined type with YUV. DCN3 use distributed points type with YUV. Sign

[PATCH 09/14] drm/amd/display: Explicitly disable cursor when disabling CRTC

2020-11-06 Thread Bindu R
From: Victor Lu [why] On DCE, the cursor is not being disabled on commits where there is no CRTC or FB enabled. [how] Explicitly disable the cursor in the commit tail only if the pending commit disables the CRTC. Signed-off-by: Victor Lu Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/dis

[PATCH 05/14] drm/amd/display: Move common speakersToChannels definition to hw_shared.h

2020-11-06 Thread Bindu R
From: Eric Bernstein Signed-off-by: Eric Bernstein Acked-by: Bindu Ramamurthy --- .../amd/display/dc/dce/dce_stream_encoder.c | 82 -- .../display/dc/dcn10/dcn10_stream_encoder.c | 82 -- .../gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c | 1 + .../gpu/drm/amd/

[PATCH 14/14] drm/amd/display: cap dpp dto phase not more than modulo.

2020-11-06 Thread Bindu R
From: Yongqiang Sun [Why] 4K monitor shows corruption if dpp dto phase is larger than modulo. [How] cap phase value never larger than modulo. Signed-off-by: Yongqiang Sun Acked-by: Bindu Ramamurthy --- .../gpu/drm/amd/display/dc/dcn21/dcn21_dccg.c | 46 ++- 1 file changed, 25

[PATCH 03/14] drm/amd/display: Engage PSR synchronously

2020-11-06 Thread Bindu R
From: Krunoslav Kovac [Why & How] The intended use is to force PSR into active state and ignore all events until explicit EXIT. A new event force_static is added to power module. It is then sent to FW. Signed-off-by: Krunoslav Kovac Acked-by: Bindu Ramamurthy Acked-by: Bindu Ramamurthy --- ..

[PATCH 04/14] drm/amd/display: correct dml dsc bpc assignment

2020-11-06 Thread Bindu R
From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c b/drivers/gpu/drm/amd/dis

[PATCH 06/14] drm/amd/display: Only wait for flip pending on immediate flips

2020-11-06 Thread Bindu R
From: Aric Cyr [Why] We want to make sure all immediate flips are completed before locking the pipes, but not pipes that are not flip immediate as they will be locked by the OTG [How] Skip non flip immediate pipes when checking for flip pending. Signed-off-by: Aric Cyr Acked-by: Bindu Ramamurt

[PATCH 08/14] drm/amd/display: update dpp dto phase and modulo.

2020-11-06 Thread Bindu R
From: Yongqiang Sun [Why & How] Program modulo with ref dpp clk Mhz/10. Program phase with pipe dpp clk Mhz /10. DMUB FW could use these value to determine optimization clk for PSR power saving. Signed-off-by: Yongqiang Sun Acked-by: Bindu Ramamurthy --- .../amd/display/dc/clk_mgr/dcn21/rn_cl

[PATCH 13/14] drm/amd/display: check actual clock value.

2020-11-06 Thread Bindu R
From: Yongqiang Sun [Why] Actual dpp/disp clock PMFW set are always equal or more than requested. Need to cache the actual clock for debugging purpose. [How] Add actuall dpp/disp clk in clock manager and save it when set clocks. Add an ASSERT in case of actual clock less than requested. Signed-

[PATCH 02/14] drm/amd/display: Prevent freesync power optimization during validation

2020-11-06 Thread Bindu R
From: Isabel Zhang [Why] Due to the freesync power optimization increasing vtotal, the driver believes that MPO is supported. MPO is turned on. Freesync then exits, MPO can no longer be supported and immediate flip fails. This causes corruption on the panel. [How] Avoid the freesync optimization

[PATCH 10/14] drm/amd/display: Check other planes for iflip only if GSL already enabled

2020-11-06 Thread Bindu R
From: Alvin Lee [Why] We don't want GSL to be enabled when only updating plane address [How] Only check other pipes for immediate flip if GSL is already enabled Signed-off-by: Alvin Lee Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 12 +++- 1 fil

[PATCH 11/14] drm/amd/display: [FW Promotion] Release 0.0.41

2020-11-06 Thread Bindu R
From: Anthony Koo Signed-off-by: Anthony Koo Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 12/14] drm/amd/display: 3.2.111

2020-11-06 Thread Bindu R
From: Aric Cyr Signed-off-by: Aric Cyr Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index c368de08969b..67e9602c069d 100644 --- a

[PATCH 01/14] drm/amd/display: Add fallback to prefetch mode 1 if 0 fails

2020-11-06 Thread Bindu R
From: Isabel Zhang [Why] In some cases, prefetch mode 0 is unsupported but prefetch 1 is supported. Due to previous change always forcing prefetch mode to 0, we are failing bandwidth validation in cases where we should not. [How] By default try prefetch mode 0 but in the case validation fails, a

[PATCH 00/14] DC Patches 11 09,2020

2020-11-06 Thread Bindu R
This DC patchset brings improvements in multiple areas. In summary, we have: Alvin Lee (1): drm/amd/display: Check other planes for iflip only if GSL already enabled Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.41 Aric Cyr (2): drm/amd/display: Only wait for flip pending

Re: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-06 Thread Sam Ravnborg
Hi Lee and DRM folks. On Fri, Nov 06, 2020 at 09:49:30PM +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are 5000 warnings to work through. It will take a

[PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-06 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. There are 5000 warnings to work through. It will take a couple more sets. Although, ("drm/amd/display/dc/basics/fixpt31_32: Move variables to wher

[PATCH 12/19] drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're used

2020-11-06 Thread Lee Jones
Also rid some unused ones. This patch solves 2000 warnings! Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:33, from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30, from drivers/gpu/drm/amd/amdgpu/../d

[PATCH 10/19] drm/radeon/radeon: Move prototype into shared header

2020-11-06 Thread Lee Jones
Unfortunately, a suitable one didn't already exist. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype for ‘radeon_device_is_virtual’ [-Wmissing-prototypes] 637 | bool radeon_device_is_virtual(void) | ^

[PATCH 11/19] drm/radeon/radeon_drv: Source file headers are not good candidates for kernel-doc

2020-11-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_drv.c:2: warning: Cannot understand * file radeon_drv.c Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Gareth Hughes Cc: amd-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesk

[PATCH 15/19] drm/radeon: Move prototypes to shared header

2020-11-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_kms.c:756:5: warning: no previous prototype for ‘radeon_get_vblank_counter_kms’ [-Wmissing-prototypes] 756 | u32 radeon_get_vblank_counter_kms(struct drm_crtc *crtc) | ^ drivers/gpu/drm/

[PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param

2020-11-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or member 'dev' not described in 'radeon_info_ioctl' drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function parameter 'rdev' description in 'radeon_info_ioctl' Cc:

[PATCH 06/19] drm/radeon/atom: Move prototype into shared location

2020-11-06 Thread Lee Jones
Both source files include atom.h, which seems like a reasonable location to place an atom based function into. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes]

[PATCH 16/19] drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device dev_info' from the stack

2020-11-06 Thread Lee Jones
Place it on the heap instead. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c: In function ‘amdgpu_info_ioctl’: drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:979:1: warning: the frame size of 1128 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Al

[PATCH 13/19] drm/radeon/radeon_drv: Move prototypes to a shared headerfile

2020-11-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): 62 | void radeon_driver_unload_kms(struct drm_device *dev) | ^~~~ drivers/gpu/drm/radeon/radeon_kms.c:105:5: warning: no previous prototype for ‘radeon_driver_load_kms’ [-Wmissing-prototypes] 105 | int radeon_driver_load_kms

[PATCH 18/19] drm/radeon/atombios_crtc: Remove description of non-existent function param 'encoder'

2020-11-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/atombios_crtc.c:1796: warning: Excess function parameter 'encoder' description in 'radeon_get_shared_nondp_ppll' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.or

[PATCH 07/19] drm/radeon/radeon_kms: Include header containing our own prototypes

2020-11-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_kms.c:61:6: warning: no previous prototype for ‘radeon_driver_unload_kms’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_kms.c:104:5: warning: no previous prototype for ‘radeon_driver_load_kms’ [-Wmissing-prot

[PATCH 14/19] drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params

2020-11-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:594: warning: Function parameter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg' drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:624: warning: Function parameter or member 'reg_addr' not

RE: [PATCH] drm/amd/amdgpu: Import amdgpu_amdkfd_gfx_v9 header file into implementation

2020-11-06 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Friday, November 6, 2020 2:05 PM To: amd-gfx@lists.freedesktop.org Cc: Errabolu, Ramesh Subject: [PATCH] drm/amd/amdgpu: Import

[PATCH] drm/amd/amdgpu: Import amdgpu_amdkfd_gfx_v9 header file into implementation

2020-11-06 Thread Ramesh Errabolu
[Why] Prevent compiler warnings when building amdgpu kernel module [How] Add the include directive for amdgpu_amdkfd_gfx_v9 header file Signed-off-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/am

[PATCH 2/2] drm/amdgpu/pm/smu11: cache smu firmware version

2020-11-06 Thread Alex Deucher
So we print the proper SMU firmware version in debugfs, ioctls, etc. for vangogh. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c b/drivers/gpu/drm/amd/pm/swsmu/s

[PATCH 1/2] drm/amdgpu/pm/smu12: cache smu firmware version

2020-11-06 Thread Alex Deucher
So we print the proper SMU firmware version in debugfs, ioctls, etc. for Renoir. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c b/drivers/gpu/drm/amd/pm/swsmu/sm

Re: [PATCH] drm/amdgpu: enable DCN for navi10 headless SKU

2020-11-06 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Tianci Yin Sent: Friday, November 6, 2020 2:36 AM To: amd-gfx@lists.freedesktop.org Cc: Long, Gang ; Chen, Guchun ; Xu, Feifei ; Yin, Tianci (Rico) ; Tui

Re: [PATCH] Fix bug to get average GPU power

2020-11-06 Thread Tom St Denis
For whatever reason when I download this message and try to add it with "git am" it says the patch is empty. Can you attach the patch as an attachment please? Thanks, Tom On Mon, Oct 26, 2020 at 11:29 PM Quan, Evan wrote: > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: