[PATCH] drm/amd/pm: increase mclk switch threshold to 200 us

2020-10-12 Thread Evan Quan
To avoid underflow seen on Polaris10 with some 3440x1440 144Hz displays. As the threshold of 190 us cuts too close to minVBlankTime of 192 us. Change-Id: Ieca0dc900f0b5764dc661e397e41e8c277ff13de Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 2 +- 1 file chan

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-12 Thread Matthew Wilcox
On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote: > kmap_atomic() is always preferred over kmap()/kmap_thread(). > kmap_atomic() is _much_ more lightweight since its TLB invalidation is > always CPU-local and never broadcast. > > So, basically, unless you *must* sleep while the mapping

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-12 Thread Dave Hansen
On 10/12/20 9:19 AM, Eric Biggers wrote: > On Sun, Oct 11, 2020 at 11:56:35PM -0700, Ira Weiny wrote: >>> And I still don't really understand. After this patchset, there is still >>> code >>> nearly identical to the above (doing a temporary mapping just for a memcpy) >>> that >>> would still be

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-12 Thread Eric Biggers
On Sun, Oct 11, 2020 at 11:56:35PM -0700, Ira Weiny wrote: > > > > And I still don't really understand. After this patchset, there is still > > code > > nearly identical to the above (doing a temporary mapping just for a memcpy) > > that > > would still be using kmap_atomic(). > > I don't unde

[PATCH] drm/amd/display: remove no need return value

2020-10-12 Thread Bernard Zhao
Functions (disable_all_writeback_pipes_for_stream & dc_enable_stereo & dc_post_update_surfaces_to_stream) always return true, there is no need to keep the return value. This change is to make the code a bit more readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc.c

RE: [PATCH v3] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Patel, Mihir
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Koenig, Christian Sent: Monday, October 12, 2020 4:24 PM To: Patel, Mihir ; amd-gfx@lists.freedesktop.org Cc: Chauhan, Madhav ; Deucher, Alexander ; Kamliya, Prakash ; Surampalli, Kishore Subject: Re: [PAT

Re: [PATCH v4] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Christian König
Am 12.10.20 um 13:48 schrieb Mihir Patel: From: Mihir Bhogilal Patel Create new debugfs entry to print memory info using VM buffer objects. V2: Added Common function for printing BO info. Dump more VM lists for evicted, moved, relocated, invalidated. Removed dumping VM mapped BOs. V3

[PATCH v4] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Mihir Patel
From: Mihir Bhogilal Patel Create new debugfs entry to print memory info using VM buffer objects. V2: Added Common function for printing BO info. Dump more VM lists for evicted, moved, relocated, invalidated. Removed dumping VM mapped BOs. V3: Fixed coding style comments, renamed print A

Re: [PATCH v3] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Christian König
Am 12.10.20 um 12:50 schrieb Christian König: Am 12.10.20 um 12:00 schrieb Patel, Mihir: [AMD Official Use Only - Internal Distribution Only] -Original Message- From: Koenig, Christian Sent: Monday, October 12, 2020 3:14 PM To: Patel, Mihir ; amd-gfx@lists.freedesktop.org Cc: Chauhan

Re: [PATCH v3] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Christian König
Am 12.10.20 um 12:00 schrieb Patel, Mihir: [AMD Official Use Only - Internal Distribution Only] -Original Message- From: Koenig, Christian Sent: Monday, October 12, 2020 3:14 PM To: Patel, Mihir ; amd-gfx@lists.freedesktop.org Cc: Chauhan, Madhav ; Deucher, Alexander ; Surampalli, Ki

RE: [PATCH v3] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Patel, Mihir
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Koenig, Christian Sent: Monday, October 12, 2020 3:14 PM To: Patel, Mihir ; amd-gfx@lists.freedesktop.org Cc: Chauhan, Madhav ; Deucher, Alexander ; Surampalli, Kishore ; Kamliya, Prakash Subject: Re: [PAT

Re: [PATCH v3] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Christian König
[SNIP] Hi Christian, One question regarding getting total allocations by app and also swapped size for the app. Shouldn’t we print mapped entries as well to get total allocation by the process ? Also which list would represent swapped memory? None, we don't really have that information anywhe

RE: [PATCH v3] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Patel, Mihir
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Koenig, Christian Sent: Monday, October 12, 2020 2:41 PM To: Patel, Mihir ; amd-gfx@lists.freedesktop.org Cc: Chauhan, Madhav ; Deucher, Alexander ; Surampalli, Kishore ; Kamliya, Prakash Subject: Re: [PAT

Re: [PATCH v3] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Christian König
Am 12.10.20 um 11:01 schrieb Mihir Patel: From: Mihir Bhogilal Patel Create new debugfs entry to print memory info using VM buffer objects. Pending: - Consolidated memory utilization info like total, swap etc. V2: Added Common function for printing BO info. Dump more VM lists for evicted

[PATCH v3] drm/amdgpu: Add debugfs entry for printing VM info

2020-10-12 Thread Mihir Patel
From: Mihir Bhogilal Patel Create new debugfs entry to print memory info using VM buffer objects. Pending: - Consolidated memory utilization info like total, swap etc. V2: Added Common function for printing BO info. Dump more VM lists for evicted, moved, relocated, invalidated. Removed

Re: [PATCH RFC PKS/PMEM 57/58] nvdimm/pmem: Stray access protection for pmem->virt_addr

2020-10-12 Thread Ira Weiny
On Fri, Oct 09, 2020 at 07:53:07PM -0700, John Hubbard wrote: > On 10/9/20 12:50 PM, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The pmem driver uses a cached virtual address to access its memory > > directly. Because the nvdimm driver is well aware of the special > > protections it h

Re: [PATCH RFC PKS/PMEM 48/58] drivers/md: Utilize new kmap_thread()

2020-10-12 Thread Coly Li
On 2020/10/12 13:28, Ira Weiny wrote: > On Sat, Oct 10, 2020 at 10:20:34AM +0800, Coly Li wrote: >> On 2020/10/10 03:50, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> These kmap() calls are localized to a single thread. To avoid the over >>> head of global PKRS updates use the new kmap_t

Re: [PATCH RFC PKS/PMEM 09/58] drivers/gpu: Utilize new kmap_thread()

2020-10-12 Thread Ira Weiny
On Sat, Oct 10, 2020 at 12:03:49AM +0200, Daniel Vetter wrote: > On Fri, Oct 09, 2020 at 12:49:44PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > These kmap() calls in the gpu stack are localized to a single thread. > > To avoid the over head of global PKRS updates use the new kma

Re: [PATCH RFC PKS/PMEM 48/58] drivers/md: Utilize new kmap_thread()

2020-10-12 Thread Ira Weiny
On Sat, Oct 10, 2020 at 10:20:34AM +0800, Coly Li wrote: > On 2020/10/10 03:50, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > These kmap() calls are localized to a single thread. To avoid the over > > head of global PKRS updates use the new kmap_thread() call. > > > > Hi Ira, > > The

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-12 Thread Ira Weiny
On Fri, Oct 09, 2020 at 06:30:36PM -0700, Eric Biggers wrote: > On Sat, Oct 10, 2020 at 01:39:54AM +0100, Matthew Wilcox wrote: > > On Fri, Oct 09, 2020 at 02:34:34PM -0700, Eric Biggers wrote: > > > On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > > > > The kmap() calls in th

Re: [PATCH RFC PKS/PMEM 26/58] fs/zonefs: Utilize new kmap_thread()

2020-10-12 Thread Damien Le Moal
On 2020/10/10 4:52, ira.we...@intel.com wrote: > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Damien Le Moal > Cc: Naohiro Aota > Signed-off-by: Ira Weiny > --- > fs/

Re: [PATCH RFC PKS/PMEM 10/58] drivers/rdma: Utilize new kmap_thread()

2020-10-12 Thread Bernard Metzler
-ira.we...@intel.com wrote: - >To: "Andrew Morton" , "Thomas Gleixner" >, "Ingo Molnar" , "Borislav >Petkov" , "Andy Lutomirski" , "Peter >Zijlstra" >From: ira.we...@intel.com >Date: 10/09/2020 09:52PM >Cc: "Ira Weiny" , "Mike Marciniszyn" >, "Dennis Dalessandro" >, "Doug Ledford" , >"Jas