[AMD Public Use]
My BAD. Will correct it in v3.
Regards,
Guchun
-Original Message-
From: Zhang, Hawking
Sent: Tuesday, September 29, 2020 2:36 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Deucher,
Alexander ; Li, Dennis ; Zhou1,
Tao ; Clements, John
Subject: RE: [PATCH] drm/
The same ECC check has been executed in amdgpu_ras_init for vega10,
prior to gmc_v9_0_late_init.
v2: drop all atombios helper callings
v3: use bit operation
Signed-off-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 16
1 file changed, 4 insertions(+), 12 deletions(
[AMD Public Use]
Reviewed-by: Tao Zhou
> -Original Message-
> From: Chen, Guchun
> Sent: Tuesday, September 29, 2020 12:55 PM
> To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> ; Zhang, Hawking ;
> Li, Dennis ; Zhou1, Tao ;
> Clements, John
> Cc: Chen, Guchun
> Subject: [PATCH
[AMD Public Use]
+ if (adev->ras_features & AMDGPU_RAS_BLOCK__UMC)
ras_feature is in bitmask, so it should be 1 << block or use BIT macro here for
the check
Regards,
Hawking
-Original Message-
From: Chen, Guchun
Sent: Tuesday, September 29, 2020 14:14
To: amd-gfx@lists.
The same ECC check has been executed in amdgpu_ras_init for vega10,
prior to gmc_v9_0_late_init.
v2: drop all atombios helper callings
Signed-off-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drive
[AMD Public Use]
Let me send v2 later to correct it.
Regards,
Guchun
-Original Message-
From: Zhang, Hawking
Sent: Tuesday, September 29, 2020 2:05 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Deucher,
Alexander ; Li, Dennis ; Zhou1,
Tao ; Clements, John
Subject: RE: [PATCH]
[AMD Public Use]
Although we unified check ecc capability to ras_init, we still need to query
the ecc capability here to apply the vega10 specific workaround. So we don't
need to call the atomfirmware helper again, but leverage adev->ras_features to
decide apply the workaround or not.
Regards,
[ 179.556745] kernel BUG at drivers/dma-buf/dma-resv.c:282!
[snip]
[ 179.702910] Call Trace:
[ 179.705696] amdgpu_bo_fence+0x21/0x50 [amdgpu]
[ 179.710707] amdgpu_vm_sdma_commit+0x299/0x430 [amdgpu]
[ 179.716497] amdgpu_vm_bo_update_mapping.constprop.0+0x29f/0x390 [amdgpu]
[ 179.723927] ?
[AMD Official Use Only - Internal Distribution Only]
Pls ignore this patch.
-Original Message-
From: Pan, Xinhui
Sent: 2020年9月29日 13:17
To: amd-gfx@lists.freedesktop.org
Cc: Koenig, Christian ; Deucher, Alexander
; Pan, Xinhui
Subject: [PATCH] amd/amdgpu: Fix resv shared fence overflow
[ 179.556745] kernel BUG at drivers/dma-buf/dma-resv.c:282!
[snip]
[ 179.702910] Call Trace:
[ 179.705696] amdgpu_bo_fence+0x21/0x50 [amdgpu]
[ 179.710707] amdgpu_vm_sdma_commit+0x299/0x430 [amdgpu]
[ 179.716497] amdgpu_vm_bo_update_mapping.constprop.0+0x29f/0x390 [amdgpu]
[ 179.723927] ?
The same ECC check has been executed in amdgpu_ras_init for vega10,
prior to gmc_v9_0_late_init.
Signed-off-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
b/driver
It should be one copy-paste typo.
Signed-off-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.h
index f29a8611d69b.
[+Alex]
I think this was added for Arcturus, which shares the same IH IP as
Navi10 and needs to support virtualization.
Regards,
Felix
Am 2020-09-25 um 7:30 a.m. schrieb Zhang, Hawking:
> [AMD Public Use]
>
> Hi Likun,
>
> Let's take a step back to check with Alex S why he add the ASIC type ch
Include linux/vmalloc.h to fix compile failure in 4.9.184 kernel
Signed-off-by: Jiawei
---
include/kcl/kcl_mm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/kcl/kcl_mm.h b/include/kcl/kcl_mm.h
index 0afe2f099aa1..dac2f84c9dd3 100644
--- a/include/kcl/kcl_mm.h
+++ b/include/kcl/kcl
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Prike Liang
Thanks,
Prike
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Tuesday, September 29, 2020 2:19 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH] drm/a
On 2020-09-25 4:10 p.m., Alex Deucher wrote:
> From: Huang Rui
>
> This patch is to add power gating handle for gfx10.
Ray, you can just say:
"This patch adds power gating handler for gfx10."
You can drop "is to" and just use "adds".
And similarly for all other patches where you use that.
>
On 2020-09-25 4:10 p.m., Alex Deucher wrote:
> From: Huang Rui
>
> APU needs load toc firmware for gfx10 series on psp front door loading.
>
> v2: rebase against latest code
>
> Signed-off-by: Huang Rui
> Acked-by: Alex Deucher
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgp
[AMD Official Use Only - Internal Distribution Only]
Forgot the mention, the main reason I think it is not necessary to write a
comment in this case is, if you program with C language and write something
like below, the unset function pointer is NULL guaranteed by compiler.
+const struct amdgpu
[AMD Official Use Only - Internal Distribution Only]
Sorry for late reply…
Yes some of the function pointers can be NULL. For those NULL function pointer,
it is the call’s responsibility to *not* call them. We have been practicing
like this for many function pointers before. For example, if you
On Mon, Sep 28, 2020 at 9:23 AM Jean Delvare wrote:
>
> Hi all,
>
> I have recently experienced a regression in stable kernel series 5.8.
> The problem is that my display will randomly turn to black after just a
> few seconds of inactivity. I have to switch to text console then back
> to X to reco
On 2020-09-25 4:10 p.m., Alex Deucher wrote:
> From: Xiaojian Du
>
> This patch is to add smu v11.5 driver interface header for vangogh.
>
> Signed-off-by: Xiaojian Du
> Reviewed-by: Kevin Wang
> Reviewed-by: Huang Rui
> Signed-off-by: Alex Deucher
> ---
> .../drm/amd/pm/inc/smu11_driver_if
Applied. Thanks!
Alex
On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland wrote:
>
> On 2020-09-27 10:35 p.m., Jason Yan wrote:
> > This addresses the following sparse warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6:
> > warning: symbol 'dce110_set_curs
Applied. Thanks!
On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland wrote:
>
> On 2020-09-27 10:36 p.m., Jason Yan wrote:
> > This addresses the following sparse warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
> > warning: symbol 'get_color_space_type' was n
On 2020-09-25 4:09 p.m., Alex Deucher wrote:
> From: Huang Rui
>
> The interrupts are not stable while uses guest physical address (GPA)
> for interrupt packet write space even on direct loading case.
>
> Signed-off-by: Huang Rui
> Acked-by: Alex Deucher
> Signed-off-by: Alex Deucher
> ---
>
On 2020-09-25 4:09 p.m., Alex Deucher wrote:
> From: Huang Rui
>
> Van gogh only has one sdma.
>
> v2: use num_instances rather than APU flag
>
> Signed-off-by: Huang Rui
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/nv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 delet
On 2020-09-25 4:09 p.m., Alex Deucher wrote:
> From: Huang Rui
>
> This patch adds common ip support for van gogh.
>
> Signed-off-by: Huang Rui
> Reviewed-by: Alex Deucher
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/nv.c | 8
> 1 file changed, 8 insertions(+)
>
On 2020-09-25 4:09 p.m., Alex Deucher wrote:
> From: Huang Rui
>
> This patch adds vangogh_reg_base_init function to init the register base for
> van gogh.
>
> Signed-off-by: Huang Rui
> Reviewed-by: Alex Deucher
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/Makefile
On Mon, 2020-09-28 at 16:32 -0400, Alex Deucher wrote:
> Yes, but module parameters global for all devices claimed by that
> driver. E.g., if you have a system with 2 or 3 AMD GPUs in it, that
> will be applied to all of them. I think if we want to be able to set
> KMS properties on the kernel co
On Mon, Sep 28, 2020 at 4:24 PM James Ettle wrote:
>
> On Mon, 2020-09-28 at 16:12 -0400, Kazlauskas, Nicholas wrote:
> >
> > The problem with the module parameters is that it'd be applying a
> > default to every DRM connector. No way to specify different defaults
> > per
> > DRM connector, nor do
On Mon, 2020-09-28 at 16:12 -0400, Kazlauskas, Nicholas wrote:
>
> The problem with the module parameters is that it'd be applying a
> default to every DRM connector. No way to specify different defaults
> per
> DRM connector, nor do we know the full connector set at driver
> initialization. Th
Fix perms: a+x --> a-x.
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amd
On 2020-09-28 3:31 p.m., Christian König wrote:
Am 28.09.20 um 19:35 schrieb James Ettle:
On Mon, 2020-09-28 at 10:26 -0400, Harry Wentland wrote:
On 2020-09-25 5:18 p.m., Alex Deucher wrote:
On Tue, Sep 22, 2020 at 4:51 PM James Ettle
wrote:
On 22/09/2020 21:33, Alex Deucher wrote:
+/**
+
Am 28.09.20 um 19:35 schrieb James Ettle:
On Mon, 2020-09-28 at 10:26 -0400, Harry Wentland wrote:
On 2020-09-25 5:18 p.m., Alex Deucher wrote:
On Tue, Sep 22, 2020 at 4:51 PM James Ettle
wrote:
On 22/09/2020 21:33, Alex Deucher wrote:
+/**
+ * DOC: pixel_encoding (string)
+ * Specify the in
The state array is in the reverse order compared to other asics
(high to low rather than low to high).
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1313
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 8 +---
1 file changed, 5 insertions(+), 3 deleti
On Mon, 2020-09-28 at 10:26 -0400, Harry Wentland wrote:
>
> On 2020-09-25 5:18 p.m., Alex Deucher wrote:
> > On Tue, Sep 22, 2020 at 4:51 PM James Ettle
> > wrote:
> > > On 22/09/2020 21:33, Alex Deucher wrote:
> > > > > +/**
> > > > > + * DOC: pixel_encoding (string)
> > > > > + * Specify the i
LGTM,
Reviewed-by: Rodrigo Siqueira
On 09/28, Bhawanpreet Lakha wrote:
> From: Dmytro Laktyushkin
>
> At the moment on flip opp reassignment does not work in all cases
> for non root pipes.
> This change simply makes sure we prefer pipes not used previously
> when splitting in dcn3.
>
> Signe
From: Dmytro Laktyushkin
At the moment on flip opp reassignment does not work in all cases
for non root pipes.
This change simply makes sure we prefer pipes not used previously
when splitting in dcn3.
Signed-off-by: Dmytro Laktyushkin
Acked-by: Bhawanpreet Lakha
---
.../drm/amd/display/dc/dcn
If I had to guess, I'd say something HMM-related. There has been some
back-and-forth between kernel releases. So I won't say anything more
specific without knowing exactly which branch or release you're on.
Regards,
Felix
Am 2020-09-25 um 10:29 a.m. schrieb Thomas Zimmermann:
> Hi,
>
> whenever
ping...
在 2020/9/12 10:22, Jason Yan 写道:
The 'trigger_hotplug' entry in debugfs is defined but not wired up. This
causes a gcc warning build with W=1.
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:2045:37:
warning: ‘dp_trigger_hotplug_debugfs_fops’ defined but not used
[-W
On 2020-09-25 5:18 p.m., Alex Deucher wrote:
> On Tue, Sep 22, 2020 at 4:51 PM James Ettle wrote:
>>
>> On 22/09/2020 21:33, Alex Deucher wrote:
+/**
+ * DOC: pixel_encoding (string)
+ * Specify the initial pixel encoding used by a connector.
+ */
+static char amdgpu_pi
On 2020-09-28 10:06 a.m., Jason Yan wrote:
> ping...
>
Fix by YueHaibing is already merged for this:
commit 73b1acd54e13686fbb002afdf892c670177f0c57
Author: YueHaibing
Date: Thu Sep 10 11:13:52 2020 +0800
drm/amd/display: Create trigger_hotplug entry
Add trigger_hotplug debugfs entr
On 2020-09-27 10:35 p.m., Jason Yan wrote:
> This addresses the following sparse warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6:
> warning: symbol 'dce110_set_cursor_position' was not declared. Should it
> be static?
> drivers/gpu/drm/amd/amdgpu/../displa
On 2020-09-27 10:36 p.m., Jason Yan wrote:
> This addresses the following sparse warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
> warning: symbol 'get_color_space_type' was not declared. Should it be
> static?
>
If you have multiple fixes of the same or simi
Hi all,
I have recently experienced a regression in stable kernel series 5.8.
The problem is that my display will randomly turn to black after just a
few seconds of inactivity. I have to switch to text console then back
to X to recover.
I bisected it down to:
commit b86657e328b601a5b98f8c4c21d10
[AMD Public Use]
Some minor things inline
> -Original Message-
> From: amd-gfx On Behalf Of Ramesh
> Errabolu
> Sent: Friday, September 25, 2020 6:03 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Errabolu, Ramesh
> Subject: [PATCH 3/3] drm/amd/amdkfd: Surface files in Sysfs to allow use
[AMD Public Use]
Some minor typos
> -Original Message-
> From: amd-gfx On Behalf Of Ramesh
> Errabolu
> Sent: Friday, September 25, 2020 6:03 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Errabolu, Ramesh
> Subject: [PATCH 2/3] drm/amd/amdgpu: Define and implement a function that
> col
[AMD Public Use]
Comments inline
> -Original Message-
> From: amd-gfx On Behalf Of Ramesh
> Errabolu
> Sent: Friday, September 25, 2020 6:03 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Errabolu, Ramesh
> Subject: [PATCH 1/3] drm/amd/amdgpu: Prepare implementation to support
> reporti
On Mon, Sep 28, 2020 at 03:15:30PM +0800, Du, Xiaojian wrote:
> From: Xiaojian Du
>
> From: Xiaojian Du
>
> This patch is to add one sysfs file -- "pp_od_clk_voltage" for
> Raven/Raven2/Picasso APU, which is only used by dGPU like VEGA10.
> This sysfs file supports the feature to modify gfx eng
[AMD Official Use Only - Internal Distribution Only]
comment inline.
after fixed, the patch is
Reviewed-by: Kevin Wang
Best Regards,
Kevin
From: Du, Xiaojian
Sent: Monday, September 28, 2020 3:15 PM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray ; Wang, Kevi
From: Xiaojian Du
From: Xiaojian Du
This patch is to add one sysfs file -- "pp_od_clk_voltage" for
Raven/Raven2/Picasso APU, which is only used by dGPU like VEGA10.
This sysfs file supports the feature to modify gfx engine clock(Mhz units), it
can
be used to configure the min value and the max
Alex Deucher writes:
> On Wed, Sep 23, 2020 at 3:45 PM Dirk Gouders wrote:
>>
>> Dirk Gouders writes:
>>
>> > Alex Deucher writes:
>> >
>> >> On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote:
>> >>>
>> >>> Dirk Gouders writes:
>> >>>
>> >>> > Hi,
>> >>> >
>> >>> > I noticed a call trace (a
This addresses the following sparse warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26:
warning: symbol 'get_color_space_type' was not declared. Should it be
static?
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
---
drivers/gpu/drm/amd/display/dc/core/dc_hw_sequ
Commit 78fe9f63947a2b (drm/amd/display: Remove DISPCLK Limit Floor
for Certain SMU Versions) added a call to
rn_vbios_smu_get_smu_version() to set clk_mgr->smu_ver. That field is
initialized prior to the if-statement, already.
Fixes: 78fe9f63947a2b (drm/amd/display: Remove DISPCLK Limit Floor for
This addresses the following sparse warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6:
warning: symbol 'dce110_set_cursor_position' was not declared. Should it
be static?
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6:
warning: symb
54 matches
Mail list logo
