Am 23.09.20 um 16:08 schrieb Alex Deucher:
This will allow us to have different defaults per asic
in a future patch.
Signed-off-by: Alex Deucher
Looks good to me, Reviewed-by: Christian König
for both.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++
drivers/gpu/dr
This patch is Reviewed-by: Frank Min
-邮件原件-
发件人: amd-gfx 代表 Emily.Deng
发送时间: 2020年9月24日 12:10
收件人: amd-gfx@lists.freedesktop.org
抄送: Deng, Emily
主题: [PATCH] drm/amdgpu: Remove some useless code
Signed-off-by: Emily.Deng
Change-Id: I1a14dcc6f2d5395b2c385f4f290494ce7de108b4
---
drivers
Signed-off-by: Emily.Deng
Change-Id: I1a14dcc6f2d5395b2c385f4f290494ce7de108b4
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c| 5 -
drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 5 -
drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 13 -
.../gpu/drm/am
[AMD Official Use Only - Internal Distribution Only]
Series is Reviewed-by: Emily.Deng
>-Original Message-
>From: amd-gfx On Behalf Of
>Jingwen Chen
>Sent: Wednesday, September 23, 2020 6:07 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Chen, JingWen
>Subject: [PATCH 2/2] drm/amd: Skip n
Dirk Gouders writes:
> Alex Deucher writes:
>
>> On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote:
>>>
>>> Dirk Gouders writes:
>>>
>>> > Hi,
>>> >
>>> > I noticed a call trace (attached) when starting my machine (ThinkPad
>>> > L14). This machine is new and I am still working on it's
>>> >
Alex Deucher writes:
> On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote:
>>
>> Dirk Gouders writes:
>>
>> > Hi,
>> >
>> > I noticed a call trace (attached) when starting my machine (ThinkPad
>> > L14). This machine is new and I am still working on it's
>> > configuration but visually noticea
Documents PP_FEATURE_MASK enum.
Provides instructions on how to use ppfeaturemasks.
v2: improve enum definitions and add kernel command line parameters to
ppfeaturemask instructions
v3: fix alignment issues
Signed-off-by: Ryan Taylor
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/includ
Non-outbound data metrics are non useful so mark them as legacy.
Bucket new perf counters into device and not device ip.
Bind events to chip instead of IP.
Report available event counters and not number of hw counter banks.
Move DF public macros to private since not needed outside of IP version.
v
Mapping hw counters per event config will cause ABA problems so map per
event instead.
v2: Discontinue starting perf counters if add fails. Make it clear what's
happening with pmc_start.
Signed-off-by: Jonathan Kim
---
drivers/gpu/drm/amd/amdgpu/amdgpu_df.h | 6 +-
drivers/gpu/drm/amd/amdgp
Add xgmi perfmons for Arcturus.
Signed-off-by: Jonathan Kim
v3: Align with patch 2 streamlining perf types versus event config types.
v2: Resend for re-review with alignment for v3 in patch 2.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 43 +
drivers/gpu/drm/amd/amdgpu
[AMD Official Use Only - Internal Distribution Only]
Reviewed-By: Harish Kasiviswanathan
-Original Message-
From: amd-gfx On Behalf Of Ramesh
Errabolu
Sent: Thursday, September 17, 2020 1:10 PM
To: amd-gfx@lists.freedesktop.org
Cc: Errabolu, Ramesh
Subject: [PATCH 1/3] drm/amd/amdgpu:
I see, I'll add it to the end next time then.
Ryan
On 9/23/20 10:13 AM, Luben Tuikov wrote:
> On 2020-09-23 12:31, Ryan Taylor wrote:
>> Thanks Luben,
>>
>> I'll make these revisions and try out Git's patch version setting.
>
> Well, Git's own patch revision command line option (-v of git-format
On 2020-09-23 12:31, Ryan Taylor wrote:
> Thanks Luben,
>
> I'll make these revisions and try out Git's patch version setting.
Well, Git's own patch revision command line option (-v of git-format-patch)
would put it in the "[PATCH v] Title text" as you had it here, and I'd
presumed that you'd use
On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote:
>
> Dirk Gouders writes:
>
> > Hi,
> >
> > I noticed a call trace (attached) when starting my machine (ThinkPad
> > L14). This machine is new and I am still working on it's
> > configuration but visually noticeable is that scrolling in xterms w
Thanks Luben,
I'll make these revisions and try out Git's patch version setting.
Best,
Ryan
On 9/23/20 7:40 AM, Luben Tuikov wrote:
> On 2020-09-22 11:55, Ryan Taylor wrote:
>> Documents PP_FEATURE_MASK enum.
>> Provides instructions on how to use ppfeaturemasks.
>>
>> v2: Improved enum definiti
Series is Reviewed-by: Luben Tuikov
This is a good change!
Regards,
Luben
On 2020-09-23 10:08, Alex Deucher wrote:
> This allows us to set different defaults on a per asic basis. This
> way we can enable noretry on dGPUs where it can increase performance
> in certain cases and disable it on ch
On 2020-09-22 11:55, Ryan Taylor wrote:
> Documents PP_FEATURE_MASK enum.
> Provides instructions on how to use ppfeaturemasks.
>
> v2: Improved enum definitions. Adds kernel command line
> parameters to ppfeaturemask instructions.
>
> Signed-off-by: Ryan Taylor
> Reviewed-by: Alex Deucher
Feel free to add an Acked-by: Christian König
to all patches which I haven't explicitly reviewed.
I would say we should just push this to drm-misc-next now.
Thanks for the nice cleanup,
Christian.
Am 23.09.20 um 12:21 schrieb Thomas Zimmermann:
The GEM and PRIME related callbacks in struct d
This will allow us to have different defaults per asic
in a future patch.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
driver
This allows us to set different defaults on a per asic basis. This
way we can enable noretry on dGPUs where it can increase performance
in certain cases and disable it on chips where it can be problematic.
For now the default is 0 for all asics, but we may want to try and
enable it again for newe
Am 23.09.20 um 14:52 schrieb Samuel Pitoiset:
On 8/28/20 10:23 AM, Christian König wrote:
Am 28.08.20 um 10:14 schrieb Samuel Pitoiset:
On 8/28/20 9:57 AM, Christian König wrote:
Am 25.08.20 um 16:07 schrieb Samuel Pitoiset:
A trap handler can be used by userspace to catch shader exceptions
Dirk Gouders writes:
> Hi,
>
> I noticed a call trace (attached) when starting my machine (ThinkPad
> L14). This machine is new and I am still working on it's
> configuration but visually noticeable is that scrolling in xterms with
> SHIFT-PgUp/PgDn is broken. Using the mouse wheel works.
>
> I
On 8/28/20 10:23 AM, Christian König wrote:
Am 28.08.20 um 10:14 schrieb Samuel Pitoiset:
On 8/28/20 9:57 AM, Christian König wrote:
Am 25.08.20 um 16:07 schrieb Samuel Pitoiset:
A trap handler can be used by userspace to catch shader exceptions
like divide by zero, memory violations etc.
O
On Mi, 2020-09-23 at 12:21 +0200, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in etnaviv. The only exception is gem_prime_mmap,
> which is non-trivial
Hi Thomas,
On Wed, Sep 23, 2020 at 12:21:44PM +0200, Thomas Zimmermann wrote:
> The i.MX DCSS driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this chan
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vkms.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_drv.c | 8
drivers/gpu/drm
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in xen. The only exception is gem_prime_mmap,
which is non-trivial to convert.
v2:
* convert xen_drm_drv_free_object_unlocked()
Several GEM and PRIME callbacks have been deprecated in favor of
per-instance GEM object functions. Remove the callbacks as they are
now unused. The only exception is .gem_prime_mmap, which is still
in use by several drivers.
What is also gone is gem_vm_ops in struct drm_driver. All drivers now
us
The xlnx driver uses CMA helpers with default callback functions.
Initialize the driver structure with the rsp CMA helper macro. The
driver is being converted to use GEM object functions as part of
this change.
Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
to their default i
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in tegra.
Signed-off-by: Thomas Zimmermann
Acked-by: Thierry Reding
---
drivers/gpu/drm/tegra/drm.c | 4
drivers/gpu/drm/tegra/g
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces virtgpu's per-driver PRIME export
function with a per-object function.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/virtio/virtgpu_drv.c| 1 -
driv
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in msm. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vet
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vgem. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Melissa W
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in omapdrm.
v2:
* make omap_gem_free_object() static (Tomi)
Signed-off-by: Thomas Zimmermann
Reviewed-by: Laurent Pinchart
Re
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in radeon.
v2:
* move object-function instance to radeon_gem.c (Christian)
* set callbacks in radeon_gem_object_create()
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in rockchip. The only exception is gem_prime_mmap,
which is non-trivial to convert.
v3:
* update documentation
Signed-off-by: T
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in pl111. The only exception is gem_prime_mmap,
which is non-trivial to convert.
v2:
* use drm_gem_cma_create_object_default_fun
The i.MX DCSS driver uses CMA helpers with default callback functions.
Initialize the driver structure with the rsp CMA helper macro. The
driver is being converted to use GEM object functions as part of
this change.
Two callbacks, .gem_prime_export and .gem_prime_import, were initialized
to their
The GEM and PRIME related callbacks in struct drm_driver are deprecated in
favor of GEM object functions in struct drm_gem_object_funcs. This patchset
converts the remaining drivers to object functions and removes most of the
obsolete interfaces.
Version 3 of this patchset mostly fixes drm_gem_pri
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vc4. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Eric Anhol
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in gma500.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/gma500/framebuffer.c | 2 ++
drivers/gpu/
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in exynos. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in nouveau.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 -
d
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
which is non-trivial to convert.
v3:
* remove amdgpu_object.c from patch (Chris
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in etnaviv. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in i915.
v2:
* move object-function instance to i915_gem_object.c (Jani)
Signed-off-by: Thomas Zimmermann
Reviewed-by: Tvrtko
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in mediatek. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Danie
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in armada.
Signed-off-by: Thomas Zimmermann
Acked-by: Russell King
---
drivers/gpu/drm/armada/armada_drv.c | 3 ---
drivers/gpu/drm/
smc, sdma, sos, ta and asd fw is not used in SRIOV. Skip them to
accelerate sw_init for navi12.
v2: skip above fw in SRIOV for vega10 and sienna_cichlid
v3: directly skip psp fw loading in SRIOV
Signed-off-by: Jingwen Chen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 10 ++
smc fw is not needed in SRIOV, thus driver should not try to get smc
fw data.
Signed-off-by: Jingwen Chen
---
.../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 61 ++-
1 file changed, 32 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
b/
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c: warning:
variable speakers set but not used
Reported-by: Hulk Robot
Signed-off-by: Li Heng
---
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c | 2 --
1 file changed, 2 deletions(-)
diff --git
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Feifei Xu
-Original Message-
From: amd-gfx On Behalf Of Flora Cui
Sent: Wednesday, September 23, 2020 2:54 PM
To: amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH] drm/amd/display: fix return value check for
52 matches
Mail list logo