RE: [PATCH] drm/amdgpu: Update RAS init handling

[AMD Public Use] + { + dev_warn(psp->adev->dev, "RAS Init Status: 0x%X\n", ras_cmd->ras_status); + } Please remove the redundant bracket. Other than that, the patch is Reviewed-by: Hawking Zhang

[PATCH] drm/amdgpu: Update RAS init handling

[AMD Official Use Only - Internal Distribution Only] Added RAS status check and tear down RAS context if RAS init fails 0001-drm-amdgpu-Update-RAS-init-handling.patch Description: 0001-drm-amdgpu-Update-RAS-init-handling.patch ___ amd-gfx mailing list

Re: [PATCH 3/3] drm/amdkfd: Reduce eviction/restore message levels

Am 2020-09-10 um 2:54 p.m. schrieb Philip Cox: > Reduce the eviction and restore messages from INFO level to DEBUG level. > > Signed-off-by: Philip Cox This patch is Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 8 > 1 file changed, 4 in

Re: [PATCH 2/3] drm/amdkfd: Add process eviction counters to sysfs

Am 2020-09-10 um 2:54 p.m. schrieb Philip Cox: > Add per-process eviction counters to sysfs to keep track of > how many eviction events have happened for each process. > > Signed-off-by: Philip Cox > --- > drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 15 ++- > drivers/gpu/drm/amd/amdkfd/kfd_proce

Re: [PATCH 1/3] drm/amdkfd: Add some eveiction debugging code

Am 2020-09-10 um 2:54 p.m. schrieb Philip Cox: > Extending the module parameter debug_evictions to also print a stack > trace when the eviction code path is called. > > Signed-off-by: Philip Cox This patch is Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_device_queue_m

[PATCH 1/1] drm/amdkfd: Use a new capability bit for SRAM ECC

Existing, buggy user mode breaks when SRAM ECC is correctly reported as "enabled". To avoid breaking existing user mode, deprecate that bit and leave it as 0. Define a new bit to report the actual SRAM ECC mode that new, correct user mode can use in the future. Fixes: 7ec177bdcfc1 ("drm/amdkfd: fi

[PATCH 2/3] drm/amdkfd: Add process eviction counters to sysfs

Add per-process eviction counters to sysfs to keep track of how many eviction events have happened for each process. Signed-off-by: Philip Cox --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 15 ++- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 117 +++ 2 files changed, 130 inse

[PATCH 1/3] drm/amdkfd: Add some eveiction debugging code

Extending the module parameter debug_evictions to also print a stack trace when the eviction code path is called. Signed-off-by: Philip Cox --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 + drivers/gpu/drm/amd/amdkfd/kfd_process.c | 1 + 2 files changed, 2 insertions(

[PATCH 3/3] drm/amdkfd: Reduce eviction/restore message levels

Reduce the eviction and restore messages from INFO level to DEBUG level. Signed-off-by: Philip Cox --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/driver

RE: [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

[AMD Public Use] > -Original Message- > From: amd-gfx On Behalf Of > Daniel Vetter > Sent: Monday, September 7, 2020 3:15 AM > To: Jan Kiszka ; amd-gfx list g...@lists.freedesktop.org>; Wentland, Harry ; > Kazlauskas, Nicholas > Cc: dri-devel ; intel-gfx g...@lists.freedesktop.org>;

[PATCH] drm/amdgpu: Include sienna_cichlid in USBC PD FW support.

Create sysfs interface also for sienna_cichlid. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index a7771aa..60001

Re: [PATCH -next] drm/amd/display: Create trigger_hotplug entry

On 2020-09-09 11:13 p.m., YueHaibing wrote: Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +

Re: [PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

On 2020-09-09 11:26 p.m., YueHaibing wrote: If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/am

Re: [PATCH v2 -next] drm/amdkfd: Fix -Wunused-const-variable warning

Am 2020-09-10 um 3:50 a.m. schrieb YueHaibing: > If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: > ‘raven_device_info’ defined but not used [-Wunused-const-variable=] > static const struct kfd_device_info raven_device_info = {

[PATCH 41/42] drm/amd/display: update dcn30_optc header with missing declarations

From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 5 ++--- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h | 4 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH 35/42] drm/amd/display: Add connector to the state if DSC debugfs is set

From: Eryk Brol [why] We want to trigger atomic check on connector, which DSC debugfs properties have changed. [how] Add a helper function that iterates through all active connectors and add them to the state if DSC debugfs parameters have changed. Signed-off-by: Eryk Brol Signed-off-by: Mikit

[PATCH 40/42] drm/amd/display: get socBB from VBIOS

From: Jun Lei [why] Some SOC BB paramters may vary per SKU, and it does not make sense for driver to hardcode these values [how] Parse the values from VBIOS if available, and use them if valid Signed-off-by: Jun Lei Acked-by: Aurabindo Pillai --- .../drm/amd/display/dc/bios/bios_parser2.c

[PATCH 34/42] drm/amd/display: Calculate DSC number of slices in debugfs when forced

From: Eryk Brol [why] When comparing current DSC timing settings with enforced through debugfs we have to calculate number of both vertical and horisontal slices. So instead of doing that every time we should just use number of slices rather than setting its dimensions. [how] In connector's dsc

[PATCH 32/42] drm/amd/display: Update idle optimization handling

From: Joshua Aberback [How] - use dc interface instead of hwss interface in cursor functions, to keep dc->idle_optimizations_allowed updated - add dc interface to check if idle optimizations might apply to a plane Signed-off-by: Joshua Aberback Acked-by: Aurabindo Pillai --- drivers/gpu/drm

[PATCH 15/42] drm/amd/display: Power eDP panel back ON before link training retry

From: Ashley Thomas [why] When link training failures occur for eDP, dp_disable_link_phy is called which powers OFF eDP panel. After link training retry delay, the next retry begins by calling dp_enable_link_phy which does not issue a correspnding eDP panel power ON, leaving panel powered OFF whi

[PATCH 38/42] drm/amd/display: update nv1x stutter latencies

From: Jun Lei [why] Recent characterization shows increased stutter latencies on some SKUs, leading to underflow. [how] Update SOC params to account for this worst case latency. Signed-off-by: Jun Lei Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 ++

[PATCH 37/42] drm/amd/display: fix compile warning in dml

From: Roman Li [Why] gcc version 5.4.0 fails compilation with: ‘PixelPTEReqHeightPTEs’ may be used uninitialized in this function [-Werror=maybe-uninitialized] [How] Initialized variable explicitly with 0 Signed-off-by: Roman Li Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/d

[PATCH 39/42] drm/amd/display: Further fix of psr eDP p-state warning

From: Fangzhi Zuo [Why] psr doesn't get fully disabled before hitting hubbub1_wm_change_req_wa. [How] Pass TRUE to "wait" parameter to get psr fully disabled. Follow-Up fix to: dc: PSR eDP p-state warning occurs intermittently after unplug DP Signed-off-by: Fangzhi Zuo Acked-by: Aurabindo Pil

[PATCH 04/42] drm/amd/display: Detect plane change when detect pipe change.

From: "JinZe.Xu" [Why] If plane has changed, dcn20_detect_pipe_changes doesn't update dc_plane_state->update_flags, and the following dcn20_program_pipe can't reprogram hubp correctly. [How] Add a new flags bit "plane_changed" in pipe_ctx->update_flags.If old plane isn’t identical to new plan

[PATCH 21/42] drm/amd/display: Compare plane when looking for pipe split being lost

From: Alvin Lee [Why] There are situations where we go from 2 pipe to 1 pipe in MPO, but this isn't a pipe split being lost -- it's a plane disappearing in (i.e. video overlay goes away) so we lose one pipe. In these situations we don't want to disable the pipe in a separate operation from the r

[PATCH 36/42] drm/amd/display: remove dc context from transfer function

From: Josip Pavic [Why] The ctx field of dc_transfer_func is not always populated and therefore isn't reliable. [How] Remove dc context from dc_transfer_func Signed-off-by: Josip Pavic Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c| 1 - drivers/gpu/dr

[PATCH 28/42] drm/amd/display: adding pathway to retrieve stutter period

From: Martin Leung why: some functions may need be dependent on stutter period in the future how: Extract from stutter calculations and place into perf_params structure Signed-off-by: Martin Leung Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/dcn30/dcn30_resource.c| 3 +++ .

[PATCH 26/42] drm/amd/display: Add DSC force disable to dsc_clock_en debugfs entry

From: Eryk Brol [why] For debug purposes we want not to enable DSC on certain connectors even if algorithm deesires to do so, instead it should enable DSC on other capable connectors or fail the atomic check. [how] Adding the third option to connector's debugfs entry dsc_clock_en. Accepted inpu

[PATCH 42/42] drm/amd/display: update clock when non-seamless boot stream exist

From: Lewis Huang [Why] Seamless boot skip porgram clock when set path mode. It cause driverprogram clock after unblank stream. [How] update clock when non-seamless boot stream exist Signed-off-by: Lewis Huang Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--

[PATCH 17/42] drm/amd/display: Flip pending check timeout due to disabled hubp

From: Aric Cyr [Why] When pipe locks are being taken we wait for flip pending to clear first. In some cases the pipe mapping is changed and the pending we're checking for will never clear. [How] Don't check disabled pipes for flip pending. Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --

[PATCH 05/42] drm/amd/display: Add CP_IRQ clear capability

From: Harmanprit Tatla [Why] Currently we do not clear the CP_IRQ bit upon receiving it. [How] Added a function to clear CP_IRQ bit. Signed-off-by: Harmanprit Tatla Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/modules/hdcp/hdcp.c | 9 + .../gpu/drm/amd/display/modules/hd

[PATCH 03/42] drm/amd/display: Fixed Intermittent blue screen on OLED panel

From: Naveed Ashfaq [why] Changing to smaller modes on OLED panel caused a blue screen crash as driver reported dram change during vactive when it shouldn't [how] Added an extra condition to prevent incorrect dram change timing Signed-off-by: Naveed Ashfaq Acked-by: Aurabindo Pillai --- .../

[PATCH 06/42] drm/amd/display: Compare mpcc_inst to mpcc_count instead of a constant

From: Joshua Aberback [Why] This assert triggers a false negative because there are more than 4 MPCCs on many asics. [How] - change assert comparisson - remove unused variable Signed-off-by: Joshua Aberback Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c |

[PATCH 01/42] drm/amd/display: [FW Promotion] Release 0.0.30

From: Anthony Koo Signed-off-by: Anthony Koo Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 13/42] drm/amd/display: Only use offset for first ODM pipe

From: Wesley Chalmers [WHY] Only the first pipe in ODM combine group should have nonzero recout offset. All other pipes should have recout offset 0; otherwise there will be gaps in the image. [HOW] Set recout.x to 0 if the pipe is not the leftmost ODM pipe. When computing viewports, calculate t

[PATCH 00/42] DC Patches Septemper 14, 2020

This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC Version 3.2.102 * DMUB Firmware release 0.0.32 * DSC improvements * PSR enablement for DCN3 * Various bug fixes and improvements for eDP, OLED panel and others -- Aidan Gratton (1): drm/amd/display: Increas

[PATCH 33/42] drm/amd/display: Return the number of bytes parsed than allocated

From: Eryk Brol [why & how] Previously we were returning the number of bytes allocated for a write buffer from debugfs and when manually used it wouldn't rise any errors, but it wouldn't match the size of the parameters passed from userspace. In successful case return the size passed by usermode

[PATCH 09/42] drm/amd/display: Check clock table return

From: Rodrigo Siqueira During the load processes for Renoir, our display code needs to retrieve the SMU clock and voltage table, however, this operation can fail which means that we have to check this scenario. Currently, we are not handling this case properly and as a result, we have seen the fo

[PATCH 24/42] drm/amd/display: Multi display cause system lag on mode change

From: Aric Cyr [Why] DCValidator is created/destroyed repeatedly for cofunctional validation which causes a lot of memory thrashing, particularly when Driver Verifer is enabled. [How] Implement a basic caching algorithm that will cache DCValidator with a matching topology. When a match is found

[PATCH 11/42] drm/amd/display: 3.2.101

From: Aric Cyr Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 0607122e04de..464f2c657597 100644 --- a

[PATCH 20/42] drm/amd/display: Enabling PSR on DCN30 on driver side

From: Zhan Liu [Why] PSR needs to be enabled on DCN30. This is the driver part of PSR enablement. Also disabled retired DMCU on driver side, since DMCU is not supported on DCN30 anymore. [How] Add necessary changes to enable PSR on DCN30. Signed-off-by: Zhan Liu Acked-by: Aurabindo Pillai --

[PATCH 02/42] drm/amd/display: 3.2.100

From: Aric Cyr Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 1d9c8e09c08b..7416fd37e7d8 100644 --- a

[PATCH 27/42] drm/amd/display: Add trigger connector unplug

From: Eryk Brol [why] We need a virtual tool that would emulate a physical connector unplug to usermode, while connector is still physically plugged in. [how] Added a new option to debugfs entry "trigger_hotplug". It emulates hotplug irq handling scenario by clearing DC and DM connector states.

[PATCH 22/42] drm/amd/display: Don't use DRM_ERROR() for DTM add topology

From: Bhawanpreet Lakha [Why] Previously we were only calling add_topology when hdcp was being enabled. Now we call add_topology by default so the ERROR messages are printed if the firmware is not loaded. This error message is not relevant for normal display functionality so no need to print a E

[PATCH 30/42] drm/amd/display: 3.2.102

From: Aric Cyr Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 464f2c657597..8631d290afee 100644 --- a

[PATCH 08/42] drm/amd/display: Triplebuffering should not be used by default

From: Aric Cyr Disable triplebuffering by default. Signed-off-by: Aric Cyr Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- drivers/gpu/drm/amd/display/dc/core/dc.c| 9 +++-- drivers/gpu/drm/amd/display/dc/dc.h | 2

[PATCH 19/42] drm/amd/display: remove early return from dm_late_init

From: Roman Li [Why] ABM feature initialization was not executed due to early return. dm_late_init() had an early return in case if DMCU is not used. With the implementation of ABM on DMUB, DMCU can be disabled but ABM still needs to be initialized. [How] Remove verification for DMCU from the t

[PATCH 07/42] drm/amd/display: add option to override cr training pattern

From: Wenjing Liu Signed-off-by: Wenjing Liu Acked-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 33 --- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 1 + .../amd/display/include/link_service_types.h | 1 + 3 files changed, 23 insertions(+), 12

[PATCH 14/42] drm/amd/display: Fix CP_IRQ clear bit and logic

From: Harmanprit Tatla [Why] Currently clearing the wrong bit for CP_IRQ, and logic on when to clear needs to be fixed. [How] Corrected bit to clear and improved logic for decision to clear. Signed-off-by: Harmanprit Tatla Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/modules/hd

[PATCH 10/42] drm/amd/display: [FW Promotion] Release 0.0.31

From: Anthony Koo Signed-off-by: Anthony Koo Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 12/42] drm/amd/display: always use 100us for cr aux rd interval

From: Wenjing Liu [why] It is a regression caused by below commit. I1654c11ba3e229e17483959e0f66319d7de9e320 In this commit the cr training aux rd interval is modified without following specs requirements. According to the commit message the change was not intended to modify the value. Therefore

[PATCH 16/42] drm/amd/display: Increase Max EDID Size Constant

From: Aidan Gratton [HOW & WHY] Change max EDID size constant to 1280 to support 10-block EDIDs. Signed-off-by: Aidan Gratton Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displa

[PATCH 31/42] drm/amd/display: implement notify stream mask

From: Eric Yang [Why] Send stream active state info to DMUB [How] Implement GPINT to notify stream mask Signed-off-by: Eric Yang Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 18 ++ drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 16

[PATCH 25/42] drm/amd/display: make dcn20 stream_gating use a pointer for dsc_pg_control

From: Dmytro Laktyushkin This allows us to reuse these on different asics. Signed-off-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/displa

[PATCH 23/42] drm/amd/display: Disable idle optimization when PSR is enabled

From: Zhan Liu [Why] Idle optimization and PSR conflict each other. If both enabled at the same time, display flickering will be observed. [How] Disable idle optimization when PSR is enabled. Signed-off-by: Zhan Liu Acked-by: Aurabindo Pillai --- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c

[PATCH 29/42] drm/amd/display: [FW Promotion] Release 0.0.32

From: Anthony Koo | [Header Changes] | - Add debug flag to log line numbers for PSR debug Signed-off-by: Anthony Koo Acked-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/am

[PATCH 18/42] drm/amd/display: Rename set_mst_bandwidth to align with DP spec

From: George Shen [Why] The function set_mst_bandwidth is poorly name since it isn't clear what it does, and it also does not reflect any part of the allocation sequence described in the DP spec. [How] Rename the function set_mst_bandwidth to set_throttled_vcp_size. (cherry picked from commit 9

RE: [PATCH 4/4] drm/amdgpu: add xgmi perfmons for arcturus

[AMD Official Use Only - Internal Distribution Only] Ping. Thanks, Jon > -Original Message- > From: Kim, Jonathan > Sent: Tuesday, September 8, 2020 9:07 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Kim, Jonathan > ; Kim, Jonathan > Subject: [PATCH 4/4] drm/amdgpu: a

Re: [PATCH] drm/amdgpu: add ta DTM/HDCP print in amdgpu_firmware_info for apu

On Wed, Sep 09, 2020 at 01:50:27PM +0800, Zhu, Changfeng wrote: > From: changzhu > > From: Changfeng > > It needs to add ta DTM/HDCP print to get HDCP/DTM version info when cat > amdgpu_firmware_info > > Change-Id: I05f20d6868ce2cac06a8496890b766dbb61de671 > Signed-off-by: Changfeng Reviewed

RE: [PATCH] drm/amd/pm: update driver if version for navy_flounder

[AMD Public Use] Reviewed-by: Tao Zhou > -Original Message- > From: Jiansong Chen > Sent: Thursday, September 10, 2020 5:26 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao ; Chen, Jiansong (Simon) > > Subject: [PATCH] drm/amd/pm: update driver if version for navy_flounder > >

[PATCH] drm/amd/pm: update driver if version for navy_flounder

It's in accordance with pmfw 65.8.0 for navy_flounder. Signed-off-by: Jiansong Chen Change-Id: Iddb07c2123c0fd5dedff68f9a3a2f43685600117 --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v11_0.h b/driver

Re: [PATCH -next] drm/ttm/agp: Fix Wunused-variable warning

Am 10.09.20 um 04:33 schrieb YueHaibing: If CONFIG_AGP is not set, gcc warns: drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_ttm_tt_bind’: drivers/gpu/drm/radeon/radeon_ttm.c:692:24: warning: unused variable ‘rdev’ [-Wunused-variable] struct radeon_device *rdev = radeon_get_rdev(bd

RE: [PATCH] drm/amd/pm: update driver if file for sienna cichlid

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Jiansong Chen -Original Message- From: Gao, Likun Sent: Thursday, September 10, 2020 4:27 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth ; Chen, Jiansong (Simon) ; Gao, Likun Subject: [PATCH] d

[PATCH] drm/amd/pm: update driver if file for sienna cichlid

From: Likun Gao Update drive if file for sienna_cichlid. Signed-off-by: Likun Gao Change-Id: I53e5210acb760901622cd50aaf81193e9699feba --- .../pm/inc/smu11_driver_if_sienna_cichlid.h | 20 ++- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 2 +- .../amd/pm/swsmu/smu11/sienn

Re: [PATCH 1/1] drm/amdgpu: fix a typo

ping. On 9/8/20 5:57 PM, Nirmoy Das wrote: Fixes: 9a0154630e958a2f (drm/amdgpu: Bring back support for non-upstream FreeSync) Signed-off-by: Nirmoy Das --- include/uapi/drm/amdgpu_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/amdgpu_drm.h b/incl

Re: [PATCH v2 -next] drm/amdkfd: Fix -Wunused-const-variable warning

On Thu, Sep 10, 2020 at 03:50:06PM +0800, YueHaibing wrote: > If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: > ‘raven_device_info’ defined but not used [-Wunused-const-variable=] > static const struct kfd_device_info raven_de

[PATCH -next 2/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3563:5-31: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/d

[PATCH -next 7/8] drm/amd/amdgpu: fix comparison pointer to bool warning in amdgpu_atpx_handler.c

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c:619:15-49: WARNING: Comparison to bool drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c:629:15-49: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 ++-- 1 f

[PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning

Zheng Bin (8): drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_0.c drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_2

[PATCH -next 3/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_0.c

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:619:5-11: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/dr

[PATCH -next] drm/ttm/agp: Fix Wunused-variable warning

If CONFIG_AGP is not set, gcc warns: drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_ttm_tt_bind’: drivers/gpu/drm/radeon/radeon_ttm.c:692:24: warning: unused variable ‘rdev’ [-Wunused-variable] struct radeon_device *rdev = radeon_get_rdev(bdev); ^~~~ Move it t

[PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 de

[PATCH -next] drm/amdkfd: Fix -Wunused-const-variable warning

If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: ‘raven_device_info’ defined but not used [-Wunused-const-variable=] static const struct kfd_device_info raven_device_info = { ^

[PATCH] drm/amd/display: optimize code runtime a bit

In fnction is_cr_done & is_ch_eq_done, when done = false happened once, no need to circle left ln_count. This change is to make the code run a bit fast. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 14 +- 1 file changed, 5 insertions(+), 9 deleti

[PATCH -next 5/8] drm/amd/amdgpu: fix comparison pointer to bool warning in si.c

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/si.c:1342:5-10: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/gpu/drm/amd/amdgpu/si.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c ind

[PATCH -next 4/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_2.c

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:562:5-11: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/dr

[PATCH -next 6/8] drm/amd/amdgpu: fix comparison pointer to bool warning in uvd_v6_0.c

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c:1243:14-25: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu

[PATCH -next 1/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2805:5-11: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/

[PATCH -next 8/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v4_0.c

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:1003:4-9: WARNING: Comparison to bool drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:1083:5-11: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

[PATCH -next] drm/amd/display: Create trigger_hotplug entry

Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/am

Re: [PATCH 1/2] drm/radeon: Don't use WC for VRAM if !RADEON_GEM_GTT_WC

On 09/09/2020 12:21 PM, Huacai Chen wrote: Though RADEON_GEM_GTT_WC is initially used for GTT, but this flag is bound to drm_arch_can_wc_memory(), and if arch doesn't support WC, then VRAM should not use WC. +cc RADEON and AMDGPU DRM DRIVERS maintainer Alex Deucher Christian König amd-gfx@lis

Re: [PATCH -next] drm/amdkfd: Fix -Wunused-const-variable warning

On Thu, Sep 10, 2020 at 10:55:32AM +0800, YueHaibing wrote: > If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: > ‘raven_device_info’ defined but not used [-Wunused-const-variable=] > static const struct kfd_device_info raven_de