RE: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-27 Thread Gu, JiaWei (Will)
[AMD Official Use Only - Internal Distribution Only] Hi Nirmoy, I also found amdgpu_device_ip_reinit_late_sriov() part is missed. Will push another patch to make them consistent soon. Best regards, Jiawei -Original Message- From: Das, Nirmoy Sent: Friday, August 28, 2020 2:33 PM To: D

Re: [PATCH 5/7] drm/amdgpu: Fix consecutive DPC recoveries failure.

2020-08-27 Thread Christian König
Am 28.08.20 um 02:00 schrieb Grodzovsky, Andrey: Ping Andrey *From:* amd-gfx on behalf of Andrey Grodzovsky *Sent:* 27 August 2020 10:54 *To:* Alex Deucher *Cc:* Deucher, Alexander ; Das, Nirmoy ; amd-gfx list *Subje

Re: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-27 Thread Nirmoy
On 8/28/20 3:16 AM, Deng, Emily wrote: [AMD Official Use Only - Internal Distribution Only] Hi Nirmoy, Still think the original logical is more clear. No problem but we should at least make sure amdgpu_device_ip_reinit_late_sriov() and amdgpu_device_ip_reinit_early_sriov() are cons

RE: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-27 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Hi Nirmoy, Still think the original logical is more clear. Best wishes Emily Deng >-Original Message- >From: Das, Nirmoy >Sent: Thursday, August 27, 2020 11:19 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Liu,

Re: [PATCH 5/7] drm/amdgpu: Fix consecutive DPC recoveries failure.

2020-08-27 Thread Grodzovsky, Andrey
Ping Andrey From: amd-gfx on behalf of Andrey Grodzovsky Sent: 27 August 2020 10:54 To: Alex Deucher Cc: Deucher, Alexander ; Das, Nirmoy ; amd-gfx list Subject: Re: [PATCH 5/7] drm/amdgpu: Fix consecutive DPC recoveries failure. On 8/26/20 11:20 AM, Alex D

[PATCH][next] drm/amdgpu/swsmu: fix potential uint32_t multiplication overflow

2020-08-27 Thread Colin King
From: Colin Ian King The calculation of tmp64 is performed using a 32 bit multiply and then is stored in the uint64_t variable tmp64. This indicates that a 64 bit result may be expected, so cast crystal_clock_freq to a uint64_t to ensure a 64 bit multiplication is being performed to avoid any pot

Re: [PATCH 1/1] drm/amdgpu: fix compiler warnings

2020-08-27 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: Das, Nirmoy Sent: Thursday, August 27, 2020 11:58 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Das, Nirmoy Subject: [PATCH 1/1] drm/amdgpu: fix compiler warni

Re: 0001-Fix-a-array-bound-overflow-bug-in-function-umr_clock

2020-08-27 Thread Tom St Denis
isn't a better fix to simply delete the line? The print seems redundant to me. Tom On Thu, Aug 27, 2020 at 9:27 AM 张二东 wrote: > > > > > ___ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gf

[PATCH 1/1] drm/amdgpu: fix compiler warnings

2020-08-27 Thread Nirmoy Das
Fixes below compiler warnings: CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_device.o drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:381:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] 381 | void static inline amdgpu_mm_wreg_mmio(struct amdgpu_device *adev, uint32_t r

[PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-27 Thread Nirmoy Das
This patch removes some unwanted code duplication and simplifies sriov's ip block reinit logic. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 117 +++-- 1 file changed, 60 insertions(+), 57 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH 5/7] drm/amdgpu: Fix consecutive DPC recoveries failure.

2020-08-27 Thread Andrey Grodzovsky
On 8/26/20 11:20 AM, Alex Deucher wrote: On Wed, Aug 26, 2020 at 10:46 AM Andrey Grodzovsky wrote: DPC recovery after prev. DPC recovery or after prev. MODE1 reset fails unles you save the cashe the saved PCI confspace to load it after each new reset. Also use same cached state for other use

Re: [PATCH] drm/amd/display: Fix memory leak in amdgpu_dm_mode_config_init()

2020-08-27 Thread Markus Elfring
> When amdgpu_display_modeset_create_props() fails, state and > state->context should be freed to prevent memleak. It's the > same when amdgpu_dm_audio_init() fails. * Can another imperative wording become helpful for the change description? * Would you like to consider the tag “Fixes” for the co

Re: [PATCH] drm/radeon: Prefer lower feedback dividers

2020-08-27 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 27, 2020 at 7:18 AM Christian König wrote: > > Am 25.08.20 um 19:33 schrieb Kai-Heng Feng: > > Commit 2e26ccb119bd ("drm/radeon: prefer lower reference dividers") > > fixed screen flicker for HP Compaq nx9420 but breaks other laptops like > > Asus X50SL. > > >

Re: [PATCH 1/7] drm/amdgpu: Implement DPC recovery

2020-08-27 Thread Andrey Grodzovsky
Indeed, I noticed it later and did it in patch 6 (merging 1 and 6 was very messy due to following changes so I just kept it as a separate patch). Andrey On 8/26/20 9:23 PM, Li, Dennis wrote: [AMD Official Use Only - Internal Distribution Only] Hi, Andrey, I found that the sequences of a

0001-Fix-a-array-bound-overflow-bug-in-function-umr_clock

2020-08-27 Thread 张二东
0001-Fix-a-array-bound-overflow-bug-in-function-umr_clock.patch Description: Binary data ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/radeon: Prefer lower feedback dividers

2020-08-27 Thread Christian König
Am 25.08.20 um 19:33 schrieb Kai-Heng Feng: Commit 2e26ccb119bd ("drm/radeon: prefer lower reference dividers") fixed screen flicker for HP Compaq nx9420 but breaks other laptops like Asus X50SL. Turns out we also need to favor lower feedback dividers. Mhm, let's hope that this works out for a

RE: [PATCH] SWDEV-220451 - Query guest's information by VF2PF message - part 2

2020-08-27 Thread Liu, Monk
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Monk Liu _ Monk Liu|GPU Virtualization Team |AMD -Original Message- From: amd-gfx On Behalf Of Bokun Zhang Sent: Saturday, May 2, 2020 1:48 AM To: amd-gfx@lists.freedesktop.org Cc: Zh

RE: [PATCH] SWDEV-220451 - Query guest's information by VF2PF message - Guest side - part 1

2020-08-27 Thread Liu, Monk
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Monk Liu _ Monk Liu|GPU Virtualization Team |AMD -Original Message- From: amd-gfx On Behalf Of Bokun Zhang Sent: Wednesday, August 5, 2020 11:32 PM To: amd-gfx@lists.freedesktop.org C

RE: [PATCH] SWDEV-220451 - Query guest's information by VF2PF message - Guest side - part 1

2020-08-27 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Emily.Deng >-Original Message- >From: amd-gfx On Behalf Of Bokun >Zhang >Sent: Wednesday, August 5, 2020 11:32 PM >To: amd-gfx@lists.freedesktop.org >Cc: Zhang, Bokun >Subject: [PATCH] SWDEV-220451 - Query guest's inform

Re: [PATCH] drm/amdgpu: simplify hw status clear/set logic

2020-08-27 Thread Nirmoy
On 8/27/20 4:32 AM, Jiawei wrote: Optimize code to iterate less loops in amdgpu_device_ip_reinit_early_sriov() Signed-off-by: Jiawei --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/am

RE: [PATCH] drm/amd/pm: enable MP0 DPM for sienna_cichlid

2020-08-27 Thread Zhou1, Tao
[AMD Public Use] Reviewed-by: Tao Zhou > -Original Message- > From: Jiansong Chen > Sent: Thursday, August 27, 2020 2:47 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao ; Feng, Kenneth > ; Chen, Jiansong (Simon) > Subject: [PATCH] drm/amd/pm: enable MP0 DPM for sienna_cichlid >