When unloading driver by "modprobe -r amdgpu", one NULL pointer
dereference bug occurs in ras debugfs releasing. The cause is the
duplicated debugfs_remove, as drm debugfs_root dir has been cleaned
up already by drm_minor_unregister.
BUG: kernel NULL pointer dereference, address: 00a0
Reviewed-by: Kevin Wang
Best Regards,
Kevin
On 8/13/20 12:25 PM, Alex Deucher wrote:
The caller does this now for all reset types. This is now
a duplicate call.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/dr
The caller does this now for all reset types. This is now
a duplicate call.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c
index 2082c
Hi Dave, Daniel,
Fixes for 5.9.
The following changes since commit f87812284172a9809820d10143b573d833cd3f75:
drm/amdgpu: Fix bug where DPM is not enabled after hibernate and resume
(2020-08-07 17:52:15 -0400)
are available in the Git repository at:
git://people.freedesktop.org/~agd5f/linu
On Wed, Aug 12, 2020 at 10:31 PM Daniel Dadap wrote:
>
> Thanks, Lukas. I've incorporated your feedback into my local tree, but
> will wait for additional feedback from the individual DRM driver
> maintainers before sending out a series v2.
>
> On 8/8/20 5:11 PM, Lukas Wunner wrote:
> > On Mon, Ju
This patch adds a new trace event to track the PTE update
events. This specific event will provide information like:
- start and end of virtual memory mapping
- HW engine flags for the map
- physical address for mapping
This will be particularly useful for memory profiling tools
(like RMV) which a
[AMD Official Use Only - Internal Distribution Only]
Hi Tom,
drm/amdgpu: fix uninit-value in arcturus_log_thermal_throttling_event()
the fixed patch has been merged into drm-next branch.
Best Regards,
Kevin
From: amd-gfx on behalf of Quan, Evan
Sent: Thursda
Thanks, Lukas. I've incorporated your feedback into my local tree, but
will wait for additional feedback from the individual DRM driver
maintainers before sending out a series v2.
On 8/8/20 5:11 PM, Lukas Wunner wrote:
On Mon, Jul 27, 2020 at 03:53:54PM -0500, Daniel Dadap wrote:
+
[AMD Official Use Only - Internal Distribution Only]
Your change below should be able to suppress the compile warning.
-arcturus_get_smu_metrics_data(smu,
+ret = arcturus_get_smu_metrics_data(smu,
METRICS_THROTTLER_STATUS,
&throttler_status);
+if (ret) {
+dev_err(adev->dev, "Could n
[AMD Public Use]
Reviewed-by: Alex Deucher
From: Bhawanpreet Lakha
Sent: Wednesday, August 12, 2020 4:17 PM
To: Kazlauskas, Nicholas ; Deucher, Alexander
; amd-gfx@lists.freedesktop.org
Cc: Clements, John ; Lakha, Bhawanpreet
Subject: [PATCH] drm/amdgpu: loa
call psp_int_ta_microcode() to parse the ta firmware.
Signed-off-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index d488d2
On Wed, Aug 12, 2020 at 11:54 AM Christian König
wrote:
>
> The whole approach wasn't thought through till the end.
>
> We already had a reset lock like this in the past and it caused the same
> problems like this one.
>
> Completely revert the patch for now and add individual trylock protection
The whole approach wasn't thought through till the end.
We already had a reset lock like this in the past and it caused the same
problems like this one.
Completely revert the patch for now and add individual trylock protection to
the hardware access functions as necessary.
This reverts commit
Am 12.08.20 um 17:19 schrieb Steven Rostedt:
On Wed, 12 Aug 2020 16:36:36 +0200
Christian König wrote:
Am 12.08.20 um 16:17 schrieb Steven Rostedt:
On Fri, Aug 07, 2020 at 03:36:58PM +0200, Christian König wrote:
Trace something useful instead of the pid of a kernel thread here.
Signed-off-
Am 12.08.20 um 17:07 schrieb Felix Kuehling:
Am 2020-08-12 um 4:53 a.m. schrieb Christian König:
Am 12.08.20 um 03:19 schrieb Li, Dennis:
[AMD Official Use Only - Internal Distribution Only]
Hi, Felix,
Re: It may be better to fix it the other way around in
amdgpu_amdkfd_alloc_gtt_mem. Always
On Wed, 12 Aug 2020 16:36:36 +0200
Christian König wrote:
> Am 12.08.20 um 16:17 schrieb Steven Rostedt:
> > On Fri, Aug 07, 2020 at 03:36:58PM +0200, Christian König wrote:
> >> Trace something useful instead of the pid of a kernel thread here.
> >>
> >> Signed-off-by: Christian König
> >> --
On 8/12/20 2:43 PM, StDenis, Tom wrote:
[AMD Official Use Only - Internal Distribution Only]
Possibly, but since the arcturus_get_smu_metrics_data() can error out we should
check that return value no?
Yes, we need that return check.
(also setting *value to 0 avoids this bug in the futur
Am 2020-08-12 um 4:53 a.m. schrieb Christian König:
> Am 12.08.20 um 03:19 schrieb Li, Dennis:
>> [AMD Official Use Only - Internal Distribution Only]
>>
>> Hi, Felix,
>>
>> Re: It may be better to fix it the other way around in
>> amdgpu_amdkfd_alloc_gtt_mem. Always take the reset_sem inside the
>
On 8/11/20 9:30 AM, Nirmoy Das wrote:
This patch will ignore non-fatal errors and try to
stop amdgpu's sw stack on fatal errors.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 56 -
1 file changed, 54 insertions(+), 2 deletions(-)
diff --gi
On Fri, Aug 07, 2020 at 03:36:58PM +0200, Christian König wrote:
> Trace something useful instead of the pid of a kernel thread here.
>
> Signed-off-by: Christian König
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd
Am 12.08.20 um 16:17 schrieb Steven Rostedt:
On Fri, Aug 07, 2020 at 03:36:58PM +0200, Christian König wrote:
Trace something useful instead of the pid of a kernel thread here.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 1 +
1 file changed, 1 insertion(+)
Am 12.08.20 um 15:49 schrieb Daniel Vetter:
On Wed, Aug 12, 2020 at 3:42 PM Christian König
wrote:
Ping? Daniel, Dave any opinion on this?
Type patch, cc: tracing people, see what they say?
Adding Ingo and Steven then.
tbh I have no idea,
but they have been making unhappy noises about some
On Tue, Aug 11, 2020 at 09:42:11AM -0400, Marek Olšák wrote:
> There are a few cases when the flags can change, for example DCC can be
> disabled due to a hw limitation in the 3d engine. Modifiers give the
> misleading impression that they help with that, but they don't. They don't
> really help wi
On Wed, Aug 12, 2020 at 3:42 PM Christian König
wrote:
>
> Ping? Daniel, Dave any opinion on this?
Type patch, cc: tracing people, see what they say? tbh I have no idea,
but they have been making unhappy noises about some of the tricks
we've played in the past in i915 tracepoints. So not everythi
Ping? Daniel, Dave any opinion on this?
Christian.
Am 07.08.20 um 15:36 schrieb Christian König:
Hi everybody,
in amdgpu we got the following issue which I'm seeking advise how to cleanly
handle it.
We have a bunch of trace points which are related to the VM subsystem and
executed in either
On Wed, Aug 12, 2020 at 12:57 AM Evan Quan wrote:
>
> Support Navi1X mgpu fan boost enablement.
>
> Change-Id: Iafbf07c56462120d2db578b6af45dd7f985a4cc1
> Signed-off-by: Evan Quan
> ---
> .../drm/amd/powerplay/inc/smu_v11_0_ppsmc.h | 4 +++-
> drivers/gpu/drm/amd/powerplay/navi10_ppt.c| 2
Am 12.08.20 um 14:09 schrieb Shashank Sharma:
On 12/08/20 2:02 pm, Christian König wrote:
Am 12.08.20 um 10:15 schrieb Shashank Sharma:
Hello Christian,
On 12/08/20 12:15 pm, Christian König wrote:
Am 12.08.20 um 06:33 schrieb Shashank Sharma:
This patch adds a new trace event to track the P
[AMD Official Use Only - Internal Distribution Only]
Possibly, but since the arcturus_get_smu_metrics_data() can error out we should
check that return value no?
(also setting *value to 0 avoids this bug in the future...).
Tom
From: Das, Nirmoy
Sent: We
On 8/12/20 2:20 PM, Tom St Denis wrote:
Fixes:
CC [M] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.o
drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c: In function
‘arcturus_log_thermal_throttling_event’:
drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:22
Fixes:
CC [M] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.o
drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c: In function
‘arcturus_log_thermal_throttling_event’:
drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2223:24: warning:
‘throttler_status’ may be u
On 8/12/20 11:19 AM, Emily.Deng wrote:
From: jqdeng
Only for no job running test case need to do recover in
flr notification.
For having job in mirror list, then let guest driver to
hit job timeout, and then do recover.
Signed-off-by: jqdeng
Change-Id: Ic6234fce46fa1655ba81c4149235eeac75e75
On 12/08/20 2:02 pm, Christian König wrote:
> Am 12.08.20 um 10:15 schrieb Shashank Sharma:
>> Hello Christian,
>>
>> On 12/08/20 12:15 pm, Christian König wrote:
>>> Am 12.08.20 um 06:33 schrieb Shashank Sharma:
This patch adds a new trace event to track the PTE update
events. This spec
[AMD Official Use Only - Internal Distribution Only]
Am 12.08.20 um 12:02 schrieb Li, Dennis:
> [AMD Official Use Only - Internal Distribution Only]
>
> Am 12.08.20 um 11:23 schrieb Li, Dennis:
>> [AMD Official Use Only - Internal Distribution Only]
>>
>> Am 12.08.20 um 03:33 schrieb Li, Dennis:
>
Am 12.08.20 um 12:02 schrieb Li, Dennis:
[AMD Official Use Only - Internal Distribution Only]
Am 12.08.20 um 11:23 schrieb Li, Dennis:
[AMD Official Use Only - Internal Distribution Only]
Am 12.08.20 um 03:33 schrieb Li, Dennis:
[AMD Official Use Only - Internal Distribution Only]
Hi, Christ
[AMD Official Use Only - Internal Distribution Only]
Am 12.08.20 um 11:23 schrieb Li, Dennis:
> [AMD Official Use Only - Internal Distribution Only]
>
> Am 12.08.20 um 03:33 schrieb Li, Dennis:
>> [AMD Official Use Only - Internal Distribution Only]
>>
>> Hi, Christian,
>>
>> Re: I was wondering t
Am 12.08.20 um 11:23 schrieb Li, Dennis:
[AMD Official Use Only - Internal Distribution Only]
Am 12.08.20 um 03:33 schrieb Li, Dennis:
[AMD Official Use Only - Internal Distribution Only]
Hi, Christian,
Re: I was wondering the same thing for the amdgpu_gem_va_ioctl() as well. We
shouldn't ha
[AMD Official Use Only - Internal Distribution Only]
Am 12.08.20 um 03:19 schrieb Li, Dennis:
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi, Felix,
>
> Re: It may be better to fix it the other way around in
> amdgpu_amdkfd_alloc_gtt_mem. Always take the reset_sem inside the
> res
From: jqdeng
Use function printk_ratelimit to limit the print rate.
Signed-off-by: jqdeng
Change-Id: Ief05debe30d975cbcf88e473c9f486d70b5a202c
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
[AMD Official Use Only - Internal Distribution Only]
Am 12.08.20 um 03:33 schrieb Li, Dennis:
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi, Christian,
>
> Re: I was wondering the same thing for the amdgpu_gem_va_ioctl() as well. We
> shouldn't have any hardware access here, so ta
From: jqdeng
Only for no job running test case need to do recover in
flr notification.
For having job in mirror list, then let guest driver to
hit job timeout, and then do recover.
Signed-off-by: jqdeng
Change-Id: Ic6234fce46fa1655ba81c4149235eeac75e75868
---
drivers/gpu/drm/amd/amdgpu/mxgpu_a
Am 12.08.20 um 03:33 schrieb Li, Dennis:
[AMD Official Use Only - Internal Distribution Only]
Hi, Christian,
Re: I was wondering the same thing for the amdgpu_gem_va_ioctl() as well. We
shouldn't have any hardware access here, so taking the reset_sem looks like
overkill to me.
[Dennis Li] am
Am 12.08.20 um 03:19 schrieb Li, Dennis:
[AMD Official Use Only - Internal Distribution Only]
Hi, Felix,
Re: It may be better to fix it the other way around in
amdgpu_amdkfd_alloc_gtt_mem. Always take the reset_sem inside the reservation.
Otherwise you will never be able to take the reset_sem
[AMD Public Use]
Please remember to revert it when root cause is found out, the patch is:
Reviewed-by: Tao Zhou
> -Original Message-
> From: Jiansong Chen
> Sent: Wednesday, August 12, 2020 4:44 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhou1, Tao ; Feng, Kenneth
> ; Chen, Jiansong
gfxoff is temporarily disabled for navy_flounder,
since at present the feature has broken some basic
amdgpu test.
Signed-off-by: Jiansong Chen
Change-Id: Icc030370997a66fb9f01cdd4b1c45816e3c88584
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dr
Am 12.08.20 um 10:15 schrieb Shashank Sharma:
Hello Christian,
On 12/08/20 12:15 pm, Christian König wrote:
Am 12.08.20 um 06:33 schrieb Shashank Sharma:
This patch adds a new trace event to track the PTE update
events. This specific event will provide information like:
- start and end of virt
Hello Christian,
On 12/08/20 12:15 pm, Christian König wrote:
> Am 12.08.20 um 06:33 schrieb Shashank Sharma:
>> This patch adds a new trace event to track the PTE update
>> events. This specific event will provide information like:
>> - start and end of virtual memory mapping
>> - HW engine flags
46 matches
Mail list logo
